From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f68.google.com (mail-wr1-f68.google.com [209.85.221.68]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F2F5131E824 for ; Thu, 2 Apr 2026 07:14:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.68 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775114056; cv=none; b=lHgBhxN/wbWjj31ALkITq/7mf+2xs/9MXThUiYLqwQ1aRcy83+eDAzCiU2JVKUQ3Sl5ZIw5jhKufW7cZEATn9Y5Xcj0dwwKQOtvx2s+Ckwm8DXfq5G7x8cUl6ScnlI/IkxseIsg4STnXxi8p4cEVC67+HIy8KzjvUOPWAbJdIls= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775114056; c=relaxed/simple; bh=/Y0wK1DjYHCDfqnPqGoeviCY5Z0746wIceBPkmgPE5g=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=m/t14FJCmU/2l16WTYiLVo6zzn00VyDrextppCRdPO5JDohoAHqRFG1fZHqfOIY5ktUv7cVgNLW9Ol/K9rgiyTlxcjoqL1zv+X+LjhvGZt2Q1GjpIrY1Ba964KahJX6SraJ0QWn760G+Wuoag2eo8iWf2bKt95Bfj90dQC9a1Aw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=ULsjoTd+; arc=none smtp.client-ip=209.85.221.68 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ULsjoTd+" Received: by mail-wr1-f68.google.com with SMTP id ffacd0b85a97d-43b8982c2f4so289543f8f.2 for ; Thu, 02 Apr 2026 00:14:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1775114053; x=1775718853; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=D4DL3TNu9MpIP2feemW+kpE1U6+jIZ/jDYv1Nlo4q00=; b=ULsjoTd+TDPo+bYlGVtFIGQ8LhmdNjmXpUJvh6loPpkIhkTnYWZCk7W/dK6YkmqhQT hlUWDU4CV7Lt6lrLXfwO7VHrepQxzCyrTtvKK9z769TZHthXaGgpvbHGzA+/3dyT4qTo +Uk5RbQvjuPaw8U4rmxXqTHTW4XyJmKVpRuoiyNI8xr5fjV7eJiO61O+IYYUAekIj0dA TyJUaAZKPg/yCBFXM0Q7csyIlf0GswBsqbHhPUqHKfLgHlYjh8eRwevnGybh8jv9BaKl kiiOO/scIqPQKoswwBprxbtY4HRGTXUQNR2gtNdooLq8YRDXcjg5hs4pez7iu5KKGIvF 8kPQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775114053; x=1775718853; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=D4DL3TNu9MpIP2feemW+kpE1U6+jIZ/jDYv1Nlo4q00=; b=nowALSE2xuNBKpXlZDUBST1GSdcV44KxRdOTdKwOXxqwkAfomyJrOeCstMyDa+SihN OduQOV8CVou487a4oW+f5Gc5ENiI/TKW5O99aaOi2wvxDAQuzJKQeXManOXnxpuUaR/V AbbrC9ttTmi347IadBGOVEBE7C6DpobpAe4v+Oj3vivw1c2ha9+pWlK5vroNWgx6DRko SiXMJnEtHTWX/htM6ZZbOBPB3+UZN5Q2yyXqRWdVTd+kuq5m45ssom1MDdMD16kQ4bN9 HHseGMGhocVXiTv/266Ho4QRU0Fvy8c9jjFcxoaiP51YX0MCp4cYukhkzaBq7mJOIfOg p6JA== X-Forwarded-Encrypted: i=1; AJvYcCV37dO35neERRodWUYjs/SLCxJ69icgOfC2tlybAvLG6/PpuO5vX6pZiGz+NJ0SszeOtvF/KEshm7IhLf0=@vger.kernel.org X-Gm-Message-State: AOJu0YwLiiTHN/BGFbwSipejXJLVN09qSkGQlW+PnI8OxRqFduSMuNTH T/C9ncmTgm+kFKdig7PakSGceWRCN6yyqA2OYWVwN/E2/AIyv7uZHsTw X-Gm-Gg: ATEYQzybHCYg1lQv6eZRpKiGPYIw77az384ynzTQu5VDSbcc2wILOHZnJyMRRkYzSiA /NfH0Z5XgSK0hdkwHxWMTD+25phschz5QLFckWI9U4PyNmNXCWdSRCsaXe1SZfTHtTi4qkxeTdT xSZLe7e/2O5mdC0PJSGaS0GihmYNKMCpl69CdPdgmO10OzARDY3qkxq/RYKN10CnsMQSb3UVuvH oW9ooWBu3OQ4vk3hfQiFHsZSDuyJs076Y2u0nAgekaJeACE/7vI8Bl2KiDqVy8oULcYXEI9PgWM A0yqQ+3snomfVh79lMI8/QkCtmk4DILckA8MBlJVmhitNr/hqpbH9U5w1ybUwUROMiZ2+9K8mqR HuqQ9igLdeSzgzXLZ4RSfqB4TD1Z9clfg6X+9hNWb625Vwv99KyFo1BvhxoXo6BgeUfnAuYXU89 xeLfTAgf7Ad3kB3rhrH6jo X-Received: by 2002:a5d:5d0a:0:b0:43d:127b:7e81 with SMTP id ffacd0b85a97d-43d1f233f58mr3861693f8f.28.1775114053190; Thu, 02 Apr 2026 00:14:13 -0700 (PDT) Received: from bera-arch ([2a02:ff0:c13:2eeb:2e7c:3a4f:2bc2:f78a]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43d1e2c5419sm6443738f8f.11.2026.04.02.00.14.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 02 Apr 2026 00:14:12 -0700 (PDT) From: =?UTF-8?q?Bera=20Y=C3=BCzl=C3=BC?= To: tommyguo039@gmail.com Cc: b9788213@gmail.com, gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, linux-staging@lists.linux.dev Subject: Re: [PATCH v2] staging: rtl8723bs: remove GEN_CMD_CODE macro and callback array Date: Thu, 2 Apr 2026 10:13:37 +0300 Message-ID: <20260402071336.12211-2-b9788213@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260402023621.142194-1-tommyguo039@gmail.com> References: <20260402023621.142194-1-tommyguo039@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit On Wed, 1 Apr 2026 22:35:59 -0400, Xiyuan Guo wrote: > The GEN_CMD_CODE macro and the rtw_cmd_callback function pointer array > add unnecessary layers of indirection and make the code difficult to > follow. Remove the GEN_CMD_CODE macro and replace the function pointer array > dispatcher in rtw_cmd_thread() with a direct switch statement. > > Additionally, rename the associated command enums from CamelCase to > UPPERCASE_SNAKE_CASE to comply with the standard Linux kernel coding > style. > > Signed-off-by: Xiyuan Guo > --- ... > -#endif /* _CMD_H_ */ > +#endif /* _CMD_H_ */ This must be __RTW_CMD_H_ but it is competely unrelated with this patch. If you want to fix this you can send a separate patch. Thanks, Bera