From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5D7A7344D8E for ; Thu, 2 Apr 2026 18:15:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775153751; cv=none; b=SWGkUdXs77d+CKpJlq+CQJJ1iV2kyk/hXxHsgKbVMNmgUadBbm8ridnVvQBAiopGNtTApCAWiS5mtjrD5NXNXwDLCgYWzNnIIU9BzCPE7O9pfUHuRMcekuHLajYtM9VGR8QKIp1JLjulIfISzbXSw1ZDWZ1TlKhMTYc+g3n3bWc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775153751; c=relaxed/simple; bh=S/mtJxsULXb06Bk6Hx5Ma99iJ2YjQ3xvhYTdzw+Jars=; h=Date:From:To:Cc:Subject:Message-Id:In-Reply-To:References: Mime-Version:Content-Type; b=f7OxAPQroqW6gG8iG5w8QfPCYD6+h/L4fMCUmYK0gbbEQ6q1Y0czsjneM0O6cr3mjaxQD1NNamnyTEstfnnbosDkWVydKme0rtwecfi06JQcp9GlE4obQIHNQCwem3EiJWtgT4fyA0QsLapm85fKauXnjAbXzi0S7iBHxxQqFqE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux-foundation.org header.i=@linux-foundation.org header.b=MASL4p2p; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux-foundation.org header.i=@linux-foundation.org header.b="MASL4p2p" Received: by smtp.kernel.org (Postfix) with ESMTPSA id D0CA2C116C6; Thu, 2 Apr 2026 18:15:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1775153751; bh=S/mtJxsULXb06Bk6Hx5Ma99iJ2YjQ3xvhYTdzw+Jars=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=MASL4p2pt1XPbLKQ4RR9cJnF6WyXCpzdZXYt2qLsr7Dw6LtIVlhOCJopMANef3+Fq nRVuo7FdZXB9GZSmGnc+7d1aTWq2ni+KJAwFbx78O3IPq9h9NKue+YXPcmeTgkdW2L TLi7PijdJwc9RwrYuppl4aQP1jlxWUukC0ZAyXL8= Date: Thu, 2 Apr 2026 11:15:50 -0700 From: Andrew Morton To: Pratyush Yadav Cc: Leo Timmins , pasha.tatashin@soleen.com, rppt@kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 2/2] liveupdate: initialize incoming FLB state before finish Message-Id: <20260402111550.82c0f204ccaae2f81d584d71@linux-foundation.org> In-Reply-To: <2vxzmrzlfq4e.fsf@kernel.org> References: <20260326042546.8031-1-leotimmins1974@gmail.com> <20260326042546.8031-3-leotimmins1974@gmail.com> <2vxzmrzlfq4e.fsf@kernel.org> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Thu, 02 Apr 2026 13:28:33 +0000 Pratyush Yadav wrote: > The state of an incoming FLB object is initialized when it is first > used. The initialization is done via luo_flb_retrieve_one(), which looks > at all the incoming FLBs, matches the FLB to its serialized entry, and > initializes the incoming data and count. > > luo_flb_file_finish_one() is called when finish is called for a file > registered with this FLB. If no file handler has used the FLB by this > point, the count stays un-initialized at 0. luo_flb_file_finish_one() > then decrements this un-initialized count, leading to an underflow. This > results in the FLB finish never being called since the count has > underflowed to a very large value. > > Fix this by making sure the FLB is retrieved before using its count. I like that the above tells people what the actual bug is! I still have both Leo's patches in mm.git, in wait-and-see mode. What to do here? Should I upstream [1/2] and drop [2/2]? Drop both and revisit after -rc1? Also, did we consider cc:stable for these two? Perhaps add the cc:stable if we decide to attend to this after -rc1?