From: kernel test robot <lkp@intel.com>
To: Samuel Holland <samuel.holland@sifive.com>
Cc: oe-kbuild-all@lists.linux.dev, linux-kernel@vger.kernel.org,
Palmer Dabbelt <palmer@rivosinc.com>
Subject: arch/riscv/mm/init.c:354 relocate_kernel() warn: always true condition '(relocated_addr >= (((0)))) => (0-u32max >= 0)'
Date: Fri, 03 Apr 2026 16:43:08 +0800 [thread overview]
Message-ID: <202604030129.dUfFBGXI-lkp@intel.com> (raw)
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: 9147566d801602c9e7fc7f85e989735735bf38ba
commit: ea2bde36a46d5724c1b44d80cc9fafbd73c2ecf9 riscv: Support CONFIG_RELOCATABLE on riscv32
date: 1 year ago
config: riscv-randconfig-r073-20260402 (https://download.01.org/0day-ci/archive/20260403/202604030129.dUfFBGXI-lkp@intel.com/config)
compiler: riscv32-linux-gcc (GCC) 14.3.0
smatch: v0.5.0-9004-gb810ac53
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Fixes: ea2bde36a46d ("riscv: Support CONFIG_RELOCATABLE on riscv32")
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202604030129.dUfFBGXI-lkp@intel.com/
smatch warnings:
arch/riscv/mm/init.c:354 relocate_kernel() warn: always true condition '(relocated_addr >= (((0)))) => (0-u32max >= 0)'
vim +354 arch/riscv/mm/init.c
51b766c79a3d741 Samuel Holland 2024-10-26 326
51b766c79a3d741 Samuel Holland 2024-10-26 327 static void __init relocate_kernel(void)
51b766c79a3d741 Samuel Holland 2024-10-26 328 {
ea2bde36a46d572 Samuel Holland 2024-10-26 329 Elf_Rela *rela = (Elf_Rela *)&__rela_dyn_start;
51b766c79a3d741 Samuel Holland 2024-10-26 330 /*
51b766c79a3d741 Samuel Holland 2024-10-26 331 * This holds the offset between the linked virtual address and the
51b766c79a3d741 Samuel Holland 2024-10-26 332 * relocated virtual address.
51b766c79a3d741 Samuel Holland 2024-10-26 333 */
51b766c79a3d741 Samuel Holland 2024-10-26 334 uintptr_t reloc_offset = kernel_map.virt_addr - KERNEL_LINK_ADDR;
51b766c79a3d741 Samuel Holland 2024-10-26 335 /*
51b766c79a3d741 Samuel Holland 2024-10-26 336 * This holds the offset between kernel linked virtual address and
51b766c79a3d741 Samuel Holland 2024-10-26 337 * physical address.
51b766c79a3d741 Samuel Holland 2024-10-26 338 */
51b766c79a3d741 Samuel Holland 2024-10-26 339 uintptr_t va_kernel_link_pa_offset = KERNEL_LINK_ADDR - kernel_map.phys_addr;
51b766c79a3d741 Samuel Holland 2024-10-26 340
ea2bde36a46d572 Samuel Holland 2024-10-26 341 for ( ; rela < (Elf_Rela *)&__rela_dyn_end; rela++) {
ea2bde36a46d572 Samuel Holland 2024-10-26 342 Elf_Addr addr = (rela->r_offset - va_kernel_link_pa_offset);
ea2bde36a46d572 Samuel Holland 2024-10-26 343 Elf_Addr relocated_addr = rela->r_addend;
51b766c79a3d741 Samuel Holland 2024-10-26 344
51b766c79a3d741 Samuel Holland 2024-10-26 345 if (rela->r_info != R_RISCV_RELATIVE)
51b766c79a3d741 Samuel Holland 2024-10-26 346 continue;
51b766c79a3d741 Samuel Holland 2024-10-26 347
51b766c79a3d741 Samuel Holland 2024-10-26 348 /*
51b766c79a3d741 Samuel Holland 2024-10-26 349 * Make sure to not relocate vdso symbols like rt_sigreturn
51b766c79a3d741 Samuel Holland 2024-10-26 350 * which are linked from the address 0 in vmlinux since
51b766c79a3d741 Samuel Holland 2024-10-26 351 * vdso symbol addresses are actually used as an offset from
51b766c79a3d741 Samuel Holland 2024-10-26 352 * mm->context.vdso in VDSO_OFFSET macro.
51b766c79a3d741 Samuel Holland 2024-10-26 353 */
51b766c79a3d741 Samuel Holland 2024-10-26 @354 if (relocated_addr >= KERNEL_LINK_ADDR)
51b766c79a3d741 Samuel Holland 2024-10-26 355 relocated_addr += reloc_offset;
51b766c79a3d741 Samuel Holland 2024-10-26 356
ea2bde36a46d572 Samuel Holland 2024-10-26 357 *(Elf_Addr *)addr = relocated_addr;
51b766c79a3d741 Samuel Holland 2024-10-26 358 }
51b766c79a3d741 Samuel Holland 2024-10-26 359 }
51b766c79a3d741 Samuel Holland 2024-10-26 360 #endif /* CONFIG_RELOCATABLE */
51b766c79a3d741 Samuel Holland 2024-10-26 361
:::::: The code at line 354 was first introduced by commit
:::::: 51b766c79a3d741fb97419c3da1c58fce5e66f0e riscv: Support CONFIG_RELOCATABLE on NOMMU
:::::: TO: Samuel Holland <samuel.holland@sifive.com>
:::::: CC: Palmer Dabbelt <palmer@rivosinc.com>
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
next reply other threads:[~2026-04-03 8:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-03 8:43 kernel test robot [this message]
-- strict thread matches above, loose matches on Subject: below --
2025-12-18 15:10 kernel test robot
2025-09-01 1:00 kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202604030129.dUfFBGXI-lkp@intel.com \
--to=lkp@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=palmer@rivosinc.com \
--cc=samuel.holland@sifive.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome