From: Zhan Xusheng <zhanxusheng1024@gmail.com>
To: Gao Xiang <xiang@kernel.org>
Cc: linux-erofs@lists.ozlabs.org, linux-kernel@vger.kernel.org,
Zhan Xusheng <zhanxusheng@xiaomi.com>
Subject: [PATCH] erofs: handle 48-bit blocks/uniaddr for extra devices
Date: Fri, 3 Apr 2026 11:34:09 +0800 [thread overview]
Message-ID: <20260403033409.70704-1-zhanxusheng@xiaomi.com> (raw)
erofs_init_device() only reads blocks_lo and uniaddr_lo from the
on-disk device slot, ignoring blocks_hi and uniaddr_hi that were
introduced alongside the 48-bit block addressing feature.
For the primary device (dif0), erofs_read_superblock() already handles
this correctly by combining blocks_lo with blocks_hi when 48-bit
layout is enabled. But the same logic was not applied to extra
devices.
With a 48-bit EROFS image using extra devices whose uniaddr or blocks
exceed 32-bit range, the truncated values cause erofs_map_dev() to
compute wrong physical addresses, leading to silent data corruption.
Fix this by reading blocks_hi and uniaddr_hi in erofs_init_device()
when 48-bit layout is enabled, consistent with the primary device
handling.
Fixes: 61ba89b57905 ("erofs: add 48-bit block addressing on-disk support")
Signed-off-by: Zhan Xusheng <zhanxusheng@xiaomi.com>
---
Note: erofs-utils also needs corresponding fixes for the write path
(erofs_mkfs_format_devices) and a swapped hi/lo read in
erofs_read_superblock, which will be sent separately.
---
fs/erofs/super.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/fs/erofs/super.c b/fs/erofs/super.c
index 972a0c82198d..a04e70ef4fcc 100644
--- a/fs/erofs/super.c
+++ b/fs/erofs/super.c
@@ -177,6 +177,10 @@ static int erofs_init_device(struct erofs_buf *buf, struct super_block *sb,
dif->blocks = le32_to_cpu(dis->blocks_lo);
dif->uniaddr = le32_to_cpu(dis->uniaddr_lo);
+ if (erofs_sb_has_48bit(sbi)) {
+ dif->blocks |= (u64)le32_to_cpu(dis->blocks_hi) << 32;
+ dif->uniaddr |= (u64)le16_to_cpu(dis->uniaddr_hi) << 32;
+ }
sbi->total_blocks += dif->blocks;
*pos += EROFS_DEVT_SLOT_SIZE;
return 0;
--
2.43.0
next reply other threads:[~2026-04-03 3:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-03 3:34 Zhan Xusheng [this message]
2026-04-03 5:26 ` Gao Xiang
2026-04-03 6:36 ` [PATCH v2] " Zhan Xusheng
2026-04-03 8:27 ` Gao Xiang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260403033409.70704-1-zhanxusheng@xiaomi.com \
--to=zhanxusheng1024@gmail.com \
--cc=linux-erofs@lists.ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=xiang@kernel.org \
--cc=zhanxusheng@xiaomi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®