From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1569431A7EA for ; Sat, 4 Apr 2026 08:53:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775292791; cv=none; b=C02qklB5R/hMwoLJ409ckbPUqN51LJDkkcxxNqeBByb+eJxJ+g0MAzDZHyINYUkTKLjhq8Gx8B2ML0rtlnLP0RwsvpdA0a5tXE2c3NfWVvS7SG6wTK3/grGq5KNVIQCpS1kkBGEJo0V9jmp+vMucrUDjgelPFYWdBO3GPz/4Bls= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775292791; c=relaxed/simple; bh=akcwv7FwYHslYB8DD2ESdGVUWQ9b/KqvjRHw6aenFWs=; h=From:Subject:Date:Message-Id:MIME-Version:Content-Type:To:Cc; b=Pv6E+GMUJdXhOTp7oOGaFXBq5F0lhsVXiRPBXG0011ZVBVNxjk5GkRlfxptjNPdtorYBOflA/4GUWqGxBqXJfaxP6EPRBEO6GiPP9Y7CR/Tytm4Y0oJeDmQUESJej6YZD6FN8W+3uk7LFNZUoSnO3ymNbRTMGYJMQj9a7Y/cqfU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=Jjmhkl2U; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=UKbdGKC2; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="Jjmhkl2U"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="UKbdGKC2" Received: from pps.filterd (m0279866.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6344mFhF920366 for ; Sat, 4 Apr 2026 08:53:09 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:message-id :mime-version:subject:to; s=qcppdkim1; bh=3hR3upw8WMAdZtDHAYAYDf zySf6SjjpZrsN+YGn4b58=; b=Jjmhkl2UWHJPGkiJDXqdzTePOgoB6SPtrNgdiC XwEMsHPKoTV8gUHxnsnvI6xf5rzPCYtkV4Olh04HDS/pWMolqthpOanTFaVoDwTh XrHxTyQE28PdOUrzce4BOadFZpWJ1gl95YggRIGjo2DIvYJrzLIukcS6fbfOlwfV QrfJBA9m5wAVyUyP1aywb28cmBuuPxHrqG80sAmNesr2JWjZ5QVbP+cdSpDSTE2M ggiqdZUVzs3lWweZlto917N+1LdTi+9u+CzfTKVKXiEgRovxFSy/5uWSv4jEWFeO TjbHPqhJqR7WP2ExWQBmY4DVzJp0L7Ifsr0USAJ1S5hpK+hQ== Received: from mail-pl1-f198.google.com (mail-pl1-f198.google.com [209.85.214.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4daux88dfa-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Sat, 04 Apr 2026 08:53:09 +0000 (GMT) Received: by mail-pl1-f198.google.com with SMTP id d9443c01a7336-2b258636d16so24230715ad.2 for ; Sat, 04 Apr 2026 01:53:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1775292788; x=1775897588; darn=vger.kernel.org; h=cc:to:content-transfer-encoding:mime-version:message-id:date :subject:from:from:to:cc:subject:date:message-id:reply-to; bh=3hR3upw8WMAdZtDHAYAYDfzySf6SjjpZrsN+YGn4b58=; b=UKbdGKC2WIVtxq26xDAu4MhxgqPa9Zie0Z3gj4o1YgaS8lP2BVTVLEXj/80oXgpvz0 r7IEWYmR4V3Nz0rPWE6cwv2WJwl84ls/yzHaGEq2Uek88rJxhoCJ4ehkNkIq/qstUPhX Ai5v4B20vo/10JE+NUQfGMbZZDuEnGHzKhVyYVA/geiuTcRkK/eUui1nS6i9GcTUcmyd tGB9Xjuvxfw2Dss+9uE8+219n6CsFuFNVSalnxgoUugeQrJpVqObtxWYMP4djOKSbm1v z1wc4tNxYstV24qVqJGMJqQn0yUv3yDt/1VzATLFG2xwlDMCZyfWRk71w621kgnQNgG8 Q0ow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775292788; x=1775897588; h=cc:to:content-transfer-encoding:mime-version:message-id:date :subject:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=3hR3upw8WMAdZtDHAYAYDfzySf6SjjpZrsN+YGn4b58=; b=ok30PyH5JqugkO3ih+/YFpAAa9KKlJ/egT0wa6XYL4DsY6b+VY48mEcpHmRNVz945v CceE7OV7LZt/AcD5uA8hpMWjas0bd1PTIft+aY5y9kmnFzMK9AknZ6DO0gkuCXH6nwkI ubYQRSrgDkoBcR0xGap0l53aPiVrlg42FlxGS/nb5sSWczsAkTykbms0czgGvlkueS4I H/O3CFd7ViulUfF2fyYX3oc2G7vB6cDLgHn5zHgvDTwTCpRDreNYdO29uD2rsWQP+LkO j9QD5RZPNO6dxxM5JDBm0LdBhySjhK29ozeIpmBuV7gRIYw4lNx4iNMJyMGXQN0eSPJV nATQ== X-Forwarded-Encrypted: i=1; AJvYcCW0aPBkKV+ZDT6sDLe3GFKaGVe9rjpuE2dGYfpGui7NdWlo1tQWwEYKm+FQXx1VwVgxiCuObadnrsUAz9g=@vger.kernel.org X-Gm-Message-State: AOJu0YyC2QdGfnup34tl+70DJyY/CedrZxAeplqY/8x/SFKy2EKdia+A 2haeZkzFnX2Zb1QV5EMPZhHhMN20jsTUrahVubVplV0d4rmGyStF/uadT3SDcVLF0VYHqRaG5n9 RYUHj52rOFJxrmNJiPMFkH+Ln8csMJfg7rbTrSHLpswkg9x8ynNRxbhri1iJLFVccTDk= X-Gm-Gg: AeBDiev4XJ4GgY88U73DAXA0tIeH/RSaqki8IVzlUD+ONPOYYjbk09kq1/j8pdr6Mf2 tvaVAHWnYHFYed2uuwOkDrG2vHOFDRANkz4pyWcpkX4x9uLQK2SoPBmbcdPGjgwjKLLciLPZyCM xnCmuqvjtjk9CrtauX08t+fZZtLR0v0fguBQkEY6O1675vNYvHMRSssxU6o3LafCIJ1lND3IjlF glVFFByEs87ZyAUeyBD5OVp/vBBK/zwhjeP04Hcmk90aYsNiS6vna5dkeCEzpOBhFL7TF9t064U s9v83yiP3jI5pkvXQS0pFExOjX/gc0CDGrzHeKUUauYB9MP7H1WZlB+v8mcDtOYrnU9PMC9wlzi +gg7FkcAHXs+qB0XScOQOmHP9FP+oW9+AScAMFO+Y7in+uasjMuc7HW4Y X-Received: by 2002:a17:903:38d0:b0:2ae:c981:2a29 with SMTP id d9443c01a7336-2b2817ceaeamr59196265ad.2.1775292788487; Sat, 04 Apr 2026 01:53:08 -0700 (PDT) X-Received: by 2002:a17:903:38d0:b0:2ae:c981:2a29 with SMTP id d9443c01a7336-2b2817ceaeamr59196025ad.2.1775292787974; Sat, 04 Apr 2026 01:53:07 -0700 (PDT) Received: from hu-krichai-hyd.qualcomm.com ([202.46.23.25]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2b2749e2e97sm106883085ad.82.2026.04.04.01.53.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 04 Apr 2026 01:53:07 -0700 (PDT) From: Krishna Chaitanya Chundru Subject: [PATCH 0/2] PCI: Fix NULL pointer access in pci_store_saved_state() Date: Sat, 04 Apr 2026 14:22:58 +0530 Message-Id: <20260404-fix_pci_access-v1-0-416f32c6f7ec@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-B4-Tracking: v=1; b=H4sIAGrR0GkC/x2MQQqAIBAAvxJ7TjAND30lQnLdai8mLkQg/j3pO DAzFYQKk8AyVCj0sPCdOkzjAHjt6STFsTMYbZy22qqDX5+R/Y5IIgq1DTa4OcaA0KNcqBv/cN1 a+wD7g2LLYAAAAA== X-Change-ID: 20260303-fix_pci_access-c03b3b64ddbc To: Bjorn Helgaas , manivannan.sadhasivam@oss.qualcomm.com Cc: linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, Krishna Chaitanya Chundru , Shawn Anastasio , Timothy Pearson , Lukas Wunner X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1775292784; l=1433; i=krishna.chundru@oss.qualcomm.com; s=20230907; h=from:subject:message-id; bh=akcwv7FwYHslYB8DD2ESdGVUWQ9b/KqvjRHw6aenFWs=; b=ASk8IWHZTKdMs+IDgdvapUGBUZTKJC6y7w88GlYDKhchbaaQCoYuktwiabsONwz/pyjMBBPl/ nwxqvGxurrwC7U+kYJaUsMYPmMLNBV/DG+trnIg3i+xjaD9Xrg5qis2 X-Developer-Key: i=krishna.chundru@oss.qualcomm.com; a=ed25519; pk=10CL2pdAKFyzyOHbfSWHCD0X0my7CXxj8gJScmn1FAg= X-Proofpoint-ORIG-GUID: qlBrKvagozxouVcFC8Dl6VJ3vbzfDdI_ X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNDA0MDA3OCBTYWx0ZWRfXw0yMAX+opAB7 DJwsuK24354vAa9B3VQyX4oNUjja6XmGwhj19c8bltLSsL+zPCL2FKzdfC/Y9hvk9YCG1dDt8/T 2sjCF8nom/7wVJ91/eeZwhkLx0Tapn+xogX0etOmsLULeOEl61WEpPiG5NGo4WpzNBy4oGt7dFb 9p7W9ywEzrgCvo+/lPLb87z/Ev6JnBuhOIvSokd4lnxwo/VH+UdkeKFPeeaZN1PVjXyQyV2BqmF jnhaXrgwq9yyeXVhS8XgSTUysD+E2qAB6/dSy1X+fNlWEtvGyji0LtjLN8lhDK+1G9r0wz4vlBK g2n6dTlCAZbjiu+DQ1X+8y7ijJcTOWr9iZLQa3ACWRqEMXkrjeunZISrq8mVXv4a6/JRUzRPe3Q RVdibCvwB15VmyuPCgFIDgiE1+CzW1aXJiiq2/NvqijHoDZaWSPSckUab4u4hKK4F7VtAXp6hvt j1M51tiq5anP8/I8gBg== X-Proofpoint-GUID: qlBrKvagozxouVcFC8Dl6VJ3vbzfDdI_ X-Authority-Analysis: v=2.4 cv=AuzjHe9P c=1 sm=1 tr=0 ts=69d0d175 cx=c_pps a=MTSHoo12Qbhz2p7MsH1ifg==:117 a=ZePRamnt/+rB5gQjfz0u9A==:17 a=IkcTkHD0fZMA:10 a=A5OVakUREuEA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=YMgV9FUhrdKAYTUUvYB2:22 a=EUspDBNiAAAA:8 a=ZZdOtCZIvBGHUYC86cEA:9 a=QEXdDO2ut3YA:10 a=GvdueXVYPmCkWapjIL-Q:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-04-03_07,2026-04-03_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 phishscore=0 clxscore=1015 lowpriorityscore=0 suspectscore=0 spamscore=0 impostorscore=0 malwarescore=0 adultscore=0 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2604040078 If the PCIe link goes down while pci_save_state() is in progress, reads from the device configuration space may return invalid values(all 0xF's). This can lead to saving corrupted or inconsistent capability state and subsequent memory corruption. The issue is not limited to a specific capability type and may occur at any point during the save process. One example is, while saving VC extended capability save path (pci_save_vc_state() / pci_vc_do_save_buffer()) then interprets all-1s capability fields as valid and ends up writing far beyond the allocated pci_cap_saved_state buffer, corrupting the pci_dev->saved_cap_space list. Signed-off-by: Krishna Chaitanya Chundru --- Krishna Chaitanya Chundru (2): PCI: Add pcie_link_is_active() to determine if the link is active PCI: Fix NULL pointer access in pci_store_saved_state() drivers/pci/hotplug/pciehp.h | 1 - drivers/pci/hotplug/pciehp_ctrl.c | 2 +- drivers/pci/hotplug/pciehp_hpc.c | 35 ++++------------------------------- drivers/pci/pci.c | 38 +++++++++++++++++++++++++++++++++++--- drivers/pci/pci.h | 1 + 5 files changed, 41 insertions(+), 36 deletions(-) --- base-commit: 7ca6d1cfec80ebe46cc063f3284c5896c344d9a1 change-id: 20260303-fix_pci_access-c03b3b64ddbc Best regards, -- Krishna Chaitanya Chundru