From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f50.google.com (mail-wm1-f50.google.com [209.85.128.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3287E39A063 for ; Tue, 7 Apr 2026 08:35:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.50 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775550918; cv=none; b=PBzy1eKWROVd0rQ7SV1INDzmvi6Ryh0y95UsrE8PpMIA/XnVH1wLasvUTPRltvHnV+OCBOSNRP717CENJVQSrALWny9bIz0WZu7uQBCK+9aBdnj0pNh6Nx0OX7JcIcrQbGVFUy1rWAP+gf3oxvOY3ZXkDc4KUhNma8N7KL9h4+Y= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775550918; c=relaxed/simple; bh=K3WwHJtUPfm66i3F0gPb6DNHBW7Q/RpWfQ0AoPgRO84=; h=Date:From:To:Cc:Subject:Message-ID:MIME-Version:Content-Type: Content-Disposition; b=QT3B6I+d7pwNjzkW3VbblE+RcgfgqrzxG8qFGTG6BDIR7M/KDhjsRI13ZhV4yTNuVbDE8bB6hbc2Gj5kDpXrnEv9m8DWrnZ82L+HL/7bztoT+KFXuFxeYdbobYSWbHbEuEWFOBSEyOOroklSKrSvlTusu2X8GPagvaRTw/jY8Es= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=rfbhTSdW; arc=none smtp.client-ip=209.85.128.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="rfbhTSdW" Received: by mail-wm1-f50.google.com with SMTP id 5b1f17b1804b1-488b3f8fa2bso17073595e9.1 for ; Tue, 07 Apr 2026 01:35:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1775550909; x=1776155709; darn=vger.kernel.org; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :from:to:cc:subject:date:message-id:reply-to; bh=GSiA63+8lYz5lH26kAB6IVl8Sxxj8wSbU0L1qxLcLIQ=; b=rfbhTSdWTbatu2u4NeUSIZ8jXKxN3jxDlCvRqcD3nJ+te1VRqujHMixMQUEFIq+W52 mBBgsT7nKy965dywC8a0/HJ8BeDD38nsedhYYDpNvLKKl/f8jhSBrnZROM1M/tYeafTY PWlzsLMRBfvaltvI3v0vgwJ7kxnbXx1fOf+/loSLVQKiI/jJ2LI2F0zspyRSDRtRArZr IDCE0FW4A86sS1aLDF0Hgk+kZz+qtiTgH6CCZRzHHRfGYh0+RKAaBhDCa2taWhzCw0GL dRxAZjVp4iKkyWB1iiF1oaSTVXyMBDdW5/lqp1xtCoFRI50a8sskwaAQEM+kSq0EU7a3 WZzQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775550909; x=1776155709; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=GSiA63+8lYz5lH26kAB6IVl8Sxxj8wSbU0L1qxLcLIQ=; b=N+jrxV7xO76CxPvRLMDnUVEjLcfiVEM4m7X8HrRbSlf43c78y7/F0d5+dlE8I94NrQ 8+/UA9JI98S0WKdQx3oJrHLSbF7HZlqOP+vwnixi+e2rzuRYtd7lN3NCr034D1vTeMku MaUUypvB4LEhA560SquRci/5k5YvgjHWtW2+k43hH5pCIrSFzaODmzE2AMdzR8GCwzC1 5j6si11ukAGHLZnwejDrexOrvCO4eFH4DEIMAXmJMb6Y1jBX8pn1RskNUaruCizMJpHo X+hPqwpjKXsJUp3zpS7YFEPMSutXJuvNdMk8ZgJNSAndCe788ZVo367OvM+nCDwNgQBd 7Xsg== X-Forwarded-Encrypted: i=1; AJvYcCWkxz8ObOX0eLOgjVIOXjb7BZMlxdLT3d7tUsjXxWR2+hjPQbpQmxaF/eaWlucyE/3igVS9MK3HPvE9M3U=@vger.kernel.org X-Gm-Message-State: AOJu0YwjhTIWmI9+fL/ZArwRDyXK2y9weu5DsTQJIM74X61RvuRJyE+q xIsMDRINI1idaz+QlwThGqmT3oIWZTDglWJphDvkXmU0sUncRsPoB54+ X-Gm-Gg: AeBDievbx+0bJT+fYromOWqHL2teqquq1RNn2BN0mgtMCNJoGFcZhTCSjP6kRvUD1Lx P/MWmMVEdKg8+9mmGVJvbX72BrSqlNsTkkuobHMIVLReGL9jnT+0AucKYYURdfykaARAcvVM+Fl 472RiItsfeIuGprktWQiAyyF2ws2ivjeWX1S6Ba7NXWbLvTZyKxyiZfD06VG/2KEzn3sCJ8P8ID wClUkar1rYcsMKqtGrGAW8a/xkIfOYS0C2tENu0/WSFIhOp0Q4kz1CkByZgr5SpynLMwnYEoZ/i YqklwkV3p3cqybELQ8lbsEFahUS0YjTl69dOniEBAc9acFk0Y4DYNFnsV6iY3Jx9PnXQlELGOd+ sZ+WjlakQN4rbVvG/QT0UkKLWmKLJuS/hlV7s1Twd/eLydEHBTY89He6tr431xgTHQJ7gLAOfGB de8opA/iNQ3RQAwNEdKao= X-Received: by 2002:a05:600c:45cf:b0:477:9890:9ab8 with SMTP id 5b1f17b1804b1-4889945f8c3mr188304265e9.3.1775550908297; Tue, 07 Apr 2026 01:35:08 -0700 (PDT) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48899ea0091sm114883225e9.28.2026.04.07.01.35.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Apr 2026 01:35:07 -0700 (PDT) Date: Tue, 7 Apr 2026 11:35:04 +0300 From: Dan Carpenter To: oe-kbuild@lists.linux.dev, Peng Fan Cc: lkp@intel.com, oe-kbuild-all@lists.linux.dev, linux-kernel@vger.kernel.org, Mark Brown Subject: sound/arm/pxa2xx-ac97-lib.c:334 pxa2xx_ac97_hw_probe() warn: passing zero to 'PTR_ERR' Message-ID: <202604041426.i2C1xqHk-lkp@intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: 7ca6d1cfec80ebe46cc063f3284c5896c344d9a1 commit: c76d50b71e898694c946993eb3c77f50efa97254 ASoC: ac97: Convert to GPIO descriptors config: microblaze-randconfig-r072-20260404 (https://download.01.org/0day-ci/archive/20260404/202604041426.i2C1xqHk-lkp@intel.com/config) compiler: microblaze-linux-gcc (GCC) 12.5.0 smatch: v0.5.0-9004-gb810ac53 If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Fixes: c76d50b71e89 ("ASoC: ac97: Convert to GPIO descriptors") | Reported-by: kernel test robot | Reported-by: Dan Carpenter | Closes: https://lore.kernel.org/r/202604041426.i2C1xqHk-lkp@intel.com/ smatch warnings: sound/arm/pxa2xx-ac97-lib.c:334 pxa2xx_ac97_hw_probe() warn: passing zero to 'PTR_ERR' vim +/PTR_ERR +334 sound/arm/pxa2xx-ac97-lib.c e21596bba143563 Bill Pemberton 2012-12-06 320 int pxa2xx_ac97_hw_probe(struct platform_device *dev) 9c63634221f6745 Dmitry Baryshkov 2008-09-10 321 { 9c63634221f6745 Dmitry Baryshkov 2008-09-10 322 int ret; 2548e6c76ebfae0 Arnd Bergmann 2019-09-10 323 int irq; 26ade896b6ba3fd Robert Jarzmik 2009-03-15 324 8ff064521f97554 Arnd Bergmann 2019-09-18 325 ac97_reg_base = devm_platform_ioremap_resource(dev, 0); 8ff064521f97554 Arnd Bergmann 2019-09-18 326 if (IS_ERR(ac97_reg_base)) { 8ff064521f97554 Arnd Bergmann 2019-09-18 327 dev_err(&dev->dev, "Missing MMIO resource\n"); 8ff064521f97554 Arnd Bergmann 2019-09-18 328 return PTR_ERR(ac97_reg_base); 8ff064521f97554 Arnd Bergmann 2019-09-18 329 } 8ff064521f97554 Arnd Bergmann 2019-09-18 330 be829277ef79aa6 Peng Fan 2026-01-22 331 if (dev->dev.of_node) { c76d50b71e89869 Peng Fan 2026-01-22 332 /* Assert reset using GPIOD_OUT_HIGH, because reset is GPIO_ACTIVE_LOW */ c76d50b71e89869 Peng Fan 2026-01-22 333 rst_gpio = devm_gpiod_get(&dev->dev, "reset", GPIOD_OUT_HIGH); c76d50b71e89869 Peng Fan 2026-01-22 @334 ret = PTR_ERR(rst_gpio); This was intended to be PTR_ERR_OR_ZERO(rst_gpio) c76d50b71e89869 Peng Fan 2026-01-22 335 if (ret == -ENOENT) be829277ef79aa6 Peng Fan 2026-01-22 336 reset_gpio = -1; c76d50b71e89869 Peng Fan 2026-01-22 337 else if (ret) c76d50b71e89869 Peng Fan 2026-01-22 338 return ret; Otherwise we always return here. c76d50b71e89869 Peng Fan 2026-01-22 339 reset_gpio = desc_to_gpio(rst_gpio); 26ade896b6ba3fd Robert Jarzmik 2009-03-15 340 } else { 26ade896b6ba3fd Robert Jarzmik 2009-03-15 341 if (cpu_is_pxa27x()) 26ade896b6ba3fd Robert Jarzmik 2009-03-15 342 reset_gpio = 113; 26ade896b6ba3fd Robert Jarzmik 2009-03-15 343 } 9c63634221f6745 Dmitry Baryshkov 2008-09-10 344 9d1cf39be670976 Dmitry Baryshkov 2008-09-10 345 if (cpu_is_pxa27x()) { 3b4bc7bccc78572 Mike Dunn 2013-01-07 346 /* 3b4bc7bccc78572 Mike Dunn 2013-01-07 347 * This gpio is needed for a work-around to a bug in the ac97 3b4bc7bccc78572 Mike Dunn 2013-01-07 348 * controller during warm reset. The direction and level is set 3b4bc7bccc78572 Mike Dunn 2013-01-07 349 * here so that it is an output driven high when switching from 3b4bc7bccc78572 Mike Dunn 2013-01-07 350 * AC97_nRESET alt function to generic gpio. 3b4bc7bccc78572 Mike Dunn 2013-01-07 351 */ c76d50b71e89869 Peng Fan 2026-01-22 352 gpiod_set_consumer_name(rst_gpio, "pxa27x ac97 reset"); 053fe0f166e540a Mike Dunn 2013-01-07 353 pxa27x_configure_ac97reset(reset_gpio, false); 3b4bc7bccc78572 Mike Dunn 2013-01-07 354 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki