mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Tushar Sariya <tushar.sariya77@gmail.com>
To: Trond Myklebust <trond.myklebust@hammerspace.com>,
	Anna Schumaker <anna@kernel.org>
Cc: linux-nfs@vger.kernel.org, linux-kernel@vger.kernel.org,
	carnil@debian.org, maik.nergert@uni-hamburg.de,
	valentin.samir@magellium.fr, regressions@lists.linux.dev,
	Tushar Sariya <tushar.97@hotmail.com>
Subject: [PATCH v2 0/1] NFSv4.1: Apply session size limits on clone path
Date: Sat,  4 Apr 2026 11:58:02 -0230	[thread overview]
Message-ID: <20260404142831.3341498-1-tushar.sariya77@gmail.com> (raw)
In-Reply-To: <177349021750.3039212.10211295677877269201@eldamar.lan>

From: Tushar Sariya <tushar.97@hotmail.com>

The NFS automount clone path (nfs4_clone_server) is missing the
session-size clamping that top-level mounts get in
nfs4_server_common_setup(). This was exposed by 2b092175f5e3 which
changed submounts to no longer unconditionally inherit the parent's
already-clamped rsize/wsize. On servers that enforce tight
max_request_size budgets (reported on Dell EMC Isilon/OneFS), the
child mount ends up with raw unclamped values that exceed the session
channel limits, resulting in NFS4ERR_REQ_TOO_BIG and user-visible EIO.

Note: I was unable to reproduce the exact failure locally as it appears
to require a server that enforces tight max_request_size budgets. The
fix is based on code analysis — the clone path is missing the same
session-limit clamping that top-level mounts apply in
nfs4_server_common_setup(). Tested that the kernel builds and boots
successfully.

Tushar Sariya (1):
  NFSv4.1: Apply session size limits on clone path

 fs/nfs/internal.h   | 2 ++
 fs/nfs/nfs4client.c | 4 ++--
 fs/nfs/nfs4proc.c   | 3 +++
 3 files changed, 7 insertions(+), 2 deletions(-)

--
2.43.0


  parent reply	other threads:[~2026-04-04 14:28 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-14 12:23 [regression] Large rsize/wsize (1MB) causes EIO after 2b092175f5e3 ("NFS: Fix inheritance of the block sizes when automounting") Salvatore Bonaccorso
2026-03-14 15:38 ` Trond Myklebust
2026-03-15  8:37   ` Aurélien Couderc
2026-03-15 11:29   ` Jeff Layton
2026-03-15 14:12     ` Trond Myklebust
2026-04-04 14:28 ` Tushar Sariya [this message]
2026-04-04 14:28   ` [PATCH v2 1/1] NFSv4.1: Apply session size limits on clone path Tushar Sariya

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260404142831.3341498-1-tushar.sariya77@gmail.com \
    --to=tushar.sariya77@gmail.com \
    --cc=anna@kernel.org \
    --cc=carnil@debian.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-nfs@vger.kernel.org \
    --cc=maik.nergert@uni-hamburg.de \
    --cc=regressions@lists.linux.dev \
    --cc=trond.myklebust@hammerspace.com \
    --cc=tushar.97@hotmail.com \
    --cc=valentin.samir@magellium.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®