From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BD0C230B502; Mon, 6 Apr 2026 07:59:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775462369; cv=none; b=hjDkwQLWXiRaK6M0ooRrfB1UbQ0mWiCt3zlh9E6SM+CV97E0dXieq6cnoDW6II/8d3ravC6/Z4l43q6FURieToBXPrVDMGnanPReZLkXap7Nnz46ksbNziv/GSVQDD6+1c5Y4iyjkTv9lPqYQtBBk+VH85H+kzSLnsfl4FNnRLs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775462369; c=relaxed/simple; bh=H3kuvxg8ZHne3PX9xJGEzutPg/Mzcmu/UywTM0mbcz0=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=rXZrT9uNCwYSIDAT2Ot+n0OLWzL2KZUP3Hm82ZAA2VkwIz1qYsfqXYPXcaIoFjguuCvSva3kYJHw5iEHTwQoauWwmZqP8fLKDxmgnj7w2XZwGYmPhClbG7IXUrUq91A8eu1MupiPkyLckQrPmY7Xy7mqIlcdzoJk5v/BRD64ALY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=MLPvHqtN; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="MLPvHqtN" Received: by smtp.kernel.org (Postfix) with ESMTPSA id DB334C4CEF7; Mon, 6 Apr 2026 07:59:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1775462369; bh=H3kuvxg8ZHne3PX9xJGEzutPg/Mzcmu/UywTM0mbcz0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=MLPvHqtNDibelkhWsspKp8g1g5/z5kCt8APbvI2N0179QAEqc3UXpesAV6GxuYDAN oPwEnq/Hn4h6hld/zWITBqffmIOokZnxQ8nqJpcjLs0pI6+SYUcHlDzW/kOf+4IlPm h0CMHBTtH2shIFAa55wF7m4b2uFuKTN1LgziNs9PNbDmohAdBvxoWP7HOwciDECfWn lFlNqqswHLPtImYRbnSSnfXoo1GrKfsjndSNyUjcldh3MXn8+yBWB1AuEiGZUmfl9M DTyLRjKNi5HS6K8g5CI/FcjaHoFEIoqlCV/7GuiEAMiT+L6tlbGfUj8tPWbS7h7WCg W0kVWNUdJMfkg== Date: Mon, 6 Apr 2026 09:59:26 +0200 From: Krzysztof Kozlowski To: Markus Probst Cc: Hans de Goede , Ilpo =?utf-8?B?SsOkcnZpbmVu?= , Bryan O'Donoghue , Lee Jones , Pavel Machek , Miguel Ojeda , Boqun Feng , Gary Guo , =?utf-8?B?QmrDtnJu?= Roy Baron , Benno Lossin , Andreas Hindborg , Alice Ryhl , Trevor Gross , Danilo Krummrich , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Greg Kroah-Hartman , platform-driver-x86@vger.kernel.org, linux-leds@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, rust-for-linux@vger.kernel.org Subject: Re: [PATCH v6 2/2] dt-bindings: embedded-controller: Add synology microp devices Message-ID: <20260406-ancient-amethyst-poodle-1ba0b2@quoll> References: <20260405-synology_microp_initial-v6-0-08fde474b6c9@posteo.de> <20260405-synology_microp_initial-v6-2-08fde474b6c9@posteo.de> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20260405-synology_microp_initial-v6-2-08fde474b6c9@posteo.de> On Sun, Apr 05, 2026 at 07:36:29PM +0200, Markus Probst wrote: > Add the Synology Microp devicetree bindings. Those devices are > microcontrollers found on Synology NAS devices. They are connected to a > serial port on the host device. > > Those devices are used to control certain LEDs, fan speeds, a beeper, to > handle buttons, fan failures and to properly shutdown and reboot the > device. > > This includes the following compatible ids: > - synology,ds923p-microp > - synology,ds918p-microp > - synology,ds214play-microp > - synology,ds225p-microp > - synology,ds425p-microp > - synology,ds710p-microp > - synology,ds1010p-microp > - synology,ds723p-microp > - synology,ds1522p-microp > - synology,rs422p-microp > - synology,ds725p-microp > - synology,ds118-microp > - synology,ds124-microp > - synology,ds223-microp > - synology,ds223j-microp > - synology,ds1823xsp-microp > - synology,rs822p-microp > - synology,rs1221p-microp > - synology,rs1221rpp-microp > - synology,ds925p-microp > - synology,ds1525p-microp > - synology,ds1825p-microp Drop, we see this in the diff. > > Signed-off-by: Markus Probst > --- > .../synology,ds923p-microp.yaml | 112 +++++++++++++++++++++ > MAINTAINERS | 1 + > 2 files changed, 113 insertions(+) > > diff --git a/Documentation/devicetree/bindings/embedded-controller/synology,ds923p-microp.yaml b/Documentation/devicetree/bindings/embedded-controller/synology,ds923p-microp.yaml > new file mode 100644 > index 000000000000..4518e9b74be1 > --- /dev/null > +++ b/Documentation/devicetree/bindings/embedded-controller/synology,ds923p-microp.yaml > @@ -0,0 +1,112 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/embedded-controller/synology,ds923p-microp.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Synology NAS on-board Microcontroller > + > +maintainers: > + - Markus Probst > + > +description: | > + Synology Microp is a microcontroller found in Synology NAS devices. > + It is connected to a serial port on the host device. > + > + It is necessary to properly shutdown and reboot the NAS device and > + provides additional functionality such as led control, fan speed control, > + a beeper and buttons on the NAS device. > + > +properties: > + compatible: > + enum: > + - synology,ds923p-microp > + - synology,ds918p-microp > + - synology,ds214play-microp > + - synology,ds225p-microp > + - synology,ds425p-microp > + - synology,ds710p-microp > + - synology,ds1010p-microp > + - synology,ds723p-microp > + - synology,ds1522p-microp > + - synology,rs422p-microp > + - synology,ds725p-microp > + - synology,ds118-microp > + - synology,ds124-microp > + - synology,ds223-microp > + - synology,ds223j-microp > + - synology,ds1823xsp-microp > + - synology,rs822p-microp > + - synology,rs1221p-microp > + - synology,rs1221rpp-microp > + - synology,ds925p-microp > + - synology,ds1525p-microp > + - synology,ds1825p-microp So we already talked about this and you were told to use compatibility. Your driver clearly states several of these are compatible, so I am confused that I do not see it expressed here. > + > + fan-failure-gpios: > + description: GPIOs needed to determine which fans stopped working on a fan failure event. > + minItems: 2 > + maxItems: 3 > + > +required: > + - compatible > + > +allOf: > + - if: > + properties: > + compatible: > + contains: > + enum: > + - synology,ds214play-microp > + - synology,ds225p-microp > + - synology,ds710p-microp > + - synology,ds723p-microp > + - synology,ds725p-microp > + - synology,ds118-microp > + - synology,ds124-microp > + - synology,ds223-microp > + - synology,ds223j-microp > + - synology,ds1823xsp-microp > + - synology,rs822p-microp > + - synology,rs1221p-microp > + - synology,rs1221rpp-microp > + - synology,ds1825p-microp > + then: > + properties: > + fan-failure-gpios: false > + else: > + required: > + - fan-failure-gpios > + > +additionalProperties: false > + > +examples: > + - | > + #include > + #include > + > + embedded-controller { > + compatible = "synology,ds923p-microp"; > + > + fan-failure-gpios = <&gpio 68 GPIO_ACTIVE_HIGH>, <&gpio 69 GPIO_ACTIVE_HIGH>; Keep only one example, they are basically the same. Difference in one property does not need a new example. Best regards, Krzysztof