From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dl1-f41.google.com (mail-dl1-f41.google.com [74.125.82.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 64FD6883F for ; Mon, 6 Apr 2026 17:00:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.41 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775494860; cv=none; b=t5KDGLQ0IPQ+zUPuRTB2Nr0otRWbC+a8s/5RxvM87OCIxO5w3DMs9fcp91zd8iSGUUexZIMZjpsuM7C2pryEScA8He6gEUguQUJ9Es0ooy0Xt564nOO2ymnSwDBvThuhYZAXUI4SLsK2me+LLRABkHh57FEo1g5TQVO40VWmPSk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775494860; c=relaxed/simple; bh=8QXY/xHAvGSuZXvMIUIACvAJfxKoBGG5tRlmTQslQxM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=BhkEwaTDMhrLuzGpApZEGt+oY5hPBQ7cILpBPbdC+J0kAV8LaSQV5Jl/Tqa9SXDra+2diTDOtWeLSoEOVfXEC0WqdL0GLnllWCHTk7jD6l46CdMZKngOwzdTfhadlrh64evWXtlSzRzjCFnoG75aKdWRZJR3w2zP2sGlCwDR8g8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=mokdEd6I; arc=none smtp.client-ip=74.125.82.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="mokdEd6I" Received: by mail-dl1-f41.google.com with SMTP id a92af1059eb24-12c080efc1eso1034778c88.0 for ; Mon, 06 Apr 2026 10:00:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1775494858; x=1776099658; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=8QXY/xHAvGSuZXvMIUIACvAJfxKoBGG5tRlmTQslQxM=; b=mokdEd6IING8qLu/vjvj3pMkPOxyri37Sjw1FLohbmAoNtw8J4iQRICL3mNBoExn/q 8H9dYpqHkVD52uZwoECL5BdfySpyHM9fnkgNwecC+Em1Y23eAJr+o0xA41Onw8Gnx+AD sUlA+F9/4YTCSyZAU83cWi3f2Lp+wvrfZrwKOhPqBM4N4ui45s/2UlTegIDKe5I6VeGa 9kYLm7MQoWeNzk7PMXdwrmOFDyjFaFJ6mLutHP+1Z3ALeRFttRj4apDzyJFcuaDoaX/j QM0wTGsK0QmTbXP6ffUENOZgaGWmcjAe9VjzmE34AX6cGj43eEgbkoCEiq1YY7Xr+ioX o4FA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775494858; x=1776099658; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=8QXY/xHAvGSuZXvMIUIACvAJfxKoBGG5tRlmTQslQxM=; b=Wy//CHYher94nhIYLNgi7d1z024NEQQbo3PZcyKgxK+l9yhujgH5i4s1LgfXjubZEK 6cTmdsKaD4wIrlk7NqTLfsrTjCZw2lozuvObWKDPGi00ghqEC+7HcZeGDqlPEYb+cIdk Fh2f/ONztAU9WPjtLgSxE1cB1FGj0YtfuYE1Emmuynz36m7z6lmO0bU1MPUFw6ZqWvVW 0yR77Dy446LWKQXW3DFyc/KTxdEXUD7KXp5V8vukjWj/0Kh/9CtM+aDBv0iRy00ZOtpV o+aSKYqqGQgPAD4nJHrwBlB2KQcHGfIdERKoAzC0G9APCW0YBTjaOVxF4hbf/PdPvIi1 7EZw== X-Forwarded-Encrypted: i=1; AJvYcCUIir108p744rDWEBkZhpifgJwL2KJZA3d9/mlmmxMjEiNfBKbc+0cPcZ4oH1LE2eK2Kb0DhlXKJZiMBRM=@vger.kernel.org X-Gm-Message-State: AOJu0YzroGrGFpbkMa/rvgfhtAymItQFnjkoJxV2xkxkjW6ugpxKcKas f49riXblPNz9Zel9Fhw4cgwN9Z+xaTQcf5Kh2CcNTg6yKVeixQBeWj/0ncYbPg== X-Gm-Gg: AeBDieuxwp7eGkQpI0vs33vrABcuZlykLc9L/CGWCo6qPDNqJ8QWxDMqNeUzmfwu6Uz TTyqMaDTrhx/3Hr3b0nAFcjDM1X85SfFknfRihVlnz3/VO+2/u0rvFoimNq4GIm8nNUVY9ryhHY Pun7E5zsmxj1/7f/aoSJj6knznV6PiTrKKqtvfo5WyQwmhc6aI7DP918oRKQRUmk2a4DXVHZdoq La0LsaRWF1BUfEyL0AIbNriNj+tvXCJdJg0QJY8845U+UKsmEC3wXoTfcKeCTVXG7vC/IRJwSUg h0FddrJXfrSvZ/nkb2kPIN3s6fzodAHh/zDBaRjqVBUbS/p4ym1fZtujKnVrt7b34BFK89WPkJz QhdJWZY1gaiZHsCHNoChLMK3XB5oIiYpmMicfD8IxvnstKl4/as3iAeAYfauY5bpuedSQ+mjT/g 5hxQrPpjwEPipg9EkE0GKZ24T2inXDRKDlPH9TDyyDHVFw6c39U4vpxv3leuydFUptnsYfckaU1 NiSctNEy1Cb6qA2780rNjxWOC3pqKoQTguAF1qw33lnoUbbsLJWeVS5aoSRJrPBvQ== X-Received: by 2002:a05:7022:1284:b0:119:e569:f86d with SMTP id a92af1059eb24-12bfaf4edeemr4414215c88.10.1775494858043; Mon, 06 Apr 2026 10:00:58 -0700 (PDT) Received: from uf0ccb33743a85f.ant.amazon.com ([2601:642:4e01:ba30:bfe6:a9ff:a137:33b4]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-12c05a7beffsm5972737c88.15.2026.04.06.10.00.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Apr 2026 10:00:57 -0700 (PDT) From: Armando De Leon X-Google-Original-From: Armando De Leon To: dmitry.torokhov@gmail.com Cc: Armando De Leon , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] Input: gpio-keys - add hibernation support Date: Mon, 6 Apr 2026 09:58:06 -0700 Message-ID: <20260406165833.3137128-1-learmand@amazon.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: References: <20260406160437.3084755-1-learmand@amazon.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Hi Dmitry, Thank you for the review. The interrupt controller (GICv3) is re-initialized by platform firmware during hibernate restore - this is expected behavior, not a bug. The IRQ trigger type (EDGE_BOTH) was originally configured by devm_request_any_context_irq() during probe(), which does not run again after hibernate restore. The TLMM/pinctrl registers are correctly saved and restored by the platform's syscore_ops - I verified this with register dumps. The issue is specifically that the IRQ trigger type configured at the GIC level during probe is lost and not re-applied. Should the generic IRQ core be responsible for restoring trigger types across hibernate? Otherwise, consumer drivers like gpio-keys need to handle this in their .restore callback. Either way, gpio-keys currently lacks .freeze/.restore callbacks entirely, which is needed for proper hibernation support. Thanks, Armando