From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dl1-f44.google.com (mail-dl1-f44.google.com [74.125.82.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 613AB2512C8 for ; Mon, 6 Apr 2026 20:40:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.44 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775508005; cv=none; b=Iy7if9RwIS/h8ypKBbY7LsJ8IUz1i2ZaHch7AGVz8977WC9hRkWdHXGhHwB53qOtzNORn8lvoT0bQSxXfVdTyV7icdpKiKgBAjhJQwiOGlQkryQo/CW1PWE4kNLauoZo7f72Rba9d20u5BFqQKBvN3fU/9ng8Hua55H1HoN0cwU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775508005; c=relaxed/simple; bh=wAzUYiyC/qldYt3rtR7GC71JBuh0zXTtX8/OPm0uo3I=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=KefsoF+xIbYyjoxLxCBVOIcnlMDsJRLfkbcdXHRhalpFxbxn8j2SYl5WJttGKfMvqosPuQldsBDdSResCCN71ZJrW1Dw2AYtzr277QbG1EFsilvk5H7bpgLeQnu5J5bEQHhoDbFd8hyZCMCb9WL9KqE28IAGtEYgU1LlJw6P6Og= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=QVpXn8c/; arc=none smtp.client-ip=74.125.82.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="QVpXn8c/" Received: by mail-dl1-f44.google.com with SMTP id a92af1059eb24-12776bebe9fso9916304c88.1 for ; Mon, 06 Apr 2026 13:40:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1775508003; x=1776112803; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=wAzUYiyC/qldYt3rtR7GC71JBuh0zXTtX8/OPm0uo3I=; b=QVpXn8c/MTjWnvFPqXpOAe0WFVaNfMQ/aD5WcT+C4J6dzbz/+NMHE/MtBN1fgr+GNx cZTGQiJmv7ZKCyJmCQLITSXhNE/otq0XL5auoJMi4yh1Jl34l3Qx+hpnVe788dmGwZCQ CpVyBF4O5fTdmQ8jgPHUbqLjsffMuxAHn1Yg5ac2ufFmdwo3Y9lIJRVHHdXc/sbNXhuX cM4FHmbrvST/Pqvnf2/q2qXpDL04n4kmNjJIKM5YeOAI468xjG0H5aKzGelWr+06SQ90 bwZtfTx2iJ8Qd5GSb2kJbIpwkIKorW287QBzjg//74Qb07UccRMTUzk6yiBxU8NF9Wqd 2BAQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775508003; x=1776112803; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=wAzUYiyC/qldYt3rtR7GC71JBuh0zXTtX8/OPm0uo3I=; b=eXXkEklHjbD1X4u3EY26FanGgz8Pq3jVDLIAQtPOz+0VuoUBNJJP/XRmIZN6Wx2+qP 9TzW22IzFJQHnwqwroz3jp19id6+8sAT1vBhqGfuS43Gndq4US1Q+9knCBPcMNVM/ufz V+rQOhR+f22BaJc8bb3DMe9AAlbFMlG+9c9MzqVeRlrL/xOD3Qcp7QyX6SanIemjwWu1 LK0gf6g/FQVxybLn7BsdcvoMSkM3INfyB9t6J5h5mJZLwzH8kBDq8mWw1x35FneL1Mqn dvZR7inl4m5CaXAtxkW1vy1H9LExE5WhB2wcDu+8lgkaska9sfETA8PrnzRn0mHonKnL ZFwQ== X-Forwarded-Encrypted: i=1; AJvYcCUu1HHHINqk5zKKoPtrNTuvgc5/7iUuako1+5zV1qQC6G3jSTCP32jkdSncDT7zSvWxJsFg2Qzp2X1LuJc=@vger.kernel.org X-Gm-Message-State: AOJu0YydNjUcA7J6s41+/yObEMbUMBWinAVbjYOjf9G8K6kMfM3uHxf5 32uvGqSQ1V6c0RbyoYClit+5e/AG5XMApo/Lr2vcMY2tGtRX5W2JswWW+axK8g== X-Gm-Gg: AeBDiesPDlgW13hT56kyE5JDJS2hNg+HDJadsD6//VtugAlALkB5upz9LEUuIm40UZm 8hfEBoPHEOBDnuo/bCjrwDMKwQlm+F02vt5LDMsj3UzWm+OC5PQZ6oBm4/7cmdaUsO0Dn34k7iU IlLzZ5z1ZVHsjKje2+G+o7Op8rAPuEjdF3RfhGUyEUAbjJHUQoFRwwcBxIm340D7UImSRHJSJze sPHLzP69tA5npzP5WV8amb/pfQr7A/U4XBWKirw+c/2fVVzP4m5FlKZ2EW4Kdo9NK4OeB478Cm3 sgDBcmC+Mzxa5jDLl7f2lQXnLCuEknp7ENH5maUU411c7CGhpmeVlmMt4IGU53mZxosmpKcBr9K A9NbzwMclfrWs3iBSC5zKWzVdyV9YBwCRVJJbuAHShSYuBqUzFUX9BV/clVKJSCRGqW2qhE2Pxq oZXVico8iJ+Q0wcZDcSDe0f3I3opkIceSZcs6LN9E6weHWOV27OqwfuqQvj+cOqKfVXh5u9qra7 gFvew+VMjUQNhggUJJVfFyeuo6XfExAfZrXn0p1Y/4q1k1HiotmZgJLaJlzPezA X-Received: by 2002:a05:7022:eacb:b0:12a:6ab7:3f8a with SMTP id a92af1059eb24-12bfb6ecb1dmr6616192c88.3.1775508003334; Mon, 06 Apr 2026 13:40:03 -0700 (PDT) Received: from uf0ccb33743a85f.ant.amazon.com.com ([15.248.6.159]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-12bfea5f860sm11021469c88.2.2026.04.06.13.40.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Apr 2026 13:40:02 -0700 (PDT) From: Armando De Leon X-Google-Original-From: Armando De Leon To: dmitry.torokhov@gmail.com Cc: Armando De Leon , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] Input: gpio-keys - add hibernation support Date: Mon, 6 Apr 2026 13:39:10 -0700 Message-ID: <20260406203932.3391600-1-learmand@amazon.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: References: <20260406160437.3084755-1-learmand@amazon.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Hi Dmitry, Thanks for the guidance. I investigated further: The upstream GICv3 driver (irq-gic-v3.c) has no suspend/resume or syscore_ops for the distributor - it does not save or restore any per-IRQ configuration across power cycles. On platforms where the GIC is re-initialized by firmware during hibernate restore, all trigger type configurations set by consumer drivers during probe() are lost. The IRQ core does preserve the trigger type in irq_data (irqd_get_trigger_type), but resume_irq() in kernel/irq/pm.c only re-enables the interrupt without re-applying the trigger type to hardware. A fix in the IRQ PM resume path (having resume_irq() call irq_set_irq_type() using the saved trigger type) would fix all consumer drivers generically. However, such a change would have broad consequences and impact across all platforms and interrupt controllers, and would need very careful review and testing. Given that the gpio-keys fix is a single irq_set_irq_type() call in the .restore callback - minimal, self-contained, and low risk - would it be acceptable to handle it at the driver level for now? This avoids the risk of a sweeping IRQ core change while solving the immediate problem for gpio-keys users with hibernation support. Thanks, Armando