From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qk1-f178.google.com (mail-qk1-f178.google.com [209.85.222.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EAB2D39EF36 for ; Mon, 6 Apr 2026 22:23:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.178 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775514244; cv=none; b=iZOaFn7DAnD2/1iAtlhe4VcYNkr1kB/pz9O/AzWodyqwHjsB9O7XCBvQ7toePxt/3S09XYDIDirYCArwMqJswKN0uDoeHZtRx8TvfS1hP6XSlxDh4FH2KcHz+7PrwGArghbDG4/Ql0NfOGOu33GR4bCIXJ8ytP+CPi2725sYbVU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775514244; c=relaxed/simple; bh=Y6TIkewA7pr7BU41YN6fsY/qGH3Blpqq6CVa25KcPOk=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=t864s/ZoWuuYc181cd+AHqfvQHjvkEIUITAlp1S4wajkLJpM2CGhR3ilh05WJ1xVxIjiHWQglV/01YLcvtULDG7bcabDW5hvJBGkVb7rsaX9tpNXw+yrB/zIdb3YErby/Ku1o5ji2Z8K8/XFw/xtloJwDRamiHEhtGj4OPaNtrA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ziepe.ca; spf=pass smtp.mailfrom=ziepe.ca; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b=Ab/Ol9L9; arc=none smtp.client-ip=209.85.222.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ziepe.ca Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ziepe.ca Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b="Ab/Ol9L9" Received: by mail-qk1-f178.google.com with SMTP id af79cd13be357-8d76492e51bso162165485a.0 for ; Mon, 06 Apr 2026 15:23:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; t=1775514238; x=1776119038; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=7JVUGCgs+KhnTdURUUNkr64e5wz2LU5sjCx+P9IT4hE=; b=Ab/Ol9L9GUjIw1FJ9g/pm5S9rlTJ1rBkKRYAW/hC5m2LQer6sQ8otKgn4fbf3DvbIb NZNWYI1CThPstaFArJvUeQoEw8qz2NRQ1K93tUZYEud7KJR6iwQhvijis/ldUozJGv+a N2+DgWlUNjNYHcIGEpSfawX6hQxRo30xNcRIN4ofnVzCrbNVSPf3gRbweQHz2ByOV1lk nhNKWoiT+OSwE6abllXKdPSwCb1udQGgMEEGaa6ZMOt2eT6c02hlE8RJwbLh2XWm0va9 oKoijxpO47zAMO00qY5ufzohwhoKRELv0krobKUy+cZc1sa0sra0C7J9obmKijf1oKHD 9Z7w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775514238; x=1776119038; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=7JVUGCgs+KhnTdURUUNkr64e5wz2LU5sjCx+P9IT4hE=; b=JMHguilheRTRLHM7jxB09OsHes34cH5EMyBBQzS4LA0rVijuQf3w4PkGOVq4Nw5Nq3 13tHGz2GXZTY7MxG+hszV3PBMlL9FepIJLal4DHXKgaznQjo6jrJHIAAODEWRZnoYgfe lk1YrnJr/WPUjy0eRRQxsXVYi7Vfe2Jt8iydyMYmv32LZQNFhD6krWPCEP0VlScPllJm atQD/4ynwti/uZtFKFic2CnqMHgVpZFvMtd8WElJ/BNhSC1lHniox72cdwT1d1NjFR1a OHAvuHSppe3quvMhhgLLTz6llGsMULWBrCYaTL21TTM17JkAiIoE5SKETWqUM65vgk8E 4XCA== X-Forwarded-Encrypted: i=1; AJvYcCXMEeuAOkOm/yGAW18oy+T9z8/zdYbgP49Ye/+cSpJB8J4KAwDemtIpPy15ZOxCnOcab6LPZvjEdomJ52g=@vger.kernel.org X-Gm-Message-State: AOJu0Yx5FuWwDJvI/VLnhwPsiIvN+euwclSMhQhzw6rw5Yi0ZcUAtjVC tJ/qduP8mhwfQX/XARpZ97j4pNOHBYMYeTSmanm9rLpjArNOSgKbv1rkZyRvxhH/fjw= X-Gm-Gg: AeBDiev/NHF1t4Y4W8ZF5cOVfaIAKaWU0ZaZbM0rSqZuqS3vmYb+jItrq0VvYOpWZmi P2/w6KeTnrb8xTM4YC9r9n+rhQjErVzYiC38ipKHUvEXj2Bwybcy9kaUZhWEtQiZJTV4os4WB0R MmcUScbsoc9QR3Kp+Lht9rNLY2cPsvP1ASX9xin8kRbOJnrPoqDettH0vX74i1CRECnjGPtFYdS 0fwg0C4sjBsb/zB6Rz4bc5BWY8nlM0T6augUWtVoFTeAnykczpMhi5mPUEN5ibtA/tBEqS/dixq XGRs+lb8TFGyGras6/0bFdDyp9JmcAr/WeZQXC/ciO8HLAqRXO4ce/trWeOOj2l4G8S45SLqPdQ zbc/KcNBIaOV2qYTDIwjUHB/bmkRws5WDuJ9rLo4Kj9mwKpuP3GtluNdNEfQWbpoPoD/XOVGcLp /294bZqIvpft8YAaLUUQyfFhC1mjvPZ3eIanIvf0Mnj9q8qiSJH3wrtFGfc550tYwbiHDCGQ== X-Received: by 2002:a05:620a:2a04:b0:8cb:717e:17bd with SMTP id af79cd13be357-8d41c5a7077mr2034994485a.27.1775514237875; Mon, 06 Apr 2026 15:23:57 -0700 (PDT) Received: from ziepe.ca (mctnnbsa70w-159-2-73-22.dhcp-dynamic.fibreop.nb.bellaliant.net. [159.2.73.22]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-8a596e03dc6sm154007816d6.34.2026.04.06.15.23.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Apr 2026 15:23:57 -0700 (PDT) Received: from jgg by wakko with local (Exim 4.97) (envelope-from ) id 1w9sMO-0000000E56V-3Cv0; Mon, 06 Apr 2026 19:23:56 -0300 Date: Mon, 6 Apr 2026 19:23:56 -0300 From: Jason Gunthorpe To: Edward Srouji Cc: Leon Romanovsky , Chiara Meiohas , Dennis Dalessandro , Gal Pressman , Mark Bloch , Steve Wise , Mark Zhang , Neta Ostrovsky , Patrisious Haddad , Doug Ledford , Matan Barak , majd@mellanox.com, Maor Gottlieb , linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH rdma-next v2 03/11] RDMA/core: Preserve restrack resource ID on reinsertion Message-ID: <20260406222356.GJ2551565@ziepe.ca> References: <20260406-security-bug-fixes-v2-0-ee8815fa81b7@nvidia.com> <20260406-security-bug-fixes-v2-3-ee8815fa81b7@nvidia.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20260406-security-bug-fixes-v2-3-ee8815fa81b7@nvidia.com> On Mon, Apr 06, 2026 at 12:11:14PM +0300, Edward Srouji wrote: > From: Patrisious Haddad > > rdma_restrack_add() currently always allocates a new ID via > xa_alloc_cyclic(), regardless of whether res->id is already set. > This change makes sure that the object’s ID remains the same across > removal and reinsertion to restrack. It would be better to somehow pre-delete it so it is still in the xarray but somehow blocked and then allow un pre-deleting. del/add pairs are not a good design. Jason