From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yw1-f177.google.com (mail-yw1-f177.google.com [209.85.128.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0F4BC3191BB for ; Mon, 6 Apr 2026 23:47:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.177 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775519272; cv=none; b=rqszImM+OMu8wDjYLRTF9gX3AIoaMAtdFBu0uT0UxdcDXfkrT8YLFG/YmPznEMEOimSJLRWbAwTqgLfPAErw1rEVTPtaz5xqOGu+tbIojw3RaFJMTPyPmnkv4VDvYUlsTg8T5K/ue39PvawDOXBqkgo9chLKLixIPuhjHxwm+Iw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775519272; c=relaxed/simple; bh=ZrPPXo/ApIPPC+cqw2mGR6rvX9gdyDuvfG7CLYkJ1v4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=kOKEz6V05hNLFFCoO4U6GtWY1TkMQcOkCKmY7M7F1X7b0kXYNaXpegqb6z/zIQhoH6j4xM9io12N1YcwhiHRnI/Q+64tuLuleZ0MqDn0RpUIQMmfrVjNPBMb3J/hDLbLXMAObK1+gs55RRDyKOhmJTZv2wkk2dr2hffnlwem5kw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=cTDPZoNm; arc=none smtp.client-ip=209.85.128.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="cTDPZoNm" Received: by mail-yw1-f177.google.com with SMTP id 00721157ae682-7947cf097c1so40250247b3.2 for ; Mon, 06 Apr 2026 16:47:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1775519270; x=1776124070; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=fGFKokrs+E6BpbQjbbjTYkzD/AIdw/D6owYfFXIKI2o=; b=cTDPZoNmtqr9WrAG9foxM27jbmQx9Vh+nwkcUqlkzjUAR/G+ti9qXFG3m5d4zdQHBD pCAR5ouLtM37o8zB+wvmR7DNyVR+0ytFRXCAGswOa4S+5b9gIrzsBj8xfxsnHd65slii PA52aouF2nLPxewK8qzLeA8FdD6n8LmTW3rUZxOmCq0wLxwDlehmNnjo1a2VVv00p5Gf COY/Cy0LBPIoBlOodlq8cOFZ25HI4/oqhkjITb7NEsmDCA5bnQiwJVLNt/bwASj+3Jvs b6jE+KvryQBVmdzq8XHelXIfT5JiB/NC6r5nND2/GXp+0634SKuSDZAFvx6oDg6orusx RhcQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775519270; x=1776124070; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=fGFKokrs+E6BpbQjbbjTYkzD/AIdw/D6owYfFXIKI2o=; b=SltFTQZlM+6WJ2mClqizLuu+8y06DFp6jy3AXnh12Sv1/kmeE4I0eHSFRYmvdQPEIC wCr9QiTU0jOqpK167wWTcsPcylowJu7sZ9rD7uQ/+w1VwHdUv9l+D0dkkFdHGxI6IfiQ m3MCjSps5QZ9bSbDo5ACrH3C5itytCK5r+l8/PDIV/AQnlX1TAVDBp3muJGPtksyKdoQ q929jxl3PXbh5/ocQ7wQKp4nKY8rScygSD68bOP0ti0Csv8+vVA5xo9+vqR/YzD+iH+N K/DFxRnxigRzrdXl9o3kLPgaZTE0D/y97iVu2ruRI4VXUSdrdw9bMQNyjyvVrP33bWHo Y/dQ== X-Forwarded-Encrypted: i=1; AJvYcCUnPPlNi+dwL3ZMTUMSK1E4woCpqqCXyIaLgRCfsTFHDBngx/iCGWUtB6b9Z/0qCmVMf47uWTdJBWQ3tL4=@vger.kernel.org X-Gm-Message-State: AOJu0YzSzEui119reb2nlbJHeQDof/jfN/WvUtf1ws902Wo8mNy+tQcY WIhxtseYpmZIgmnoz0t2TjOmkvMJwHYmI9u7pYA6xRwgJyudapJha6Kd X-Gm-Gg: AeBDievSc+s0209y5o/49by6uyS2g8RUnOmgMoKKkyt8yY3wAeheJvzHgpy2RBJORKD jgM4T1R5yKELLQczj+/10KxZFyWPI2JeNhFfGCvPdj/wiGH3ubI56FlGs05J5gzokawt7Q6cC/c AP1FopyjKCszJ7fskJ4u+rlwf5eXjsWCrbsXRn6RTGHcwKJ2ufWwxni7bXNEaaMVZSJXHmoi/mq 0PatSr5sunjGPdQJbUpD2Rca9Y0M2KX+7B7SCLLZIawnA2MdyOznyZe/qInVZSB/DEuqbil0O8C m944GPJ3Pie0cPSbbZVJxUtErOKp8GvbCPLaLSQkKsc7dDjdJIX+NKXsOyTa/b/JCX56OOfoPCu x3EQnce68UjFejiAfkCmA1ErXdpjlLu7z0t7mUfQ113O3fUS6dQ2vHu9C9vNUOACAwrvDY+/MdS sNARYJprP+5KrgKuBYVdXqYnjcDhCp4dtjFsY/Hf9emKY00aDynAJwWLI8gEDS X-Received: by 2002:a05:690c:9:b0:79a:b983:b44f with SMTP id 00721157ae682-7a4d31e86d5mr152606447b3.5.1775519270045; Mon, 06 Apr 2026 16:47:50 -0700 (PDT) Received: from DEV.lan (c-75-74-152-49.hsd1.fl.comcast.net. [75.74.152.49]) by smtp.gmail.com with ESMTPSA id 00721157ae682-7a36e42ff31sm59350177b3.6.2026.04.06.16.47.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Apr 2026 16:47:49 -0700 (PDT) From: Joshua Klinesmith To: linux-wireless@vger.kernel.org Cc: nbd@nbd.name, lorenzo@kernel.org, ryder.lee@mediatek.com, shayne.chen@mediatek.com, sean.wang@mediatek.com, linux-kernel@vger.kernel.org, Joshua Klinesmith , stable@vger.kernel.org Subject: [PATCH wireless 1/4] wifi: mt76: mt7915: fix RCPI chain 3 mask in sta_poll RSSI extraction Date: Mon, 6 Apr 2026 19:47:36 -0400 Message-ID: <20260406234739.29926-2-joshuaklinesmith@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260406234739.29926-1-joshuaklinesmith@gmail.com> References: <20260406234739.29926-1-joshuaklinesmith@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The fourth receive chain RCPI uses GENMASK(31, 14), an 18-bit mask spanning bits 14-31. It should be GENMASK(31, 24), an 8-bit mask for the fourth byte, consistent with the other three chains and with the RCPI3 definitions used elsewhere in the driver (MT_PRXV_RCPI3 and MT_TXS7_F0_RCPI_3 both use GENMASK(31, 24)). On devices with fewer than 4 antenna chains, the corrupted value is masked out by antenna_mask in mt76_rx_signal(). On 4-chain devices, this produces incorrect ACK signal strength readings. Fixes: e57b7901469f ("mt76: add mac80211 driver for MT7915 PCIe-based chipsets") Cc: stable@vger.kernel.org Signed-off-by: Joshua Klinesmith --- drivers/net/wireless/mediatek/mt76/mt7915/mac.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/mediatek/mt76/mt7915/mac.c b/drivers/net/wireless/mediatek/mt76/mt7915/mac.c index 1c0d310146..946d2bd0d9 100644 --- a/drivers/net/wireless/mediatek/mt76/mt7915/mac.c +++ b/drivers/net/wireless/mediatek/mt76/mt7915/mac.c @@ -221,7 +221,7 @@ static void mt7915_mac_sta_poll(struct mt7915_dev *dev) rssi[0] = to_rssi(GENMASK(7, 0), val); rssi[1] = to_rssi(GENMASK(15, 8), val); rssi[2] = to_rssi(GENMASK(23, 16), val); - rssi[3] = to_rssi(GENMASK(31, 14), val); + rssi[3] = to_rssi(GENMASK(31, 24), val); msta->ack_signal = mt76_rx_signal(msta->vif->phy->mt76->antenna_mask, rssi); -- 2.43.0