From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yw1-f171.google.com (mail-yw1-f171.google.com [209.85.128.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BF61D39FCA9 for ; Mon, 6 Apr 2026 23:47:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.171 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775519273; cv=none; b=mzXT051xeg97xHjJcq50WCxuojOAc55vWhum/teoKCP6X2QlK4shDM9LsVpq3sBpua2bJydfQwxKHTYTnQ4tIXHmJRZ0uODv9yLzKmwjqHXbnZ5i2PBgi9v68H8JAkpHfM+iWrk0TyUq0YQeqteMTKa3c/q3Dht4qZxbrN0xAhA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775519273; c=relaxed/simple; bh=TAPzuaW5AlDW+othVr5o2bBlmoV+im03JSrJdzDaQdQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=T+UhxWC1VTPOdOrgn/CJr1mcn8RipaE3s/zYfKf9RHizU5kGMxZcshlUAhRRcswKQ3stXgOE3ULfP5idZPvv8PO/SdFHCzcYi/p6hQ9WTgOJay01y334YvUnHif8MQgFyDb/nCq1l6g+11GIOb7nz/bu1ZDIDXAhUsWnWD0hla4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=LFrRhbD3; arc=none smtp.client-ip=209.85.128.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="LFrRhbD3" Received: by mail-yw1-f171.google.com with SMTP id 00721157ae682-79a535e7c00so44659887b3.3 for ; Mon, 06 Apr 2026 16:47:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1775519271; x=1776124071; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=daA/SDL/He3KnWtFLBF284CvHqGYJ/f/DA6iaNDSago=; b=LFrRhbD3p0hKZVKABNG0HVt4/RyIlg+r6iXfBw9k74L81a0bXfkQ0Pbz4CSUZVzeSJ cgEBBtfjOLj3nuDI3aV48LUylGLOZuDzZyDuXBt9rOmRsWQYt03P1vHKsdWdiEZTI4i5 jN7JGH9Qr3V3+M8yJSzEQZ/nmzw+itHgEBKsaDqPsqSd+JFCRwbX9EJeNJ6R/dqQeh49 hOgeer5KEmXgVF/sT3hiVbfUbTq7VsSzlkkAXwpRRrOgNUUOs0rTXTlD8owdtq96NflY xSNWNO88nO39lmYb/3YoDg2+26fq8+bfmVCBLxYeGOkxRjXsZGABl0y5o3CnI6uWkAsC K9ZQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775519271; x=1776124071; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=daA/SDL/He3KnWtFLBF284CvHqGYJ/f/DA6iaNDSago=; b=qielbysWqw0PH4eW6K2kIAkCkozw/6zzIUKw7NCQ5/9got/II/pi2tquOVxrFiWs6l 4xvt3CyH0YNQ7boik3MZhA3mVFSlsYNLBakQcSolRDSEKU2qeoLnzMm42iYmrqB425LP YxMb27zx4YT3CxKx9o/oHKWDJ9lCLxVXLT+hVNdgSLDNsh19HjiDukAIh/8GgPIy3b00 ofWS6Steu1yuo00u1ETkPn/kSFbczLsUVYiqF8xWj9w3WhJ/avzHETODf/6hE11a9pJn loEDO3TWFGznyTYNx62yMfryQu/p1TsbPOX6Mylhq/Z0XbmyeHtI9vnelKLSZUO2JeNq C97w== X-Forwarded-Encrypted: i=1; AJvYcCWhRIVTDXV3NiOx4f0ycv9Dm+oGojVFFC3XeB1R7u9WIw9Gxs0GWGCZtobgMHF4fml1tDslr/YVze2l7Ek=@vger.kernel.org X-Gm-Message-State: AOJu0Yw3QkDGXAolZUd2ANrIga7DHzKrSO2h4ZGiCh8xauEZEh3jQ7LZ rfbscAgN921MT9VhUFF5FGPLSlxtYMAM3Z1isQgB/u/iYWKCYeTLUZej X-Gm-Gg: AeBDietb5HVWznve+WtgqxyNG6KAXV8zNxnS1TfaXcwxPzcX46i1QWAeYfTcwS0r/VZ FDcL025ggW7ua9Fq64FXHmN82XI8/eqJsNJI2/EBzV3j4mGYKs/F92MeRTz/FbFU3q0oQEZNBkk NWv2OiBt8TfIbNZ8dmX9lSZ8mQoMTpkiO4EI9qfnNY/KjKpKDWIiiWt8p0mD1U+/salPzeCujsC PJnxkSjgS9SSxOyIp9vmpG23BrXgE6GaXAQ5Fo5hgywqDtEdhpNyS7bI02bdOE+GVZtoWlrsQYz IGbBPN3fb5qUCo79M63WsWwicG4TehXHDldj2ZhQgMkTWbAcodBZkOyLp7IsfWD9uxrAAG1RKV4 CmaEHWhAU5IULkDG264KAuhCObgxmLDiokeOosDU4JArjtLyoanjaH9kVk2wHDzioBMEqK2x5PA Ag+c1gSO6YEHM/t4Q+hBH8FknHnjr5j4TgIlEq596vjQGALkNtBLr35J6Y2K/O X-Received: by 2002:a05:690c:498f:b0:7aa:451d:bf9f with SMTP id 00721157ae682-7aa451dc2c2mr16718657b3.5.1775519270856; Mon, 06 Apr 2026 16:47:50 -0700 (PDT) Received: from DEV.lan (c-75-74-152-49.hsd1.fl.comcast.net. [75.74.152.49]) by smtp.gmail.com with ESMTPSA id 00721157ae682-7a36e42ff31sm59350177b3.6.2026.04.06.16.47.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Apr 2026 16:47:50 -0700 (PDT) From: Joshua Klinesmith To: linux-wireless@vger.kernel.org Cc: nbd@nbd.name, lorenzo@kernel.org, ryder.lee@mediatek.com, shayne.chen@mediatek.com, sean.wang@mediatek.com, linux-kernel@vger.kernel.org, Joshua Klinesmith , stable@vger.kernel.org Subject: [PATCH wireless 2/4] wifi: mt76: mt7996: fix RCPI chain 3 mask in sta_poll RSSI extraction Date: Mon, 6 Apr 2026 19:47:37 -0400 Message-ID: <20260406234739.29926-3-joshuaklinesmith@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260406234739.29926-1-joshuaklinesmith@gmail.com> References: <20260406234739.29926-1-joshuaklinesmith@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The fourth receive chain RCPI uses GENMASK(31, 14), an 18-bit mask spanning bits 14-31. It should be GENMASK(31, 24), an 8-bit mask for the fourth byte, consistent with the other three chains and with the RCPI3 definitions used elsewhere in the driver (MT_PRXV_RCPI3 and MT_TXS7_F0_RCPI_3 both use GENMASK(31, 24)). On devices with fewer than 4 antenna chains, the corrupted value is masked out by antenna_mask in mt76_rx_signal(). On 4-chain devices, this produces incorrect ACK signal strength readings. Fixes: 98686cd21624 ("wifi: mt76: mt7996: add driver for MediaTek Wi-Fi 7 (802.11be) devices") Cc: stable@vger.kernel.org Signed-off-by: Joshua Klinesmith --- drivers/net/wireless/mediatek/mt76/mt7996/mac.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/mediatek/mt76/mt7996/mac.c b/drivers/net/wireless/mediatek/mt76/mt7996/mac.c index ca2305ea7c..ab47118fb1 100644 --- a/drivers/net/wireless/mediatek/mt76/mt7996/mac.c +++ b/drivers/net/wireless/mediatek/mt76/mt7996/mac.c @@ -205,7 +205,7 @@ static void mt7996_mac_sta_poll(struct mt7996_dev *dev) rssi[0] = to_rssi(GENMASK(7, 0), val); rssi[1] = to_rssi(GENMASK(15, 8), val); rssi[2] = to_rssi(GENMASK(23, 16), val); - rssi[3] = to_rssi(GENMASK(31, 14), val); + rssi[3] = to_rssi(GENMASK(31, 24), val); mlink = rcu_dereference(msta->vif->mt76.link[wcid->link_id]); if (mlink) { -- 2.43.0