From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yw1-f174.google.com (mail-yw1-f174.google.com [209.85.128.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1C2773A2540 for ; Mon, 6 Apr 2026 23:47:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.174 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775519274; cv=none; b=lOKvN8YCta1yV7beeeRAGDsdxCy73dk9VnmqVnogKIYaVmiPndnnlCW/7xGc6dtKONalLduyX7v0g8LhvAnTtaNQLnxdpk3CCWGacqImLTOnUkLAlEDlfkcQ+EKHCtNmE4qn76rux+ZMIu1Vf0EHE7bpZGN7OXceR7ZrsScTnX4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775519274; c=relaxed/simple; bh=jcpF1sZHHWf1OwVn8dXWeZm3vgEO/wJOncyayRAHT1Y=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=a9ZCG8zfthy/LpaXaKezHRRrq7WtcPjw9jBZz+CCCGt9dq6rk4QC1iqp9y6hByb83eGWYJIcUdtEuksFZnOw3TJr4AxI3jarzS91PEB3ogLdON/WAU0WogK/9FSfTRrXuSiMoenhRZsVEXrHzyXpA2faoCn1VK0YmSVN44D7pDw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=RUp2rByL; arc=none smtp.client-ip=209.85.128.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="RUp2rByL" Received: by mail-yw1-f174.google.com with SMTP id 00721157ae682-7947cf097c1so40250497b3.2 for ; Mon, 06 Apr 2026 16:47:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1775519272; x=1776124072; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=YxwuaqOVriBYwsFBn6+xbKIu8945UDO3QfFnEekL/38=; b=RUp2rByL4R8G3w/V5XAQ0swoRqwik/amTIZppvp1RKdPgIO6tf1OnaKByMLKvgK7Zj h8vOmmv0ewhDiu1LDe3Nn4uMuhdYEcT+Ob++vkHqlpRCi0oHGTj31YpgxcWxFXqsSYn5 3rZ16Z4FCUX2tHsEQvx888r5yrHwTTO1pIuqkjXHAZdplhhHtHv6WgmhDLEIRH42yyM4 ROzesdenmvnCPCHXIt6R+dpPR+atugmizWz2E/D6+JEjwJT6A1PyDCMt8SLNoPI4GmM3 6eRCR/6ytYkqeijYDUcEx+7FP1fsaPDmhMbASd3gJ0WYiiAldam+AOnDu+87F0aXEFnG n1TA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775519272; x=1776124072; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=YxwuaqOVriBYwsFBn6+xbKIu8945UDO3QfFnEekL/38=; b=AR3Bk4W/3lsRhc2Xxpy2YzxSVK0s2QkT6RHnUhXTs3/eeHYRV8ePBzyGQhTbUOyca9 JzVnsB7eIaJjzdfSVc4ihCiffzgDks/xid/hSF/dmvWeEI4w1G2GrEJYmv2KKPVqvcKD bGfiD47pvha91Bz7/qMzynhbI5kezMRz76yHINCfWLJL8u7t+WMSsKsuQ3lqLEMU7g2A p7jOwVSs5jMAjTO0vVa5M7PLgYwZIo9G7Y76cIv1VoRAn45GGGf6HiCotVN2ZFMSe8RW dFgWLW6+M2pUATYzp0aO9SObJoF6edBwghrul4F4dpiYfok4I18KRdT+JsyzVVeSTL56 EtHw== X-Forwarded-Encrypted: i=1; AJvYcCXXky9aGEoy8fgmEvM1YSN2kEzF/sAT+k87tR+5OHP5br+RDylpjOVIPhYXhHbWHo07FnugtGr/Gu+b0BY=@vger.kernel.org X-Gm-Message-State: AOJu0YzlRIl/Ux1gHjedz3jvIycSk+xTYa1uRGRH0An4JvemRTxAdgIm 6BPuSksjWGZN5v0qcH7SgKf2uXlJvWdTyYqycep8Y+qJJ3bAQrjirel9 X-Gm-Gg: AeBDiesEziADf4qQLyp5alEv/U4JMka4BkEuT4fa9sUr8vnW1uCIDdLmdfkNLq6mexy BPda6CrzV59BFas4Qk2GUPCk7n9atU1DduB+L/LSPBge2f+dOaTfcnS7KSPm/ScazPVKzQM0KqU Xpppaug9l/ozw5yF4/E+azCPtVS+thEAy5DLI9dT/hI9treNnfNzmR7F1jNvle30Jkg7Jw9V6Dc MuDnX0gbyfeiIm7+3yp8/nH4Gv/9MzHoIaQfMV94BPqUOW8iUn7Yv2A/tshxNBFawL3xDDq6S42 Ch9IrZjUcf4KB25EnodeeOKL2wIRcj7puuF6jZEqCreV+ADSZAeFxT+lHlp0E6j8cZLI9yUTW7Y nDWvmrf7W/cIkgzwLJ6bvypTNB7rG/yJrZzyO5uoVIv1XK5NpjDkFCKT2KA6qRpLXJ/jGgE5iov RrtgkgIpae1k2POWS8r2KpuZDZfUXKsiqWeD/b4gFDHEuRMFEscnuPATvncjw8 X-Received: by 2002:a05:690c:e3e8:b0:79a:ac83:ac84 with SMTP id 00721157ae682-7a4d5d5aeb7mr151996137b3.41.1775519272091; Mon, 06 Apr 2026 16:47:52 -0700 (PDT) Received: from DEV.lan (c-75-74-152-49.hsd1.fl.comcast.net. [75.74.152.49]) by smtp.gmail.com with ESMTPSA id 00721157ae682-7a36e42ff31sm59350177b3.6.2026.04.06.16.47.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Apr 2026 16:47:51 -0700 (PDT) From: Joshua Klinesmith To: linux-wireless@vger.kernel.org Cc: nbd@nbd.name, lorenzo@kernel.org, ryder.lee@mediatek.com, shayne.chen@mediatek.com, sean.wang@mediatek.com, linux-kernel@vger.kernel.org, Joshua Klinesmith , stable@vger.kernel.org Subject: [PATCH wireless 3/4] wifi: mt76: mt7921: fix RCPI chain 3 mask in sta_poll RSSI extraction Date: Mon, 6 Apr 2026 19:47:38 -0400 Message-ID: <20260406234739.29926-4-joshuaklinesmith@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260406234739.29926-1-joshuaklinesmith@gmail.com> References: <20260406234739.29926-1-joshuaklinesmith@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The fourth receive chain RCPI uses GENMASK(31, 14), an 18-bit mask spanning bits 14-31. It should be GENMASK(31, 24), an 8-bit mask for the fourth byte, consistent with the other three chains and with the RCPI3 definitions used elsewhere in the driver (MT_PRXV_RCPI3 and MT_TXS7_F0_RCPI_3 both use GENMASK(31, 24)). On devices with fewer than 4 antenna chains, the corrupted value is masked out by antenna_mask in mt76_rx_signal(). On 4-chain devices, this produces incorrect ACK signal strength readings. Fixes: 163f4d22c118 ("mt76: mt7921: add MAC support") Cc: stable@vger.kernel.org Signed-off-by: Joshua Klinesmith --- drivers/net/wireless/mediatek/mt76/mt7921/mac.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/mediatek/mt76/mt7921/mac.c b/drivers/net/wireless/mediatek/mt76/mt7921/mac.c index bce26389ab..7a46b50171 100644 --- a/drivers/net/wireless/mediatek/mt76/mt7921/mac.c +++ b/drivers/net/wireless/mediatek/mt76/mt7921/mac.c @@ -155,7 +155,7 @@ static void mt7921_mac_sta_poll(struct mt792x_dev *dev) rssi[0] = to_rssi(GENMASK(7, 0), val); rssi[1] = to_rssi(GENMASK(15, 8), val); rssi[2] = to_rssi(GENMASK(23, 16), val); - rssi[3] = to_rssi(GENMASK(31, 14), val); + rssi[3] = to_rssi(GENMASK(31, 24), val); mlink->ack_signal = mt76_rx_signal(msta->vif->phy->mt76->antenna_mask, rssi); -- 2.43.0