From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f46.google.com (mail-wr1-f46.google.com [209.85.221.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E7AC23B8949 for ; Tue, 7 Apr 2026 14:05:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.46 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775570761; cv=none; b=m5g+6mY+I7W6PLG/NpcOPFEWFZ205oQgydTydAb4zROo2aIBC8w4n+KuzrduyAn68HtEmqLh/tp9VxLY6CimvuMSN0Wltv+xCX9HFes+Uf6pa66YBA2X7pXjsgSIARJQhI0JxckPTgL5RxLwyH+CX10M2DRqlyQZ1rIwGVXLruA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775570761; c=relaxed/simple; bh=1TtLlyGoEjpcMlM0IIi6mugXWU7ed7R1NsJlS7WhIk4=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=K0l64HNfqDYVsg50NEJKDUmxxbrxMBcPF0XTHx3R0t2TdDjj0wTxS/Qpz06+EfzRVMYbcQOuHbH8e5gTNp5MEojyy19DQTTFZYAxd3FhI6ntEQ7I+dfadYGDI/7UI8WuW6sdqjVyoqgGm5Fp+B2oIVmL9xwO8Wj/0kpEiOR/P/0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=A2KFQXvJ; arc=none smtp.client-ip=209.85.221.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="A2KFQXvJ" Received: by mail-wr1-f46.google.com with SMTP id ffacd0b85a97d-43cf73bbfbdso3061523f8f.1 for ; Tue, 07 Apr 2026 07:05:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1775570755; x=1776175555; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=QpsJulnDdvHBRscZw94/N6Zs1iwUAKYW6ZQQ9YyXyQU=; b=A2KFQXvJ+/VJNJpeFajXPdXp8dZXQGkBky29JDCWWklSpaHX51w0iR4euI0y+4HaDd 3LdNNfmIZ+peERPTgJ7J0IKyEA3jk9CYD6XBIlshZYcw994vG5pM/cdgoIHfI2sxwx5Y peD5McVpX4Ix0YAzBWAOF7kD4uDl/2rJnadaEtiTFz4/yCr66hpyaXRFl4T/Vo7Jznc0 wH9TJoF0cMehLPOuc/tFj8Cmq4K39PS0pISA6T2R89z3MPTTtti8BrfrEUPPW+bYIz7m uEPHrGv6Nqpi0v6V42Q0Ar1XqD3FQx4iLD6pDn5GkxV3CqhqJ7KnXbiiwgpjc+PnEXyF pe7A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775570755; x=1776175555; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=QpsJulnDdvHBRscZw94/N6Zs1iwUAKYW6ZQQ9YyXyQU=; b=W4XpAQMLoPcYIJds71sdVq/JyX8F6FeC95oURHoYHqDC2vAQqgKihNh93XCbj+bnFn mbmdIuwz6EdXnEPfsJbdySrFdLqDLMS5Soo0ooMKgauakifWXVIcDa8+ojaWfb3tcsSF 5Jn8RzL/eMXk28XSZwyvnRkzwfYORnH8YZMc+kJ5bYq/I58talXIj9Tg0pwEMQI9Y1YC qGpikLDV4wtkziMU1oFU7mC/0dBMYmfmHNkNjQgWTMaRRVY50gQhxIIduY4cLImIjEaP Bi2lGRnfpUDOkDYETk+uFohQfRyQeB2gTWd66iaDEV3Y/RYybUJla67/5tpmUppeNrcm gQbQ== X-Forwarded-Encrypted: i=1; AJvYcCUDxwRGVXI7yVGmF/W++u36CnrVAPYu44Qspt6ENncyeykIQseqLbly5D1eU9F8dbiLFZwCH2LTfa0GMRM=@vger.kernel.org X-Gm-Message-State: AOJu0YxxDhrjCzd1twpa/+ytUez9fbqaeH1EbFNrYFMDC48YJhwozo9n bngivTm0TamMSKCt+FlYJA3+CzqAvytwXNCCHYopX1VHqVSiaqFGZCk3bEgH5CtPXUM= X-Gm-Gg: AeBDieudDsNnihG6KVjbP0WmjjsVzlRXX9ER0d1L1LG8HQKdZbnZOb/iYsEz7RZWrjF egR0OzgLPEtI4fpetwOi/KXhWMumfAIVeiTF0b0v3nFavIvYrrJKpABMI2/NVQRJwR7viZjiBZd BdGdVJfFVsTrU9HZfgf3dx1PamIOjayeXQi+5I8bVMjpTYuat943z3lTZClKpIGtQrTf7YMfZE8 h7ZDPjdZrnbWz7d2csTs4s44m8gZ19waoiEAKMb/Tpjuqk/2Q/+EI3WsyBJacXAPuVmKf2ufNv+ bV4E9sw52l2IT4Mekemmn6k52Gv7ISs55mn1c5AUJk/cLUnLgCfYDugIxmLkeivunmjj89woH5s 336l7eHReDfT52dyL70anAWlUN/fNqSx5Pa1vrgBrT5Lv9Y0YCOmn4hoBiyd7LeRNh0zrzccBBF ZwxDU1Ncbah35Pb/gTJndikmzq88Hi8+z3 X-Received: by 2002:a05:600c:a4a:b0:488:904b:f31 with SMTP id 5b1f17b1804b1-488997a44e2mr248941935e9.22.1775570755200; Tue, 07 Apr 2026 07:05:55 -0700 (PDT) Received: from ho-tower-lan.lan ([185.48.77.170]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4887e822227sm626876145e9.4.2026.04.07.07.05.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Apr 2026 07:05:54 -0700 (PDT) From: James Clark Date: Tue, 07 Apr 2026 15:05:16 +0100 Subject: [PATCH v2 2/6] perf arm_spe: Handle missing CPU IDs Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260407-james-spe-impdef-decode-v2-2-55d3ef997c48@linaro.org> References: <20260407-james-spe-impdef-decode-v2-0-55d3ef997c48@linaro.org> In-Reply-To: <20260407-james-spe-impdef-decode-v2-0-55d3ef997c48@linaro.org> To: John Garry , Will Deacon , Mike Leach , Leo Yan , Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Namhyung Kim , Mark Rutland , Alexander Shishkin , Jiri Olsa , Ian Rogers , Adrian Hunter , Al Grant Cc: linux-arm-kernel@lists.infradead.org, linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org, James Clark X-Mailer: b4 0.14.0 Don't call strtol() with a null pointer to avoid undefined behavior. I'm not sure of the exact scenario for missing CPU IDs but I don't think it happens in practice. SPE decoding can continue without them with reduced functionality, but print an error message anyway. Signed-off-by: James Clark --- tools/perf/util/arm-spe.c | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/tools/perf/util/arm-spe.c b/tools/perf/util/arm-spe.c index 7447b000f9cd..fc11f32e4911 100644 --- a/tools/perf/util/arm-spe.c +++ b/tools/perf/util/arm-spe.c @@ -968,16 +968,23 @@ static int arm_spe__get_midr(struct arm_spe *spe, int cpu, u64 *midr) pr_warning_once("Old SPE metadata, re-record to improve decode accuracy\n"); cpuid = perf_env__cpuid(perf_session__env(spe->session)); + if (!cpuid) + goto err; + *midr = strtol(cpuid, NULL, 16); return 0; } metadata = arm_spe__get_metadata_by_cpu(spe, cpu); if (!metadata) - return -EINVAL; + goto err; *midr = metadata[ARM_SPE_CPU_MIDR]; return 0; + +err: + pr_err("Failed to get MIDR for CPU %d\n", cpu); + return -EINVAL; } static void arm_spe__synth_ds(struct arm_spe_queue *speq, -- 2.34.1