From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yx1-f51.google.com (mail-yx1-f51.google.com [74.125.224.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 105293C465 for ; Tue, 7 Apr 2026 00:16:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.224.51 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775520969; cv=none; b=e+GGXmsJ/5RDazI/iM1VSYywC5XJlQGRI8JLnUSMFSgTekjhKaSKIpaXpkzv9i+71Op2jUGs3h/PP5C0qswWzZl33uHqLnZWbVyhw3XmVFVKyYyncp4gEd9jcMCZ9VOHq3EJPQmrXrJep7Yj1KTF74R53/uWm9HCwIsC31Ck/uo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775520969; c=relaxed/simple; bh=LfkYvGNeVcUMPzu6EUpovhxxAgmTZnYfYq+C8OGymRY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=nQn5JFtI8fhe89QuTSdcbVg6VNpacnUjPHEITnN9svG+EYQK3rveA/Gc/nTfxKl/tyTOYW4baFzMlQF1TAK28G5/BETBf1Rnay13AWbYFrxf3+XYqJZ2Om5CJdnF4O/RhZo7/GEpaI6Xkkuj3Ap14YfUK2yDZ+UN22K5ct3jKzI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=n1IryfIF; arc=none smtp.client-ip=74.125.224.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="n1IryfIF" Received: by mail-yx1-f51.google.com with SMTP id 956f58d0204a3-6501725d888so3430940d50.0 for ; Mon, 06 Apr 2026 17:16:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1775520967; x=1776125767; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=xFQLJBb/lmxRWKB/kx5iZa1pg9O2vzapGfay6oRBkO0=; b=n1IryfIFiR0hQp5Lgkw7I+X4jRXY1eIajpiyQYEKLgTMfNUP97iHJC2+teAqhcObIy t2n5vXFJAzpeN2+PquAjxsVcCa8laE54lKZxKdMz+CZEaonfcTE4xTL3RPVG0Fv2jFS9 ZnSyIJRZN48LPNywfCadM2BKlPjJAQIe+PQ0zi/CwxZYDy1PUSEM8dJG0lcBgsOa0hFW OHCiebc5HyT7P2IK9upx5NbJknz0zC6f0EN7rPSQPzGIT37xwh9IdCryhhmn32Yh2ImS j/etsFpKuKMLklxI/oI+mlf6KjfXF3c8ZOu6kCxjpvJw01fjcIJzDT3a9vLzNbj/ysuV uQSA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775520967; x=1776125767; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=xFQLJBb/lmxRWKB/kx5iZa1pg9O2vzapGfay6oRBkO0=; b=JzAnHWgBVDtBUJJhdy/6xpTanxKvPollNZrVzeGwMi8FRGWXUR2LknlNtnWD700YNB 9jwoOrEEXBBCnTFMSI6fCtS+nNTVba2SNhSylK6EXS+Ef5gxQJmAicbjoZtIlPE2+BRa s2HIpM4BwtOwghnVomz6A7LcXT9d5RPdw9n6hTexX37V5/evOfTfUQKr0Loohy/4leZ9 eHZlIb7cX6ztDfM1lWaBbf/IvAIFBqIXtwxrcOGRfvAy6HrmmkJU3vW5B7vBA4N7nlTv tqsUTCMLx20S/db4D26G4jgyHgREpZ/4MM4iHm1uJSk91zV//j8R13WCPDqyhGke0AxC C+2w== X-Forwarded-Encrypted: i=1; AJvYcCW7Mw1byzA2UDrwJ6RRtFh+QmiJgrj+6gn4K2fJAmw+G6Wk4/uQx1ihTx5tER4PYXUIHiNKzouS3N14Qns=@vger.kernel.org X-Gm-Message-State: AOJu0Yy6D5UBbyA7SxLZgbyi06dAMxYmt2OstKUrMsrz6tPQU5gByfWf wgv0XrWdAFaaWh5qZ6HGQnhcWBKWmtbkZsH8fkU7q5AMAlEQFyyE1MK4Rea3JpFt X-Gm-Gg: AeBDiettxoIeSKnZZv+WdCBVqXtO7+Vc6i5yBIgUk6x+qoAvsjJEbNlWiwQq/xI6cuN lcBBu2oxQJvLd+ttuejCM5QBoFN2uSl5iXTzOODjl8Fm3GWZRVTtKTKF6MhVsZlhW/+z2I9gzJM EfN2/ky5xgvbTjwktP+QaWBgy3elcRY82PVZtUr+aaTBEeKFAqQoXzUzJS9K+zENu9rmUhNENeo o72hY1ZS4OUz8KSaeAM8lNAst25JwxY6WNCJ6mBn49hfgfHKOg+/XQabSSl5+nh1B1OAVMEEuaz o6jjviXgKjoFd3OF54WMr2r8Ae8vuv4UzGW/yH/Uw8IZGm98sG/V+E+Jbwh9i5HUvZZxwn0+1EZ REFI0Y2McZ3tut2xg2TMwJsbg49JVrOOaX8z3q0qaL7VQ0GvoPw1W/7Hs4OC2YDNIOTv3W6pgQc y5fUykyIhPGIzPIZ2F5Nlh4VSyPK6mRP4f84fcuMj7x4mhfWCMd4r14EbgRPNU X-Received: by 2002:a05:690e:d49:b0:650:37e7:e590 with SMTP id 956f58d0204a3-6504869b126mr13770674d50.15.1775520966993; Mon, 06 Apr 2026 17:16:06 -0700 (PDT) Received: from DEV.lan (c-75-74-152-49.hsd1.fl.comcast.net. [75.74.152.49]) by smtp.gmail.com with ESMTPSA id 956f58d0204a3-6503a9d50afsm6698649d50.19.2026.04.06.17.16.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Apr 2026 17:16:06 -0700 (PDT) From: Joshua Klinesmith To: linux-wireless@vger.kernel.org Cc: nbd@nbd.name, lorenzo@kernel.org, ryder.lee@mediatek.com, shayne.chen@mediatek.com, sean.wang@mediatek.com, linux-kernel@vger.kernel.org, Joshua Klinesmith , stable@vger.kernel.org Subject: [PATCH wireless v2 2/4] wifi: mt76: mt7996: fix RCPI chain 3 mask in sta_poll RSSI extraction Date: Mon, 6 Apr 2026 20:15:58 -0400 Message-ID: <20260407001600.31234-3-joshuaklinesmith@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260407001600.31234-1-joshuaklinesmith@gmail.com> References: <20260407001600.31234-1-joshuaklinesmith@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The fourth receive chain RCPI uses GENMASK(31, 14), an 18-bit mask spanning bits 14-31. It should be GENMASK(31, 24), an 8-bit mask for the fourth byte, consistent with the other three chains and with the RCPI3 definitions used elsewhere in the driver (MT_PRXV_RCPI3 and MT_TXS7_F0_RCPI_3 both use GENMASK(31, 24)). On devices with fewer than 4 antenna chains, the corrupted value is masked out by antenna_mask in mt76_rx_signal(). On 4-chain devices, this produces incorrect ACK signal strength readings. Fixes: 98686cd21624 ("wifi: mt76: mt7996: add driver for MediaTek Wi-Fi 7 (802.11be) devices") Cc: stable@vger.kernel.org Signed-off-by: Joshua Klinesmith --- drivers/net/wireless/mediatek/mt76/mt7996/mac.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/mediatek/mt76/mt7996/mac.c b/drivers/net/wireless/mediatek/mt76/mt7996/mac.c index d4f3ee943b..a0342012e5 100644 --- a/drivers/net/wireless/mediatek/mt76/mt7996/mac.c +++ b/drivers/net/wireless/mediatek/mt76/mt7996/mac.c @@ -205,7 +205,7 @@ static void mt7996_mac_sta_poll(struct mt7996_dev *dev) rssi[0] = to_rssi(GENMASK(7, 0), val); rssi[1] = to_rssi(GENMASK(15, 8), val); rssi[2] = to_rssi(GENMASK(23, 16), val); - rssi[3] = to_rssi(GENMASK(31, 14), val); + rssi[3] = to_rssi(GENMASK(31, 24), val); mlink = rcu_dereference(msta->vif->mt76.link[wcid->link_id]); if (mlink) { -- 2.43.0