From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from verein.lst.de (verein.lst.de [213.95.11.211])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6A8883793DC
	for <linux-kernel@vger.kernel.org>; Tue,  7 Apr 2026 05:54:15 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=213.95.11.211
ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;
	t=1775541258; cv=none; b=b3SoT5fRs70EKEnlNXVufv5hZrX/bbN79kydpiWAlSkojNzYTaLCJU06748mpVvaCUlVQzPDd3G38wFqT8xgerrJpT2Lk3UFNWP5aC6CD4o69WGKf8bwEy9UyjGsiYhrEpj8xDC/x2XtzsH1fIw8d1nR6//fXAU12GQIM26ADwM=
ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org;
	s=arc-20240116; t=1775541258; c=relaxed/simple;
	bh=wvQV/Lzt0XgZrMJV2Z5BpDmBDHVs7izr+/JzmYXzbBE=;
	h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:
	 Content-Type:Content-Disposition:In-Reply-To; b=lE1Cfq+Np7EYKFFv97KesnN/H5aAQ9aBHrMP95q8iFkntNbO5nPFCYuG0FDG8m9t6nLdCf1u+tOHwJEv2lercoeyFF7zOLussJUylowRXuI3w6YDu4U8Jr1vUYV0bntmEhdaIZtS9kquWp4PBAsI1WDzbwLPpcb0Wx93GTvW4gI=
ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lst.de; spf=pass smtp.mailfrom=lst.de; arc=none smtp.client-ip=213.95.11.211
Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lst.de
Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=lst.de
Received: by verein.lst.de (Postfix, from userid 2407)
	id 0270868C4E; Tue,  7 Apr 2026 07:54:13 +0200 (CEST)
Date: Tue, 7 Apr 2026 07:54:12 +0200
From: Christoph Hellwig <hch@lst.de>
To: Daniel Wagner <wagi@monom.org>
Cc: Christoph Hellwig <hch@lst.de>, Daniel Wagner <wagi@kernel.org>,
	Keith Busch <kbusch@kernel.org>, Sagi Grimberg <sagi@grimberg.me>,
	Hannes Reinecke <hare@suse.de>, linux-nvme@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] nvme: expose TLS mode
Message-ID: <20260407055412.GB6405@lst.de>
References: <20260401-expose-tls-mode-v1-1-433a83d1d23f@kernel.org> <20260401140934.GD21703@lst.de> <ac373146-cf2d-47e0-a851-9c304bacd5f2@nitrogen.local>
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <ac373146-cf2d-47e0-a851-9c304bacd5f2@nitrogen.local>
User-Agent: Mutt/1.5.17 (2007-11-01)

On Thu, Apr 02, 2026 at 08:42:57AM +0200, Daniel Wagner wrote:
> On Wed, Apr 01, 2026 at 04:09:34PM +0200, Christoph Hellwig wrote:
> > Looks fine to me with the example fixed.
> 
> BTW, do you think an empty string is better instead of "none" when TLS
> is off? 

Empty strings are confusing, so either none or off would be much
preferred. Out of the two none would be my slight preference.