From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f182.google.com (mail-pg1-f182.google.com [209.85.215.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B8598381B1B for ; Tue, 7 Apr 2026 06:21:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.182 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775542910; cv=none; b=sXRrXWU4gYqzSU57cgMNOTrgmh+bMrhSgrIKaSjuFkO6dHi6SgY+An4a5wlmPOtCSJ8rm+aepjbjEZvUClEyXaogCyqnwz8EQ8IzOoYTri8RcKYBXNVdMuxGQGA2Fdt48EyLRNpQUZaSq36HPhK8xU2yV9AYu1B0NKsN/synwAA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775542910; c=relaxed/simple; bh=svIk16rOxDZdvYjL960T1InOrh5WjHTfn0DXLglJZy8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=gGhNliFMKW9+Z8dDaFCjhbEmY+f9p8cMV63cq7frQy+k0fB2VuZD8mPOc0pao4us/VO+TFUK4O8DMh30S9ecErECBs8pWxY1Xj/Ngheq7EM7VFMxzoAKfUiuFAHa+1hnVa0SM3bOIpuss9aKmYWoIxbYRN9JjWs+hFHOyBjZ5ws= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=S5581krN; arc=none smtp.client-ip=209.85.215.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="S5581krN" Received: by mail-pg1-f182.google.com with SMTP id 41be03b00d2f7-c70fb6aa323so1597843a12.3 for ; Mon, 06 Apr 2026 23:21:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1775542909; x=1776147709; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=svIk16rOxDZdvYjL960T1InOrh5WjHTfn0DXLglJZy8=; b=S5581krNDNYXV/lfOwBRMJnitN6zyLF2xCWx5mu1jO8mHxUYPNofsThRBJGdOm2cwg F4TX4jDdAR5EjbGaulyDN8ILwmEZOqDiZfoFthCOoJC8mYb0ZkjiE0pDL9jAEU3eXnKT V64HELTH1EGNCP1X9uNqm+JOajPChW0THEBr/wrdHk2b+96tfjrS1a07ezfT6kweDq7S VPEB/zSEyT26huNezXa+Q9KdfUK6uALz1vfSotz3Iq9wEa1poUWLrWKEVZUZ+SDzBDkm zBXEM3Yx7HzDJIKDmiCW8LuuKVSMkwSI6jIzgbNgxsgndVQK+I63wYkOEGkDRHPBKjiL Ae8A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775542909; x=1776147709; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=svIk16rOxDZdvYjL960T1InOrh5WjHTfn0DXLglJZy8=; b=NEosEKgnh97JX0AjPMpCMAUb4z287Bn+2k5lW0jEkkJInRZZ3mZ2ydvqFy1ipd3fFd YuDQxgjPX+ATegY7opRHQkXHOKHmsxGxuOXxNVqnSfs0BvLci9MAHxsZhlSVS+WhbUY+ 06nntMc4aZPgVXdVrzSFdjDNwKsR/rVdrMLfnDsdxacXHopJnOSi31HNunJj2YxFC0XF 5TDRhNcmXRJhYKaWDm1OSl8n8GApreSDd+5rX6/Z5qZEPPfhtAEOgoScVf4twvvWHGlN /VpjgOGSucsL2d1Q44zhD++VQSG1o9D96EpJB2zPB2/1ttwgvwaRbTwTa7JndN9VSmjc YXww== X-Forwarded-Encrypted: i=1; AJvYcCWaLBb+RkXvuIDAurpBoYFFfKlykstMRc0f9O2fcp6nDWwDOhFFlwZvRZlkLM/W+DG0FQqlVfJvrSsn1tE=@vger.kernel.org X-Gm-Message-State: AOJu0YyCfCs2ZxlN59klG+1jRJLC//ChJxReT50N3q86C0BNo2PttutA OOjmyiQgYjgSosiA5S+HPgDBbVYLMyiTqWIWmpD1IaRR4b4pzZXjBpu1 X-Gm-Gg: AeBDietWzNwoq3n5PiUj9+JZQXz+UTwGl6hqIi0QPqoAU5gtKSSXMeXTYKPlwOTULfI 6ucotM0Nn1htckCvwGa2nLHmZQM9geOHIVfsAtPne5gD+qyB03uwbVg/VkkDp3bHoM0w6XwoIvU eON101B2pLKZFlx/BKBgMTdMGMgfVMKtyWUhWxSBcPurTkUlOz8iEfjGXsuRKgAPlg1AAVChYMQ ZSSVlmeFJecy+3KEBhVSp7eRTk8arZqFLGcb6P8GoOYk7YnomBsCut4E7CRS8+LgHxpAW+Thir/ DAZkiIJ36fBciE6DfOQEYozMc39kGt1LycOvkgPz2P7Bw0Lxiy4AQchxshq0dAcP7QVgWyjRHML 5YWhy30xav+NTKyw0bZ9rnhfvOFY3SgNlVZRfSvioAnZxrKBNsKsqDLMkUalB+CFOOuKfRlSwux s4TmDnXX0CYk9xXB8MS75axrZqoyJIwXVO8yEWZAiHBGjDA6lMdZOTP5xJEiURl07GSP66dy9gJ HJvobqaksGwx/+P X-Received: by 2002:a17:902:da92:b0:2b2:5256:9ce7 with SMTP id d9443c01a7336-2b2818e65c4mr163971965ad.36.1775542908952; Mon, 06 Apr 2026 23:21:48 -0700 (PDT) Received: from localhost.localdomain ([45.248.78.44]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2b2b118f84csm6942705ad.58.2026.04.06.23.21.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Apr 2026 23:21:48 -0700 (PDT) From: Nathan Rebello To: gregkh@linuxfoundation.org, tiwai@suse.de Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, heikki.krogerus@linux.intel.com, Nathan Rebello Subject: Re: Spurious errors "ucsi_acpi USBC000:00: bogus connector number in CCI: 1" on 7.0-rc7 Date: Tue, 7 Apr 2026 02:21:13 -0400 Message-ID: <20260407062113.1494-1-nathan.c.rebello@gmail.com> X-Mailer: git-send-email 2.43.0.windows.1 In-Reply-To: <2026040734-headfirst-tingly-e6ea@gregkh> References: <2026040734-headfirst-tingly-e6ea@gregkh> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit On Tue, Apr 07, 2026 at 07:58:00AM +0200, Greg Kroah-Hartman wrote: > On Tue, Apr 07, 2026 at 07:38:50AM +0200, Takashi Iwai wrote: > > Is this a firmware bug, or some missing piece in the code? > > Judging from the message, it means that ucsi->cap.num_connectors is 0, > > I suppose. > > Ugh, what's the odds this is an off-by-one error in the firmware? :) > > Nathan and Heikki, any ideas? This isn't an off-by-one or firmware bug. Takashi is right that num_connectors is 0. The validation checks against ucsi->cap.num_connectors, but notifications can arrive before ucsi_init() has populated that field via GET_CAPABILITY. Pre-init notifications are already handled safely by the early-event guard in ucsi_connector_change(), so the fix is to skip validation when num_connectors hasn't been initialized yet. Sending a fix shortly. Thanks, Nathan