From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dl1-f73.google.com (mail-dl1-f73.google.com [74.125.82.73]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9E9AEDDCD for ; Tue, 7 Apr 2026 06:46:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.73 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775544370; cv=none; b=OaE3aEEtfAot1x70f5GZyPVovrecPwA1p6FKJuad6eLHiKQDlLnFr0Rmz6MXkZrSCVzrnjiH2RGDQKKMaG20y3oPP2t2JbsHlzngYyJE/oZJ20Yp82ap90w4pzPTIArIHm43q13mELxog3UvREbDunkBzXdfG93XOhXyKrXJ2Yw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775544370; c=relaxed/simple; bh=EuQ94UQRGamNEvKl4ItgKYazHWgUA0nKvtb0UT0leFU=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=YWzfAwpe/AU7oxLUz9cZxPOCKfNM8Y99J92GSpXC9yK7/Ca0jVmPQaIBcQFbYlawzTaoxNvq4bpOtumd2IW0g05dYVOr5RKvtPXdIRWc2efkg0vd1rRTSB+cvC2i+/5Lmd11m/CltkVB1qb+oQBMKPnGByHodLjgJbUC3QGZaYA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--wnliu.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=gGftm0kZ; arc=none smtp.client-ip=74.125.82.73 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--wnliu.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="gGftm0kZ" Received: by mail-dl1-f73.google.com with SMTP id a92af1059eb24-1273dfdaf5dso4615412c88.0 for ; Mon, 06 Apr 2026 23:46:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1775544369; x=1776149169; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:from:subject:message-id:references :mime-version:in-reply-to:date:from:to:cc:subject:date:message-id :reply-to; bh=sjddnILpH/lRXg/T9aV00xAEjWsnXJ4ijmDgFRwGJUg=; b=gGftm0kZoOyfMBxepbTP5MTJsfWNXzREGNpHJ4spSkimSh4eCVTMrbsObMcmRkrLMM +NG5deQ7EH8DlIDQa/fmN7jut5VesoBXm8oJuMvuplWbaKZcKigWFLiCeBoOtmtVC/+L ezX/bFXuoHOl4pj4Ep+7bHmLjVzn+iqhtaAY7FY6df4VnX7uz3kqkopVqAG7wAci6fWT 4oH4ANLyb3HWW5TClQbvivULy46Varp57QNHjkWHVOYT4sEXgm40RzPSdJ9snApUdqQ3 7825WmBFqgSOGXVOcVsipNPng5CVJEVQiYMdDZjgs3ioubakNCT9faxruQDDdTmPcmhd tPrA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775544369; x=1776149169; h=content-transfer-encoding:cc:to:from:subject:message-id:references :mime-version:in-reply-to:date:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=sjddnILpH/lRXg/T9aV00xAEjWsnXJ4ijmDgFRwGJUg=; b=ahH1ZkITy7zLao2xyUahLdmPOKKhymLdk3HQo90yA3Kh0epF0GIOEFIfiB5JfcjB2M +WP1gcxl7PacBXHqKL8TV5McDvUkRNoBlg/mdZ+lO7INnT0dPNyROaQcE1S8DE3yd9hj WJKkbKH7MN6Pv71bKuUn2MaKWCwfN2z4+rBiujiR4WDKx8uZKrr08Cd/30opBOUG+0JL 9qp3CUvnzmbdIXnseg3ysN807jXNIvF+YEh4v0IzHScMb5DWFaN70FcYo9aE9mv0R9qC nvatdeZfALdmkKQF1Cx6x9gEl9e4bQGNkuK7vitqN63gCvsGYorIRkTd8oUIbg49HQAe cuog== X-Forwarded-Encrypted: i=1; AJvYcCW1qWic3mekfArHJDtGkzA37bPtZt8baDHib4hb2xXP0qqTP1sZJjrZ0W32CjPFju6zzNm+Lh/HldFfRcY=@vger.kernel.org X-Gm-Message-State: AOJu0Yzn39Gq7wsv11RuOLJ8TTBiaVQgmcrbOZfITeu6aDORlV/JwmlC K33KCjWYmV+OGtPojY/nVbyKLdn49I6HZ//QC/4+IFPgbfUBm/ZaE9JMdiwZuJ+cAIcRD0jCHT7 tmQ== X-Received: from dldoa12.prod.google.com ([2002:a05:701a:ca8c:b0:12a:83c5:a16f]) (user=wnliu job=prod-delivery.src-stubby-dispatcher) by 2002:a05:7022:6706:b0:11c:883d:1ef0 with SMTP id a92af1059eb24-12bf08538c3mr6887678c88.15.1775544368429; Mon, 06 Apr 2026 23:46:08 -0700 (PDT) Date: Tue, 7 Apr 2026 06:46:06 +0000 In-Reply-To: <20260330084206.9251-5-suravee.suthikulpanit@amd.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20260330084206.9251-5-suravee.suthikulpanit@amd.com> X-Mailer: git-send-email 2.53.0.1213.gd9a14994de-goog Message-ID: <20260407064607.611771-1-wnliu@google.com> Subject: Re: [PATCH 4/22] iommu/amd: Introduce IOMMUFD vIOMMU support for AMD From: Weinan Liu To: suravee.suthikulpanit@amd.com Cc: chriscli@google.com, dantuluris@google.com, iommu@lists.linux.dev, jay.chen@amd.com, jgg@nvidia.com, jon.grimm@amd.com, joro@8bytes.org, kevin.tian@intel.com, kpsingh@google.com, linux-kernel@vger.kernel.org, nicolinc@nvidia.com, sairaj.arunkodilkar@amd.com, santosh.shukla@amd.com, vasant.hegde@amd.com, wnliu@google.com, wvw@google.com, yi.l.liu@intel.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Mon, Mar 30, 2026 at 1:43=E2=80=AFAM Suravee Suthikulpanit wrote: > diff --git a/drivers/iommu/amd/iommufd.c b/drivers/iommu/amd/iommufd.c > index ad627fd5ccc7..e7ffa7e8915b 100644 > --- a/drivers/iommu/amd/iommufd.c > +++ b/drivers/iommu/amd/iommufd.c > @@ -34,6 +34,9 @@ void *amd_iommufd_hw_info(struct device *dev, u32 *leng= th, u32 *type) > > size_t amd_iommufd_get_viommu_size(struct device *dev, enum iommu_viommu= _type viommu_type) > { > + if (viommu_type !=3D IOMMU_VIOMMU_TYPE_AMD) > + return 0; > + It should also return 0 here if amd_viommu_init() fails or if amd_iommu_vio= mmu is false.