From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.alien8.de (mail.alien8.de [65.109.113.108]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 92DBC3A4514 for ; Tue, 7 Apr 2026 14:11:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=65.109.113.108 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775571083; cv=none; b=f24GnVHAVK/M6Knwu4l8uZukENZrcFnOLqS5T5XJj3qLnz+FI8ZcyiV4mVAZhsU/swT1cSqpoJcICTwjYhe1VkuIHGPKIn/ETaFFPL/fe3t1lK3vdF1MUELfkaqmNmDDeuQ9gAk+lakSrhHqgavcB/tJeDiQs9ImbBSPwG6lQGQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775571083; c=relaxed/simple; bh=W9N3E4J6T7YYHNJqMPvjbjwpbVNUzIh7aifbNMZH+/s=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=gDqizDijS2NrNSR+I3ifuG0jR3oKktPDzIkKmxBuR0HdYYEXgLBE6ItUXGWhhlBqJDVVBezCOkKDVsFoKlLZi3shN3GyhGBMNIbDO1OzdSMk5Vz5SGnnK9wRVgz3/bxh7lOAXqf82UzBs+WVSaibDy5GlxEcxP8fvw69ENhbuKU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=alien8.de; spf=pass smtp.mailfrom=alien8.de; dkim=pass (4096-bit key) header.d=alien8.de header.i=@alien8.de header.b=R5U0mxZS; arc=none smtp.client-ip=65.109.113.108 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=alien8.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=alien8.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (4096-bit key) header.d=alien8.de header.i=@alien8.de header.b="R5U0mxZS" Received: from localhost (localhost.localdomain [127.0.0.1]) by mail.alien8.de (SuperMail on ZX Spectrum 128k) with ESMTP id 5A46440E0163; Tue, 7 Apr 2026 14:11:18 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at mail.alien8.de Authentication-Results: mail.alien8.de (amavisd-new); dkim=pass (4096-bit key) header.d=alien8.de Received: from mail.alien8.de ([127.0.0.1]) by localhost (mail.alien8.de [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id 75w5tsd2D395; Tue, 7 Apr 2026 14:11:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=alien8; t=1775571074; bh=gxvV/V19Wtd/F+NgHaqwmHRegWYSIb6/hLWPSse0M6o=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=R5U0mxZSBt5qDgPcBwd+SlHJ3VCtcrrutzc3OarS+/jCjvT1VpLqC4Fx55OLA5up7 8Y44MMIJB+OoOFUPdUpfg1BiVEHFfXXZxBnH+GlP7d+c7a1TUWYuAgDDkk+ufE9j26 vfjyctydVwgWi/fY1EHIyTVrEZittNA3sE9a0X9w1i2BDNpRfe2VNeYmF+sxPDUo9G +H0vJEQ9k+b92JBaR4Qm0Lzyyp7yY15Asp6LWtfdEcG1Ogn93USd0ArtYMEtZeeqsH KS6W18Bq6vZVNwZLR+131DEgd0uuSAofjAzPOmOxFFs1N2HiVDy0z0mwnQVBvyftEs XX5Z72qbgQOApekPctu1jH/EmZbCfjyJL9Vi+W9YhafPferJQLAXGr3LhYkSy/fdlF mkdY1+WvevazSyNpUdaon/fsA9i8Mn6COcHEJfzIahRBoxjHUocZuwFvTN2SQKovrE 9SAaVUkZtdLyb5ZJJ8ZHMfFEJDlOP8CEiaEeGq0LUjgAKEGJxYVe4Jj0dpWINwdAVP fDpLo87qFnXY9g2P5BNkJNOtbv39/sMVTwTKYvdYWHY/23DPAD0qRyF4gn9f4NQKm+ E2WUCa040sdKfANYJAuhGzGiggZPmW4va/lxkUtBZcIu53pxXUPNNWjnLaURiwPa9P Pu++/vuaSJ3qHJlSuhnNy9R8= Received: from zn.tnic (p5de8e020.dip0.t-ipconnect.de [93.232.224.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature ECDSA (P-256) server-digest SHA256) (No client certificate requested) by mail.alien8.de (SuperMail on ZX Spectrum 128k) with UTF8SMTPSA id 83A5B40E00DE; Tue, 7 Apr 2026 14:11:06 +0000 (UTC) Date: Tue, 7 Apr 2026 16:11:00 +0200 From: Borislav Petkov To: Dave Hansen Cc: Fu Hao , tglx@kernel.org, mingo@redhat.com, dave.hansen@linux.intel.com, x86@kernel.org, hpa@zytor.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 5/8] x86/microcode/hygon: Add microcode loading support for Hygon processors Message-ID: <20260407141100.GDadUQdPUIEnGA18Om@fat_crate.local> References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: On Tue, Apr 07, 2026 at 07:00:39AM -0700, Dave Hansen wrote: > On 4/7/26 01:24, Fu Hao wrote: > ... > > arch/x86/kernel/cpu/microcode/hygon.c | 927 +++++++++++++++++++++++ > This looks a lot like: > > cat amd.c | perl -pe 's/amd/hygon/' > hygon.c > > If it's something like that, I think it probably needs to get mentioned > up front and discussed about what's actually *different* from the AMD > implementation. Yes, and there's a *lot* of AMD-specific stuff in there. I'd suggest you go through the code with a fine-toothed comb and remove everything you won't need and you don't use. Thx. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette