From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f48.google.com (mail-wm1-f48.google.com [209.85.128.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 26AF83BE16E for ; Tue, 7 Apr 2026 14:25:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.48 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775571944; cv=none; b=H0VJvFLMjOp8JBzwfw2lfDIyJjgzNpQA0UskFUtEfKUmozQ/LywHNWTyXyzOm7FxQPR4saeR5yy8qYH6BN7v/7tB7jVb9YXO7ARy+DFKNXQng7+RFkdQnCvM33Bed1I8+P/fDueuYJ/TcTgAXy6E9m0odFGxY9gRQO4VcxXdHj4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775571944; c=relaxed/simple; bh=YxZ/d8hWc5Dojxq2+WQ8y//zQ0MV75jV5AaZq1iu/u8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=RIVnmDzQ7wpmXzPxKT2s0b3tHkFgD8vLN07tDYvscGnMdA0Fn27O69fsC84jpmLHksY7No7fJPdud94mqr477ClVd4AmKqXAgoySlY9AKlZCZSXvj0oJvisubODWr9IukzaBgU06cwF5RqQbZuf8aPPGcJB12WDNeZPNYP0zVAs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=jIbURaW+; arc=none smtp.client-ip=209.85.128.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="jIbURaW+" Received: by mail-wm1-f48.google.com with SMTP id 5b1f17b1804b1-483708b697cso7713325e9.3 for ; Tue, 07 Apr 2026 07:25:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1775571941; x=1776176741; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=dxSRimATBcfYurd5oZ/SGQyL2ML4iFG/Nsr5i0TaWFg=; b=jIbURaW+ukOGuQQctJEoairvOPQeByCUvvxUD+PGkWm6bdyaiWI0ltQPinY65dB0QY ua5efzQYPoCVt3wl1z9nD7vLnIC3gtnCxv+9QQguRXpkAI8wx/qvDbEn4HDBYJ2y8vNj SW/DBlfFCR0Sr2SdbmGq/N+TlKgS3+J3daqp+zDDwXfwiHW6uXnFDx7ENxrEQ4oNueqc /8JozC6SehqasCorKIalQkCfSha4F2jFxa+ScdFfj+XRwQEikNce2d5zA+BvL93yBKUZ HJ4zTMAja1OOuwcJSkVFCQKTNRtHb0QIudmcR3S6bTdkKkniRYehBdOpX2IxP1zjVosz 9r1A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775571941; x=1776176741; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=dxSRimATBcfYurd5oZ/SGQyL2ML4iFG/Nsr5i0TaWFg=; b=adniE1MNvBgAIaFD6Fqc5DHI/kl22xV5NBFucDAfSYFImnR//fuCMWVEbibYJWZPxK I4KCbq75K9ooI7kUVqsYlsXwSf+0DB5JGOdpW3DBkVDIVoMs0UngtmO+OLL5xn7z7lTN 7R8kvqQw6nHxnKC9WwNbUht9dEFzHBUOnQJu3o8a1gaGbV+2HYKL/gxvtu9HoFR7AFZ5 RwEx+InKCBtf+XWHwQJsu+WV036w/OrsmraLetb+f6FaQiDVAizslkPTwZslbIMgBrft Z8eOBRydbdzQIup9WzkQ3bpm4zo+0bNUX0pmnJy+EaeS2OhJOBB8H0OEJNKoQAOPSkgp DkQQ== X-Forwarded-Encrypted: i=1; AJvYcCUEISwVP/MSnVVzl21ExNE99TvrwO4FsSv32JsrdYlL5wAbOBu8++idE+NhcR/miuyxAzwSvlQCrQuANFM=@vger.kernel.org X-Gm-Message-State: AOJu0Ywl2atHIYIevBMJUJ085gyRJpXa87GOzLQeprSqIn3SZJSa4YU9 gl64Z2q7GpNNw0LrqB+djCvdg8luBr5cTx0rH/fLz2oyenpC2idFwEkx X-Gm-Gg: AeBDiev+ssX87peXgpW5PYqjnaCUXXCtx7gL5GVdNuqdk7P9JgKF5DoDjqvWk7/2jxj i7pSGWHlYEDyp7qqzVKcqKwDYFLxH7bpUU21jMgL50UHhZeDXnKHXRjHm9PuixCzOK9orST3KKr 1gWotPAV61pFq+riqcsYQ8f7IpMurUbtq9CH11kPv84Fztcxp1GfYEMtv1ZvNVmFOdRXSk747/8 krxFVEgX5BMTODc+ddyRilGiY0iNaEjpiwJJHEHlY8Eo5Xq27H22nFrS1oy3+rxM7W6oSN6LTg4 YrNJ96TIyVcmC4jDHcFmFsY3JueapDO84FogsAjTbOEep/pGNiwnuaasxfIUArKiMAA5n+iQ5Ju w8nsVDqRLKT80vbRodlp9g8GddEzqi2h5ytJUPlpXfZox6ojsA8nRZlDpjSWhTRExAKxq6gYhRG ehPJb/bkZn+7eu9t4wb0cDr3znon/kgakailNUJvrO55litGx3hb6rtbUX9u/AYw== X-Received: by 2002:a05:600c:3152:b0:486:b967:5c9b with SMTP id 5b1f17b1804b1-48899e90690mr135036095e9.3.1775571941416; Tue, 07 Apr 2026 07:25:41 -0700 (PDT) Received: from localhost.localdomain ([31.7.38.28]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43d1e4f1a99sm53489990f8f.32.2026.04.07.07.25.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Apr 2026 07:25:40 -0700 (PDT) From: Emre Cecanpunar To: platform-driver-x86@vger.kernel.org Cc: hansg@kernel.org, ilpo.jarvinen@linux.intel.com, linux-kernel@vger.kernel.org, krishna.chomal108@gmail.com, edip@medip.dev, emreleno@gmail.com Subject: [PATCH v4 3/5] platform/x86: hp-wmi: use mod_delayed_work to reset keep-alive timer Date: Tue, 7 Apr 2026 17:25:12 +0300 Message-ID: <20260407142515.20683-4-emreleno@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260407142515.20683-1-emreleno@gmail.com> References: <20260407142515.20683-1-emreleno@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Currently, schedule_delayed_work() is used to queue the 90s keep-alive timer. If a user manually changes the fan speed at T=85s, schedule_delayed_work() leaves the existing timer in place as it is a no-op if the work is already pending. This results in the keep-alive timer firing unnecessarily at T=90s, just 5 seconds after the user action. Replace schedule_delayed_work() with mod_delayed_work() to reset the 90s timer whenever fan settings are applied. This guarantees a full 90s delay after every user interaction, preventing redundant keep-alive executions and improving efficiency. Fixes: c203c59fb5de ("platform/x86: hp-wmi: implement fan keep-alive") Signed-off-by: Emre Cecanpunar --- Changes in v3: - Reworded commit message to clarify this is an inefficiency fix, not a functional bug. drivers/platform/x86/hp/hp-wmi.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/platform/x86/hp/hp-wmi.c b/drivers/platform/x86/hp/hp-wmi.c index 79d6bc3cd223..2932cab9aa78 100644 --- a/drivers/platform/x86/hp/hp-wmi.c +++ b/drivers/platform/x86/hp/hp-wmi.c @@ -2361,8 +2361,8 @@ static int hp_wmi_apply_fan_settings(struct hp_wmi_hwmon_priv *priv) ret = hp_wmi_fan_speed_max_set(1); if (ret < 0) return ret; - schedule_delayed_work(&priv->keep_alive_dwork, - secs_to_jiffies(KEEP_ALIVE_DELAY_SECS)); + mod_delayed_work(system_wq, &priv->keep_alive_dwork, + secs_to_jiffies(KEEP_ALIVE_DELAY_SECS)); return 0; case PWM_MODE_MANUAL: if (!is_victus_s_thermal_profile()) @@ -2370,8 +2370,8 @@ static int hp_wmi_apply_fan_settings(struct hp_wmi_hwmon_priv *priv) ret = hp_wmi_fan_speed_set(priv, pwm_to_rpm(priv->pwm, priv)); if (ret < 0) return ret; - schedule_delayed_work(&priv->keep_alive_dwork, - secs_to_jiffies(KEEP_ALIVE_DELAY_SECS)); + mod_delayed_work(system_wq, &priv->keep_alive_dwork, + secs_to_jiffies(KEEP_ALIVE_DELAY_SECS)); return 0; case PWM_MODE_AUTO: if (is_victus_s_thermal_profile()) { -- 2.53.0