From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f49.google.com (mail-wr1-f49.google.com [209.85.221.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C3B6635E939 for ; Tue, 7 Apr 2026 15:17:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.49 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775575028; cv=none; b=AeltG9wyuSDB3oAAFHoXj+GIeKTvF/DTZkTZvnGzgG2mLUzf71cF4PERmQjktGLDCCaXihmBvpzqKfgR7yN4k9MgAphKkQlp3WpdQki0eulb2usmyVGgJSzZTzlYDddDGSFUgpgb/6uDTCAs2UhhpaH699OKzOJSK4sJOzQHEp8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775575028; c=relaxed/simple; bh=BN2pG+ggdHeNF5nMAlMlL8UpqqNMmhM7u8s4CviSu9s=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=ZDBbOHhgDKHMqJxUOjYjsYYjlslgkbf3rNF0HvXFUdFfdjVCsLK8J0AbKOjwYPkKNBTdVtQIYoT5JTZEj/Y6epnn+9jt+o9+CKa8+5wDLzxO8BuvNhxRO86fpAmEVrYxhogEGOXW8Bv3niynmNDx6byup2824p4TW1M81139ftU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=K5yOfu1W; arc=none smtp.client-ip=209.85.221.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="K5yOfu1W" Received: by mail-wr1-f49.google.com with SMTP id ffacd0b85a97d-43cff5dafc3so4542551f8f.1 for ; Tue, 07 Apr 2026 08:17:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1775575025; x=1776179825; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=rnxS0m7DOJUnPu1WgBcCkLSOJWSnp+7wrzdW4TpX8Gc=; b=K5yOfu1WkUX4hppeU5wMMX7SjjlwY6b2kMEyxw0ajMF4JJgHXxmiP5conQdNE22NE3 wqrla1mDNVwITncGT00YXsvY4Q2UNw/AkNH303Og1BIa0o86vfv00V138kuxGKMJiaHP dBBwKwVjZ7c91YL3kQfYHHaEeKYMuOyKlXKgn0+5uKaAu47A0FPGjXptyFw9kukrdNTW bBHjbWMfMTi+fwMB2DONJgk66u7pd+ZHsb6GDQqOrxbiSUcXGwHQ36t5VeFOR+Hns1OQ bIf8s+ybbEGiw1vGZorzULYLzAGOAsadN5EYiqU+K5fvh59m8ve5lGZk0dmoF6zmMFSd 8Jeg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775575025; x=1776179825; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=rnxS0m7DOJUnPu1WgBcCkLSOJWSnp+7wrzdW4TpX8Gc=; b=CrLi54r3PHaJbZXJ58G5R6ivKR4O+vqIrl1SWVfSOZoBGLeOpt/oMh+dWnS3Al3mBJ TjZ/sD94K3Lu2y0jnXQVYcvl9zXh4dNvUM7jXTFISu+8tqGdbqVfAT2X+b6GiTKQNPhb mNbSs10N+wZMgbZoVnUpHlvcSOQzz6i36MkljA1Xv1Ol5znsiwWchxEM+m8aJoiZh++h 0smPwY//ZQaFumNbgaAs+7zUsRXAFM8yPHYoZHaMuXvEvMWCulmSK6DTWMDXIvcRkP+1 2iNKPRnRWCEAC5qWOQpBTfA/0xJPvtJwKc7OZBt26U/RMzzNYHTwj19THif2DDf6B/bE LClA== X-Forwarded-Encrypted: i=1; AJvYcCUS42owQPJQ8W7E5g1CTAP+tkwwEYGcl7wsWGBlvb/p4nIl8JwZZd4nFSfJ4mJWIx2U8giAlRt8STdS55k=@vger.kernel.org X-Gm-Message-State: AOJu0YwAU/xpn/VrFdy/vHDGiIzh1+XWLTu+sCTWTm8mzjJGdSQ697Jn BzOTstN0ib3K63uZiMWpfa2aSc/PVRipWgfogTR9z+QrqnEMYvdhzlmR X-Gm-Gg: AeBDiev/0+nQyOvrpCN8uH5rDtG9jvRiYAVx/dl++3dGbFRWqEO36MnCb75BpW4tjhQ 4OoA0LoMr+KxEt7UBZJmJLWRZ2C5nB355hIlfBRomZeej8jOAN3CWaZZ0CU7g/50mFZtC1HR5Wa j9od54v1OnwosXBv8UXtjqFjIqueG7qh8mG9rcyGp4vRxz11ULVAztEHBfQnN9NJAYEHM7OmybH UWE4u83sZNOIpYqmCKziy5qPZhmjamiTyUN3Q0tklAYBj/zQyKQfxaXSSJMiqqdZAs/GrQiInzX h9WBTBq1JZ4azHprel9K36YvRwYDbIiOFw0Qei9yblWM7caha89U3jXGlv12OSh2t4YpjNQ+lVn HJDCYL0XhhGAWvr1viVMYbyvrG1dYWRSSUUM5i472YkxphKZ/E5XL2NUkWLRXzsaUL9QBLs5pQv 0QJUB47kGq8XwEqr5lMcWdoeeMbMI5zKvsNbwgxgu6vB+vW6VafHM= X-Received: by 2002:a05:6000:400a:b0:43d:4c:229f with SMTP id ffacd0b85a97d-43d292e27admr25354253f8f.44.1775575025059; Tue, 07 Apr 2026 08:17:05 -0700 (PDT) Received: from aldo-conte-t14.tailf68ad9.ts.net ([37.163.52.91]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43d1e2a6f13sm51924922f8f.3.2026.04.07.08.17.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Apr 2026 08:17:04 -0700 (PDT) From: Aldo Conte To: jic23@kernel.org Cc: ktsai@capellamicro.com, dlechner@baylibre.com, nuno.sa@analog.com, andy@kernel.org, daniel.baluta@intel.com, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, skhan@linuxfoundation.org, me@brighamcampbell.com, linux-kernel-mentees@lists.linux.dev Subject: [PATCH v4 0/2] iio: light: cm3323: fix and cleanup Date: Tue, 7 Apr 2026 17:17:00 +0200 Message-ID: <20260407151702.15208-1-aldocontelk@gmail.com> X-Mailer: git-send-email 2.53.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Series fixes a bug and does a cleanup of the CM3323 color light sensor driver. Patch 1 fixes data->reg_conf being incorrectly initialized with the return value of the i2c_smbus_write_word_data() instead of the actual register value. Tested with i2c-stub on a Raspberri Pi 3B. Patch 2 converts dev_err() to dev_err_probe() in the probe path. Changes in v4: - Patch 2: Add Reviewed-by tag from Andy Shevchenko Changes in v3: - Patch 2: remove extra blank line after cm3323_init() error path in cm3323_probe() Changes in v2: - Patch 1: fix typos in commit message - Patch 2: add struct device *dev to shorten dev_err_probe() calls to one-liners (suggested by Andy Shevchenko) Aldo Conte (2): iio: light: cm3323: fix reg_conf not being initialized correctly iio: light: cm3323: use dev_err_probe() in probe path drivers/iio/light/cm3323.c | 22 ++++++++-------------- 1 file changed, 8 insertions(+), 14 deletions(-) -- 2.53.0