From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f46.google.com (mail-wr1-f46.google.com [209.85.221.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6995736402C for ; Tue, 7 Apr 2026 15:17:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.46 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775575031; cv=none; b=KZM3Z2kt2VL8FQZVOdOSBq6TfQOgXwF5+eXbuE6tS03M55IHbcKKmk+SqqKXpx1oa/k33AqnjthBzb0N/wx6iAQ737N93eW4M4J08xLlSxrT5VW74NNy4zU2E+wmxOdImSwRH6jnrXS0z4HYHNIuv5naeQhg8cnp9JQE5FiR7T4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775575031; c=relaxed/simple; bh=UpzQeOIgo32bTfZF9bCVO05d7AFWMI6EAflnf4kcCto=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=De9fsZZW0y5qBB92p6BxzZgWWTHGGQwd3QbYvJrUemT0pwgQH6ikoaAP03QlRTaG99Sm5M3wR6/mJ/4h+v93FjUhk0RBKRsMNmacApka0WXPcL4y47K+MbiJMxQXyCFRm06OdX5m9bz/NOtvli3NexCAPFMQ14bJRN9tJ1gDLyg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=gs28txXF; arc=none smtp.client-ip=209.85.221.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="gs28txXF" Received: by mail-wr1-f46.google.com with SMTP id ffacd0b85a97d-43cf5ad500fso4446037f8f.0 for ; Tue, 07 Apr 2026 08:17:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1775575029; x=1776179829; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=WDXxiHNfIFx/blBavOrxi008CsS+1VUvxTy8fmtLmJo=; b=gs28txXFXIKxp8oukFwdJdZHTzL5aOfa+ky6rcCrQqqKgQZQbnsbf7jftoq5nFPsUu hfObjhuSMmWAN3T66XKMasyw6gt4lg5pukXTWOfEhXDupK7pu5yyyDwJTxWgOToiWd4o EKM8zHLjcrHjrQ3qsSWp4t2TG8NJ8dGJZc11hWwzboIyRMjqEoe7ut1VjAZXQkRkcqn1 FgAjUhjLjDwfGnWXKG1mc9zb2FF9c0WIJZBKGDTFppl/6f3LNHDBcMN5ALgLlvjhGZL6 kj4JLAbG41xzS1NgbPFLP+2AJdJ02pjbnkm/HJmG5JrOn+I4bfcO1oklXavbcEeBEK1T UC9A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775575029; x=1776179829; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=WDXxiHNfIFx/blBavOrxi008CsS+1VUvxTy8fmtLmJo=; b=mUjps7gaHhoja//Y52o3IhJHtyxYm2LD4OqMB4IIxTQ9EAM5Ky2BSIsr9VZkuYjD79 u6My4hTVLt/NpimzknbmaRnjenBGwQGw6VQx6n2SIGP1CaW2/A58AgRdrphE/uwqz8Oj 712k0JBHn9w7RENveexv4Ezj4EUzbXRp1bR5DJz3m5FlK1ZJ/65x7yr2qPQO2IPQxM5G 7PvnyQC4ShZ9JWV6VFml0BPQN9G1woWpNV+pti3KpbwM9t3Sl28C2v/TAGEG20kcxxuc ajN9WC5Xh6Ja75437ULjaQZALaT0u5HaGuoWX3kWhNRt2Zc7PO46B7DrLMJpA4MoEFyu tsDA== X-Forwarded-Encrypted: i=1; AJvYcCWF2Ur591MtGYUvkPjTz8nQ1Y2LZBiZi2Mmsb2X7B972UhJR3/bQK/C+iVSl9ZpnWQJVzt/P5EqSjJvej4=@vger.kernel.org X-Gm-Message-State: AOJu0YzmznNiRf2iSbPPT1tn1km0k6ngjKMVJo4fXfF8CdcxXOBgaDiE euBOLHBQL3QQP9jjavAnemenlgTLy3G8Mx4IYsgqfYuOIwnhbjVEqCT6 X-Gm-Gg: AeBDieuMZwfwDelYb86dNYoX1k4DuxQxX0/ak+iVujM290o//+MSio+F6JWsEpGsEhI Kpx7yH0VeFCXD1kxTPd3u/KU8FTBsC9BtrAmaZ5HwfWtl609xaUM/sqvDewqpz6oSNplOht3ULe RKsUjW12UG8pwg8sPyJmLv/mJXfTS7fjFOBU7vfWFb8VZkBA54jJClXAUobDLnymOATatRrUY3X 61jSscr/49K8XLab5x54c7uakpmdYk7gkMgG8INWTUe9NWh/xR6uJ8aXgJrUbmP+M5nfRY6TcR8 3bm2HfVGjuyD7jikjSurdijl7TauZukYy0E0f/SgPxM6NZyk7Ab8r71qJZt9gx6ErVv+0S78XA0 9KV3m18wlCw6qpzzOxzuJLoGp1xdvEw8WdokoOLwdWxtb4r/y6ChAe7/FCPPt5RXDEZkPGjWzyV I+k5HoUkz22usQAFEe+Lg8X+hG8t6BoIMwrCMaEUjWlMlahTugK9w= X-Received: by 2002:a05:6000:2303:b0:439:bd70:6114 with SMTP id ffacd0b85a97d-43d292ec01cmr23778032f8f.38.1775575028749; Tue, 07 Apr 2026 08:17:08 -0700 (PDT) Received: from aldo-conte-t14.tailf68ad9.ts.net ([37.163.52.91]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43d1e2a6f13sm51924922f8f.3.2026.04.07.08.17.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Apr 2026 08:17:08 -0700 (PDT) From: Aldo Conte To: jic23@kernel.org Cc: ktsai@capellamicro.com, dlechner@baylibre.com, nuno.sa@analog.com, andy@kernel.org, daniel.baluta@intel.com, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, skhan@linuxfoundation.org, me@brighamcampbell.com, linux-kernel-mentees@lists.linux.dev Subject: [PATCH v4 2/2] iio: light: cm3323: use dev_err_probe() in probe path Date: Tue, 7 Apr 2026 17:17:02 +0200 Message-ID: <20260407151702.15208-3-aldocontelk@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260407151702.15208-1-aldocontelk@gmail.com> References: <20260407151702.15208-1-aldocontelk@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Replace dev_err() calls with dev_err_probe() in cm3323_init() and cm3323_probe(). cm3323_init() is called by cm3323_probe(), so using dev_err_probe() ensures that deferred probing is handled correctly and simplifies error paths. Remove the redundant error message in cm3323_probe(). Tested on a Raspberry Pi 3B using i2c-stub. The driver probes successfully and successfully read integration_time after this change. Reviewed-by: Andy Shevchenko Suggested-by: Andy Shevchenko Signed-off-by: Aldo Conte --- Changes in v4: - Add Reviewed-by tag from Andy Shevchenko Changes in v3: - Remove extra blank line after cm3323_init() error path in cm3323_probe() Changes in v2: - Add struct device *dev local variable to shorten dev_err_probe() calls to one-liners (suggested by Andy Shevchenko) drivers/iio/light/cm3323.c | 17 ++++++----------- 1 file changed, 6 insertions(+), 11 deletions(-) diff --git a/drivers/iio/light/cm3323.c b/drivers/iio/light/cm3323.c index 0fe61b8a7029..c8112685e415 100644 --- a/drivers/iio/light/cm3323.c +++ b/drivers/iio/light/cm3323.c @@ -80,22 +80,19 @@ static int cm3323_init(struct iio_dev *indio_dev) { int ret; struct cm3323_data *data = iio_priv(indio_dev); + struct device *dev = &data->client->dev; ret = i2c_smbus_read_word_data(data->client, CM3323_CMD_CONF); - if (ret < 0) { - dev_err(&data->client->dev, "Error reading reg_conf\n"); - return ret; - } + if (ret < 0) + return dev_err_probe(dev, ret, "Error reading reg_conf\n"); /* enable sensor and set auto force mode */ ret &= ~(CM3323_CONF_SD_BIT | CM3323_CONF_AF_BIT); data->reg_conf = ret; ret = i2c_smbus_write_word_data(data->client, CM3323_CMD_CONF, data->reg_conf); - if (ret < 0) { - dev_err(&data->client->dev, "Error writing reg_conf\n"); - return ret; - } + if (ret < 0) + return dev_err_probe(dev, ret, "Error writing reg_conf\n"); return 0; } @@ -236,10 +233,8 @@ static int cm3323_probe(struct i2c_client *client) indio_dev->modes = INDIO_DIRECT_MODE; ret = cm3323_init(indio_dev); - if (ret < 0) { - dev_err(&client->dev, "cm3323 chip init failed\n"); + if (ret < 0) return ret; - } ret = devm_add_action_or_reset(&client->dev, cm3323_disable, indio_dev); if (ret < 0) -- 2.53.0