From: Jose Javier Rodriguez Barbarin <dev-josejavier.rodriguez@duagon.com>
To: linusw@kernel.org, brgl@kernel.org
Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
Jose Javier Rodriguez Barbarin
<dev-josejavier.rodriguez@duagon.com>
Subject: [RFC PATCH 5/5] gpio: mmio: add port-mapped read/write callbacks
Date: Tue, 7 Apr 2026 20:48:05 +0200 [thread overview]
Message-ID: <20260407184805.807328-6-dev-josejavier.rodriguez@duagon.com> (raw)
In-Reply-To: <20260407184805.807328-1-dev-josejavier.rodriguez@duagon.com>
Implement PMIO read and write callbacks for 8-, 16- and 32-bit
register accesses using the corresponding port I/O helpers.
Signed-off-by: Jose Javier Rodriguez Barbarin <dev-josejavier.rodriguez@duagon.com>
---
drivers/gpio/gpio-mmio.c | 102 ++++++++++++++++++++++++++++++++++++++-
1 file changed, 100 insertions(+), 2 deletions(-)
diff --git a/drivers/gpio/gpio-mmio.c b/drivers/gpio/gpio-mmio.c
index 247ce5b76441..9b20283632a9 100644
--- a/drivers/gpio/gpio-mmio.c
+++ b/drivers/gpio/gpio-mmio.c
@@ -124,6 +124,60 @@ static unsigned long gpio_mmio_read32be(struct gpio_chip_reg *reg)
return ioread32be(reg->mmio);
}
+#ifdef CONFIG_HAS_IOPORT
+
+static void gpio_port_write8(struct gpio_chip_reg *reg, unsigned long data)
+{
+ outb(data, reg->port);
+}
+
+static unsigned long gpio_port_read8(struct gpio_chip_reg *reg)
+{
+ return inb(reg->port);
+}
+
+static void gpio_port_write16(struct gpio_chip_reg *reg, unsigned long data)
+{
+ outw(data, reg->port);
+}
+
+static unsigned long gpio_port_read16(struct gpio_chip_reg *reg)
+{
+ return inw(reg->port);
+}
+
+static void gpio_port_write32(struct gpio_chip_reg *reg, unsigned long data)
+{
+ outl(data, reg->port);
+}
+
+static unsigned long gpio_port_read32(struct gpio_chip_reg *reg)
+{
+ return inl(reg->port);
+}
+
+static void gpio_port_write16be(struct gpio_chip_reg *reg, unsigned long data)
+{
+ outw(swab16(data), reg->port);
+}
+
+static unsigned long gpio_port_read16be(struct gpio_chip_reg *reg)
+{
+ return swab16(inw(reg->port));
+}
+
+static void gpio_port_write32be(struct gpio_chip_reg *reg, unsigned long data)
+{
+ outl(swab32(data), reg->port);
+}
+
+static unsigned long gpio_port_read32be(struct gpio_chip_reg *reg)
+{
+ return swab32(inl(reg->port));
+}
+
+#endif /* CONFIG_HAS_IOPORT */
+
static inline void gpio_chip_reg_init(struct gpio_chip_reg *reg, bool io_port,
void __iomem *addr, unsigned long port)
{
@@ -474,6 +528,46 @@ static int gpio_mmio_dir_out_val_first(struct gpio_chip *gc, unsigned int gpio,
return gpio_mmio_dir_return(gc, gpio, true);
}
+static int gpio_port_setup_accessors(struct device *dev,
+ struct gpio_generic_chip *chip,
+ bool byte_be)
+{
+#ifdef CONFIG_HAS_IOPORT
+ switch (chip->bits) {
+ case 8:
+ chip->read_reg = gpio_port_read8;
+ chip->write_reg = gpio_port_write8;
+ break;
+ case 16:
+ if (byte_be) {
+ chip->read_reg = gpio_port_read16be;
+ chip->write_reg = gpio_port_write16be;
+ } else {
+ chip->read_reg = gpio_port_read16;
+ chip->write_reg = gpio_port_write16;
+ }
+ break;
+ case 32:
+ if (byte_be) {
+ chip->read_reg = gpio_port_read32be;
+ chip->write_reg = gpio_port_write32be;
+ } else {
+ chip->read_reg = gpio_port_read32;
+ chip->write_reg = gpio_port_write32;
+ }
+ break;
+ default:
+ dev_err(dev, "unsupported data width %u bits\n", chip->bits);
+ return -EINVAL;
+ }
+
+ return 0;
+#else
+ dev_err(dev, "not supported because of missing I/O resource\n");
+ return -ENXIO;
+#endif /* CONFIG_HAS_IOPORT */
+}
+
static int gpio_mmio_setup_accessors(struct device *dev,
struct gpio_generic_chip *chip,
bool byte_be)
@@ -684,8 +778,12 @@ int gpio_generic_chip_init(struct gpio_generic_chip *chip,
if (ret)
return ret;
- ret = gpio_mmio_setup_accessors(dev, chip,
- flags & GPIO_GENERIC_BIG_ENDIAN_BYTE_ORDER);
+ if (chip->io_port)
+ ret = gpio_port_setup_accessors(dev, chip,
+ flags & GPIO_GENERIC_BIG_ENDIAN_BYTE_ORDER);
+ else
+ ret = gpio_mmio_setup_accessors(dev, chip,
+ flags & GPIO_GENERIC_BIG_ENDIAN_BYTE_ORDER);
if (ret)
return ret;
--
2.53.0
next prev parent reply other threads:[~2026-04-07 18:49 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-07 18:48 [RFC PATCH 0/5] gpio: add PMIO support to gpio-mmio Jose Javier Rodriguez Barbarin
2026-04-07 18:48 ` [RFC PATCH 1/5] gpio: generic: add a generic register wrapper for MMIO and PMIO Jose Javier Rodriguez Barbarin
2026-04-09 7:53 ` Linus Walleij
2026-04-07 18:48 ` [RFC PATCH 2/5] gpio: generic: extend gpio_generic_chip_config with PMIO register fields Jose Javier Rodriguez Barbarin
2026-04-09 7:59 ` Linus Walleij
2026-04-07 18:48 ` [RFC PATCH 3/5] gpio: generic: add io_port to struct gpio_generic_chip Jose Javier Rodriguez Barbarin
2026-04-09 8:04 ` Linus Walleij
2026-04-09 8:21 ` Linus Walleij
2026-04-07 18:48 ` [RFC PATCH 4/5] gpio: mmio: convert accessors to generic register descriptors Jose Javier Rodriguez Barbarin
2026-04-09 8:07 ` Linus Walleij
2026-04-10 7:10 ` Jose Javier Rodriguez Barbarin
2026-04-07 18:48 ` Jose Javier Rodriguez Barbarin [this message]
2026-04-09 8:08 ` [RFC PATCH 5/5] gpio: mmio: add port-mapped read/write callbacks Linus Walleij
2026-04-09 8:14 ` [RFC PATCH 0/5] gpio: add PMIO support to gpio-mmio Linus Walleij
2026-04-10 7:44 ` Jose Javier Rodriguez Barbarin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260407184805.807328-6-dev-josejavier.rodriguez@duagon.com \
--to=dev-josejavier.rodriguez@duagon.com \
--cc=brgl@kernel.org \
--cc=linusw@kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®