mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Daniil Bulgar <bulgardaniil18@gmail.com>
To: "Mark Pearson" <mpearson-lenovo@squebb.ca>,
	"Hans de Goede" <hansg@kernel.org>,
	"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
Cc: Henrique de Moraes Holschuh <hmh@hmh.eng.br>,
	"Derek J . Clark" <derekjohn.clark@gmail.com>,
	ibm-acpi-devel@lists.sourceforge.net,
	platform-driver-x86@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	Daniil Bulgar <bulgardaniil18@gmail.com>
Subject: [PATCH v2] platform/x86: thinkpad_acpi: remove obsolete TODO comment
Date: Tue,  7 Apr 2026 21:05:46 +0200	[thread overview]
Message-ID: <20260407190546.109900-1-bulgardaniil18@gmail.com> (raw)
In-Reply-To: <e4723a5a-0bdd-4062-af38-ca5f4a4f6d1d@app.fastmail.com>

This patch removes the obsolete TODO comment regarding fan speed
presets in fan_write_cmd_speed. After discussion with the
maintainers, it was decided that fixed presets (low/medium/high)
are not suitable due to platform-specific variations.

Signed-off-by: Daniil Bulgar <bulgardaniil18@gmail.com>
---
v2:
 - Removed the preset implementation as requested by Mark Pearson
   and only removed the TODO comment.
v1: 
 - Initial attempt to implement low/medium/high presets.
 
 drivers/platform/x86/lenovo/thinkpad_acpi.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/drivers/platform/x86/lenovo/thinkpad_acpi.c b/drivers/platform/x86/lenovo/thinkpad_acpi.c
index 8982d92df..75e141304 100644
--- a/drivers/platform/x86/lenovo/thinkpad_acpi.c
+++ b/drivers/platform/x86/lenovo/thinkpad_acpi.c
@@ -9249,9 +9249,6 @@ static int fan_write_cmd_speed(const char *cmd, int *rc)
 {
 	int speed;
 
-	/* TODO:
-	 * Support speed <low> <medium> <high> ? */
-
 	if (sscanf(cmd, "speed %d", &speed) != 1)
 		return 0;
 
-- 
2.53.0


  reply	other threads:[~2026-04-07 19:07 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-30 20:35 [PATCH] platform/x86/lenovo: thinkpad_acpi: add named speed presets to fan_write_cmd_speed Даниил Булгарь
2026-03-31  1:19 ` Mark Pearson
2026-04-07 17:39   ` Mark Pearson
2026-04-07 19:05     ` Daniil Bulgar [this message]
2026-04-07 19:07       ` [PATCH v2] platform/x86: thinkpad_acpi: remove obsolete TODO comment Mark Pearson
2026-04-09 13:41       ` Ilpo Järvinen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260407190546.109900-1-bulgardaniil18@gmail.com \
    --to=bulgardaniil18@gmail.com \
    --cc=derekjohn.clark@gmail.com \
    --cc=hansg@kernel.org \
    --cc=hmh@hmh.eng.br \
    --cc=ibm-acpi-devel@lists.sourceforge.net \
    --cc=ilpo.jarvinen@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mpearson-lenovo@squebb.ca \
    --cc=platform-driver-x86@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®