From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from invmail4.hynix.com (exvmail4.hynix.com [166.125.252.92]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 6693434676F for ; Wed, 8 Apr 2026 04:56:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=166.125.252.92 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775624194; cv=none; b=tbaeZArANrdGYOw5TYNMEbtULXlOPbT61/FOa4A+P4bXQOMmQ51g68Nw20b6tEhlUYUhYOXUlvV3SrWt7pRMhqelq7W4hG9OKOvBfaH4P9QYgDmVsLqD2lgVCofFOuokIzxmMHU/cy7QePGqn4YS/n//gPkztYitKRXhHySHsjQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775624194; c=relaxed/simple; bh=JoJkqvkQz0GJBT7LckkH64QHyn/w6QSKOlx8oRf4BPM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=kAQU8KOKop7JOji4DlTEnY/8wFhYFG+xWT1jQYdpME1GGFfU98WM0jzYJSY3GI1QeEFXEDOdMcCupzZ/A5opBw1Ecr/Q7LbelGacqEffeHhaP3AB/ccZxBZovZ3A4ZIpu+ETMxD5c9qz2XWXe9wZvZBD9BjDCzi0P3mVFX53F/0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=sk.com; spf=pass smtp.mailfrom=sk.com; arc=none smtp.client-ip=166.125.252.92 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=sk.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=sk.com X-AuditID: a67dfc5b-c45ff70000001609-7b-69d5dff35c30 From: Rakie Kim To: Joshua Hahn Cc: Jackie Liu , David Hildenbrand , Zi Yan , Matthew Brost , Rakie Kim , Byungchul Park , Gregory Price , Ying Huang , Alistair Popple , linux-mm@kvack.org, linux-kernel@vger.kernel.org, kernel-team@meta.com, Andrew Morton , kernel_team@skhynix.com Subject: Re: [PATCH] mm/mempolicy: Fix weighted interleave auto sysfs name Date: Wed, 8 Apr 2026 13:56:13 +0900 Message-ID: <20260408045617.318-1-rakie.kim@sk.com> X-Mailer: git-send-email 2.52.0.windows.1 In-Reply-To: <20260407141415.3080960-1-joshua.hahnjy@gmail.com> References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrILMWRmVeSWpSXmKPExsXC9ZZnke7n+1czDa5dtLKYs34Nm8WuGyEW z7f+YrT4efc4u8XxrfPYLfZdBIpf3jWHzeLemv+sFo8OFlp865O2WL0mw2L20XvsDjweO2fd ZffobrvM7rF4z0smj02rOtk8Nn2axO5xYsZvFo+dDy09FjZMZfY4d7HCo7f5HZvH501yAdxR XDYpqTmZZalF+nYJXBm/nnxnL/jIU9HQ0MrSwLiXq4uRk0NCwETi1t3ZbDB257c5LF2MHBxs AkoSx/bGgIRFBDQlTrROYu5i5OJgFnjKLHHt7EEmkISwgJfEwcNXWEBsFgFVifdnDzKC2LwC xhLNZ09CzdSUWLfxFlgNp4C9xLNFK8FqhAR4JF5t2A9VLyhxcuYTsBpmAXmJ5q2zwZZJCHxn k5j+fTkTxCBJiYMrbrBMYOSfhaRnFpKeBYxMqxiFMvPKchMzc0z0MirzMiv0kvNzNzECI2JZ 7Z/oHYyfLgQfYhTgYFTi4T3x40qmEGtiWXFl7iFGCQ5mJRHepPrLmUK8KYmVValF+fFFpTmp xYcYpTlYlMR5jb6VpwgJpCeWpGanphakFsFkmTg4pRoYjQ+enVLyv9/zk8D+R/fn3zr42FFC ZgZTqGVPhCD/Np384NZ6TtN1jZsvnHUJaN9Z7nmk+8CxeJVWuz3XnV523FuzLkfP6ChXqMS/ vyyLDgmJLr8if/TnEY57bhLXfpdvlAtMuCvX+NHsdNu9eTrN0reeL538sWjtjN1Xjyx4yqW4 IiY1vGbhRSWW4oxEQy3mouJEAN9CIl+EAgAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrGLMWRmVeSWpSXmKPExsXCNUM9Rvfz/auZBq1HDSzmrF/DZrHrRojF uSmz2Syeb/3FaPHz7nF2i+Nb57Fb7LsIlDw89ySrxeVdc9gs7q35z2rx6GChxbc+aYtD156z Wqxek2Ex++g9dgd+j52z7rJ7dLddZvdYvOclk8emVZ1sHps+TWL3ODHjN4vHzoeWHgsbpjJ7 nLtY4dHb/I7N49ttD4/FLz4weXzeJBfAG8Vlk5Kak1mWWqRvl8CV8evJd/aCjzwVDQ2tLA2M e7m6GDk5JARMJDq/zWHpYuTgYBNQkji2NwYkLCKgKXGidRJzFyMXB7PAU2aJa2cPMoEkhAW8 JA4evsICYrMIqEq8P3uQEcTmFTCWaD57kg1ipqbEuo23wGo4Bewlni1aCVYjJMAj8WrDfqh6 QYmTM5+A1TALyEs0b53NPIGRZxaS1CwkqQWMTKsYRTLzynITM3NM9YqzMyrzMiv0kvNzNzEC Q39Z7Z+JOxi/XHY/xCjAwajEw3vg45VMIdbEsuLK3EOMEhzMSiK8SfWXM4V4UxIrq1KL8uOL SnNSiw8xSnOwKInzeoWnJggJpCeWpGanphakFsFkmTg4pRoYUxdv/sg4W2eC872dtc9Kdzyt seG2YH324fcxDo0wW9fwPQp33Mykp6wW/eLfnBo5P33W7ufnTyVWL4vKlPX77bnIuveZmLWt 7uZZ/y3mNIZFyl6RnhiZfze4I2pL00dvnh0LY/MiFkaZlZ1qD/G8Oalrrdiq1PZDx1iPWL4s 2HT1xLTXbk+ElViKMxINtZiLihMBsWaQjnkCAAA= X-CFilter-Loop: Reflected On Tue, 7 Apr 2026 07:14:14 -0700 Joshua Hahn wrote: > The __ATTR macro is a utility that makes defining kobj_attributes easier > by stringfying the name, verifying the mode, and setting the show/store > fields in a single initializer. It takes a raw token as the first value, > rather than a string, so that __ATTR family macros like __ATTR_RW can > token-paste it for inferring the _show / _store function names. > > Commit e341f9c3c841 ("mm/mempolicy: Weighted Interleave Auto-tuning") > used the __ATTR macro to define the "auto" sysfs for weighted > interleave. A few months later, commit 2fb6915fa22d ("compiler_types.h: > add "auto" as a macro for "__auto_type"") introduced a #define macro > which expanded auto into __auto_type. > > This led to the "auto" token passed into __ATTR to be expanded out into > __auto_type, and the sysfs entry to be displayed as __auto_type as well. > > Expand out the __ATTR macro and directly pass a string "auto" instead of > the raw token 'auto' to prevent it from being expanded out. Also bypass > the VERIFY_OCTAL_PERMISSIONS check by triple checking that 0664 is > indeed the intended permissions for this sysfs file. > > Before: > $ ls /sys/kernel/mm/mempolicy/weighted_interleave > __auto_type node0 > > After: > $ ls /sys/kernel/mm/mempolicy/weighted_interleave/ > auto node0 Hello Joshua, This was indeed an unfortunate and tricky issue to track down, given that it was caused by an unexpected global macro expansion. great catch, and thanks for the quick response and clean fix. Reviewed-by: Rakie Kim