From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dl1-f68.google.com (mail-dl1-f68.google.com [74.125.82.68]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 77CE83B8D76 for ; Wed, 8 Apr 2026 10:45:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.68 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775645119; cv=none; b=WQdJS3ysstBxnd3BF/234CrVYsoeo5LlpO7TVpKiTqhtUQrPYt5wUlv1/cu6ir3eG45pOzreXoZol/mU9dyPz6K7p8CCGC1pgQuiE1bBj0yQ9iHQ6hR2ln4MZ6ZcsEVYuegQUlZ4kLcl9cPtd77inBcA8TvwaR0KBn157P3U9Qk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775645119; c=relaxed/simple; bh=4wh+x2eLwodENhw62MeDkphPHbsEUxgzqtLtvKsRBL0=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=uN0SU7vaMXHq8Tdz/RZJL0m6k4llNMiwbV53oNBA9wy6fg5zKPoWbHLqlNiWvoociJV7FfeAw+jvHpUHea1pJv66QcG0HMq39eYynGnCyqkIk443AkgGbZ+xUrTEViknXOVMZugeLeGaqndhIyU5If3W+kXxQpv4/+NstxOExRQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Qw9frEe8; arc=none smtp.client-ip=74.125.82.68 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Qw9frEe8" Received: by mail-dl1-f68.google.com with SMTP id a92af1059eb24-12732165d1eso8428532c88.1 for ; Wed, 08 Apr 2026 03:45:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1775645118; x=1776249918; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=AVLohcLw2czX7vhFZmwjRjFd9S+RQsSrUtRS+thu1qE=; b=Qw9frEe8Iq1RVIB9XtZcf2MeyfiWH+MnoTxMOiaXRYIvLkzHaU8UpNytoAKvqmE6WP RV8HdaOGpVJcvuh+zC/Z4sNpnapTzLYWpZTaHnkS5X/XlooyVxqBxhBFhVPY0J+o4e0/ SAXI+ifOmsDREbHcicTVqYahF19bHGCMjQhtDtvkBvNGrorpt4ZxoZ9IXOo+ev7RqQU4 pu/lPY7Dxr+9/E78WpIvBfrUm2uLyN76750c/A/VQb6WVg6BS7kmTW5cVOkghCyf1Tpa zvwZUdi6mP9MIz1z2UReN0wZea/5jUcN12yb+I+B3gZNZsb9Be/cinD7c6WiHEYUuJ9/ 66rg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775645118; x=1776249918; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=AVLohcLw2czX7vhFZmwjRjFd9S+RQsSrUtRS+thu1qE=; b=CXG561g7X78r6ZKJOQSmkAcv8J0cVBKokJNBzQw4GJSk+OLqsFYywGLMoqpDBlf/lH FvFjIknXZ47eDTkLAynQKyEaatEzOOfuFcH1ImTyz93ynuUUMi3ya+OQUiD0VRLBBGWh CQw3GbbGKd6OmZ8f/pAMlEx5DQ/3p+Ugj6zXXr3o83dgy12d9N52TCsA4Q8GGKIL5Efo /HQrz8OmA1dI+La6zGh9atn9d2nUaPcOMtnKfJuPn8cBrR0ZcXfxdUmIxDAimRtKn3Eq B+jHhWcTZ26ccqllre1i7oYL16BfTNx7aiHU68OJTm5upjl+eFdUle0qfe0XwuszaMn/ 6V6w== X-Forwarded-Encrypted: i=1; AJvYcCXh0wiIlFiPuzMp1ZtNlHt+5nl6WUKWfL4nd0yf7iF9cSEE7EnmnUT5daDTLGG/rvzG9QL2qJnCryuZHXo=@vger.kernel.org X-Gm-Message-State: AOJu0YxqBI3I9tQzuYRSLc2o37EWEhPUKt4XoSpsbJ+in+3QpTBZdQRt nE13QKFj9UJuvv4yHJGH3mW+z8lOaaMka5lTxxMN3wO7tusj03C6LgJu X-Gm-Gg: AeBDieuQGSFqvAnp+80LaxlgWYPUL1u4ua6YSAl0IbE+qc1A1EUbT07I9IEDfFRaVOV mjBTrQeXBfJRxDNEUlMMWbQPFn5sbchX870NPG7ng1ghEiNXKWy8ThLtVni93nYeUam1t89B0Aa YOYwUhFsJLoNYNMC0GPFkXt9ljhORvh0ZFb0nGIqdV8wh9xHA5F+ohnMUl6bsyfK48BybczCC// taDQPINXowmw6AdzvFFG8OVZWYnyA2zkpTuO9PJuverThQQ5L4s4qqoi8vKnDIJMRPIpfL4dTnP JdY9Y4ENEogxdfTnp1nXxTgvYtbNnBOSf+dbW5ReAYPp8UzAZkAf+JnEn66vjBPq++IQcRlvpoy C5OBYrL+HfXFdiG6LmapztbjESRHb0NQaqNidaVk/jjVGo+PEwumn2aAIMVKMCa7U2yuWsgAyJO zcUsIpw9bTpSy7kvf2LM2/HQj15AJy8Cvy3b3giFfQvDxGZw5iypDpIdg= X-Received: by 2002:a05:7022:6199:b0:11d:c22e:a131 with SMTP id a92af1059eb24-12bfb6edfbbmr9823569c88.3.1775645117556; Wed, 08 Apr 2026 03:45:17 -0700 (PDT) Received: from localhost.localdomain ([76.32.119.210]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-12bed93f861sm24417783c88.0.2026.04.08.03.45.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Apr 2026 03:45:16 -0700 (PDT) From: Hungyu Lin To: gregkh@linuxfoundation.org Cc: dan.carpenter@linaro.org, ethantidmore@gmail.com, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Hungyu Lin Subject: [PATCH v4 0/6] staging: rtl8723bs: convert xmit init path to standard error codes Date: Wed, 8 Apr 2026 10:44:18 +0000 Message-Id: <20260408104424.18952-1-dennylin0707@gmail.com> X-Mailer: git-send-email 2.34.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Convert the xmit initialization path to use standard kernel return conventions (0 on success, negative errno on failure). This replaces the use of _SUCCESS/_FAIL with proper error codes and improves error propagation. The changes are split into smaller patches following review feedback from Dan Carpenter, converting one function at a time to make the series easier to review. v4: - Split into a series of smaller patches as suggested by Dan Carpenter - Convert functions step by step to improve reviewability - Ensure each patch builds independently v3: - Rebase onto latest staging-next to resolve conflicts. v2: - Rework xmit init path to remove _SUCCESS/_FAIL usage - Convert allocation helpers to return standard error codes - Update caller to use direct failure checks - Address review feedback from Ethan Tidmore Hungyu Lin (6): staging: rtl8723bs: simplify _rtw_init_xmit_priv control flow staging: rtl8723bs: make rtw_alloc_hwxmits static staging: rtl8723bs: convert rtw_alloc_hwxmits to return errno staging: rtl8723bs: move rtw_os_xmit_resource_alloc to rtw_xmit.c staging: rtl8723bs: convert rtw_os_xmit_resource_alloc to return errno staging: rtl8723bs: convert _rtw_init_xmit_priv to return errno drivers/staging/rtl8723bs/core/rtw_xmit.c | 138 +++++++++--------- drivers/staging/rtl8723bs/include/rtw_xmit.h | 1 - .../staging/rtl8723bs/include/xmit_osdep.h | 1 - drivers/staging/rtl8723bs/os_dep/os_intfs.c | 5 +- drivers/staging/rtl8723bs/os_dep/xmit_linux.c | 13 -- 5 files changed, 74 insertions(+), 84 deletions(-) -- 2.34.1