From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dl1-f68.google.com (mail-dl1-f68.google.com [74.125.82.68]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DBAD13B8928 for ; Wed, 8 Apr 2026 10:45:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.68 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775645129; cv=none; b=JEZwPa2PAm/zdytt+Kic8W+XJKWjSuRiah39G1RiEGCnYSqD/2wzHMDgc8xIO05wat4EFZPfGqUYHLDTIkGkOkWaGkQkcRVUqueAj77K9Sr875hSnfQz3CZ7y3UjCTxMaDrl1h2T+Ge8yZ5iGtOSlgEMFiUIveuPNX2Nnz0rDpM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775645129; c=relaxed/simple; bh=iMMCHuUNk205M/t3RiDzeqmOCZFDI8xxxCaYom5FDDA=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=C2Id2BlHxSxAH4+hO/zeoiqNe7snaJtVowcHKZ1FesyjkDRpOG+5vZHVnuEvEwKM92rxiya7F67m9FpdlKNK8h1HkajH477vvW/NICh+4/OOWd9V3en7DM8oZ7qoQCTXSjfM4zQdbADOv9XDiJBzze+WYohF7zhVA3SH1yADDL4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=mvZJ/EBF; arc=none smtp.client-ip=74.125.82.68 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="mvZJ/EBF" Received: by mail-dl1-f68.google.com with SMTP id a92af1059eb24-1279eced0b9so7433488c88.0 for ; Wed, 08 Apr 2026 03:45:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1775645127; x=1776249927; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=J2zzxZ7T3OrjLQrZ05KQAgPaC26tt2IBs9Eiz7SOG68=; b=mvZJ/EBFUXEJfL1jsP1UvzDM5aEev8aInk6F8QrI0Qw2gVvOXHdsswo9kB3UamCU3W q6peoikU4CWNmrdfh0igyzS1xzbPFop/dxEZ83XjN3Emp9SLO1L45pBcXxA5oizXWYo3 MRMY1u/+AuIiRF+jtjpGw7j6sLhkLhOeC8LZjdW5q0DkKz12Cay9ndDr/IFkVRutHNHu wIJQ4wAkBxXp9monvwMErDLD6LWvFoCQ7cojUNq1ebSqhNCyo7r2BAih86u/Xn+KQZ3t rdOUUcT0/OAe+6XAVwITwSvC1m5Lw2gh7djKaBnUz3hus9RnBRTp8EagjboIdYxgd3+f sZ2g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775645127; x=1776249927; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=J2zzxZ7T3OrjLQrZ05KQAgPaC26tt2IBs9Eiz7SOG68=; b=Gi3Sghvoq5GGSJAXpvGMBrBYiF7o7ktJPsaQogjjb3Wevtzfwva5L5xvzd9N//a+LY 3GXrn5r3HwxiXr4l1g8pn+r9FdG2aKumD/3r9kMaFfjRjkd2ckHKTtBiu8CcVWl3lYZu Yq89foj4YZiVuogKYmCQHwV35XBrjN7TEr5xnnj24e7W6VQC3lnKcUfdR+PLrQ/JvV3T xPEmabBe235wBNYzF3riSXZHJYX8gY/1XMgL1Q0Gmd+ymkJT7IwczfQDZ20sjKHVPmzB 2S5Vyf4KARBf3RgePymymdt2KSI/7PWmvyZkaPpP4XVpT3ZWJ0cCx5wCaq8cKdooxMBY r5kg== X-Forwarded-Encrypted: i=1; AJvYcCXNnmQ9idScwmJMuhxg2RSpekzXi29EfZHUiU3o9oIyIOV5l6hLegqgqqYParnU8BTrc9hveZ+6ZzFVBzs=@vger.kernel.org X-Gm-Message-State: AOJu0YxeB4BPAkbe60bRm0FFHmBwoR1R0kecS5BlqmtBKX2ZkobjRPFn 9S/6rlWzThi22lHS3JcOgxW71MJNObaTKWld/+42nv8WCPTyLMQY4EAA X-Gm-Gg: AeBDievjjg4HSpyMOapteamZSpiAScn/ihvdiaoE5iQ7c1+bBwjdAnqmNpkX3QhLvAt 5cUhzRkbDC5mF+ShWRu5COxvt3Rxwa6P+4lfpWUXvBPTNFBeYPYQNSnGEBK3MNhv6v4rpiEPzFR cqiw/xf9Lkva/B8Em55DYERQuZd0YnYuQy79wnWoL4nv+l/j6mLTC/EiHuQgzFKbboO+hrVtRPW /cQU8TICkYQrVYoQX2vlIIY5IsNxYO9Nn87zsrOOzjUhXtogLCS8r3i8m5c+F+ah+SR4n5YJQ1H 7WJsxf6XBHtyWsd2GPVmzcKnHB1JnfESazPbbFo8rZ4ptz3EsqacEqqqvS9wfuca2EXU9RX2s3P fiWbx00ks5em2rZHKJdVPBTFEtKJmvxTA/hSeK7TLhsq+6bROUCEYMXPeeclul5udqaYt1dkV01 jWxxfYf8EHtqv24hy98xniul9BNpJ9zQzqR477Gk96uxFhOzs5AH8l664= X-Received: by 2002:a05:7022:43a8:b0:12a:6f8b:36a3 with SMTP id a92af1059eb24-12bfb6e7d0emr10243186c88.6.1775645127044; Wed, 08 Apr 2026 03:45:27 -0700 (PDT) Received: from localhost.localdomain ([76.32.119.210]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-12bed93f861sm24417783c88.0.2026.04.08.03.45.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Apr 2026 03:45:25 -0700 (PDT) From: Hungyu Lin To: gregkh@linuxfoundation.org Cc: dan.carpenter@linaro.org, ethantidmore@gmail.com, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Hungyu Lin Subject: [PATCH v4 5/6] staging: rtl8723bs: convert rtw_os_xmit_resource_alloc to return errno Date: Wed, 8 Apr 2026 10:44:23 +0000 Message-Id: <20260408104424.18952-6-dennylin0707@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260408104424.18952-1-dennylin0707@gmail.com> References: <20260408104424.18952-1-dennylin0707@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Convert rtw_os_xmit_resource_alloc() to return 0 on success and -ENOMEM on failure. Update the callers to check for non-zero return values. Signed-off-by: Hungyu Lin --- drivers/staging/rtl8723bs/core/rtw_xmit.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_xmit.c b/drivers/staging/rtl8723bs/core/rtw_xmit.c index 249947a7d910..fedfc968057b 100644 --- a/drivers/staging/rtl8723bs/core/rtw_xmit.c +++ b/drivers/staging/rtl8723bs/core/rtw_xmit.c @@ -78,12 +78,12 @@ static int rtw_os_xmit_resource_alloc(struct adapter *padapter, struct xmit_buf if (alloc_sz > 0) { pxmitbuf->pallocated_buf = kzalloc(alloc_sz, GFP_KERNEL); if (!pxmitbuf->pallocated_buf) - return _FAIL; + return -ENOMEM; pxmitbuf->pbuf = (u8 *)N_BYTE_ALIGMENT((SIZE_PTR)(pxmitbuf->pallocated_buf), XMITBUF_ALIGN_SZ); } - return _SUCCESS; + return 0; } s32 _rtw_init_xmit_priv(struct xmit_priv *pxmitpriv, struct adapter *padapter) @@ -179,10 +179,10 @@ s32 _rtw_init_xmit_priv(struct xmit_priv *pxmitpriv, struct adapter *padapter) /* Tx buf allocation may fail sometimes, so sleep and retry. */ res = rtw_os_xmit_resource_alloc(padapter, pxmitbuf, (MAX_XMITBUF_SZ + XMITBUF_ALIGN_SZ), true); - if (res == _FAIL) { + if (res) { fsleep(10 * USEC_PER_MSEC); res = rtw_os_xmit_resource_alloc(padapter, pxmitbuf, (MAX_XMITBUF_SZ + XMITBUF_ALIGN_SZ), true); - if (res == _FAIL) + if (res) return _FAIL; } @@ -258,7 +258,7 @@ s32 _rtw_init_xmit_priv(struct xmit_priv *pxmitpriv, struct adapter *padapter) pxmitbuf->buf_tag = XMITBUF_MGNT; res = rtw_os_xmit_resource_alloc(padapter, pxmitbuf, MAX_XMIT_EXTBUF_SZ + XMITBUF_ALIGN_SZ, true); - if (res == _FAIL) + if (res) return _FAIL; pxmitbuf->phead = pxmitbuf->pbuf; @@ -288,7 +288,7 @@ s32 _rtw_init_xmit_priv(struct xmit_priv *pxmitpriv, struct adapter *padapter) res = rtw_os_xmit_resource_alloc(padapter, pxmitbuf, MAX_CMDBUF_SZ + XMITBUF_ALIGN_SZ, true); - if (res == _FAIL) + if (res) return _FAIL; pxmitbuf->phead = pxmitbuf->pbuf; -- 2.34.1