From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dl1-f65.google.com (mail-dl1-f65.google.com [74.125.82.65]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 61AF43BA256 for ; Wed, 8 Apr 2026 10:45:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.65 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775645130; cv=none; b=tvi41vYwydapdw5JNZUW1eXulMVpmMOx1pAWFGasrK8grHf8xcMgDsKZGU9kF8a/O5H4cg+7WKqq72y64jwpjaBtcVv92FNyx1oHXdMa6R2VP3dB36bzjJi8Y9pt8K8We3vukuYZFQfuTLO4PghJPDK42amxIzEsyQIJsWqUla4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775645130; c=relaxed/simple; bh=hGg02QATHkkke1bjuTer3z11aD9JCZJAEagAsXT3E2A=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=codkxTmCBb15NWeD3Oz4pZrCgoddkVDQfOQ+iKRqRvX3/JnlnLvqHNyMG1R9QygywJXF2zXKg0SO2bJnn7woT3FFR4y9I/RRAGSnIejoRj5O0wwdGEHsTscLIyJlBT1O1KSNELD+JhB5Pn3xkWq95P1SAOomo6c4NSs/DnIzGJM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=kvsBmLq4; arc=none smtp.client-ip=74.125.82.65 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="kvsBmLq4" Received: by mail-dl1-f65.google.com with SMTP id a92af1059eb24-12c0b72dac7so3841542c88.0 for ; Wed, 08 Apr 2026 03:45:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1775645129; x=1776249929; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Etrgohg7PjyPKSflB7uJ/+hYjM3wfm6/HkFN+c+SMaU=; b=kvsBmLq4KaPgAMXy/9224fEWvxyK8YRkfk+6/CNP33Mmd/G3zZFmOcdymng5Fziqff hHuTsRZTDm6OoOQNgacjnnGw414sRZ1g6JS3rPPu2jOwW6mft8MC5Pyu/F+AuBdfMU61 l35Kh3tOpACNQ9QHO64C6X73ptMnrT53eQoV5ZEm/5f2tFH66q6jf0Y1mxhRPBx3ZCVv A/CpIemT3D7X4pxCwGQt+oudnUGgv51ptxR4V5N0Qg4WliYpiU1efu/5u2g3jOovrReG MaUXbY6rLONvar/y0CSXR3pWY9ypWpOMxGksnI10UH7q2fB128Wl6Udb4UlkqbZg566L TKmw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775645129; x=1776249929; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=Etrgohg7PjyPKSflB7uJ/+hYjM3wfm6/HkFN+c+SMaU=; b=Y9UvJ/dmEWlG8YCvlRYBxTTuE2f/AFqJHuiSVNWJNbC9T53GWscZurXM1CDG/HT6nL 9CSTdKqj5Wt/cO860A4avILudU3Cf1pALlUxNu72J5GBoL3QP66jl5hJkg0JHDSCN2oN FCppMSSiSOlri/rMhq5Bx2CIKlqlokzGL4lk9aiRopXOX9HIDtEot6cLvdrmbS9QrQHF Z3vbkI6ks1dZZx4gtrtvjp4a4Oi0N3KripAs0TJ4x6bf8hTlhLBkeA7wiFuHoycpL3sa KYXA+d4+8SNcUdvcOEpQiKgm1fMfpSGqDfN5zUEeis7d+58luSMVwaZxbN0MC8/fRw2S vrmA== X-Forwarded-Encrypted: i=1; AJvYcCUnEQFbxEGWVKz4Ddp8TBTQRt8c+0y8mINfxrh95nhG9x5WzjWULp74//+dxZPH9YNiXgZyL+eKDY9jVO4=@vger.kernel.org X-Gm-Message-State: AOJu0Yyjdgg0DvOwvCc6bPPpjEG8dQv6LnHQRYUyYDkci8tFcJtqzgNr YzyauEopNunyj9TToH/KQ/DiU2XNylKxyLEGfY/6eH8S+NfNKzasENdu X-Gm-Gg: AeBDieuX/NKv1H3GyXvcYnYttvDhTuXE1WdC9HHrnkhbF1easvIQG0z57tPEpH79gBV M+tGERycvbquU1+BtX7MWClCP28+IaeXHrCyL+hf1S36n5aTJR1tTiI/EUuOAJirByWwspQDfeD 0uDl2jevD9+Tz7+ydkd0tQpliPdF37XP7ajw/e//3R0X0F8CLszZEgwSKjE66OMQ3kZeN5r2s0E X3i5lB6sR5CYwhZtDV0QTzpR5pXoG7YE0qFhqYwB2Y3UfPYYvk9dEDk8rfPU4xkYrHUWo/e0FyZ GSnh9wEumOJKx8F28YencBNF8L6Ua/zCt2agkRiKPgaxSGVgm3lFDGWj+4/WAzfk8v83FBIKHJl 6bGEYVKFFxM8R4XslmXYbGBadA+wTQ70Kq3uknX4RS+uNebPZqZwpDLbIGoKJm6tTFub7vUyx0H 6aRYIhBHPhj7LTgeL1NWpbQBXAOH34SHyMTtNMrpt9aMPukaw7o63A0Kw= X-Received: by 2002:a05:7022:212:b0:128:d24a:a5ba with SMTP id a92af1059eb24-12bfb760956mr9431635c88.20.1775645128604; Wed, 08 Apr 2026 03:45:28 -0700 (PDT) Received: from localhost.localdomain ([76.32.119.210]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-12bed93f861sm24417783c88.0.2026.04.08.03.45.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Apr 2026 03:45:27 -0700 (PDT) From: Hungyu Lin To: gregkh@linuxfoundation.org Cc: dan.carpenter@linaro.org, ethantidmore@gmail.com, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Hungyu Lin Subject: [PATCH v4 6/6] staging: rtl8723bs: convert _rtw_init_xmit_priv to return errno Date: Wed, 8 Apr 2026 10:44:24 +0000 Message-Id: <20260408104424.18952-7-dennylin0707@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260408104424.18952-1-dennylin0707@gmail.com> References: <20260408104424.18952-1-dennylin0707@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Convert _rtw_init_xmit_priv() to return 0 on success and negative error codes on failure. Update the caller to check for non-zero return values. Signed-off-by: Hungyu Lin --- drivers/staging/rtl8723bs/core/rtw_xmit.c | 18 +++++++++--------- drivers/staging/rtl8723bs/os_dep/os_intfs.c | 5 ++++- 2 files changed, 13 insertions(+), 10 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_xmit.c b/drivers/staging/rtl8723bs/core/rtw_xmit.c index fedfc968057b..c6cf23b9c98a 100644 --- a/drivers/staging/rtl8723bs/core/rtw_xmit.c +++ b/drivers/staging/rtl8723bs/core/rtw_xmit.c @@ -128,7 +128,7 @@ s32 _rtw_init_xmit_priv(struct xmit_priv *pxmitpriv, struct adapter *padapter) if (!pxmitpriv->pallocated_frame_buf) { pxmitpriv->pxmit_frame_buf = NULL; - return _FAIL; + return -ENOMEM; } pxmitpriv->pxmit_frame_buf = (u8 *)N_BYTE_ALIGMENT((SIZE_PTR)(pxmitpriv->pallocated_frame_buf), 4); @@ -164,7 +164,7 @@ s32 _rtw_init_xmit_priv(struct xmit_priv *pxmitpriv, struct adapter *padapter) pxmitpriv->pallocated_xmitbuf = vzalloc(NR_XMITBUFF * sizeof(struct xmit_buf) + 4); if (!pxmitpriv->pallocated_xmitbuf) - return _FAIL; + return -ENOMEM; pxmitpriv->pxmitbuf = (u8 *)N_BYTE_ALIGMENT((SIZE_PTR)(pxmitpriv->pallocated_xmitbuf), 4); @@ -183,7 +183,7 @@ s32 _rtw_init_xmit_priv(struct xmit_priv *pxmitpriv, struct adapter *padapter) fsleep(10 * USEC_PER_MSEC); res = rtw_os_xmit_resource_alloc(padapter, pxmitbuf, (MAX_XMITBUF_SZ + XMITBUF_ALIGN_SZ), true); if (res) - return _FAIL; + return res; } pxmitbuf->phead = pxmitbuf->pbuf; @@ -212,7 +212,7 @@ s32 _rtw_init_xmit_priv(struct xmit_priv *pxmitpriv, struct adapter *padapter) if (!pxmitpriv->xframe_ext_alloc_addr) { pxmitpriv->xframe_ext = NULL; - return _FAIL; + return -ENOMEM; } pxmitpriv->xframe_ext = (u8 *)N_BYTE_ALIGMENT((SIZE_PTR)(pxmitpriv->xframe_ext_alloc_addr), 4); pxframe = (struct xmit_frame *)pxmitpriv->xframe_ext; @@ -244,7 +244,7 @@ s32 _rtw_init_xmit_priv(struct xmit_priv *pxmitpriv, struct adapter *padapter) pxmitpriv->pallocated_xmit_extbuf = vzalloc(NR_XMIT_EXTBUFF * sizeof(struct xmit_buf) + 4); if (!pxmitpriv->pallocated_xmit_extbuf) - return _FAIL; + return -ENOMEM; pxmitpriv->pxmit_extbuf = (u8 *)N_BYTE_ALIGMENT((SIZE_PTR)(pxmitpriv->pallocated_xmit_extbuf), 4); @@ -259,7 +259,7 @@ s32 _rtw_init_xmit_priv(struct xmit_priv *pxmitpriv, struct adapter *padapter) res = rtw_os_xmit_resource_alloc(padapter, pxmitbuf, MAX_XMIT_EXTBUF_SZ + XMITBUF_ALIGN_SZ, true); if (res) - return _FAIL; + return res; pxmitbuf->phead = pxmitbuf->pbuf; pxmitbuf->pend = pxmitbuf->pbuf + MAX_XMIT_EXTBUF_SZ; @@ -289,7 +289,7 @@ s32 _rtw_init_xmit_priv(struct xmit_priv *pxmitpriv, struct adapter *padapter) MAX_CMDBUF_SZ + XMITBUF_ALIGN_SZ, true); if (res) - return _FAIL; + return res; pxmitbuf->phead = pxmitbuf->pbuf; pxmitbuf->pend = pxmitbuf->pbuf + MAX_CMDBUF_SZ; @@ -301,7 +301,7 @@ s32 _rtw_init_xmit_priv(struct xmit_priv *pxmitpriv, struct adapter *padapter) res = rtw_alloc_hwxmits(padapter); if (res) - return _FAIL; + return res; rtw_init_hwxmits(pxmitpriv->hwxmits, pxmitpriv->hwxmit_entry); for (i = 0; i < 4; i++) @@ -313,7 +313,7 @@ s32 _rtw_init_xmit_priv(struct xmit_priv *pxmitpriv, struct adapter *padapter) rtw_hal_init_xmit_priv(padapter); - return _SUCCESS; + return 0; } void _rtw_free_xmit_priv(struct xmit_priv *pxmitpriv) diff --git a/drivers/staging/rtl8723bs/os_dep/os_intfs.c b/drivers/staging/rtl8723bs/os_dep/os_intfs.c index e943dcea1a21..930122275a8e 100644 --- a/drivers/staging/rtl8723bs/os_dep/os_intfs.c +++ b/drivers/staging/rtl8723bs/os_dep/os_intfs.c @@ -636,6 +636,8 @@ void rtw_reset_drv_sw(struct adapter *padapter) u8 rtw_init_drv_sw(struct adapter *padapter) { + int res; + rtw_init_default_value(padapter); rtw_init_hal_com_default_value(padapter); @@ -653,7 +655,8 @@ u8 rtw_init_drv_sw(struct adapter *padapter) init_mlme_ext_priv(padapter); - if (_rtw_init_xmit_priv(&padapter->xmitpriv, padapter) == _FAIL) + res = _rtw_init_xmit_priv(&padapter->xmitpriv, padapter); + if (res) goto free_mlme_ext; if (_rtw_init_recv_priv(&padapter->recvpriv, padapter) == _FAIL) -- 2.34.1