From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dl1-f66.google.com (mail-dl1-f66.google.com [74.125.82.66]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 879643806B8 for ; Wed, 8 Apr 2026 11:14:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.66 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775646856; cv=none; b=BkhE4jGZrVmzKK499H+QgsYPgDUs72/9HELoei9XJuT66vC1v2MxyJ3ETqnf4h7qD4HmL9kBxG74UjWnAI2s9qpbr21Nh6a6/CW+nxDANcwCiJhhYGo0DCak/zu8BCsBm+Iy85jAVpSSzfre95neyaSVEcGD8nqysIzCUbHtyBc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775646856; c=relaxed/simple; bh=iMMCHuUNk205M/t3RiDzeqmOCZFDI8xxxCaYom5FDDA=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=IPc2ii1htro+7I4w75vcUR2rghLxjq+LNg7h9jOdmkFIxaor6Hftd7/RIout1k7esdT152I5jnigQjFB1DquuPXgzyBEm/Mqu3THKUkz0tGdiz2OUz+xgdAhTeQyZMbdw2eVSJfP3PDcV1VdftI+JYoJQSOocQDreOuw6G0Ziao= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=aYCqpxuH; arc=none smtp.client-ip=74.125.82.66 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="aYCqpxuH" Received: by mail-dl1-f66.google.com with SMTP id a92af1059eb24-12c0b72dac7so3872171c88.0 for ; Wed, 08 Apr 2026 04:14:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1775646854; x=1776251654; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=J2zzxZ7T3OrjLQrZ05KQAgPaC26tt2IBs9Eiz7SOG68=; b=aYCqpxuH++TJgMrCLFnUxyzUuTwKlQfK/AM55EYfHe+esm4htycd1P86gwhdSnS2YO ErfjIVsNhJMNOyn1+u+fZT15lGNzod3yiveAOVjDuiIu7+BKvfeQqYsvtUl5KIwCm177 huf3GtVwOP9qmDNJCpkE5bkyGfmXJyfbgGXHHbmfsoi9WCLi9l21q/V8m09RdeyjMD12 rYD7gJNSNV7eZqTYK8C5jIBAFT4NVYJTHlnj6K3zJeiPH9o0c+GNFoztfykbgkJYL1Bv qEJFuWvAtoxRRudI/qO7ud9m/9O/4SqxgeYZgTYwwbs0HqIc0crmKIYm09gz3aFqJJxc I6Yg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775646854; x=1776251654; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=J2zzxZ7T3OrjLQrZ05KQAgPaC26tt2IBs9Eiz7SOG68=; b=rN8RaLZT/zpZLJNKAquVvHXA8+oCD5pz1EKrtFssyf/mf5DSDG6k0ACAf9KbzH30KI zQfQc25W6uHjIL5i+YO/X0WccNY/gCejxcqQ1VgwElbKYVjOqxJSxL/p5/tlndOb7GiU 21X66VfNRvmA7OukS6/+EUGiUQ/O5QsrPE9GlkvYx00aLitL3enR31GQAInftTx/sD7Z PX0R+Z8fQ7jFe5HUF9+RanvyoPNn9QIGFzUgJciLagUhlII+isEYFIQVMDNSPsqf68FM UW6eNEVcW2Rp1dFh9MhJ/0Nlxex5J8c3ybasVjUFKoB2AL2tkyN5goJnpN5Lj5DXbLb1 Tvfw== X-Forwarded-Encrypted: i=1; AJvYcCV++1qaEpU0hO0XhMrJE0EFct0pd0eNYLSrUGDbsADxHBKD/VNLfzybEnWI3S6Z65HDGURx/cOg2dCL0QY=@vger.kernel.org X-Gm-Message-State: AOJu0YzcxfvgVDNo6s1/JGNAe6HxYLP5HFisih/2lkXPKpOy2TaUIA6l DdI4CN8gJQWS1mkINDNAnjCFwQ3s9daK4lqvtY02ECeMOqZatFY/brRy X-Gm-Gg: AeBDiesopcklY41ZrE+qSE8xJGRS+bdGgjdP3nfBHG83LFIYm7W8/SStTGJA0exPeC5 pQd0LiFPpj0uLFTw90hKc1Zbdn0S5iNjTPGPl/FR6AMCUFNGY008QeAXGyaCVZKBQdr/Lzyc4KE 0w5Pk9ARN43R5wFqaS/Kbwl5fjDj9Xx9N6JatIhNWyjvP3+sFRTrIuqyMF7LX1XY1d16YZc0kLe ZkieLy4HGMu9kuGR2BKouyNoe13KIXGAa30fec3AFPuc8RdC5fTUhiT49nuftiWxiT0UT2mTqQG 6irxOcaFhxJUWe/5hVV1kxz+HF7QZ7oW6CrPyiM5iVBChyIGwt1ZcReCBiYjjUPmADxDYV0N3+h sQNhhcymKiV+G3cYtZBksv1o4xHuAS9A6Ys1n3gCQLMj2msfWdcuNuUmq7DLcBkY1s2Stm2BHPh LtuV64kbeZgVaoZN9f36SelNUtlJ5vsZ/LSOogloikPtqzhFwoRVkyfKw= X-Received: by 2002:a05:7022:f30f:b0:12c:43:839b with SMTP id a92af1059eb24-12c00438781mr4755345c88.35.1775646853603; Wed, 08 Apr 2026 04:14:13 -0700 (PDT) Received: from localhost.localdomain ([76.32.119.210]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-2ca7c20c0c2sm21228019eec.17.2026.04.08.04.14.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Apr 2026 04:14:12 -0700 (PDT) From: Hungyu Lin To: gregkh@linuxfoundation.org Cc: dan.carpenter@linaro.org, ethantidmore@gmail.com, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Hungyu Lin Subject: [PATCH v5 5/6] staging: rtl8723bs: convert rtw_os_xmit_resource_alloc to return errno Date: Wed, 8 Apr 2026 11:13:13 +0000 Message-Id: <20260408111314.19329-6-dennylin0707@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260408111314.19329-1-dennylin0707@gmail.com> References: <20260408111314.19329-1-dennylin0707@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Convert rtw_os_xmit_resource_alloc() to return 0 on success and -ENOMEM on failure. Update the callers to check for non-zero return values. Signed-off-by: Hungyu Lin --- drivers/staging/rtl8723bs/core/rtw_xmit.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_xmit.c b/drivers/staging/rtl8723bs/core/rtw_xmit.c index 249947a7d910..fedfc968057b 100644 --- a/drivers/staging/rtl8723bs/core/rtw_xmit.c +++ b/drivers/staging/rtl8723bs/core/rtw_xmit.c @@ -78,12 +78,12 @@ static int rtw_os_xmit_resource_alloc(struct adapter *padapter, struct xmit_buf if (alloc_sz > 0) { pxmitbuf->pallocated_buf = kzalloc(alloc_sz, GFP_KERNEL); if (!pxmitbuf->pallocated_buf) - return _FAIL; + return -ENOMEM; pxmitbuf->pbuf = (u8 *)N_BYTE_ALIGMENT((SIZE_PTR)(pxmitbuf->pallocated_buf), XMITBUF_ALIGN_SZ); } - return _SUCCESS; + return 0; } s32 _rtw_init_xmit_priv(struct xmit_priv *pxmitpriv, struct adapter *padapter) @@ -179,10 +179,10 @@ s32 _rtw_init_xmit_priv(struct xmit_priv *pxmitpriv, struct adapter *padapter) /* Tx buf allocation may fail sometimes, so sleep and retry. */ res = rtw_os_xmit_resource_alloc(padapter, pxmitbuf, (MAX_XMITBUF_SZ + XMITBUF_ALIGN_SZ), true); - if (res == _FAIL) { + if (res) { fsleep(10 * USEC_PER_MSEC); res = rtw_os_xmit_resource_alloc(padapter, pxmitbuf, (MAX_XMITBUF_SZ + XMITBUF_ALIGN_SZ), true); - if (res == _FAIL) + if (res) return _FAIL; } @@ -258,7 +258,7 @@ s32 _rtw_init_xmit_priv(struct xmit_priv *pxmitpriv, struct adapter *padapter) pxmitbuf->buf_tag = XMITBUF_MGNT; res = rtw_os_xmit_resource_alloc(padapter, pxmitbuf, MAX_XMIT_EXTBUF_SZ + XMITBUF_ALIGN_SZ, true); - if (res == _FAIL) + if (res) return _FAIL; pxmitbuf->phead = pxmitbuf->pbuf; @@ -288,7 +288,7 @@ s32 _rtw_init_xmit_priv(struct xmit_priv *pxmitpriv, struct adapter *padapter) res = rtw_os_xmit_resource_alloc(padapter, pxmitbuf, MAX_CMDBUF_SZ + XMITBUF_ALIGN_SZ, true); - if (res == _FAIL) + if (res) return _FAIL; pxmitbuf->phead = pxmitbuf->pbuf; -- 2.34.1