From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dy1-f194.google.com (mail-dy1-f194.google.com [74.125.82.194]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6FCFB381B11 for ; Wed, 8 Apr 2026 11:14:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.194 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775646857; cv=none; b=XIdtX4OhoJsRv9eZ8aN+2f0Woh+2kqbpjoaRy4qsMtFybj++84bz2mekmB1WW41tQKIfBh692ODbw3xkQYbud67EmxNINe74N5iQnFVDgDjTTF/DgwgqlcgDK2ua+gCnAM7FXCeB6V5WmI5zCHZ5lm8wUR0GeUzUHN5F/QTFec8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775646857; c=relaxed/simple; bh=5VA39pk5pr3Tb1SspAw3AEa9oD/Vw2bnGrhCZwCJt1U=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=AXAvcxDu8uirPAeM8A/G5V3CwV5oPaZT0jCuHMwxdwVHHQiE0nmswSf9NT9QXdfSpGHRleioM6RiYKsrZJLOEHgz21k0yA1LJq8TbCxkpuQ9oTd7YNnT16A5e1BPVkUksgvfleldkwI7VI6jrtUY2kLfrnm1cijNpuboetJQkeM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=pNCd5xKy; arc=none smtp.client-ip=74.125.82.194 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="pNCd5xKy" Received: by mail-dy1-f194.google.com with SMTP id 5a478bee46e88-2ce102afb0aso4969703eec.1 for ; Wed, 08 Apr 2026 04:14:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1775646856; x=1776251656; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=ZCSI+m4q94UTjIe2aTkAkzmMjm1M0fLyMUaJI6Pir6Q=; b=pNCd5xKyUvL3hzYmUP89DmpeK5xrz0KJdlW13tc4+yg0OgKZXTM3J7VPJSSJg8Uq46 uwBCNasW7pJIIHTgR2jqV98p2o7mKbpsRql0JWIIUo7/2a6RxJmeGm0br9HgAyGC4DbS b72sBSxyZX35gM2J4i4W/+Ul96c9rP1lkWJzrcVPEZCcNL8nEvcSbb4lLJp1/B1MgYUN jRmsyDiaCDLuCNB8SB63toayvXc0YooP45BjDrDrY0SIpuk/UQ/asG47r2FMgDL8slwM 71Xi4BEU2PhLMK6UCq1UYfvorXU/YuEIdiJrxj+J+hhxuR/hZF8JeWpoi+PwGWFA22k0 zjWg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775646856; x=1776251656; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=ZCSI+m4q94UTjIe2aTkAkzmMjm1M0fLyMUaJI6Pir6Q=; b=IMbwykEuV+Gx+fPNxuyu3F8dS0561Yn0HRo8SkjiWw0BSiUbva0ONMvAzISLaE5451 iQuhHoTa4r93OnYMAL909n2wkgUy8FmzYA2HQUyBaGarRnspPXQXNdu2wZBcDUfHvEn8 1hcyU89dslCAjvRFolLnIbzsfjqm/4KkekEHH2G1k/jWsq2Kp5BvRGi73/Azzk62wzCE 28pLrQVxdxiQKlMFHD3OBUS4l6Q51IHdrYBqiDWkFxr8OqTOU/O3wobozHLQFmWokzPH szduJOEvlYc5wUcWsTaytg7pIm1yr8awqytRyQI5h4qx4oJPQPLhn/nKydaVCql8V/F1 K5hA== X-Forwarded-Encrypted: i=1; AJvYcCUvFIycQhuXO3FHKyyfT9GYTw2a1/8O6Rw7SdMstOR3fC31/eFTk5v3pzH0p5wZ+XFTsStWqP1dybkAx3w=@vger.kernel.org X-Gm-Message-State: AOJu0Yxa1TSkNTMYxJaJLhKoRzuw3xcrcjrjQy7F5Xlv2Je3vvbz+gcz wqFyuDYe4FoLp71/R3MEQGN5OiempWoxQICnNNSmeyd8/bS4GY8bwHDlyUScxezs X-Gm-Gg: AeBDieu9W/1R6PtajrWWX8IjHd+52tUsttDkSzcMUF/zgmv2Ppcbc4jyQ1EbrwSxxzO 69yixRs3ZctBC76kOkRV+rIVx0sE2bMvvpMr/PsJHSjr0qjKVg51uAsGymXvQgRms70FcSmjb9y Ej7yVV2ZkYD+UGkGliMLff6hS4zCn3Mvmnc3rzH7cDiRp0/SONGri1A+B4ZNtLB99udkZheS30N 6ZyaxW52mYebnFzlbFyBEHqSEJ5KJqkdGCn7RPT+VB/NWY1ezVv54XWm69n4tPJJNyPjWZEUft1 YjAMHBYmqk8UygfPl7KhOrRRmaoiy2wd3YXyqETl4G2N8lSQsMN+RzYKV7eAUBKVCM2Ki41NtGP LfNlj8DB16sS4aq8zE3Rji1mBhOgZWbKJsHKTsI6nkzFewv/LTcp5T+ja3CiVIWIW9XFZly408M o2Ux52XWE+f/8U4SpRz0Vn9w6+Moqi8c9io3NsXAPmDhpMtq7Qtjn/uhA= X-Received: by 2002:a05:7300:bc86:b0:2cb:53f5:553e with SMTP id 5a478bee46e88-2cbf64ab2c5mr10359075eec.0.1775646855501; Wed, 08 Apr 2026 04:14:15 -0700 (PDT) Received: from localhost.localdomain ([76.32.119.210]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-2ca7c20c0c2sm21228019eec.17.2026.04.08.04.14.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Apr 2026 04:14:14 -0700 (PDT) From: Hungyu Lin To: gregkh@linuxfoundation.org Cc: dan.carpenter@linaro.org, ethantidmore@gmail.com, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Hungyu Lin Subject: [PATCH v5 6/6] staging: rtl8723bs: convert _rtw_init_xmit_priv to return errno Date: Wed, 8 Apr 2026 11:13:14 +0000 Message-Id: <20260408111314.19329-7-dennylin0707@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260408111314.19329-1-dennylin0707@gmail.com> References: <20260408111314.19329-1-dennylin0707@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Convert _rtw_init_xmit_priv() to return 0 on success and negative error codes on failure. Update the caller to check for non-zero return values. Signed-off-by: Hungyu Lin --- drivers/staging/rtl8723bs/core/rtw_xmit.c | 18 +++++++++--------- drivers/staging/rtl8723bs/os_dep/os_intfs.c | 5 ++++- 2 files changed, 13 insertions(+), 10 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_xmit.c b/drivers/staging/rtl8723bs/core/rtw_xmit.c index fedfc968057b..c6cf23b9c98a 100644 --- a/drivers/staging/rtl8723bs/core/rtw_xmit.c +++ b/drivers/staging/rtl8723bs/core/rtw_xmit.c @@ -128,7 +128,7 @@ s32 _rtw_init_xmit_priv(struct xmit_priv *pxmitpriv, struct adapter *padapter) if (!pxmitpriv->pallocated_frame_buf) { pxmitpriv->pxmit_frame_buf = NULL; - return _FAIL; + return -ENOMEM; } pxmitpriv->pxmit_frame_buf = (u8 *)N_BYTE_ALIGMENT((SIZE_PTR)(pxmitpriv->pallocated_frame_buf), 4); @@ -164,7 +164,7 @@ s32 _rtw_init_xmit_priv(struct xmit_priv *pxmitpriv, struct adapter *padapter) pxmitpriv->pallocated_xmitbuf = vzalloc(NR_XMITBUFF * sizeof(struct xmit_buf) + 4); if (!pxmitpriv->pallocated_xmitbuf) - return _FAIL; + return -ENOMEM; pxmitpriv->pxmitbuf = (u8 *)N_BYTE_ALIGMENT((SIZE_PTR)(pxmitpriv->pallocated_xmitbuf), 4); @@ -183,7 +183,7 @@ s32 _rtw_init_xmit_priv(struct xmit_priv *pxmitpriv, struct adapter *padapter) fsleep(10 * USEC_PER_MSEC); res = rtw_os_xmit_resource_alloc(padapter, pxmitbuf, (MAX_XMITBUF_SZ + XMITBUF_ALIGN_SZ), true); if (res) - return _FAIL; + return res; } pxmitbuf->phead = pxmitbuf->pbuf; @@ -212,7 +212,7 @@ s32 _rtw_init_xmit_priv(struct xmit_priv *pxmitpriv, struct adapter *padapter) if (!pxmitpriv->xframe_ext_alloc_addr) { pxmitpriv->xframe_ext = NULL; - return _FAIL; + return -ENOMEM; } pxmitpriv->xframe_ext = (u8 *)N_BYTE_ALIGMENT((SIZE_PTR)(pxmitpriv->xframe_ext_alloc_addr), 4); pxframe = (struct xmit_frame *)pxmitpriv->xframe_ext; @@ -244,7 +244,7 @@ s32 _rtw_init_xmit_priv(struct xmit_priv *pxmitpriv, struct adapter *padapter) pxmitpriv->pallocated_xmit_extbuf = vzalloc(NR_XMIT_EXTBUFF * sizeof(struct xmit_buf) + 4); if (!pxmitpriv->pallocated_xmit_extbuf) - return _FAIL; + return -ENOMEM; pxmitpriv->pxmit_extbuf = (u8 *)N_BYTE_ALIGMENT((SIZE_PTR)(pxmitpriv->pallocated_xmit_extbuf), 4); @@ -259,7 +259,7 @@ s32 _rtw_init_xmit_priv(struct xmit_priv *pxmitpriv, struct adapter *padapter) res = rtw_os_xmit_resource_alloc(padapter, pxmitbuf, MAX_XMIT_EXTBUF_SZ + XMITBUF_ALIGN_SZ, true); if (res) - return _FAIL; + return res; pxmitbuf->phead = pxmitbuf->pbuf; pxmitbuf->pend = pxmitbuf->pbuf + MAX_XMIT_EXTBUF_SZ; @@ -289,7 +289,7 @@ s32 _rtw_init_xmit_priv(struct xmit_priv *pxmitpriv, struct adapter *padapter) MAX_CMDBUF_SZ + XMITBUF_ALIGN_SZ, true); if (res) - return _FAIL; + return res; pxmitbuf->phead = pxmitbuf->pbuf; pxmitbuf->pend = pxmitbuf->pbuf + MAX_CMDBUF_SZ; @@ -301,7 +301,7 @@ s32 _rtw_init_xmit_priv(struct xmit_priv *pxmitpriv, struct adapter *padapter) res = rtw_alloc_hwxmits(padapter); if (res) - return _FAIL; + return res; rtw_init_hwxmits(pxmitpriv->hwxmits, pxmitpriv->hwxmit_entry); for (i = 0; i < 4; i++) @@ -313,7 +313,7 @@ s32 _rtw_init_xmit_priv(struct xmit_priv *pxmitpriv, struct adapter *padapter) rtw_hal_init_xmit_priv(padapter); - return _SUCCESS; + return 0; } void _rtw_free_xmit_priv(struct xmit_priv *pxmitpriv) diff --git a/drivers/staging/rtl8723bs/os_dep/os_intfs.c b/drivers/staging/rtl8723bs/os_dep/os_intfs.c index e943dcea1a21..f4214608c4fa 100644 --- a/drivers/staging/rtl8723bs/os_dep/os_intfs.c +++ b/drivers/staging/rtl8723bs/os_dep/os_intfs.c @@ -636,6 +636,8 @@ void rtw_reset_drv_sw(struct adapter *padapter) u8 rtw_init_drv_sw(struct adapter *padapter) { + int res; + rtw_init_default_value(padapter); rtw_init_hal_com_default_value(padapter); @@ -653,7 +655,8 @@ u8 rtw_init_drv_sw(struct adapter *padapter) init_mlme_ext_priv(padapter); - if (_rtw_init_xmit_priv(&padapter->xmitpriv, padapter) == _FAIL) + res = _rtw_init_xmit_priv(&padapter->xmitpriv, padapter); + if (res) goto free_mlme_ext; if (_rtw_init_recv_priv(&padapter->recvpriv, padapter) == _FAIL) -- 2.34.1