From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f174.google.com (mail-pf1-f174.google.com [209.85.210.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 18E50331A44 for ; Wed, 8 Apr 2026 18:36:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.174 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775673372; cv=none; b=KvBiDFnvIJvl63B3jvaJcN1jvxxp+QBqCAFbitl5ucsIJihrsDI1NvOIfoULyDyyUNO4Np9D5IYI+TfDb1BT7F2oNXLfdNxDgycB3UcU1kQZpxMehZnqg7j3uyDXm4e8t08cbz2XXrOQnXSuFZj8mqfmOVsT/+odfCOI7kZxQXM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775673372; c=relaxed/simple; bh=FoODtHK87ZLIsLT91VS2/t2ELTaMVveQekR6M37Rqe0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=o1aiubSY0/SCsi2bebcBXP1LPpjrIOXL36siqc0FszhN3PAtD1UHOqPyza4ZxzqWt5nmkggpdwNRCEWCYtAbFci3GrOgRC0S0XJlhmWMThjfa0X0UM/bYTl47sZWHU5Q0BLMKJFKRyasgS7lNiYbaih7h7OJSFcdzbRL9WS+X2U= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=BSKXLrPy; arc=none smtp.client-ip=209.85.210.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="BSKXLrPy" Received: by mail-pf1-f174.google.com with SMTP id d2e1a72fcca58-82cf976ecacso33649b3a.1 for ; Wed, 08 Apr 2026 11:36:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1775673369; x=1776278169; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=0wzDfLfgSZvbjTVt4w0u1g9djtPuy1licBUfHTLjI5M=; b=BSKXLrPy31xj0ggNBDzR0btuBXq5De423O67MYBxm4mKugB07CFwwhRpmJfcGdFMiV NesuKIXP2m+BjHQmfGNiyr1HZvLLGJiOMO7gybhzBwFZv2AhdDAjb9VfdvzcFymMO0wQ yJGGF/oQfxI2fmNfT8p3pGvRX+njp/FX4J3pU8dVZ3BJZSgteTRL/84yRzzf4WobPeIq hrxzlFj/wSWYBw7yASxqOHGFu+5SGhsWGEFPB2biuDvIzKfGAG3RUnQ1bSbQDRDSPdF6 0JQo599SczugsGyDI8+ZpAZIqkIaH02RyxticS3SszsfqUWeJl0DzuLNkYktzcOZHh1R Vhww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775673369; x=1776278169; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=0wzDfLfgSZvbjTVt4w0u1g9djtPuy1licBUfHTLjI5M=; b=Pkm/KU9ZCbad1NE9vfb/TfAeu+vubE0Bnbqr6GMew8yf1WxiZL8+kon1vs9TvpsJgg UmfXGBlxdkWbLm1KRUCqZ8Ttvm7nQTn+f7oUchzTokwdcV2NtNUutWRuruIWerctMepy Ccqtar4cDn9MXvlYeOnRgyQ/zHi6Qwa1f2JhEcEAylphf7wByRhAJKC6YBJJ790RjO8K ffxWxE4IQ9jQ/D2a5fo/ngogZwLKBEtMQOjUz+9f6+Tn7+5UPoJUe6JRyxaxpDD9tSGq tnM1z+GExqibQjnDifboBUev1wkxMCNA84EhWPjLm2q41h9JdGqJmdbe3mfhyDWldmcE 1bvw== X-Forwarded-Encrypted: i=1; AJvYcCWFlhpXK2N2HSzQCDpi0gIYiwgyvVOVFk/ZvjPdLQ3OlR2Jl4gZbvi6P973zVSjoUSaH5KLjctz12JXy2Q=@vger.kernel.org X-Gm-Message-State: AOJu0YzCfoRVfAjptNqhg4qbJJb4W086LlnJvVAMn7fXC71oL7A8xRhJ QAW5RuziTbb1hOhdnkzItgxYVoshfpmdk7YCXRsZQ6eBIY665+ypPxc4 X-Gm-Gg: AeBDiev6IUt0wDlOepW95RKGtluiH8xwbshHfXGxJ+XlpZLXYFM3yM9VmRzR3SEC1KC LU865uTbEesOQKszRlXLecmunD6MepMjwDIM1N5QkHv4xNSEcReeLjN6kmz4V/tBtBlkEa2lyJJ 5D0sp1rB9FFrEdmPauCQzM9qn51p6BonsLJ/zCrrZDK6jKXcD5CzI+bi0EqhkYEGqEEfHDuoK+3 6WrMo7e14kkvGl+qOM2uv5sjHWxEE8gKFQNOvgfZ6zrrc8YqMNUyH+7nf1097/pLKEYZf2z2R68 sV+XP1t63/l7Q63pVfX+MlMHJ+kOIhN2aEJptdX4YifWHO2Vl8tqVyfNlhAMPGxcYFp4xQ6+W1O dCVXxcIt+h2l3uv3c8riS6brElNmfFi6APnuDEAVuCV9wFjTES5rna53rPytY6hT8S3fkIu2QNA 2WV6ooI/Ms/Bb8ytqewtuHrJPVqGw8yw2uoE2WzxopP9nKQmCrAKKpCQeubbvHIXLjSLJk X-Received: by 2002:a05:6a00:1304:b0:829:8942:2ca4 with SMTP id d2e1a72fcca58-82dd89aae52mr482081b3a.19.1775673369332; Wed, 08 Apr 2026 11:36:09 -0700 (PDT) Received: from computer.goose-salary.ts.net ([2a09:bac5:40b2:1a96::2a6:4e]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-82cf9b21c92sm23113251b3a.11.2026.04.08.11.36.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Apr 2026 11:36:09 -0700 (PDT) From: Varun R Mallya To: bpf@vger.kernel.org, leon.hwang@linux.dev, memxor@gmail.com, jolsa@kernel.org Cc: ast@kernel.org, daniel@iogearbox.net, yonghong.song@linux.dev, rostedt@goodmis.org, linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org, varunrmallya@gmail.com Subject: [PATCH bpf-next v4 1/2] bpf: Reject sleepable kprobe_multi programs at attach time Date: Thu, 9 Apr 2026 00:05:48 +0530 Message-ID: <20260408183549.92990-2-varunrmallya@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260408183549.92990-1-varunrmallya@gmail.com> References: <20260408183549.92990-1-varunrmallya@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit kprobe.multi programs run in atomic/RCU context and cannot sleep. However, bpf_kprobe_multi_link_attach() did not validate whether the program being attached had the sleepable flag set, allowing sleepable helpers such as bpf_copy_from_user() to be invoked from a non-sleepable context. This causes a "sleeping function called from invalid context" splat: BUG: sleeping function called from invalid context at ./include/linux/uaccess.h:169 in_atomic(): 1, irqs_disabled(): 0, non_block: 0, pid: 1787, name: sudo preempt_count: 1, expected: 0 RCU nest depth: 2, expected: 0 Fix this by rejecting sleepable programs early in bpf_kprobe_multi_link_attach(), before any further processing. Fixes: 0dcac2725406 ("bpf: Add multi kprobe link") Signed-off-by: Varun R Mallya Acked-by: Kumar Kartikeya Dwivedi Acked-by: Leon Hwang Acked-by: Jiri Olsa --- kernel/trace/bpf_trace.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/kernel/trace/bpf_trace.c b/kernel/trace/bpf_trace.c index 0b040a417442..af7079aa0f36 100644 --- a/kernel/trace/bpf_trace.c +++ b/kernel/trace/bpf_trace.c @@ -2752,6 +2752,10 @@ int bpf_kprobe_multi_link_attach(const union bpf_attr *attr, struct bpf_prog *pr if (!is_kprobe_multi(prog)) return -EINVAL; + /* kprobe_multi is not allowed to be sleepable. */ + if (prog->sleepable) + return -EINVAL; + /* Writing to context is not allowed for kprobes. */ if (prog->aux->kprobe_write_ctx) return -EINVAL; -- 2.53.0