From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f41.google.com (mail-pj1-f41.google.com [209.85.216.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5C1163B19A3 for ; Wed, 8 Apr 2026 19:02:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.41 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775674934; cv=none; b=iis9x619PMHKgDK2m/e+I5xINE84nB0Ht7IAzXwoqcSlB4Pkn4/aaqqDucTO1f0l/Hwmnn3mNR2lHPThX7Xq3pSkEJsk7ijGw3NUNa8TGrWtSezxBjBEI1dtFSKpLNNvwQdpl/6YdkIIpnlGwWZpsTZpaKyY1HePmLeI3kZjH2w= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775674934; c=relaxed/simple; bh=1TRc0F+pxHZ7qBjE9nq3utn2aEfuFmKm3mLNbUw2pr0=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=uPE9gTLTIfYxosnpJ2mOnfkIoSFa1JOy/0O7HYNDzd7S3wXhZLP7tCNRyaTXAQpy18fhFDPM0EUhlabVNVrTDW+XuwsA3bPOZgdw6ZqCZDcaUN4gaqYyDLhk9iw7Ec3ZoXs8fwXvdBKvmheLD6sCY+b509TOlSq6biMey6DKbsw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=kXH7cr0J; arc=none smtp.client-ip=209.85.216.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="kXH7cr0J" Received: by mail-pj1-f41.google.com with SMTP id 98e67ed59e1d1-35d9749c26dso132152a91.2 for ; Wed, 08 Apr 2026 12:02:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1775674933; x=1776279733; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=0nesqW8fDLklcjrRw63qDNiqcszXblDoKfTOnToW0Sg=; b=kXH7cr0J0qYWahH1YtFmpoHcxwPb1m6/aIYju/4B0AUIv0yIEDBGqawlfdOey6gUKZ 5wN4EG6Zw9kSXTcbPJsw4iymyyafceTFf4+bCPcWREOrdmvOhdbusaGuIwh2Al6yCONb FHd4rCdt3XAMhWYMrxTf8Cjn8FCGf+hQvIa+4z2sl8LucXTJE8K6L0BkiRh9vD4Ub4sF NUVrzKpQoAgVqrU3xMKbU3kuE20fQHa59QRPz0OSylO/NbTgQM8PR84I1wxUlBon+NMX 9ZYUxeMHF3WXoi4eAh+IiZvzFpE6xhsyA21pdEow9ft0PsbGSja01aoBmA3cyPwHiTo9 UPIw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775674933; x=1776279733; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=0nesqW8fDLklcjrRw63qDNiqcszXblDoKfTOnToW0Sg=; b=nN7lJIA3x5556cxyEPamuJSpNlMQM8GKP79GDbF7814SO2OsKwf2v67na73qBS2vC+ k37wwBaMTNMB3MNfLaH/t88jOhSMAYx7/oMypkbHYTW33hOnnpSpF6y3exl8VIKR3DRn rKXqGy6JRCUqPTmOmJSNae+88CGADL0GG4R13htihqgLQrVppqUM/IzuFgDOSqqv6x6I 8jJCIUb60DiAlQt7ExQXe+RTiY0VoUeU4oCZDCFyaNti3UxyGzE+bb4NOf1WtKP97okq rqSlNAlcbMzz7wOASgy/ax1m0+5bp7XSfMTDDGIkSHk5BXdb737P5EJp0KYA73K+VxhK 3bQQ== X-Forwarded-Encrypted: i=1; AJvYcCWHjKVo0BEIJKfvBYKN8J2OZZWdEcYB16pZVdEr2cq8cwUsWZgzdMdW+BKVQMI66LWbLLyD9veNVZ+gG+4=@vger.kernel.org X-Gm-Message-State: AOJu0YxYNLYcdnZAZSVrYEwCcE24vBiBaUeG+JU32sNOqL5f4LwuG0FC BQRvpbdO15aPqWOSQqO58JnLhYzAOG+75LgEOfTBdZiteTRqw39G5ghO X-Gm-Gg: AeBDieu5gSub/5O5ojFYd7YJbJrKXRDuqCFmA6sNWFsSNEycuIONGFuKsF94xwTo2dw sdxXwEvPT8ULGQdLztc63+REc8mwl01a2BeiqcV/UvtwzwjBf64rbfc4LlkjRwliWg2XWHX7k2r GZrHmjp1+ZYCHuX0U4GFHwRdIXQHsRjJj5sarzesD5Ulsd3hth6fx/eamSfHvkMJVjwY09yFc0J F3u9ZBtgE8iCokC8y0bx9fHwIqChEaLuIYT9w+aU5cbwYgKSVeZWFh6tq88uTSsGI6xCSDnOshV 50bxkZj4CLxMEKkTeaO2h5gU80L2LmTY2cRotami+ojxTPAlI4De1+JNUyW7i5+O3W05pTrTihn z0Ms8+k2jorvSIsyb1XlxuHeLHgVRT4X5ugJDPV/4HQOQF2Bw5H9OxjgDDlnnXiDuR7wViSqX3L Bmurkc9CbC44L+rv1WQGnWm35LxDULMqBNjM72x+ORnTdw85M/gUGznzfT7lC9sUVtG7UUQCrIK BTT77E= X-Received: by 2002:a17:90b:3811:b0:359:1130:1047 with SMTP id 98e67ed59e1d1-35de68ebf53mr22776643a91.17.1775674932556; Wed, 08 Apr 2026 12:02:12 -0700 (PDT) Received: from computer.goose-salary.ts.net ([2a09:bac5:40b2:1a96::2a6:4e]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-35e34d0d9efsm143630a91.8.2026.04.08.12.02.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Apr 2026 12:02:12 -0700 (PDT) From: Varun R Mallya To: bpf@vger.kernel.org, leon.hwang@linux.dev, memxor@gmail.com, jolsa@kernel.org Cc: ast@kernel.org, daniel@iogearbox.net, yonghong.song@linux.dev, rostedt@goodmis.org, linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org, varunrmallya@gmail.com Subject: [PATCH bpf-next v5 0/2] Reject sleepable kprobe_multi programs at attach time Date: Thu, 9 Apr 2026 00:31:35 +0530 Message-ID: <20260408190137.101418-1-varunrmallya@gmail.com> X-Mailer: git-send-email 2.53.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit These patches fix an issue where sleepable kprobe_multi programs were allowed to attach, leading to "sleeping function called from invalid context" splats. Because kprobe.multi programs run in atomic/RCU context, they cannot sleep. However, `bpf_kprobe_multi_link_attach()` previously lacked validation for the `prog->sleepable` flag. This allowed sleepable helpers, such as `bpf_copy_from_user()`, to be invoked from an invalid non-sleepable context. This series addresses the issue by: 1. Rejecting sleepable kprobe_multi programs early in `bpf_kprobe_multi_link_attach()` by returning -EINVAL. 2. Adding selftests to explicitly verify that attaching a sleepable kprobe_multi program is rejected by the kernel. P.S: The first of these two commits has been applied to the bpf tree. Changes: v1->v2: - v1: https://lore.kernel.org/bpf/20260401134921.362148-1-varunrmallya@gmail.com/ - Defective selftest added v2->v3: - v2: https://lore.kernel.org/bpf/CAP01T74YgnKop-dgwBToOcfg4_D44t1wUBopFYPMquirCmaLfg@mail.gmail.com/ - Selftest separated from change into different commit. v3->v4: - v3: https://lore.kernel.org/bpf/20260401191126.440683-1-varunrmallya@gmail.com/ - Selftest moved to test_attach_api_fails. - Changed attachment symbol to bpf_fentry_test1 for stability. - Changes suggested by Leon implemented. v4->v5: - v4: https://lore.kernel.org/bpf/20260408183549.92990-1-varunrmallya@gmail.com/ - fix the mistake of leaving test_attach_multi_sleepable after changing location. Varun R Mallya (2): bpf: Reject sleepable kprobe_multi programs at attach time selftests/bpf: Add test to ensure kprobe_multi is not sleepable kernel/trace/bpf_trace.c | 4 +++ .../bpf/prog_tests/kprobe_multi_test.c | 35 ++++++++++++++++++- .../bpf/progs/kprobe_multi_sleepable.c | 25 +++++++++++++ 3 files changed, 63 insertions(+), 1 deletion(-) create mode 100644 tools/testing/selftests/bpf/progs/kprobe_multi_sleepable.c -- 2.53.0