From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EFED03783B1 for ; Thu, 9 Apr 2026 08:46:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775724401; cv=none; b=f1KO1nLOHjd4pmIBiOl56sfqOq8uWDEcjkBdruSirmlNFVmX5xYoGDhtQd+sdJV4hK/C3H9YGo3jPAyGc3Jxd9Deq8O0FMZEJPo1ICckzTlltRo+Woy24b9q6h0NzfsBRL72dwiCuJOOgivCvxPN/cmGg/7a0YMSfwjkKrabaPM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775724401; c=relaxed/simple; bh=L0ObvfduWGAGP21veczdi1azriQW28n0o9uJhPgYbBI=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=CjwPP1GosHakFzOOa41qQNocYB02TM2SvZwdTObCwnoaL1SY+skWVOG9pMjxuQGa/G+DDG/NFlbedL3habFyHyIF5VTMzC5A1RkId7V5yle0BG2AnMh56Hp0tsMAWBEb247UBWNAHzNMvOx2u8YM1SD8SZL+aMU8nU5n2uF1djQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=NQe54dZq; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=SjKnZYa7; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="NQe54dZq"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="SjKnZYa7" Received: from pps.filterd (m0279871.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6394t2c84107677 for ; Thu, 9 Apr 2026 08:46:39 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 6CrVle28WB7UnN3fLJ+Ty/OkvEJHEIJlIT67rX6hqJA=; b=NQe54dZqD4tXrKWt IfH99gSgI1GYFG4OJXyu4tM9Y0D3CQ+hQYtzyk47L8lKJbdAldEFtme1p1/+gXuB 2WOyN7wAOiTYe3mRuFochd6CfJ81tfCR/K4aWqT80nS1k0m16TWE79+zfjUhMfXD LB1tH9L7+2QmWawGqwtjh0feIe+DNd4C6a7eTFHnWiBBsalXbSlYye9Y0+VUsXVz Jg6r0ewcgVRDgYK9W0KAqugPa9HgDquxee4dE+AG8gAdUeSN0viTqOaOgCiC1FUK njCPnP7CaFkBuC92OV5IV05zhOuPXCnpagw9orse6BNYU6miplonpMRIxo+9P8Al j3zUPw== Received: from mail-dl1-f72.google.com (mail-dl1-f72.google.com [74.125.82.72]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4ddxhaj1hr-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 09 Apr 2026 08:46:38 +0000 (GMT) Received: by mail-dl1-f72.google.com with SMTP id a92af1059eb24-12bf921cf49so8662791c88.1 for ; Thu, 09 Apr 2026 01:46:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1775724398; x=1776329198; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=6CrVle28WB7UnN3fLJ+Ty/OkvEJHEIJlIT67rX6hqJA=; b=SjKnZYa7DXoib/ne2P0NLPNfolrQOLQDtZu7CI3t7c95m0ekprVt7G/2BBGCWajFwf resGsJo+iBJny4q/BaPMTxpx0kyYeW4f3keRrJ9uXB16wWV6VHyzGcL08STRW2AWXjDb HrI8ehEx87dcz9hu9V9S5O48QUqzngiMtvxnVvc+v+gVNaErtS1HYCm6JIdHibtD2cXP /Rv6dvkXenh5FaO2tZ/jlO1NR45nOHit7gYRaVjre7qWZ8SpOUPIF9qAt9y3O19TLzcX z5OpipsXgZTRKSxA9gdlOzqJoGx7jzSRgUMCTntI7N9CEbrKRxH69MR/yTfE1mPewSPM pJNw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775724398; x=1776329198; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=6CrVle28WB7UnN3fLJ+Ty/OkvEJHEIJlIT67rX6hqJA=; b=c8/bW7mtx0JbP43IUy9DmTBm++rJI+3gsM/IaufbYNZjpW7ndMy7XUzq3s6AhaUggl oV88nBIYxEf1+aaYfSDbcmLpoCkBVdu0uLLZVKwkz9tEJgUQmtyc03pfUedvD3hoHLVh mf7xMk1T+agfjcR0FzFekw48Yi2ZQh+WmX8ZzJN8bczkLYAKLSuCsCCO9QPUTtJgJ2zd UpPZh0374UgR6BdTWbAWlTKxW/xf5K+xPLRh7lLiGctnlVIIFPXjnGOQHDuTGKtPsJXQ gf5pBwOMgPDmGsz/uQg8FFrNvvHAqcG3hITi8PVTy+tiSsE/AKVCXfOi8iqPCSEI3wTG 1x3Q== X-Forwarded-Encrypted: i=1; AJvYcCVWWFsG/f78Tr77cCdSKwnnwxkCHpK4Rv1zea6wmaFqPlW9tTydDdwnCIUrtt63KwRuPJVhs7TRYZ4XgMM=@vger.kernel.org X-Gm-Message-State: AOJu0YzMTmINUs3ZQa164aST/DNUnhIuKfPiq77oHLUqhkk5l88lSSea f4JlejU+rM1wB3OjZLmU+yTcAf0djysxiPU1V+CQt8gWAzz6RjKL+Er7UF5GAEckx0gJKRvzJGY dKvz3B7wBpWvY4fm3XWBNfKn3dpCKIEHxZCeY8QzRCpnc3o7mNCh8b0L2oCDnGXYoyys= X-Gm-Gg: AeBDies34UtcmlLQrsZE981YoIdJHVLP55EZw1EQvOvS/lgMnkIKsvfksJZrbkm1Mmr kXqa/LzfrPJSqMdiQrmGbVNGh6EqNv3Ef1xjIiJn7QwWJIQWf3tcgfvSlyG7nMBObcQsATxE0CM xinVeN5s0UzCLai/J+BB4p1V5wLGzDN5YpCAw2qhXRH75I0nvSSlcXPcpZ9Z6AF3pQnLUXhb7dw afZbVTV8Xk1XpemSjFVY4ijDqebtYDFEbAW61jG5j9M/cBrIRzAqazAznGVeXljxqK4ftfP01L3 TNqUs0bb92f+3eGObEvS2+mW9pTMjbDd10m3NISPoNSmQDtj9z6h62eFY2pxeUdipr0PoyibX5K QdtfF0yET9RmvEdVJ/Pix/NSqWLOnRyu6pZ5KjgNT9G7ZqX/UL0c+kwGSsx7kqgo00LCqBFBu X-Received: by 2002:a05:7022:b9f:b0:128:d5bd:3572 with SMTP id a92af1059eb24-12c28c0f6f3mr1406825c88.31.1775724397915; Thu, 09 Apr 2026 01:46:37 -0700 (PDT) X-Received: by 2002:a05:7022:b9f:b0:128:d5bd:3572 with SMTP id a92af1059eb24-12c28c0f6f3mr1406807c88.31.1775724397294; Thu, 09 Apr 2026 01:46:37 -0700 (PDT) Received: from hu-jingyw-lv.qualcomm.com (Global_NAT1.qualcomm.com. [129.46.96.20]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-12bede54ba8sm28451931c88.10.2026.04.09.01.46.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 09 Apr 2026 01:46:36 -0700 (PDT) From: Jingyi Wang Date: Thu, 09 Apr 2026 01:46:22 -0700 Subject: [PATCH 2/2] remoteproc: qcom: Check glink->edge in glink_subdev_stop() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260409-rproc-attach-issue-v1-2-088a1c348e7a@oss.qualcomm.com> References: <20260409-rproc-attach-issue-v1-0-088a1c348e7a@oss.qualcomm.com> In-Reply-To: <20260409-rproc-attach-issue-v1-0-088a1c348e7a@oss.qualcomm.com> To: Bjorn Andersson , Mathieu Poirier Cc: aiqun.yu@oss.qualcomm.com, tingwei.zhang@oss.qualcomm.com, trilok.soni@oss.qualcomm.com, yijie.yang@oss.qualcomm.com, linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, Jingyi Wang X-Mailer: b4 0.15-dev-3d134 X-Developer-Signature: v=1; a=ed25519-sha256; t=1775724394; l=1712; i=jingyi.wang@oss.qualcomm.com; s=20250911; h=from:subject:message-id; bh=L0ObvfduWGAGP21veczdi1azriQW28n0o9uJhPgYbBI=; b=xe0URL/XMhcfnx9ZDqY0llEzE2lxiq1Xz3M6I/6NxV/iPXd6RWjb0BmK1m1XL6V2FSQh1nZm6 H0zrf3mmxCODjPvRtTgTbq5tDmx9MQ09y0Lkm7e7VtnHgb8tOlEpXea X-Developer-Key: i=jingyi.wang@oss.qualcomm.com; a=ed25519; pk=PSoHZ6KbUss3IW8FPRVMHMK0Jkkr/jV347mBYJO3iLo= X-Proofpoint-ORIG-GUID: RwqBMbSzyRmOhgWMeN5qf3NIMXF8Z2XO X-Proofpoint-GUID: RwqBMbSzyRmOhgWMeN5qf3NIMXF8Z2XO X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNDA5MDA3NiBTYWx0ZWRfXyn/WJxgiFSBb 9czpTatG3hO9R1gSHc4Y/VkmjddYwZ8NXF5jFIqLCDJxK9A/NJUabqfDjqV94xxOxQGdkZL2Ybi gS4hrdcLrqlyxb+bm031SRQy1as59l0USG99yyL5XDQ48OzZBnUIeGoTFsEnt1mgW8UXbkh+Kpv BgqalPPT/Fkg8cSUISbPgZFqsmhB+s0cvBkym2Nh+eMfeSVsRPVc7OVPpmyq29aPmdjUGdCLDM/ z9b6LS6OWTZIoFh1C8AfSIWmnGycCCQJwPo0ajFYl1C8qpsTehnkVtcVbSI1QQwZc+JvK4UuVCR /mzh5EyWTft+2f8bC9sI48tjoViAZQg89AAkxjVFqoFoDawUUMXyPbBgeOC0PpX4t+tcUx/3yK7 nrmkrWX48RvPRQnRsDXD/A7znDZntnLmiopjTlWR820D2/9C0tMwc7RknDX369OVJwgVg74hsuT 07l4cBLxr8iEPXoEL2w== X-Authority-Analysis: v=2.4 cv=BefoFLt2 c=1 sm=1 tr=0 ts=69d7676e cx=c_pps a=bS7HVuBVfinNPG3f6cIo3Q==:117 a=ouPCqIW2jiPt+lZRy3xVPw==:17 a=IkcTkHD0fZMA:10 a=A5OVakUREuEA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=3WHJM1ZQz_JShphwDgj5:22 a=EUspDBNiAAAA:8 a=Bsuwbdf3w_HfsqIaBggA:9 a=QEXdDO2ut3YA:10 a=vBUdepa8ALXHeOFLBtFW:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-04-09_02,2026-04-08_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 adultscore=0 suspectscore=0 spamscore=0 priorityscore=1501 phishscore=0 malwarescore=0 bulkscore=0 clxscore=1015 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604010000 definitions=main-2604090076 For rproc that doing attach, glink_subdev_start() is called only when attach successfully. If rproc_report_crash() is called in the attach function, rproc_boot_recovery()->rproc_stop()->glink_subdev_stop() could be called and cause NULL pointer dereference: Unable to handle kernel NULL pointer dereference at virtual address 0000000000000300 Mem abort info: ... pc : qcom_glink_smem_unregister+0x14/0x48 [qcom_glink_smem] lr : glink_subdev_stop+0x1c/0x30 [qcom_common] ... Call trace: qcom_glink_smem_unregister+0x14/0x48 [qcom_glink_smem] (P) glink_subdev_stop+0x1c/0x30 [qcom_common] rproc_stop+0x58/0x17c rproc_trigger_recovery+0xb0/0x150 rproc_crash_handler_work+0xa4/0xc4 process_scheduled_works+0x18c/0x2d8 worker_thread+0x144/0x280 kthread+0x124/0x138 ret_from_fork+0x10/0x20 Code: a9be7bfd 910003fd a90153f3 aa0003f3 (b9430000) ---[ end trace 0000000000000000 ]--- Add NULL pointer check in the glink_subdev_stop() to make sure qcom_glink_smem_unregister() will not be called if glink_subdev_start() is not called. Signed-off-by: Jingyi Wang --- drivers/remoteproc/qcom_common.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/remoteproc/qcom_common.c b/drivers/remoteproc/qcom_common.c index fd2b6824ad26..79d9d45e0b81 100644 --- a/drivers/remoteproc/qcom_common.c +++ b/drivers/remoteproc/qcom_common.c @@ -220,6 +220,9 @@ static void glink_subdev_stop(struct rproc_subdev *subdev, bool crashed) { struct qcom_rproc_glink *glink = to_glink_subdev(subdev); + if (!glink->edge) + return; + qcom_glink_smem_unregister(glink->edge); glink->edge = NULL; } -- 2.34.1