From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 17898315D3B for ; Thu, 9 Apr 2026 06:26:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775716008; cv=none; b=P4zrI3Us6+h2wXaNdHs9KTanohzPyHgcJoA2mWiXlVSBNB8MLw4Gx1ffCukPFXChDi3IWCh4FAEFmxgw4S6lEnpHL6pJjBPrYySzAOuC3IbyOvlhuhvMxi/VqQ+daXX5v3KwD6mudw5VvpKxKHhoD0nZQeZ87H7ebO8W6w3ilPQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775716008; c=relaxed/simple; bh=voof3OXR63zRr/xn1aaX4h9Q6+CP2DryZBJS4O9NWf4=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=nIJyQ+hm052E43TNOiNfZskF6e0XmVZieuyi2t7ABlqfwjmdVSVPbu2Wz6kckk/GsolaoC1KI4Jj9s1GFSBxIFeiF4WGFVNr2o6QnqND3aj2rdLL9AiQkvJY5ZT7om4uzaVUYhK622y5LXL41ttMuacBRTMLPg/IfFKG8OV2oCo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=U/FZNqWo; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=M2OVnFT7; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="U/FZNqWo"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="M2OVnFT7" Received: from pps.filterd (m0279871.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6394wuYV4107875 for ; Thu, 9 Apr 2026 06:26:46 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=qcppdkim1; bh=cEmJBwZTivF /RSC2tmP5X0gUH+iQ6pYh8h5AOb4GCG0=; b=U/FZNqWoz9h74xg/WkfqqUZiAJh joY1iu4/n9oeAqFcM9AF3L3fXJNRwHCXF9JHiVMSJRL+40QjDZbnALzUfTzckItr Dw6mFVkQVjZiJTOUg87NJkk4zbDMRiGRuLjYzAcR5sCu36VKWBq/MyIMNJl8SZcw 7MEVJFhcnRe0Hg6vm9MUT8xxZKrDzN7OFhejotnAXzEoRfVdX6vDtfzhWHX6s6xa N/t+uYETXR1j4ObDljFBZ4gKCxAV2IEjPFX7ZAKQar9eK7VZnrZ0v6tQrkt0hRBf Y5DEkOiicLQB8QwQtVSRQty5IaMk1tHymq+rfuXkDd60xhk9KGYk8ZxPNKw== Received: from mail-pl1-f198.google.com (mail-pl1-f198.google.com [209.85.214.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4ddxhahjf0-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 09 Apr 2026 06:26:45 +0000 (GMT) Received: by mail-pl1-f198.google.com with SMTP id d9443c01a7336-2b2471321dcso17869275ad.1 for ; Wed, 08 Apr 2026 23:26:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1775716005; x=1776320805; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=cEmJBwZTivF/RSC2tmP5X0gUH+iQ6pYh8h5AOb4GCG0=; b=M2OVnFT7r3+w9b7L5tiGa273PYd83FjJpYXMU0YEkx22kUmFkNZcVVNhrXcMuCwBHc L1yHd1Ct4upNMRrn6Oemu33Feb9UXBf8q1hFhEFH8/vICfyWk9mqEU93Lr9eLsQ6hGBq F8LHm7YVN09LYBRHXtpnn986luFpiAMTFqCd2/+XINpEqosikM/z3W0KpWRvtZ1D7mB3 PAOpTqgmVf3hpAEAwlEHILlJabAionXFkoEiEyg7a754E7pDEaox034N0+nKFcFPF9NF nfUU9gLVRWSvaQZVS6Lv7sTHPdVgz6xjZUYsTLSuh1fiIvTsnhQQPu4c8HiwqGkcerkH TDmw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775716005; x=1776320805; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=cEmJBwZTivF/RSC2tmP5X0gUH+iQ6pYh8h5AOb4GCG0=; b=qJfhTXrBXn0RqJGEbHnY2fY7FfBOBlXxRypMQb0hdVtJQ28QVIW3sJiJnO3qHyM5yY Y0LO2B6h1D2cWYyuqh47zqyikPPNWpbBm6oY0XP6reDOlxoJWF6qbWpk51I/L3LN0QmE u6OMt1DWpIW75YijK340m/7iNortkoyBKvsQCf3d9UHnIdUUeOKek0lPfLtqPmUWa/xU PAGIjdzau8KQKPFQ8dH/YL1T4YC1rMG8EwO4RaPhrD/YXhOjIRVCQyjKSOPrKz+2FOKY IGTTNT9Pegg/mm1fpRKgtSXXaRQUxmGXPaIC2GJoSYJ+qI1j2QzgLODUYKs3vgSe0bR3 Gl0Q== X-Forwarded-Encrypted: i=1; AJvYcCU8t1H9GThY0mgTuASQg/IE07CuUNS97nWDGOQFup2znX6mlw3VwI8MaktmDNA/NwHpMnNLoa7dTrNhWNA=@vger.kernel.org X-Gm-Message-State: AOJu0YyP4LzrmfHrQzd5Kw37J+T6jujiucT6ExU4ZzuukF/HSmcu3/qi 2ddaj2BQy9I+qfNE6JlS0RvjKAkmCFl3/3zMoMiyrzp3w9zncg6G2+L0zc4eoW1/zAH9K0Iopd/ UKyjwMmyzAOPXyHKGD0IENykpfB22dF4MZxdcHo/Hq9LzybwDXUf0TX6YeiCk2ThFNUM= X-Gm-Gg: AeBDietI9BWc/QDVK23xJDUsfYOsu0NV9dKPX53QHdyWrsOpLZTBpXqdqWWw8aY+Y8/ nSML4VYww1uMfwG5XoPzjKA3dZ+e441/2IC1LccgWOSZRRdURRJVdgScswk4yjIbsYDfaA0eA9c n0fdXewW/1DoRhLtj5o5QvGy3P4O9BpN6PZmWN0wlzpZOlSzpto6AurVQvYUP/3BsJTdiuLenV4 LpUIr2DcW1PwRTA6JLXcdORCOC9r/tS3aRk8vN9R8EGaSALX/70ZUvUmaXg16Ca2QR7pSnCGAV3 DtwIVeoblorRBsReXwxfQF1EamJY71iF7z0D40c6haXWkcrRDDEE7iBvgN0wyj/jyn0XoZ8TztY AiviTraOMB5THVHByuKCt9zsOXpQihTL+3PZtLA2TPYf6RkfiLSbSKDTBvqZfgSEglO43GeuYTS BefEs3eQnFWBUlTRhq5Q== X-Received: by 2002:a17:903:3586:b0:2b2:6b58:9317 with SMTP id d9443c01a7336-2b28194ec0fmr245636695ad.39.1775716004882; Wed, 08 Apr 2026 23:26:44 -0700 (PDT) X-Received: by 2002:a17:903:3586:b0:2b2:6b58:9317 with SMTP id d9443c01a7336-2b28194ec0fmr245636355ad.39.1775716004452; Wed, 08 Apr 2026 23:26:44 -0700 (PDT) Received: from QCOM-SocCW5bzXR.qualcomm.com (tpe-colo-wan-fw-bordernet.qualcomm.com. [103.229.16.4]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2b2749cbd4dsm220786795ad.76.2026.04.08.23.26.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Apr 2026 23:26:44 -0700 (PDT) From: Jianping Li To: Srinivas Kandagatla , Amol Maheshwari Cc: Arnd Bergmann , Greg Kroah-Hartman , Abel Vesa , Jorge Ramirez-Ortiz , linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, ekansh.gupta@oss.qualcomm.com, quic_chennak@quicinc.com, Jianping Li Subject: [PATCH v4 4/4] misc: fastrpc: Allow fastrpc_buf_free() to accept NULL Date: Thu, 9 Apr 2026 14:26:17 +0800 Message-Id: <20260409062617.1182-5-jianping.li@oss.qualcomm.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260409062617.1182-1-jianping.li@oss.qualcomm.com> References: <20260409062617.1182-1-jianping.li@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Proofpoint-ORIG-GUID: hH7kic5K43a68x9xMtPpP74F5jTSULEX X-Proofpoint-GUID: hH7kic5K43a68x9xMtPpP74F5jTSULEX X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNDA5MDA1NSBTYWx0ZWRfX3GO0rwSJDHSB dr43p1aXKjcVWE2bSm8A0YDthk7hkUebA1EpLKAznuc0UIVHVnIyglj5vM1VtmM8g6L+IkhYpF9 aC2jrZNluj7ST4vnE5Bl8rMB/nWFCeIdIqh0AGJfyISSAkdtyoXIGKT/1QxM2BuUp6qBlzycVQh fYuh4F8wYUlzdHVOFFrX3OsWZMnoKpJSUQ3hGzpvwhzhigM+RfW0fg741BPJ5pCLpna2H49B1yh k9QUF4GlZ9IyK03pwc/emqv+t/I+9gXEWA5Cw5eSYJNJnO6j5catCkNYfAL9hHdIxwWnlwV4HXc LBmE0PzofsegjoKGOGKKOaAMEkV9MEMlVG+cvnXmTY8WlQhxh6vThs2mnwmLEFpmVgK/rXuajDV 1Gjt/Xj0+BMA7gb7bIwHmdN3iSsTvcETOhszGtwaxbl3glEv66qV8giO6GvytzMS3cWTJTaXBS5 mqu9S2w1maH4g12X2OA== X-Authority-Analysis: v=2.4 cv=BefoFLt2 c=1 sm=1 tr=0 ts=69d746a5 cx=c_pps a=MTSHoo12Qbhz2p7MsH1ifg==:117 a=nuhDOHQX5FNHPW3J6Bj6AA==:17 a=A5OVakUREuEA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=3WHJM1ZQz_JShphwDgj5:22 a=EUspDBNiAAAA:8 a=GmafkBk8WXepDEkBruoA:9 a=GvdueXVYPmCkWapjIL-Q:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-04-09_01,2026-04-08_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 adultscore=0 suspectscore=0 spamscore=0 priorityscore=1501 phishscore=0 malwarescore=0 bulkscore=0 clxscore=1015 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604010000 definitions=main-2604090055 From: Ekansh Gupta Make fastrpc_buf_free() a no-op when passed a NULL pointer, allowing callers to avoid open-coded NULL checks. Co-developed-by: Ekansh Gupta Signed-off-by: Ekansh Gupta Signed-off-by: Jianping Li --- drivers/misc/fastrpc.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/drivers/misc/fastrpc.c b/drivers/misc/fastrpc.c index a67ae991c0b0..3cce81d0cd8b 100644 --- a/drivers/misc/fastrpc.c +++ b/drivers/misc/fastrpc.c @@ -416,6 +416,9 @@ static int fastrpc_map_lookup(struct fastrpc_user *fl, int fd, static void fastrpc_buf_free(struct fastrpc_buf *buf) { + if (!buf) + return; + dma_free_coherent(buf->dev, buf->size, buf->virt, fastrpc_ipa_to_dma_addr(buf->fl->cctx, buf->dma_addr)); kfree(buf); @@ -512,8 +515,7 @@ static void fastrpc_context_free(struct kref *ref) for (i = 0; i < ctx->nbufs; i++) fastrpc_map_put(ctx->maps[i]); - if (ctx->buf) - fastrpc_buf_free(ctx->buf); + fastrpc_buf_free(ctx->buf); spin_lock_irqsave(&cctx->lock, flags); idr_remove(&cctx->ctx_idr, ctx->ctxid >> 4); @@ -1565,8 +1567,7 @@ static int fastrpc_device_release(struct inode *inode, struct file *file) list_del(&fl->user); spin_unlock_irqrestore(&cctx->lock, flags); - if (fl->init_mem) - fastrpc_buf_free(fl->init_mem); + fastrpc_buf_free(fl->init_mem); list_for_each_entry_safe(ctx, n, &fl->pending, node) { list_del(&ctx->node); -- 2.43.0