From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 709993DD519 for ; Thu, 9 Apr 2026 15:47:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775749637; cv=none; b=r4tll+6dOes/2cifx+Wk32KHesX1Cx+j/9owx1NDRyT7Awq/U2b5PNWsf1UkO/Gcba/1vwOrAMZ84JTw3AJCZmEDeTxcivoWjEd9l9pxsoQk8tPHsCjlm+xiUAMQGYPDBwKhLWubVeBdxnCzmO+VPLyB1MNk8v5J36SUkf6LGGg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775749637; c=relaxed/simple; bh=yG9UbbMGeM+YQuacdgn4jctWS7O1LoAP55d/mSf8ZVs=; h=Date:From:To:Cc:Subject:Message-Id:In-Reply-To:References: Mime-Version:Content-Type; b=ZHiXFgLtdnOznOF8FXt1z6WMoi64aVemvurmkugKGTGWxFhYyyZFGm6nxUcLXWXYX8TZ/6iBUCpO3953d/zv9C45k4LEAwVl1jNX00TerfNfFAf4lerxJQ6D0qIm2CDOWe8CpD9PVwr2+y+Iir6mfX0vZO4SKvg78rpYiLYieFc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux-foundation.org header.i=@linux-foundation.org header.b=sUATYZCA; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux-foundation.org header.i=@linux-foundation.org header.b="sUATYZCA" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 71DD2C116C6; Thu, 9 Apr 2026 15:47:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1775749636; bh=yG9UbbMGeM+YQuacdgn4jctWS7O1LoAP55d/mSf8ZVs=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=sUATYZCAwQXpTSBibLbcWNOYmJIk/HMzh0aG/AqTfeZhF6N6gZe76YUcdl7DVPSn/ /qMswAmmQ8gRiC0lKE4J70ArQ2PQK/bs9D2uhtNbQw9IFQSlQ++zQcluEZVsiP2ATA dYKa6fPrDh6kzVAprj31aGPo6jBqLMvo1zS2lKcw= Date: Thu, 9 Apr 2026 08:47:15 -0700 From: Andrew Morton To: Breno Leitao Cc: David Hildenbrand , Lorenzo Stoakes , "Liam R. Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , Christoph Lameter , linux-mm@kvack.org, linux-kernel@vger.kernel.org, kas@kernel.org, shakeel.butt@linux.dev, usama.arif@linux.dev, kernel-team@meta.com Subject: Re: [PATCH v2] mm/vmstat: fix vmstat_shepherd double-scheduling vmstat_update Message-Id: <20260409084715.44d6ed4df7e092214cbefa90@linux-foundation.org> In-Reply-To: <20260409-vmstat-v2-1-e9d9a6db08ad@debian.org> References: <20260409-vmstat-v2-1-e9d9a6db08ad@debian.org> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Thu, 09 Apr 2026 05:26:36 -0700 Breno Leitao wrote: > vmstat_shepherd uses delayed_work_pending() to check whether > vmstat_update is already scheduled for a given CPU before queuing it. > However, delayed_work_pending() only tests WORK_STRUCT_PENDING_BIT, > which is cleared the moment a worker thread picks up the work to > execute it. Thanks, I tentatively added this to the 7.1-rc1 queue, to upstream ~2 weeks hence.