From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ot1-f41.google.com (mail-ot1-f41.google.com [209.85.210.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 19C443AD52F for ; Thu, 9 Apr 2026 09:12:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.41 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775725937; cv=none; b=Twf0vbnS61cLPqOIcV0kl9MKhnnJ8CLPQXrZIhsRQkT+zCQiWivrIDttQHTIwWHOEf0VW98O0OeN2CTKTUHHcICJGwxeZjjJrbRTIK8Ti6lV9ErzX0tLz9lhG8t6OUYkaPzi/NS4SEKspUgl99dHS/1CijbaxQ/wZDFyI5YOsSc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775725937; c=relaxed/simple; bh=KEDo4Pjr0IN3FkhSekZ94kp9g3LdLPJ7f8RzH9S1DIs=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Qg/ca94DxjTpQrJLt2zdqhcbpzXCgGUmSp49Cp+K04HDG0Mjgn5km5Fuix41SAlJ31V14XEppt8ByQ7lcJEIk3js3RJMwEHNIIo2goYdhG5DDn4H97/9mIA9XskqR6Mx6PXt4/5g4brqMmWlDkQ59VqaJNHIYSqr/xhtWYgzJ8Q= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=neuling.org; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=d+OBI65y; arc=none smtp.client-ip=209.85.210.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=neuling.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="d+OBI65y" Received: by mail-ot1-f41.google.com with SMTP id 46e09a7af769-7d4c383f2fcso505741a34.0 for ; Thu, 09 Apr 2026 02:12:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1775725929; x=1776330729; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:sender:from:to:cc:subject:date :message-id:reply-to; bh=xG5rOEE7q2/QsMF7xOjPBwhp3322th365MiqXC7VApY=; b=d+OBI65yfwJ45ZHhyfIANCsexZrMTVvdAXJ7Scp+Mr8JDMxHT3xT0uQObv5YJlEdbb kpvwEGleQ855WHmi2UJFc3zQUJQ7q8GART9Rt0nR4Tdo7q2wipk1Dk0VjjSeJWrIdJlm i7D4BXK326KxisQTi3g0EuJPTb9ojZrgpGuJ+HFl9IjqdbmCwRcwuWjCH5PnmKURw1YK obBYamR0247dhF+X1gjUzhh6T6QALS0VsAzJXh2v0p5bk24mDXPmtbeTfvViAUYbsCWB 3fMe3/N5pYdUwsQQgk/KRY/Vle9F2gpYfo0L+UJFszhAF4bJt8zb6GIBPep0FMYNVqfl EZvQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775725929; x=1776330729; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:sender:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=xG5rOEE7q2/QsMF7xOjPBwhp3322th365MiqXC7VApY=; b=pBpJ9wD+HVGjR6GtgOIjkEbEqBHLSYZ/A7QlTNfDcmGcbfDb3YnjL9BZkwE9+gXDS4 F1kHD+knsLDIvCcGRubB19iqh6YRcw4LAKzL0VDkzYhtNjEoBePZFP0OtHSnUV308ukL U7qKk2h6VI/3jG0YHlC8fXOTC30x4WhZKBddMdNDqmoX+i0vtFLV/k7Rudp1xoXx/PTl 1luOvUTCCJSPi+xA785w4PPoxr76llSqwQdCcWpUPNrXx5ahMr8LQQDzrfqiZAhTeg5+ ZQWLIJ/EAJcXn3PZa9MghiTHE563BIrWAl6ADbB1TUtRpdSYq3SnpoDhc5B2+Nz2+nrD QnBw== X-Forwarded-Encrypted: i=1; AJvYcCXmtDFC8YgW1bkk4vij47zIkSPT/HJFRJeopfXYoYQzjItyGn7fLQxFGs/gekq7K1rO5ySzoV4W5008oW0=@vger.kernel.org X-Gm-Message-State: AOJu0YyJAAMnqAziNxxBqM0y31lRyh2Bz8nD6aTLbEtEvonqJpfReN+P 3ufWnTbMEMZjOZC0W51NSZFZ3d8x4I9hka69pjYkcdPsvsl57eJaIztI X-Gm-Gg: AeBDieuAdMMD34YW6ARdUSbGUREqPD1BgBMbXnaHNSOfkeP3rkKCXUQwePtYWpGYPZL dM3kj517GCGnk9IPOwfaFkrCwSkHwZqtTtkV/O+EO3/lIfLfxmJd8Nh1uP408rWmBQH8V5QeXwi /gwyiNOGyKCfAqLKip+blkWg9WfelYH5JxF3Li0RaTm942ZII9U/OXTErr3u3p4TNRrACKnMGDO pXxDVc0TBRKUVI2QVDUvTa0KSQjqy+GjxLTvY8+DJEIOWlILc2VBFcCnrk5irRWwflkunCGj3yc 2g+PR3mcWZcAVfzxWfaWHqwmRL12ZzGUnllblTDQ3UaPBjBWAIa8dnJIYgi0AgkWeBTmJ1nTc1y lRc3oX30hRQOKLIhmFsEtl62TGyZvkTeey7PwFzpJgCAd3SkhV4gOVH4byxu4Z2Zto3+NDk9aPz FT8rb4ntGpcQfIxWYsDqDbTku/wawnbH+/lQ== X-Received: by 2002:a05:6830:d09:b0:7d7:e565:a4f7 with SMTP id 46e09a7af769-7dbb7518062mr14958706a34.18.1775725929011; Thu, 09 Apr 2026 02:12:09 -0700 (PDT) Received: from ird-aus2.tenstorrent.com ([38.104.49.66]) by smtp.gmail.com with ESMTPSA id 46e09a7af769-7dba7184e14sm15585364a34.11.2026.04.09.02.12.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 09 Apr 2026 02:12:08 -0700 (PDT) Sender: Michael Neuling From: Michael Neuling To: =?UTF-8?q?Bj=C3=B6rn=20T=C3=B6pel?= , "Mike Rapoport (Microsoft)" , "Vishal Moola (Oracle)" , Albert Ou , Aleksa Paunovic , Aleksandar Rikalo , Alexandre Ghiti , Andrew Jones , Andrew Morton , Arnd Bergmann , David Hildenbrand , Djordje Todorovic , Guo Ren , Junhui Liu , Kevin Brodsky , Lorenzo Stoakes , Nam Cao , Oleg Nesterov , Oscar Salvador , Palmer Dabbelt , Paul Walmsley , Qinglin Pan , Raj Vishwanathan4 , linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org Cc: Michael Neuling Subject: [PATCH 3/5] riscv: mm: Fix NULL pointer dereference in __set_memory Date: Thu, 9 Apr 2026 09:11:41 +0000 Message-ID: <20260409091143.1348853-4-mikey@neuling.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260409091143.1348853-1-mikey@neuling.org> References: <20260409091143.1348853-1-mikey@neuling.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit find_vm_area() can return NULL if no vm_struct covers the given address. The code immediately dereferences area->addr without a NULL check. While is_vmalloc_or_module_addr() confirms the address falls within the vmalloc/module address range, it does not guarantee the address belongs to an active allocation, so find_vm_area() may still return NULL. Add the missing NULL check. Fixes: 311cd2f6e2 ("riscv: Fix set_memory_XX() and set_direct_map_XX() by splitting huge linear mappings") Signed-off-by: Michael Neuling Assisted-by: Cursor:claude-4.6-opus-high-thinking --- arch/riscv/mm/pageattr.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/arch/riscv/mm/pageattr.c b/arch/riscv/mm/pageattr.c index 3f76db3d27..46a999c86b 100644 --- a/arch/riscv/mm/pageattr.c +++ b/arch/riscv/mm/pageattr.c @@ -289,6 +289,10 @@ static int __set_memory(unsigned long addr, int numpages, pgprot_t set_mask, int i, page_start; area = find_vm_area((void *)start); + if (!area) { + ret = -EINVAL; + goto unlock; + } page_start = (start - (unsigned long)area->addr) >> PAGE_SHIFT; for (i = page_start; i < page_start + numpages; ++i) { -- 2.43.0