From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f179.google.com (mail-pf1-f179.google.com [209.85.210.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AF31B3BD640 for ; Thu, 9 Apr 2026 10:00:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.179 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775728806; cv=none; b=AIlA5tmh1D7BFVdd7FVMXZjAxIS8CPkTTgxTcgEo+P7aqf3ObQyfvArNNaWO97TNqMGCRjcXWzFk3D6uhkKRLHW2GrON93VrayqHGzpgSojnGiwx8tvnCEGAsrBxfZRiPWLd4KxOZNh730GU51UMGCoiu/F9NxWdMh0tJQnnFNg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775728806; c=relaxed/simple; bh=FJvQA8MuAcOh6TW2OKa4PlnjZIpQv+MvTWNJtTa0wb4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=f6S0m5FfhicKyvz/mpXyZ1E8TCVPvyAor37GRIbkYUcNw4t9RshhL766NpNXraF4yE/E1b85o9kWMRM6NIGkE/SOsBWhNE4V3a1pdDh5W5+35QdSRGso2iXZlsn068rJJ8X7bmLWI3MneZ8AS8lRQtGuXEjBiNi4BvJ5I2aHxUU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=BHxpXfMb; arc=none smtp.client-ip=209.85.210.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="BHxpXfMb" Received: by mail-pf1-f179.google.com with SMTP id d2e1a72fcca58-82cf96ca071so372212b3a.1 for ; Thu, 09 Apr 2026 03:00:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1775728800; x=1776333600; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=mDxowHKiU8yEvUkG0ExyLUfpwERX0ltYh/rUSG2zFlo=; b=BHxpXfMbgFU1vPFnrRihFA6mXShnKpZ0lloYAp8CYOPBOwTmQw6hG6emZyNEB1cXC5 hJ4Ar3rtAh0MtEDxs4Nv3E7sXpuP14IXRPJHHfkdz9Y58xDzOU/0rowz7YiXltAFp7WJ 8G7XPN3rucZ9cX2kxJaA6GrW99AXresKnqlj3jswZM2L3U9ZKDqfiDk/r+z7dPfVHFht TXbORxUI3eCHIvxiF5uxEHNO9RWB/FyNVx/wWPAkndB89rATfk49eSI04ZjuxEpcAkro a7LMoOlFKcntYnQUOTqQmJvHs+KkgQ//7XWIOSPcb2DGYBmaHCLDV80w4W9vhCa81MZQ +gxg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775728800; x=1776333600; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=mDxowHKiU8yEvUkG0ExyLUfpwERX0ltYh/rUSG2zFlo=; b=U2OsSJxoXn54HICzP3mZkea7rwQsZlhGaf4te+wLt7FcxK5Dq2JdGgOyTw+9Kk9Up5 0afIGyfalVoPcJGdCcGb+TMlATKbL4uPiIpg4RpRvVYf4qANehKKiKVRzP2+NRaOqqQZ k6vVBEo/x+h+49EDxjkO3ZpiQ6xIIKHrxkBT7R29ft/OyUdj4OGa3qeZUiigNAxZ+kEG YI/4utPLRtq6RY4soC2jURBPwk6F2rUS6PG0VYqEaK3mt+cyqOfhj8A2ihM4IVcoYD5y nKvY8enevg+D9unD7q1Guwr7GJX8/UiY50x4+d6sk35BUWUo3t76NEoO8RouDsE5qWf2 odAA== X-Forwarded-Encrypted: i=1; AJvYcCXuVmh0iEYVV/6PG94CqkEy4fbFc1hqnF8U4fjGFZcf81LAwxE27JrIINMqFG8F2tcQkqhFoveqPw86mEg=@vger.kernel.org X-Gm-Message-State: AOJu0Yxu44Yu6oVtBvIr4edWEwFRiYiyigmDElB7ziq6MYVJyzbNMOfm hHUnc+9QkQyl2+vAAwldaSfk9+mQGdttkNxpMmu+alOrQILO320v5XOK X-Gm-Gg: AeBDiesN/zg7ZS1jtTuqLW7Fw/e8Xcwu9JImE+Xdpf2n4R8vFTwya+jl/QTX9DVoxVE bpUtMXlL/e2KlwSri30doI/OO+775OfjZPDTC1eIocA7eZy0nM5Rcwx5mt3baHzQKRVxUHjo0L2 pdavQPeT5BwQ/H/i7zY4CrQPZiRBwvldXCrcMPoKj5Z9T/NCdjtp3pSlUfKFF/hEdaWx9w5K/Dj mbt+fGV0zZAbsiPNJ+8B/732QI90wcYDdqi68fx3iO6711bdu5sFsaEqwYR+3Qk3yC3l1EW6U/R LEyW+5NVVNljt75C/qcrbDiQ8Ai0xMr8jWtJRif8hUe2N9mFHHXaEMp6FboHbaZxeg0K8Xvj1X4 GBPg1Q7InrW9Rr2GBzwZ4PUMBrHmXt57eVYr/WSzAU5Wz+x1hgzF+jMv57gmUHKZ3qQ6ALQfLrQ 7/tD6S03pWZrHXulwWlrC1nhjSpuOAII2hYjlD8hrju0rfNn8unGZMmODOSk14OmmsHsJkniJU0 EIRXyEhOV1FznojDadSzg//mVPuKwM7Yg== X-Received: by 2002:a05:6a00:1acb:b0:82c:d9d0:f482 with SMTP id d2e1a72fcca58-82dd8ad4a09mr2845776b3a.46.1775728800090; Thu, 09 Apr 2026 03:00:00 -0700 (PDT) Received: from dev-vm-rm.hzz4ddxqtfeetjrh00qlbgyytb.rx.internal.cloudapp.net ([20.197.52.255]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-82cf9c6b80dsm29113671b3a.42.2026.04.09.02.59.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 09 Apr 2026 02:59:59 -0700 (PDT) From: rajasimandalos@gmail.com To: sfrench@samba.org, linux-cifs@vger.kernel.org Cc: pc@manguebit.org, ronniesahlberg@gmail.com, sprasad@microsoft.com, tom@talpey.com, metze@samba.org, bharathsm@microsoft.com, samba-technical@lists.samba.org, linux-kernel@vger.kernel.org, Rajasi Mandal Subject: [PATCH 4/9] smb: client: sync retrans on remount Date: Thu, 9 Apr 2026 09:59:21 +0000 Message-ID: <20260409095926.905020-4-rajasimandalos@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260409095926.905020-1-rajasimandalos@gmail.com> References: <20260409095926.905020-1-rajasimandalos@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Rajasi Mandal The retrans mount option controls how many times the client retries sending a request before giving up. Although remount already stored the new value in cifs_sb->ctx, it was never propagated to server->retrans, so the running connection kept using the old count. Introduce smb3_sync_server_opts() to push ctx options that live on TCP_Server_Info into the live server struct after a successful remount. For now it handles retrans; subsequent patches will extend it to other server-level knobs. The assignment is guarded (if ctx->retrans) so that a bare 'mount -o remount' (which re-parses /proc/mounts and gets retrans=0 because cifs_show_options does not print it) does not accidentally reset the value to zero. Signed-off-by: Rajasi Mandal --- fs/smb/client/fs_context.c | 17 +++++++++++++++++ 1 file changed, 17 insertions(+) diff --git a/fs/smb/client/fs_context.c b/fs/smb/client/fs_context.c index 90e83f07c870..31b82f8f7ead 100644 --- a/fs/smb/client/fs_context.c +++ b/fs/smb/client/fs_context.c @@ -1336,6 +1336,21 @@ static void smb3_sync_tcon_opts(struct cifs_sb_info *cifs_sb, spin_unlock(&cifs_sb->tlink_tree_lock); } +/* + * Synchronize server-level options that are stored on TCP_Server_Info + * at mount time. These fields are consulted at runtime (retry logic) + * so remount needs to update the live server struct in addition to + * cifs_sb->ctx. + */ +static void smb3_sync_server_opts(struct cifs_sb_info *cifs_sb) +{ + struct TCP_Server_Info *server = cifs_sb_master_tcon(cifs_sb)->ses->server; + struct smb3_fs_context *ctx = cifs_sb->ctx; + + if (ctx->retrans) + server->retrans = ctx->retrans; +} + static int smb3_reconfigure(struct fs_context *fc) { struct smb3_fs_context *ctx = smb3_fc2context(fc); @@ -1475,6 +1490,8 @@ static int smb3_reconfigure(struct fs_context *fc) #endif if (!rc) smb3_sync_tcon_opts(cifs_sb, cifs_sb->ctx); + if (!rc) + smb3_sync_server_opts(cifs_sb); return rc; } -- 2.43.0