From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yx1-f52.google.com (mail-yx1-f52.google.com [74.125.224.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2A88E2D0C79 for ; Thu, 9 Apr 2026 15:16:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.224.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775747763; cv=none; b=KZVyCBwgEpyu+bGI+KcmIK7UQHlI2u3Fq9CvKa0nA6VCpvkk5jUwgP2qORWfD1xp60DKQoVqW3jPfi83AfZPokxfClMVeUHeHUywYcUAbEy3NUgY8C8Yg8z7UILDUKSQh3gowV/sWre7eXgcP7OiJKhAP9F/obG06to2lJDfPy4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775747763; c=relaxed/simple; bh=lPGV8AFmLuXxJZ6gD+bLN7/Il/AxPMIpR2Jc3CtNGME=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=UdyQ95GadW8TIzLap0j60A3a/6Y454bqs5tYA4BphYgGwClJwLB/DQL4OgZjAVXe3V6Ub4/UE0FToLVTp2LaVuJ66eykQL53eEIOS8CO+ioXkzaxExa8qoyM0gUPv0KofqvTVwVzi4sAwYi2Za4Qs30TEBUmoPYVa52/BJydElE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ziepe.ca; spf=pass smtp.mailfrom=ziepe.ca; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b=LZpz0Xab; arc=none smtp.client-ip=74.125.224.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ziepe.ca Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ziepe.ca Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b="LZpz0Xab" Received: by mail-yx1-f52.google.com with SMTP id 956f58d0204a3-6507a833e68so1033447d50.1 for ; Thu, 09 Apr 2026 08:16:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; t=1775747761; x=1776352561; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=hPQPBOBgtkvcgYqzt6x5wusYckTuQGEX69sblOJCEYc=; b=LZpz0XabV91fVUzyHR1SDVj1rFMbOlzdFmKE8y6NboHza3kYCGutR8Y8oMSvras3YG GkGgkeNuY90ChDeiWD9GIZSJkGg/7iv9K/r+Jrm3o7ttWwqpDUGijwuyLMXMwgw6AVSh ilTMnM/rrH3qEpZEF6FbT436ZDGur6BMfJLynCF+fEUebegfu38RZv4414ndahk8DqSb 48UMG2C2vksL8dwd3cY9mS1v5yL18e9Vahmf0n5D5Bhde7CxLj9Cmiw1ctbDQ2c9+YEj RkzsEM392XkRgMtxM/hBWE/zD40uu8R+hbm9+iMSUS13dmC9husxaThRkAfx6WUUPs3i gfBA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775747761; x=1776352561; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=hPQPBOBgtkvcgYqzt6x5wusYckTuQGEX69sblOJCEYc=; b=O9QYItltFRlc6YyEPQtQ3nrJO7rkCaazz3UKxrs9C4sO134MjfpeJRJcRsROfRb4RT xjUgyErRpPnntvYOFiYQxrrH9y06bdKvpls4UkbwPrtKMUWTRKbKxs7OKiH5yxBqbrUJ +P0laVKWn+mtZC4ttf5TPSxAfIgb+yNMm0ChNV1gPLInjULhGKE0JowamYVM7wz0GuTQ NWAmzSzGiscol9t0nzJQGomsPQb7LS9NrbGofEAS5Wg124Ppj656swvobYKFSHkN5xut dKoYuvlK4T4vsxNXm6Npbg+XGq187HoKc28SgrlViHYFMipIiBTo5uRd2RvpyrYrB8ma vuSg== X-Forwarded-Encrypted: i=1; AJvYcCWiokJjiinkwJAfJoMviLm/A30SdpBXXQRFlfe6wGNk5aZ3Jf56x6KlJyszIUJ5VckNYvn180qr047WcSc=@vger.kernel.org X-Gm-Message-State: AOJu0YwUHOtEF84YJxIKslNboR3isVZGzruMvMnuVqJwt7Fyh1N2Mfkh atRaQN09a7dUh5h50Fp0mQje7Hk3CqzOOwhsqzrwqTb1NzY2AFmHVIyR9u6I2iN7c1U= X-Gm-Gg: AeBDievrwV+o8FBeztVynHWDBNUiPU0f7y23AGoKZSefzGCrrJ4NjB+9aTntf3/GSeT yULlDsqCGaQdHEVz8phQcQ1GcvObK6nW6lp8CYH6rZX8C5yGPkqQZ20shZky1a3XAhHXJrV/FYY SdSDC49CmovS+wYLsXnsAzZo8Sl3S1uPLWiQ/+AxczUYg8zSl8sPEyauvSo/jNZN2nfOeQIz6Mq Bm9SluGUHQi4quRUFvwyQYtC6YpI7FAIks4kBOthCaeU0LLvg/aZnhKm9qaOK1gKVSSKlBZWPYC gxYVOCpMRsKABMqDMl/5kC0UCjxk97pfJ+sF0of/UvRS6j6dJPMXhtssuYKSQLEJeYa1C9YpqSb 3ILC4FtUWuHs4a+itOwBMM5Y1D23rML0VjunGTyPZT7HPR5CaeiVvg5vDfuBn3EnLoFE1/eSw+4 8aBeSFrWIa/LVWXNkiaoMJEKlULkcRPDEH5pMG+in5aYfvxMW60/k4gNW0tEdEmMWcylPfgA== X-Received: by 2002:a05:690e:43d1:b0:650:8c3:8df2 with SMTP id 956f58d0204a3-650488afacemr17793279d50.62.1775747760893; Thu, 09 Apr 2026 08:16:00 -0700 (PDT) Received: from ziepe.ca (mctnnbsa70w-159-2-73-22.dhcp-dynamic.fibreop.nb.bellaliant.net. [159.2.73.22]) by smtp.gmail.com with ESMTPSA id af79cd13be357-8d2a8067c73sm1700572085a.24.2026.04.09.08.16.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 09 Apr 2026 08:16:00 -0700 (PDT) Received: from jgg by wakko with local (Exim 4.97) (envelope-from ) id 1wAr6t-00000008Ihi-0wvj; Thu, 09 Apr 2026 12:15:59 -0300 Date: Thu, 9 Apr 2026 12:15:59 -0300 From: Jason Gunthorpe To: Sina Hassani Cc: kevin.tian@intel.com, joro@8bytes.org, will@kernel.org, robin.murphy@arm.com, iommu@lists.linux.dev, linux-kernel@vger.kernel.org, Aaron Wisner , stable@vger.kernel.org Subject: Re: [PATCH v2] Fixes a race in iopt_unmap_iova_range Message-ID: <20260409151559.GR2551565@ziepe.ca> References: <20260407011210.GM2551565@ziepe.ca> <20260407012726.GN2551565@ziepe.ca> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Mon, Apr 06, 2026 at 06:40:05PM -0700, Sina Hassani wrote: > On Mon, Apr 6, 2026 at 6:27 PM Jason Gunthorpe wrote: > > > > On Mon, Apr 06, 2026 at 06:17:24PM -0700, Sina Hassani wrote: > > > On Mon, Apr 6, 2026 at 6:12 PM Jason Gunthorpe wrote: > > > > > > > > On Mon, Apr 06, 2026 at 04:07:01PM -0700, Sina Hassani wrote: > > > > > > > > > io_pagetable *iopt, unsigned long start, > > > > > unmapped_bytes += area_last - area_first + 1; > > > > > > > > > > down_write(&iopt->iova_rwsem); > > > > > + > > > > > + /* Do not reconsider things already unmapped in case of > > > > > + * concurrent allocation */ > > > > > + start = area_last + 1; > > > > > > > > area_last can be ULONG_MAX so this literally overflows to 0. It is why > > > > I formed the suggestion I gave as I did > > > > > > > Yes, in which case the if (start < area_last) that follows will catch > > > it. Are you suggesting I compare against ULONG_MAX instead? > > > > iommufd does not have any overflows to 0 and rely on it tricks like > > this. You should just compare to the existing iteration last > > > Just to confirm that I understand correctly, like this? > > + if (area_last >= last) { > + break; > +. } else { > +. start = area_last + 1; > + } Yeah that looks Ok Jason