From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A3A2138A715 for ; Fri, 10 Apr 2026 20:30:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775853005; cv=none; b=YHTim8l4DyZzOI0HIqLtmDUmzugfn/HuQcupZOYhiFU1Aq9fPWUV+HsQbUFw746RqS444avx4RqPPZOlTzX8hXCSMpJUw8y2uINvj0Cg+y/cj++27MAs4CtTzsUV70PVz7Jo1L56d+BmQevMtEKzzx4vkJ4RCtLdJiTCZQ4bh+I= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775853005; c=relaxed/simple; bh=miLkCGgPWoeuYRd2Ot9VmEnBjNEzn6gpDt1Wc5dunBM=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=r5vywu2v7IX01WSuYpsU7EKAN5zn0JSC8RwdLG50IJHwJv0O2JqBM5BIJldRAmbeBEj/eRfjEZoIBmH6A+YF5j3qS4/9fZ+zNUPS33+1tuixTwIOLAlBYxCo8vSjh7pu0/AfOhgj4gSW6HiMY68naB/WQbMurDWnYeGG3xpMb40= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=XKCgo8eZ; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="XKCgo8eZ" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1775853002; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ZiwF1IZ+iqJ62AEoJed1FVgex1uf9oRtCkn8Of99PQc=; b=XKCgo8eZZfeHnZQLElBn7cH/by9nGjq6DO87WnCzggrmm6Hy0CHFwpylji16pnIpCy0gm6 4y2zsagdPWiqZtpnf1XOueL2p0KuAsYo+G3XFazkckekTUYeybBK2GNwo/a+Op9DYdKQaI tDQpR+pQGirZkWpqF+Xx5wNSQ0x5eTk= Received: from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-690-f0E6JlQNOd2OGOKO_j_lOg-1; Fri, 10 Apr 2026 16:29:57 -0400 X-MC-Unique: f0E6JlQNOd2OGOKO_j_lOg-1 X-Mimecast-MFC-AGG-ID: f0E6JlQNOd2OGOKO_j_lOg_1775852995 Received: from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 2A3181800371; Fri, 10 Apr 2026 20:29:55 +0000 (UTC) Received: from cleech-thinkpadt14sgen2i.rmtusor.csb (unknown [10.2.16.20]) by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with SMTP id DCE11195608E; Fri, 10 Apr 2026 20:29:52 +0000 (UTC) Date: Fri, 10 Apr 2026 13:29:51 -0700 From: Chris Leech To: Daniel Wagner Cc: Keith Busch , Christoph Hellwig , Sagi Grimberg , Hannes Reinecke , linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3] nvme: expose TLS mode Message-ID: <20260410-a7837a6847c8f98c51c89739@redhat.com> References: <20260408-expose-tls-mode-v3-1-b869da028eff@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260408-expose-tls-mode-v3-1-b869da028eff@kernel.org> X-Scanned-By: MIMEDefang 3.0 on 10.30.177.17 On Wed, Apr 08, 2026 at 06:19:56PM +0200, Daniel Wagner wrote: > It is not possible to determine the active TLS mode from the > presence or absence of sysfs attributes like tls_key, > tls_configured_key, or dhchap_secret. > > With the introduction of the concat mode and optional DH-CHAP > authentication, different configurations can result in identical > sysfs state. This makes user space detection unreliable. > > Expose the TLS mode explicitly to allow user space to > unambiguously identify the active configuration and avoid > fragile heuristics in nvme-cli. > > Signed-off-by: Daniel Wagner Looks good, I look forward to 'nvme config --scan --dump' being able to get these configurations correct. Thanks Daniel. Reviewed-by: Chris Leech