From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 13A05329E6F for ; Fri, 10 Apr 2026 09:34:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775813686; cv=none; b=cp3ftT7/lV7NMOznbj9OTVSEL1+HcRpOL0zQTSpiSzCzXWyto1mMdhc5LVCkDlv1puN6vH1eJwvuyDJx+ySSJ9O6l7uRzp8SCOMVy3x9L9CARUrGXIYoaOeobCLL7NYe4h2QOEXKpRy5RGnlzXNaLVE90SmVbuhN6KecZTZWK3E= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775813686; c=relaxed/simple; bh=ISlcJqsaqTclTJzJ0vHpqn6yxruy58dl5Y0F6HoiDg8=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=XZ8pKMpOyLUVc1o5giIMvgGVjr7oAgxv4Woowein8R6dj24MJSTplEiUjEh3WUYKDNsDJlKXramghPHeNKRZIFKOuRHi1QoD0yUfi0ABgliRnkDiWfyuUGQxsh3GiKK3vvmU+jkVLxIFK+Yn/RjwromK5z0IsdxUE+MKdSBGBtM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=Jq9IYHBv; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=jKVE+KF2; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="Jq9IYHBv"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="jKVE+KF2" Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 63A5Ldfv3352591 for ; Fri, 10 Apr 2026 09:34:44 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= j/biFkItFX+oUMqk3cF/h471xd5ZBoQ7TawgNxLQz4g=; b=Jq9IYHBvHrs8c2lD HowZ6aHqSLR8S8SBZhQlTIFB1NS1vZKtaYPOks0A5BusgsAidkYgqJHsoNnvGGHA 3wwG266xzfn5s2tBd4Yy8TnthIXkgf0lEieGn4l2An8rNa0vqo++rUuV0Fm6O3Lw VEShNTEh1yYTdx7b6TktHAK6oGGvx/sNA/R5vSHnST0G5bF40b2Djx/8iLc+s1T5 og1cFUiV9oez8pdf+3xxnOxfHK3TIeb8F8UxkI4WqrT1yHc7w2aodF/d1NAnsVjQ 8orAIZEzefGJ5zH1hzqX3THrrxMNIuq2k2fzvnZdrOkHHhZWKEueQCNNTtoXF8w0 kRamlg== Received: from mail-qv1-f70.google.com (mail-qv1-f70.google.com [209.85.219.70]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4dec1quv5t-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 10 Apr 2026 09:34:43 +0000 (GMT) Received: by mail-qv1-f70.google.com with SMTP id 6a1803df08f44-8950562d351so40680236d6.3 for ; Fri, 10 Apr 2026 02:34:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1775813683; x=1776418483; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=j/biFkItFX+oUMqk3cF/h471xd5ZBoQ7TawgNxLQz4g=; b=jKVE+KF2Z5brVKG3FNGxe4AMTLpYxK9nAQBOBJyvim0eXyU8XtF2HwbpyuH9Oj+20a AGG40r9PND5zbfmXKi4M8o4vyVPr6hiRfuihSnBlpR/Fld+cFUEQZ2XsegT3UEhEiI5/ 40WuDb2qEZI9PVURTeP3YXA4djK5a+ygz2VNJLcLEBd3l0twtvtqR3MC9iwsz65LwXvy hywaxRQksJuTltVwvlt4ZemkPiSL1AlPo0WN8gJ1/OG4MIXIxaa4nhTLEzvcoZBVqsuB dSRxl3KwNbh1Mo0zkwYDpKQXkROQ5tXl8WFN+d9LiAHFXM8AHTnjFuKSirwN5qEH+OgE dTwg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775813683; x=1776418483; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=j/biFkItFX+oUMqk3cF/h471xd5ZBoQ7TawgNxLQz4g=; b=QwIDfrDwWldQpgMJY4Np7keuEBeu2icqu+tcLg1y8r6dCqTOoBfF+XXA+22fRXjUzy JiMe8+Xx5k68yv6fDp91zduT9EFsSIsZ1eVXJ/FFuVctw2OFc8GVvmjq0TCR0tVUBgAT qgdvuocENocWpu3TbI7hNDWctFGA9e9NLWsZP9tLw+N3RE8NGIYf+WI7dhvs49cOpPNA Qb3RP3YhKDXoFmouVUyPQwlAYgzy/4v2MK+olZLGVFqZ5j5ZZY553J4b/hVx3jrnoVWz ZOsDnoMWol7dnvt3fygfIPM3Yaeh60kuFp6Psfg3YYowiphGfi7PWaVtvVJRlAZSHUQg +clQ== X-Forwarded-Encrypted: i=1; AJvYcCW107OD/3AmEeC9lWsp/Q2+8P5zm6tU1GdzeFoOncXvwzMcsEkqTeQNJ+CuDI+FV3ecCQh+pJDVByzzJxo=@vger.kernel.org X-Gm-Message-State: AOJu0YxBvOtyo24pFgNsH38aUrM0dbUBASWoGsPW1zX8Qo0wS4McgL1l ReVBYnjGy5ynAn2QXdJx8thmDspbK+VMkeLjLVjxU9Fc/gjlIHf2sPT0zY5iTE4Rn4IKKzCyhet wLqeUAgxbr9+KYo9EjUj1h1HibSpAKyj8giMjUdPSAKtgPzZKmqoI9FPdRajKnUKw7o4= X-Gm-Gg: AeBDieswvkbxGzdXr/owfRNOVOHg7UQCc2Bi++DFEv8FX4o2xKxKeDENHJwQiyLGbNA Yxr1dK0uRSgOhfdrEVwJUtbOTDrMLpcG37+OdYbCltPfcqnNIG3rRUW8iRt+I5Vk2FCVFGWAvPs Q4WC/t7FjRvl18ZFHOB3EieQWcNX7avxuXhl8Ya4nv3Yf/F+Q2cldpSQ3nhVsiEa/hsGzXilSob ORoXphTCu2VMlOu/f/8wwouvj5YPtwvdk94SC9xz5N3nFRUFD9t2c/fLXrGYw+ujAGpIsXFXDdQ N93tcJqyfV8CSTX/jQMhZnrvtMvl3C6WiJqSf9+hFlpiVKKkyW7fr8bZIH7S3JSVMAKPz3/+yE5 FqXP5542wuFYBtKpHtlBytBSwzVnMgZu7792YVifQ1jL82hvIfh69Y2ZU0gt8Uw8bsFLNJfM5cr uWgPdUhJA= X-Received: by 2002:a05:6214:f06:b0:899:fd80:f79f with SMTP id 6a1803df08f44-8ac8621c0a1mr34233976d6.23.1775813683273; Fri, 10 Apr 2026 02:34:43 -0700 (PDT) X-Received: by 2002:a05:6214:f06:b0:899:fd80:f79f with SMTP id 6a1803df08f44-8ac8621c0a1mr34233626d6.23.1775813682843; Fri, 10 Apr 2026 02:34:42 -0700 (PDT) Received: from yongmou2.ap.qualcomm.com (Global_NAT1_IAD_FW.qualcomm.com. [129.46.232.65]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-8ac84cb135fsm19223386d6.38.2026.04.10.02.34.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 10 Apr 2026 02:34:42 -0700 (PDT) From: Yongxing Mou Date: Fri, 10 Apr 2026 17:33:45 +0800 Subject: [PATCH v4 10/39] drm/msm/dp: split dp_ctrl_off() into stream and link parts Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260410-msm-dp-mst-v4-10-b20518dea8de@oss.qualcomm.com> References: <20260410-msm-dp-mst-v4-0-b20518dea8de@oss.qualcomm.com> In-Reply-To: <20260410-msm-dp-mst-v4-0-b20518dea8de@oss.qualcomm.com> To: Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , Jessica Zhang Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, Yongxing Mou , Abhinav Kumar , Dmitry Baryshkov X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1775813628; l=3860; i=yongxing.mou@oss.qualcomm.com; s=20250910; h=from:subject:message-id; bh=guzQ38GsRaOMwlRV9h4phTGd2vjPW/70KLxhOMZyCc0=; b=OJAr9yvQwhCxq/bCn/E87eHrdjxjohJh9n6mdnmJMS5gvqXMIRWVTF9aTTEhE7GpBYdN+yNbR TDO+rpqEOrMDdk6X0KvOWgYtMQofDl7bsHS3zNH0mbxJ/JeMneBUSH0 X-Developer-Key: i=yongxing.mou@oss.qualcomm.com; a=ed25519; pk=rAy5J1eP+V7OXqH5FJ7ngMCtUrnHhut30ZTldOj52UM= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNDEwMDA4OCBTYWx0ZWRfX2WV1YpXQQcRB K5+3kNC1A4O9Ph31G7Q2xerTUTNusSxwz0SrAYONCvyQXVlpP2ELJh3Stqbfe1cxFflNstDpc4A 8OEMaATDQGfSCxOGkGSEkjrlZe3aY/KfObLCc/K/kWDHsu1KQr4zU0XpnAuiA9eIGIUxbtLzAqC xn27G9Oo+C3uqudNqCSpp4AXP35/LlIGMH6Mb9+2ohj+j4Jv+wuxxmaeAZ+YPduW1EvlJJHnIEP 6FDgdxkoXMDBiaocJ3lAhIw4kKW3vfht4L0WEVbZQVW0GCxiy900D/Iw16rlx9D8IaDQFEKoHEh ed9UIWHDJGK+Im3aIOCbacpY/Z6bFXQvByZtH+DfwjPAZJOfrOs4mlyN9JOyX6WWkFp/IDaTm55 UA87QOyC4hTir6xp01xQGwBD/yev/xs+X6z5XTkNECqDiy8kglklIK6QVC9mHmGxlwUsNAUcJld mOVOzWPw924yaWY4zsw== X-Authority-Analysis: v=2.4 cv=eOcjSnp1 c=1 sm=1 tr=0 ts=69d8c433 cx=c_pps a=oc9J++0uMp73DTRD5QyR2A==:117 a=C3Dk8TwHQYyIj7nOf9RCJw==:17 a=IkcTkHD0fZMA:10 a=A5OVakUREuEA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=gowsoOTTUOVcmtlkKump:22 a=COk6AnOGAAAA:8 a=EUspDBNiAAAA:8 a=OtQsdMd2eBjxU-v0TgUA:9 a=QEXdDO2ut3YA:10 a=iYH6xdkBrDN1Jqds4HTS:22 a=TjNXssC_j7lpFel5tvFf:22 X-Proofpoint-GUID: AA-3q2RUE2JwG-1JDOyk7cTS1fHCebOw X-Proofpoint-ORIG-GUID: AA-3q2RUE2JwG-1JDOyk7cTS1fHCebOw X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-04-10_03,2026-04-09_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 adultscore=0 bulkscore=0 suspectscore=0 phishscore=0 impostorscore=0 lowpriorityscore=0 clxscore=1015 priorityscore=1501 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604010000 definitions=main-2604100088 From: Abhinav Kumar Split dp_ctrl_off() into stream and link parts so that for MST cases we can control the link and pixel parts separately. Signed-off-by: Abhinav Kumar Signed-off-by: Yongxing Mou Reviewed-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/dp/dp_ctrl.c | 8 ++++---- drivers/gpu/drm/msm/dp/dp_ctrl.h | 3 ++- drivers/gpu/drm/msm/dp/dp_display.c | 6 ++++-- 3 files changed, 10 insertions(+), 7 deletions(-) diff --git a/drivers/gpu/drm/msm/dp/dp_ctrl.c b/drivers/gpu/drm/msm/dp/dp_ctrl.c index fa62f8f91189..120ec00884e5 100644 --- a/drivers/gpu/drm/msm/dp/dp_ctrl.c +++ b/drivers/gpu/drm/msm/dp/dp_ctrl.c @@ -2200,7 +2200,7 @@ static int msm_dp_ctrl_on_pixel_clk(struct msm_dp_ctrl_private *ctrl, unsigned l return ret; } -static void msm_dp_ctrl_off_pixel_clk(struct msm_dp_ctrl *msm_dp_ctrl) +void msm_dp_ctrl_off_pixel_clk(struct msm_dp_ctrl *msm_dp_ctrl) { struct msm_dp_ctrl_private *ctrl; @@ -2228,7 +2228,8 @@ static int msm_dp_ctrl_process_phy_test_request(struct msm_dp_ctrl_private *ctrl * running. Add the global reset just before disabling the * link clocks and core clocks. */ - msm_dp_ctrl_off(&ctrl->msm_dp_ctrl); + msm_dp_ctrl_off_pixel_clk(&ctrl->msm_dp_ctrl); + msm_dp_ctrl_off_link(&ctrl->msm_dp_ctrl); ret = msm_dp_ctrl_on_link(&ctrl->msm_dp_ctrl); if (ret) { @@ -2620,7 +2621,7 @@ void msm_dp_ctrl_reinit_phy(struct msm_dp_ctrl *msm_dp_ctrl) phy, phy->init_count, phy->power_count); } -void msm_dp_ctrl_off(struct msm_dp_ctrl *msm_dp_ctrl) +void msm_dp_ctrl_off_link(struct msm_dp_ctrl *msm_dp_ctrl) { struct msm_dp_ctrl_private *ctrl; struct phy *phy; @@ -2634,7 +2635,6 @@ void msm_dp_ctrl_off(struct msm_dp_ctrl *msm_dp_ctrl) msm_dp_ctrl_reset(&ctrl->msm_dp_ctrl); - msm_dp_ctrl_off_pixel_clk(msm_dp_ctrl); dev_pm_opp_set_rate(ctrl->dev, 0); msm_dp_ctrl_link_clk_disable(&ctrl->msm_dp_ctrl); diff --git a/drivers/gpu/drm/msm/dp/dp_ctrl.h b/drivers/gpu/drm/msm/dp/dp_ctrl.h index 32196e97cbe9..b83be2252a9b 100644 --- a/drivers/gpu/drm/msm/dp/dp_ctrl.h +++ b/drivers/gpu/drm/msm/dp/dp_ctrl.h @@ -19,7 +19,8 @@ struct phy; int msm_dp_ctrl_on_link(struct msm_dp_ctrl *msm_dp_ctrl); int msm_dp_ctrl_on_stream(struct msm_dp_ctrl *msm_dp_ctrl, struct msm_dp_panel *msm_dp_panel); int msm_dp_ctrl_prepare_stream_on(struct msm_dp_ctrl *msm_dp_ctrl, bool force_link_train); -void msm_dp_ctrl_off(struct msm_dp_ctrl *msm_dp_ctrl); +void msm_dp_ctrl_off_link(struct msm_dp_ctrl *msm_dp_ctrl); +void msm_dp_ctrl_off_pixel_clk(struct msm_dp_ctrl *msm_dp_ctrl); void msm_dp_ctrl_push_idle(struct msm_dp_ctrl *msm_dp_ctrl); irqreturn_t msm_dp_ctrl_isr(struct msm_dp_ctrl *msm_dp_ctrl); void msm_dp_ctrl_handle_sink_request(struct msm_dp_ctrl *msm_dp_ctrl); diff --git a/drivers/gpu/drm/msm/dp/dp_display.c b/drivers/gpu/drm/msm/dp/dp_display.c index 1bf1335712bc..31e229ac2393 100644 --- a/drivers/gpu/drm/msm/dp/dp_display.c +++ b/drivers/gpu/drm/msm/dp/dp_display.c @@ -730,7 +730,8 @@ static int msm_dp_display_disable(struct msm_dp_display_private *dp) /* set dongle to D3 (power off) mode */ msm_dp_link_psm_config(dp->link, &dp->panel->link_info, true); - msm_dp_ctrl_off(dp->ctrl); + msm_dp_ctrl_off_pixel_clk(dp->ctrl); + msm_dp_ctrl_off_link(dp->ctrl); /* re-init the PHY so that we can listen to Dongle disconnect */ msm_dp_ctrl_reinit_phy(dp->ctrl); } else { @@ -738,7 +739,8 @@ static int msm_dp_display_disable(struct msm_dp_display_private *dp) * unplugged interrupt * dongle unplugged out of DUT */ - msm_dp_ctrl_off(dp->ctrl); + msm_dp_ctrl_off_pixel_clk(dp->ctrl); + msm_dp_ctrl_off_link(dp->ctrl); msm_dp_display_host_phy_exit(dp); } -- 2.43.0