From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 62CA23C1411 for ; Fri, 10 Apr 2026 09:35:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775813756; cv=none; b=BelRDKKj+xQN38JYVk3KR/aqpzt/SjilWZ95OB+xO9McWa64VBW8XRBrhc3umc5I6z66GWiJGET+aQetH18dy9O/WZmcUkcWmwEE1EEg0FjDpluCcpZsW3NXmIYvrZvoMXImOUm0/Q/Kc8IF08aRmzSkr+WKIyiDSiOAnNZRKrw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775813756; c=relaxed/simple; bh=5dPPK/vqSa+qtBhbsYuPVQd47tbzmeUp7YSNmjusLwo=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=t0YAGr3gKOlwbF0SWB1MLTLXd4Ua1dyXs/kn67ruELBEX7kRamYHfNyGfwhiT4rrZ3jh991ql/xHlzlZEydiENuvBZpiv36qibVHgidLntT3wADy0VAPBIj9mXZS8tFWE/kARQqkIYYiVvqaQmvFNqsUMUpei95LCZA5unpnQa4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=dsTSf6x/; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=XA6yBmzk; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="dsTSf6x/"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="XA6yBmzk" Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 63A5oX8n1925770 for ; Fri, 10 Apr 2026 09:35:54 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 61XgEuen/vh1qSyxqs8oQ2EWPQNDTMGXs/P/Z/wvWxc=; b=dsTSf6x/NzDD4CAy 0lH49QILi6G+snmybk+DgUclv6TEZSEVj40I1j3wVKIIbDnVeU+Kn1T4dgMVlWG/ 8v+QXi+PWvbLEVqA/D2+rR7aPnXuHTZU1CGXHTC/UtyEgK8AAwkGu+pWe1012RYo Uz8RJ8LkFT/NtG5akvbqDLX2CG1nzBRogqzUJalmsOBAH5eN+hYeLxobJu4JXUeD O2F53Bsnwn3Ir1EgnUtCYkZyfKiRzYcCwOwmNHiEVQ6tJVrrPMFek3wLOqg26J+I J8teCbcuQOzFT9guTBJC4S1iSP0Xp4UEmDKmjA0ojSnC8/0yK9HXJbt4GZcE+rRb GAFzxQ== Received: from mail-qv1-f70.google.com (mail-qv1-f70.google.com [209.85.219.70]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4deudjrt8u-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 10 Apr 2026 09:35:54 +0000 (GMT) Received: by mail-qv1-f70.google.com with SMTP id 6a1803df08f44-8a5f6110c1cso47968966d6.0 for ; Fri, 10 Apr 2026 02:35:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1775813754; x=1776418554; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=61XgEuen/vh1qSyxqs8oQ2EWPQNDTMGXs/P/Z/wvWxc=; b=XA6yBmzk9WeNVs/nkYzJUGHK+attnaLKwwYeeoPgpPp/SRllK5m4BULc8+zqPht+OA /HHdPSPlmje6wCa4YcoalnNVsGBn7PPjCCIlou7i9aeXzVgE1jG8SgKdpKicQQVevQ/6 89uqkivZ+2g4Sm9K5IbRk6vgOp2z+CAOFb9qNaZUhnmQFbSntbk9y48h5yLw7D1XT2Xg 1QzDDIU6U1JtueCTYg9S6anJoFRRKRV3annzJTtR8zDsvMeSpdAwa7Vr1D2r9FtZqtCp y9f/xvOKr7NsAGSuDI/VKJiF4ZrjxNGTAVP8JHXz9oSIdSRackyppsLkp8UpxX2rVlo/ dhMQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775813754; x=1776418554; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=61XgEuen/vh1qSyxqs8oQ2EWPQNDTMGXs/P/Z/wvWxc=; b=UeC0gDfL8yK790qb9Hf20Z3ZXPQTZadkUO76Q7fzEQTQd1to3Iy4ttQIkNZV7pbscS gx5AqVsKTbnNM/1f/v7LFOrVTBeQPx11m/1CpnyD+HfDoPe8iVIKJILV7BdIv16KH92x oKaZlTZ2Vb40V2XJtleRBWjA64h0/ZUKndcTqbaMib4QfzLrmmUBCeWlWeX2H7gogL93 0BLgg+hOw/4NrEqjzQLEsmAirYKZK0Z7gQ2QBd1d1JG3y0srWQrgonimQg+6K8b+pwwq ZTGHZW6Db+FP/jUhM5AwGIo6Dn4VQNgxHQTBUcduFo++mH+6HONefGnEhf5qW3HXQqfZ Hg9Q== X-Forwarded-Encrypted: i=1; AJvYcCW9mLfyrMfPDY5VO8KCsC2ylDfx1kFerDZMrpqJcFu3+6Mkh4ZHlErRgnz2e7aQbeMrEOIRbLjvZxBWMQ0=@vger.kernel.org X-Gm-Message-State: AOJu0YyS3z60Sz1r8wsO9D5w8ci3TLsyMZDwkoHJBdAI1XH54UpZ3OwN R41lOzlAUslqvn7PH4ZzfK/G0UDwHK1nCoLLgiQT7NmbBHzVYwLTksDxxmqk8AdC+i409N/KFCR glJRkCaJImgxGBh2glflpBhyaNQbUYPjQHhtbLucBHRGvNY1eLp+p4LccQ+tYwYZ+o0A= X-Gm-Gg: AeBDies/otdbA++plJudz8Pyq/UDaPgvNV+bboMVj14V1fVtr0tq9WwQAQMz85Uws05 fo4hdCcgoMclt+nBYaQ+yV6eR6ULK9tvhQ2qUDxYjCCJvFmS3YHnbKUD/gyyWaYpSbmtFh8gpQl fDDAPBkGgaMtnoWmEVx/z25kh8OR6Q1J5i2n854Jqg3ZhmACRobYbonfjUGjfum+erDiLKmkZ0J rzRgVojy6ru7dUSThdgy98HFRTr8RsfK5G4bh+1ihh3m3INI8gS0zE8z8Tn+ppMYzhECch9jhmz HQDDTBL8k7nGXM1D03FsOL4DovzlMBWQUxEAaJliEbGJ2wAp1FPM57q65fvYMJJNt1ko0j8dvEs gNp1bgwmVo1ofYCAZCC2zZOqf2dvh+af5jhSuDs9iIBjaqKKRtgqwcHl7lCGqHJHJXQPoXZx5re 4lY4l54t8= X-Received: by 2002:a05:6214:449e:b0:8ac:7f70:4441 with SMTP id 6a1803df08f44-8ac862b51ccmr32891286d6.48.1775813753771; Fri, 10 Apr 2026 02:35:53 -0700 (PDT) X-Received: by 2002:a05:6214:449e:b0:8ac:7f70:4441 with SMTP id 6a1803df08f44-8ac862b51ccmr32890866d6.48.1775813753334; Fri, 10 Apr 2026 02:35:53 -0700 (PDT) Received: from yongmou2.ap.qualcomm.com (Global_NAT1_IAD_FW.qualcomm.com. [129.46.232.65]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-8ac84cb135fsm19223386d6.38.2026.04.10.02.35.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 10 Apr 2026 02:35:53 -0700 (PDT) From: Yongxing Mou Date: Fri, 10 Apr 2026 17:33:59 +0800 Subject: [PATCH v4 24/39] drm/msm/dp: simplify link and clock disable sequence Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260410-msm-dp-mst-v4-24-b20518dea8de@oss.qualcomm.com> References: <20260410-msm-dp-mst-v4-0-b20518dea8de@oss.qualcomm.com> In-Reply-To: <20260410-msm-dp-mst-v4-0-b20518dea8de@oss.qualcomm.com> To: Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , Jessica Zhang Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, Yongxing Mou X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1775813628; l=1710; i=yongxing.mou@oss.qualcomm.com; s=20250910; h=from:subject:message-id; bh=5dPPK/vqSa+qtBhbsYuPVQd47tbzmeUp7YSNmjusLwo=; b=YnPj9rhLUqX0YMJuz2KcI13tmzC5pqiY6d5hLKxDeRa5BnhKKAvFXqZZs0G2L1JkUppp16Gyt XmGF/bb3PUMDT1iH5NZwq881b4Zg+vYe031JZuwYOXjWIRCdbH16bxQ X-Developer-Key: i=yongxing.mou@oss.qualcomm.com; a=ed25519; pk=rAy5J1eP+V7OXqH5FJ7ngMCtUrnHhut30ZTldOj52UM= X-Authority-Analysis: v=2.4 cv=X+hi7mTe c=1 sm=1 tr=0 ts=69d8c47a cx=c_pps a=oc9J++0uMp73DTRD5QyR2A==:117 a=C3Dk8TwHQYyIj7nOf9RCJw==:17 a=IkcTkHD0fZMA:10 a=A5OVakUREuEA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_K5XuSEh1TEqbUxoQ0s3:22 a=EUspDBNiAAAA:8 a=kizIpwokdwCcU-m5XREA:9 a=QEXdDO2ut3YA:10 a=iYH6xdkBrDN1Jqds4HTS:22 X-Proofpoint-GUID: 1Ad84zQ_DGG91kIYW-sZHvvguUO32WAY X-Proofpoint-ORIG-GUID: 1Ad84zQ_DGG91kIYW-sZHvvguUO32WAY X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNDEwMDA4OSBTYWx0ZWRfX+zxHHF5iqQ+B UqLWUE/czwApPdstF3NG492rcvskyuTsOo+qf8M9MRX4NYF3I3baFJy0kRUOkwTxmVutLRiLzsx OfVkG2aw79xz+D0lwZSWl2sOdlDRWZQPR/wyaZnvMRURczCJBRgTFE8g+o7uQinjNnunnbSDyd+ uGQ9eXRSNryyMnvx2WFzzdHuxJHUQFMmaO58olIR8vcJgQSw9dVbx9t3fwy8LQvr5avKDZZrfGx ffSfRGvxoa+7UOwt7ssLt0OIqL+nsf0s/Lgoa472JlwXf/2vxG/MOuK+LvdvHFyF3UeHjPMbOEt sqJPncd1f4hbJzDNyCoIPrLjXCvj0/lW6m1m+RXpIUhzzBUU6YaT+rV0Qkro8mWRddBH6i+0Me/ 5hOZtw2zB+ToxwQjd87/rfGu9YtSzbnG3xwoo/TdEmSrB6jQe10j66D4KowmcHvQ9+DkAkdXJPd ipPisi2cejT5tVMCvOg== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-04-10_03,2026-04-09_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 malwarescore=0 clxscore=1015 adultscore=0 priorityscore=1501 lowpriorityscore=0 suspectscore=0 spamscore=0 bulkscore=0 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604010000 definitions=main-2604100089 Move the common disable steps out of the sink_count check to make the flow easier to follow. No functional change intended. Signed-off-by: Yongxing Mou --- drivers/gpu/drm/msm/dp/dp_display.c | 25 ++++++++----------------- 1 file changed, 8 insertions(+), 17 deletions(-) diff --git a/drivers/gpu/drm/msm/dp/dp_display.c b/drivers/gpu/drm/msm/dp/dp_display.c index e8028402f748..7b3b9160e005 100644 --- a/drivers/gpu/drm/msm/dp/dp_display.c +++ b/drivers/gpu/drm/msm/dp/dp_display.c @@ -734,28 +734,19 @@ static int msm_dp_display_disable(struct msm_dp_display_private *dp) msm_dp_panel_disable_vsc_sdp(dp->panel); - /* dongle is still connected but sinks are disconnected */ - if (dp->link->sink_count == 0) { - /* - * irq_hpd with sink_count = 0 - * hdmi unplugged out of dongle - */ + msm_dp_ctrl_off_pixel_clk(dp->ctrl, dp->panel->stream_id); - /* set dongle to D3 (power off) mode */ + /* dongle is still connected but sinks are disconnected */ + if (dp->link->sink_count == 0) msm_dp_link_psm_config(dp->link, &dp->panel->link_info, true); - msm_dp_ctrl_off_pixel_clk(dp->ctrl, dp->panel->stream_id); - msm_dp_ctrl_off_link(dp->ctrl); + + msm_dp_ctrl_off_link(dp->ctrl); + + if (dp->link->sink_count == 0) /* re-init the PHY so that we can listen to Dongle disconnect */ msm_dp_ctrl_reinit_phy(dp->ctrl); - } else { - /* - * unplugged interrupt - * dongle unplugged out of DUT - */ - msm_dp_ctrl_off_pixel_clk(dp->ctrl, dp->panel->stream_id); - msm_dp_ctrl_off_link(dp->ctrl); + else msm_dp_display_host_phy_exit(dp); - } msm_dp_display->power_on = false; -- 2.43.0