From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C59C53C5DCE for ; Fri, 10 Apr 2026 09:36:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775813791; cv=none; b=jKu7B9ZBBEth4e2r9xw4/81uVNeN5OWcfoxCE4irLAwP4mGXiusyN3CTcQHtiwNEUtbw3nME/G7Aa3ArrlGOUgTPz1XyANk3hiwNTTzKkFosuQTPc39slqCyKBVwmvYfZwdskIM7KT7xMixJHcJjIeIFqs421cI9JlewzT2GFXI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775813791; c=relaxed/simple; bh=0SRrv+FxL8qkWFHKN4JQjVFRw38qXcyyamUUeTeLiXQ=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=EARgE8wicq89pQTBU3rpmWWAootXOn/+TMD/xYF+TIxmWAQgC5xjFKQl6IRaMoLMa+DSwh11M2kIEtcExEjBc3uJGZvS36NGZiQot3RR5TbD+Gfv2H+RcDQhrpGJRtNlHQVRpeO52r9zRgZgqdzlcke+v5LFU1fu7JT+pARpEXk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=LLwneB/F; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=YYGruW61; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="LLwneB/F"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="YYGruW61" Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 63A5oT3g709170 for ; Fri, 10 Apr 2026 09:36:29 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= suciv5ycZtwqHNXye/yopkUYEmvYPaNYsbC0MiFy4JQ=; b=LLwneB/FbMUtauz7 lRXdIGUXqW8fjtOIs5JXdIt1j0e4jhc7YELBTfnwdHnfilyeqD3EjFwdDBUW+/HV JvsuGZpvgNaymW+C7j4U8Ts13rFniYP1UVXlUJMmVBNHTWQaiAyNrm0HV3zE5+pO vKO6b+1olcwJV3Vv2+Nr9ykrRyqopUW/l9sjgewq85CsmqUjPbe4gEbctdyPAVcB MmcabUKY/gXIKjkvcAJi/hV5G6xlIxCAm6GOhFPgeqGnFICiiMyOQIiZjsBhziCP mzX/skWy6KLCvo6LycsKuQ8ZBfkNQ4OdXUeLTby3hjFsE2Nz+P+4mXB223YPwkKK gfW8nQ== Received: from mail-qv1-f72.google.com (mail-qv1-f72.google.com [209.85.219.72]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4deudj0tsp-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 10 Apr 2026 09:36:29 +0000 (GMT) Received: by mail-qv1-f72.google.com with SMTP id 6a1803df08f44-8ac04b2fc4eso54791736d6.0 for ; Fri, 10 Apr 2026 02:36:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1775813788; x=1776418588; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=suciv5ycZtwqHNXye/yopkUYEmvYPaNYsbC0MiFy4JQ=; b=YYGruW61/JJL4Man2XWhwGLo+d1a/hqrcxQ60jrgHxy0qHTz2+Eju6OQC8dFWoaxmo MtKd4rWClJZMPdlVXhTuZZVxIOm4et9x3ZZBd/+IDn3gt1ClOY3SzIJoEodpMwyKX2ox 8iQy+U76bf7GgN2Y1BgOLamWVh8ys02l1KFLKYyhpuvzng0buGVdWzLB0Y6BSb+oip+f 2T5rWgfXEBXz4ZDPguerSRZpxUAIUgrmFM5icc7bAlsBSIPKg/u49yYd9JeCy+WNiZwi /Qo4NsY1f83PqGZ24VLxgGGCoNvPgEAsLEwgAlLjR2AXeXgbAOutQ1WU1QUPfFnSPot6 GzPg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775813788; x=1776418588; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=suciv5ycZtwqHNXye/yopkUYEmvYPaNYsbC0MiFy4JQ=; b=ijTDE5CW1nz6iWqHBwcKHKfIWxN2xsgwjlym0mADybYhlTPbeWETsazyNO4XV2dsML EcDKLMiSjsGlBzTegetc3rCqgJcHhQN5axzKC3oCM+4GR/suodLjCKv71NuK+es9VbKp KcXw1Njp1/Xv9qYbtXqJImKaqqQ7Yv/wRglQ63mZv3iWVx/D2VVg2Os4H2HY1BRX0N3X 3a/yd8WykyUadDWtbf0y+sVaR6ykN0ifKeUbFxfSJK/pPUZxBCsg70zec/cRKWhmeEjB gZ33eCIEUsPQzJwixPwo2fBjt9KloLexztbpm813mL0CcwfCiKGUuF37Y77E9rHRPbma Y47Q== X-Forwarded-Encrypted: i=1; AJvYcCVoYRz95OTzHGapQKQEoiL6L+y5zQGT/wLlLc0i8rRI+gEfi2dyLDsVSiLL09d20t60eCEfWs1ZGpkYYB0=@vger.kernel.org X-Gm-Message-State: AOJu0YzKbmVz29Tpt0JILCIV5RSUCsTD+12PBAv7RerUOHwzSLc+rvcO svAouYxa7hwg3zjJq0p3+i4TwJpFWTP8FwKR1pQrMibHqoOUmTcJRvPQuWS1G5aF66qObrUpOvu XjN5DlunVNPq8UBz4d5idgQ80EN/9Qgmz8dR5JCfNs8TJMtGbBdHFwETkDYzJbVg701A= X-Gm-Gg: AeBDievf7EVBFGxIBrb21yRHe7e8dPrGiV+48DN9Egp+b1FuxZLA1dhR+IdG7WdDnVw MFp9u6BymR3f1/8cngvtJtet3HCF4JfdOWaXKJ0WGwMfptsPI9wVPDE3g0ssowqxxUEtSwL5Xo3 nVKWcPvuGElm6iuhPNgGkoH4VVQAMwc1rKZLhc+0EmidB9Znn7T3x+4vLQri5Yf/AtBXG1xq7Pm Tq0YSZnRvebbypEtKJBi6Rj2lsgfgOVBZPknxcDE44jqbjKlzaWHmq0K3ovuYPhYNGJiz5VAqo7 K3UXTShT1tR3eVkUY9TMJ6FLQWhloGZCxW2IO4/K0WT4zcYPmBeqh1bspGIWXPtJBPUcDmFzWgg 16ZWeeorl0UqTuRC9z3RDcFzbyhwIf466DlxzGVXuaUygDntY2lVVkRzee8YqV/pupXInaGO7p5 OsuVtS+sA= X-Received: by 2002:a05:6214:c2b:b0:8ac:8337:ca08 with SMTP id 6a1803df08f44-8ac86245532mr35195616d6.51.1775813788055; Fri, 10 Apr 2026 02:36:28 -0700 (PDT) X-Received: by 2002:a05:6214:c2b:b0:8ac:8337:ca08 with SMTP id 6a1803df08f44-8ac86245532mr35195316d6.51.1775813787576; Fri, 10 Apr 2026 02:36:27 -0700 (PDT) Received: from yongmou2.ap.qualcomm.com (Global_NAT1_IAD_FW.qualcomm.com. [129.46.232.65]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-8ac84cb135fsm19223386d6.38.2026.04.10.02.36.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 10 Apr 2026 02:36:27 -0700 (PDT) From: Yongxing Mou Date: Fri, 10 Apr 2026 17:34:06 +0800 Subject: [PATCH v4 31/39] drm/msm/dp: add prepared to manage link-level operations Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260410-msm-dp-mst-v4-31-b20518dea8de@oss.qualcomm.com> References: <20260410-msm-dp-mst-v4-0-b20518dea8de@oss.qualcomm.com> In-Reply-To: <20260410-msm-dp-mst-v4-0-b20518dea8de@oss.qualcomm.com> To: Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , Jessica Zhang Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, Yongxing Mou , Abhinav Kumar X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1775813628; l=3575; i=yongxing.mou@oss.qualcomm.com; s=20250910; h=from:subject:message-id; bh=0SRrv+FxL8qkWFHKN4JQjVFRw38qXcyyamUUeTeLiXQ=; b=6d5c41YJLaWP774PXbiRUaSi6hpDLZVBF9fp3dCvVjbBoHJ6jCxZ05GuXV7ZHazoEe4vypBTO Z0Xo2DMhypUA+vdt+2phn6uLryBin0XvB5YMh0bhYXzseoaHpiy4STj X-Developer-Key: i=yongxing.mou@oss.qualcomm.com; a=ed25519; pk=rAy5J1eP+V7OXqH5FJ7ngMCtUrnHhut30ZTldOj52UM= X-Proofpoint-ORIG-GUID: POPaxOBaUuiUMqKafOOMk4QGaDHkBp3l X-Proofpoint-GUID: POPaxOBaUuiUMqKafOOMk4QGaDHkBp3l X-Authority-Analysis: v=2.4 cv=cKfQdFeN c=1 sm=1 tr=0 ts=69d8c49d cx=c_pps a=7E5Bxpl4vBhpaufnMqZlrw==:117 a=C3Dk8TwHQYyIj7nOf9RCJw==:17 a=IkcTkHD0fZMA:10 a=A5OVakUREuEA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=Um2Pa8k9VHT-vaBCBUpS:22 a=COk6AnOGAAAA:8 a=EUspDBNiAAAA:8 a=qXKybx3EirU-fK6T7NYA:9 a=QEXdDO2ut3YA:10 a=pJ04lnu7RYOZP9TFuWaZ:22 a=TjNXssC_j7lpFel5tvFf:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNDEwMDA4OSBTYWx0ZWRfX8QpZrjDjdOg+ BZEaadclnMZSbLJbe3fucxWr6nAG4AiWyAv07Tku3EMdycpd9A5RYGgneFCoBTx/AtFme9ST0Jz uAcQ6q7LupPbERINTbIFVrWtHcsjz7Ek5mcjgSXBn00NAdnqYamXffj+JlhSOZSIH0Z+Q2EPdoV 8MA1yzuJTrcu5vSROBz7ygtAvp/volnKSUBBFzJSFMXCSHIElQwkFiz7WeBtc3x3FRVVKYHil3m iNFV0Po5p5rvN7fF/39TKXKzTnLjiMc0ufh6gb5zDZMnHs3rJRZV77Y9k+26HX4NNuyZGb0kKNz oO9RYRe9yKXdyEgIf9RBRKvVMJZVd1rNBi8ZNGGHO6IhF9GBy7dVU+2FmCGzjH9+k7Ulf9uxUIs 4cIb/E+zoKtxWkYOkQtlD8iejf0snzKyCqLq/B019XcXgWdjB4ITZXRjWnvQQAWdgvyP4WICZ2d m1ABUAIk5Xrh4+aHnpA== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-04-10_03,2026-04-09_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 clxscore=1015 suspectscore=0 phishscore=0 lowpriorityscore=0 adultscore=0 malwarescore=0 bulkscore=0 priorityscore=1501 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604010000 definitions=main-2604100089 In MST mode, multiple streams share the same DP link. Track a prepared state so msm_dp_display_prepare() runs only once per link and repeated calls are skipped. Signed-off-by: Abhinav Kumar Signed-off-by: Yongxing Mou --- drivers/gpu/drm/msm/dp/dp_display.c | 34 ++++++++++++++++++++++++++-------- drivers/gpu/drm/msm/dp/dp_display.h | 1 + 2 files changed, 27 insertions(+), 8 deletions(-) diff --git a/drivers/gpu/drm/msm/dp/dp_display.c b/drivers/gpu/drm/msm/dp/dp_display.c index 1f26283b2dee..9eaf6994a350 100644 --- a/drivers/gpu/drm/msm/dp/dp_display.c +++ b/drivers/gpu/drm/msm/dp/dp_display.c @@ -715,6 +715,11 @@ int msm_dp_display_prepare(struct msm_dp *msm_dp_display) if (msm_dp_display->is_edp) msm_dp_hpd_plug_handle(dp); + if (msm_dp_display->prepared) { + drm_dbg_dp(dp->drm_dev, "Link already setup, return\n"); + return 0; + } + rc = pm_runtime_resume_and_get(&msm_dp_display->pdev->dev); if (rc) { DRM_ERROR("failed to pm_runtime_resume\n"); @@ -734,7 +739,11 @@ int msm_dp_display_prepare(struct msm_dp *msm_dp_display) // TODO: schedule drm_connector_set_link_status_property() } - return msm_dp_ctrl_prepare_stream_on(dp->ctrl, force_link_train); + rc = msm_dp_ctrl_prepare_stream_on(dp->ctrl, force_link_train); + if (!rc) + msm_dp_display->prepared = true; + + return rc; } static int msm_dp_display_enable(struct msm_dp_display_private *dp, @@ -1590,14 +1599,16 @@ void msm_dp_display_enable_helper(struct msm_dp *msm_dp_display, struct msm_dp_p dp = container_of(msm_dp_display, struct msm_dp_display_private, msm_dp_display); - rc = msm_dp_display_enable(dp, msm_dp_panel); - if (rc) - DRM_ERROR("DP display enable failed, rc=%d\n", rc); + if (msm_dp_display->prepared) { + rc = msm_dp_display_enable(dp, msm_dp_panel); + if (rc) + DRM_ERROR("DP display enable failed, rc=%d\n", rc); - rc = msm_dp_display_post_enable(msm_dp_display); - if (rc) { - DRM_ERROR("DP display post enable failed, rc=%d\n", rc); - msm_dp_display_disable(dp, msm_dp_panel); + rc = msm_dp_display_post_enable(msm_dp_display); + if (rc) { + DRM_ERROR("DP display post enable failed, rc=%d\n", rc); + msm_dp_display_disable(dp, msm_dp_panel); + } } drm_dbg_dp(msm_dp_display->drm_dev, "type=%d Done\n", msm_dp_display->connector_type); @@ -1646,6 +1657,11 @@ void msm_dp_display_unprepare(struct msm_dp *msm_dp_display) dp = container_of(msm_dp_display, struct msm_dp_display_private, msm_dp_display); + if (!msm_dp_display->prepared) { + drm_dbg_dp(dp->drm_dev, "Link already setup, return\n"); + return; + } + if (msm_dp_display->active_stream_cnt) { drm_dbg_dp(dp->drm_dev, "stream still active, return\n"); return; @@ -1664,6 +1680,8 @@ void msm_dp_display_unprepare(struct msm_dp *msm_dp_display) msm_dp_display_host_phy_exit(dp); pm_runtime_put_sync(&msm_dp_display->pdev->dev); + + msm_dp_display->prepared = false; } void msm_dp_display_atomic_post_disable_helper(struct msm_dp *dp, struct msm_dp_panel *msm_dp_panel) diff --git a/drivers/gpu/drm/msm/dp/dp_display.h b/drivers/gpu/drm/msm/dp/dp_display.h index 5f3ef295d710..bda76319c459 100644 --- a/drivers/gpu/drm/msm/dp/dp_display.h +++ b/drivers/gpu/drm/msm/dp/dp_display.h @@ -22,6 +22,7 @@ struct msm_dp { bool mst_active; unsigned int connector_type; bool is_edp; + bool prepared; struct msm_dp_audio *msm_dp_audio; bool psr_supported; -- 2.43.0