From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E56D237AA6F for ; Fri, 10 Apr 2026 09:34:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775813666; cv=none; b=jKbvxxsVXXW3bl+tzXgVGXVf5tPrk6DVaq/AOiTU/fuAClEK4xtxS/iPSwnSu330IObfp6zzDtKCEDRrrpO/H3Fw3/ytavmWrnt1NU8yTu7VgLAWWnIZhwitEUFR8o3492KPGIDSvCkE63i4F51Hh9q4ZF3sfz3uOB5pcE9sVPc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775813666; c=relaxed/simple; bh=+7cU1V6ZRhvWTG/SKpP6TFbrSez8ukI57faMvb2HD5k=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=I8BaQiJSVDbcu6zgISI1csUO0czu82e8FY+geVyP/F5MPSygVRyK7nb4u/9pmtDPlLHNs0WkjbM3iJDdSruqMj8yELfl5ak95T6yuyBy1Zmac8jzS0PTffNwlrGiAm1am818YrITezlsWCWj+kSzPg7AsiOQrExjs7DVYS49JPw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=UJqiNuFM; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=UWS7xyts; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="UJqiNuFM"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="UWS7xyts" Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 63A4Zv6b3352593 for ; Fri, 10 Apr 2026 09:34:24 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 7h2ubxib4+P3xl/EpXUQFk46aXZCl+6yefZzWfhblSM=; b=UJqiNuFM6WXic0MI WUasUaEiZ5hkXkcs1ErQq/5N66CBJQNawudi0WM3HJV18na2iEQcGggRYa371pt+ oaOBewQamRRUSDtrlXTpWaMavL8fVqz68Wtsr94HTVFrtvI3KUzsFNQRkld1g0EY ChUt6c9F2x+uQvxBsdsWiXyCFdKOa1W76OulD6NCTCAti6swYjsFFZCh/oix1euP vFf1xfypTE9lC5sfIXvyqgKR6iMop6DSa3z5mMZPVlpIfCGyxhn/QaqNJDx9giR5 z2Z59r9WUMFuY/+VVh5n+q0kCNSOVt/rnAHLFQ1LOG2QLFI0IDZOlMIwQRU55Pwa pQHPgQ== Received: from mail-qv1-f72.google.com (mail-qv1-f72.google.com [209.85.219.72]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4dec1quv46-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 10 Apr 2026 09:34:23 +0000 (GMT) Received: by mail-qv1-f72.google.com with SMTP id 6a1803df08f44-8a275472d89so29766716d6.1 for ; Fri, 10 Apr 2026 02:34:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1775813663; x=1776418463; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=7h2ubxib4+P3xl/EpXUQFk46aXZCl+6yefZzWfhblSM=; b=UWS7xytsH4XmdNrb3aEtdKKPyX83jPeoqS6b2KZAR59u4ocO1teHncfaI1vnysyqzG TOu5KoXxO17pdBxKwD2d56NLNfOnbNP/7SdP2qUt+hvVzSFCY6a6vVGKchTXKiPXXQGE ++3qPY+CBFStDvf/6voNrsPF0IVOS2O6KeZruwPgdeGIKfealjF0yTUr5VTCm4a8R842 Wu6cB6lcNF/N5Np2mTW30EQm4lBYC9H1R+gtgJLHr+q2r0njPHHquPYRMCs4i4PCM2g+ xam/q+NDtWmeyfpxHcMvSbJRFlQeYXqAnTqOauBSXb/5klkOVvFvB5AEd3mcZ8HwENO4 zp6A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775813663; x=1776418463; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=7h2ubxib4+P3xl/EpXUQFk46aXZCl+6yefZzWfhblSM=; b=UXdHIQAMD7JSF+MxQpPREwPXY3kxWcFqlE8KPLA42VGg0grlp+UbigPzTcPqumegpu IPvyIH6VLfztcNynDQLwTdQmt0fEyn3X4KA98LoIhcBp4+UHLzXDxoB8BaytjwNbVTQe Cwv6Q0jB74HAdZgMLfGoD9uTMfhOS0fLlZ0K944IJ5ddRvEZPiJWdOGDSZuA4mHCCBja TgmftE8OU7FM9T8xuPLFm8SepQ4SZorrFmIGM1rbES1ga+tVP5JGej2i2Ad9OdY/tO0F V94ZMJsBy+2D1ixXIgYlfeWtkWURX4tNwsm/oLrZsRvgrkYIJDMkzJxYyuJRlqyBnnl8 AZuA== X-Forwarded-Encrypted: i=1; AJvYcCX1pJKg00GuzVbC3z4S9NySdO78PFbBrJu7Do6hbPW1T+sSvRbk6GctbpCG1DPk9aTKlp9Qjry1BAi9/m0=@vger.kernel.org X-Gm-Message-State: AOJu0Yx06h9xY/4dUnG2t685quQ05154nmj+dM/qua0tNBFAr3NyPoeW PaqycTEFebIx4R1SzJir0x/QBpfwhTEg/AzTQ9WGrsNTLb+d+oA8FBc0lf7KUPlnH7qosorVwlH ai2FkHSRaCGimj719tTVhIVfK4cuRwYX7CfDpNiEfVZ6ohqxTrG3jns2A4ii9kzuexDw= X-Gm-Gg: AeBDietYfzm9RTFM4b4NUzKAYW9lc0gBMzOwzofddpFYVKsjocy1o/rF06QnDQALrVH +T1xQwSQuJrNthn1Re/qcbABDkhC3OKD/TrgFhNtryVq9FH1NYd6tcPhsf56Mp5aCDO2zPmWYqc EpO0qKliFVpNj6dto80UzTT/f8Q/3Na4Di0FTHiD3Zfa/4sYWwhKw4FmAcRk/P6mZDDmUQpJlwl Hi4ED0t6FLwobb9RJZvRxKtZc84nF0jkbDgFhA5GJYSfqVx/XnkHqPkdrd4PLG+O8SK1NUfXiXS W8ReXnbsrdnoG7IQzSxRAnLHNdXl4BFFbWZOL3ucnr2pJxv7nseW1IB6abZN+XwddxKbD7O8VNr opqZz2ue+9VLzi5CkaVI0cSGk2f+d8nqyHkr/GymlFkVEOnHUeBgc03py0AKFOWNNiFokZCfahH ol+zvashM= X-Received: by 2002:a05:6214:3f82:b0:8a7:1498:5f67 with SMTP id 6a1803df08f44-8ac86106cc5mr32395586d6.18.1775813663256; Fri, 10 Apr 2026 02:34:23 -0700 (PDT) X-Received: by 2002:a05:6214:3f82:b0:8a7:1498:5f67 with SMTP id 6a1803df08f44-8ac86106cc5mr32395146d6.18.1775813662772; Fri, 10 Apr 2026 02:34:22 -0700 (PDT) Received: from yongmou2.ap.qualcomm.com (Global_NAT1_IAD_FW.qualcomm.com. [129.46.232.65]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-8ac84cb135fsm19223386d6.38.2026.04.10.02.34.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 10 Apr 2026 02:34:22 -0700 (PDT) From: Yongxing Mou Date: Fri, 10 Apr 2026 17:33:41 +0800 Subject: [PATCH v4 06/39] drm/msm/dp: extract MISC1_MISC0 configuration into a separate function Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260410-msm-dp-mst-v4-6-b20518dea8de@oss.qualcomm.com> References: <20260410-msm-dp-mst-v4-0-b20518dea8de@oss.qualcomm.com> In-Reply-To: <20260410-msm-dp-mst-v4-0-b20518dea8de@oss.qualcomm.com> To: Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , Jessica Zhang Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, Yongxing Mou , Dmitry Baryshkov X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1775813628; l=2097; i=yongxing.mou@oss.qualcomm.com; s=20250910; h=from:subject:message-id; bh=+7cU1V6ZRhvWTG/SKpP6TFbrSez8ukI57faMvb2HD5k=; b=LCulurXQCSKN0x9TrouPq77gILySvl8E7N7vxJB4Uvnj+KQ5odYyAMqe4OUUvcle5+iaABwJw idu4XOz57scD+43PuOg3QQpZ9iIKJQ0ZFMzGW64oI+tK7hI6OSU+edt X-Developer-Key: i=yongxing.mou@oss.qualcomm.com; a=ed25519; pk=rAy5J1eP+V7OXqH5FJ7ngMCtUrnHhut30ZTldOj52UM= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNDEwMDA4OCBTYWx0ZWRfX3HYlcZWgYMFk HO0gY2LyCE6qvGBn9jgAgzqVMSttLIbyNDf1tZNynoOmg/MLj7FUouEXTUZTm7lDSf6U5z+bKYs O8Bp/r8mbIq3H/7RZqeyu5s4Wy1gtUeIfwMqGRsMAFxjuA0cDHNgiwrnbk0HKb2EL3803eo9s+M mGYeN1oTsiO+wD09bnI6afyKGxhLXWA7DloNsWorsodvuiQQhG7OypZTPFA5ig6eqR9wDY4J8Ah sO0ghKNMJ7fnGil+0RNbU6wmyWxZlw8v9LWLdknmyeQXMqK4/b4F+t2uhks89SRsquD125u4x5W b2NXpCkifbeTscOmW+a9vDZ83cqQUaHMiqyIdsa0FDzfbi5Ahejfcf2nR6x/0OuBTZStxsws5Hq BqNiADfnZZKgyQ1lofCuikgabKFpHQqwULSEUby3rF+VOEeuu9+k1g0aYI8JlFvie+dUdQCk7qD Tqsh6L4HsXJZOkmi7FA== X-Authority-Analysis: v=2.4 cv=eOcjSnp1 c=1 sm=1 tr=0 ts=69d8c41f cx=c_pps a=7E5Bxpl4vBhpaufnMqZlrw==:117 a=C3Dk8TwHQYyIj7nOf9RCJw==:17 a=IkcTkHD0fZMA:10 a=A5OVakUREuEA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=gowsoOTTUOVcmtlkKump:22 a=EUspDBNiAAAA:8 a=kqER-IEIHq1TX1bzL54A:9 a=QEXdDO2ut3YA:10 a=pJ04lnu7RYOZP9TFuWaZ:22 X-Proofpoint-GUID: 3lk4ZwnlJMrHJQ0SsUA-JLzg8xQ1ZiAR X-Proofpoint-ORIG-GUID: 3lk4ZwnlJMrHJQ0SsUA-JLzg8xQ1ZiAR X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-04-10_03,2026-04-09_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 adultscore=0 bulkscore=0 suspectscore=0 phishscore=0 impostorscore=0 lowpriorityscore=0 clxscore=1015 priorityscore=1501 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604010000 definitions=main-2604100088 Refactor the MISC1_MISC0 register configuration into a standalone helper function to support MST. Signed-off-by: Yongxing Mou Reviewed-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/dp/dp_ctrl.c | 23 +++++++++++++++-------- 1 file changed, 15 insertions(+), 8 deletions(-) diff --git a/drivers/gpu/drm/msm/dp/dp_ctrl.c b/drivers/gpu/drm/msm/dp/dp_ctrl.c index 85315467b5d0..fd6caebae148 100644 --- a/drivers/gpu/drm/msm/dp/dp_ctrl.c +++ b/drivers/gpu/drm/msm/dp/dp_ctrl.c @@ -455,17 +455,13 @@ static void msm_dp_ctrl_lane_mapping(struct msm_dp_ctrl_private *ctrl) ln_mapping); } -static void msm_dp_ctrl_configure_source_params(struct msm_dp_ctrl_private *ctrl) +static void msm_dp_ctrl_config_misc1_misc0(struct msm_dp_ctrl_private *ctrl, + struct msm_dp_panel *msm_dp_panel) { u32 colorimetry_cfg, test_bits_depth, misc_val; - msm_dp_ctrl_lane_mapping(ctrl); - msm_dp_setup_peripheral_flush(ctrl); - - msm_dp_ctrl_config_ctrl_link(ctrl); - msm_dp_ctrl_config_ctrl_streams(ctrl, ctrl->panel); - - test_bits_depth = msm_dp_link_get_test_bits_depth(ctrl->link, ctrl->panel->msm_dp_mode.bpp); + test_bits_depth = msm_dp_link_get_test_bits_depth(ctrl->link, + msm_dp_panel->msm_dp_mode.bpp); colorimetry_cfg = msm_dp_link_get_colorimetry_config(ctrl->link); misc_val = msm_dp_read_link(ctrl, REG_DP_MISC1_MISC0); @@ -479,6 +475,17 @@ static void msm_dp_ctrl_configure_source_params(struct msm_dp_ctrl_private *ctrl drm_dbg_dp(ctrl->drm_dev, "misc settings = 0x%x\n", misc_val); msm_dp_write_link(ctrl, REG_DP_MISC1_MISC0, misc_val); +} + +static void msm_dp_ctrl_configure_source_params(struct msm_dp_ctrl_private *ctrl) +{ + msm_dp_ctrl_lane_mapping(ctrl); + msm_dp_setup_peripheral_flush(ctrl); + + msm_dp_ctrl_config_ctrl_link(ctrl); + msm_dp_ctrl_config_ctrl_streams(ctrl, ctrl->panel); + + msm_dp_ctrl_config_misc1_misc0(ctrl, ctrl->panel); msm_dp_panel_timing_cfg(ctrl->panel, ctrl->msm_dp_ctrl.wide_bus_en); } -- 2.43.0