From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8A9B43AD50C for ; Fri, 10 Apr 2026 09:34:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775813670; cv=none; b=U24QeZ8lmex36rsfCqmDQVTs3aGjU3vBgVrYDMRRo1h8WuRGDzBM+57x154m43KnM1gkz2JEXfAQCwOBpELW+D0HDsUuuStnt0nX7iiYI6aI86lVpCrX7nkx7VZxsTeJsZeaDj4LExYr92gEnoK3C781IX9RTAdqqYTH+NNUYms= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775813670; c=relaxed/simple; bh=vaB5TI6vRjLHkdJJHUC0+HLPLyjZuxAcbDY5pvSAxd0=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=DHqFaWGW6lNj8ZB1iGXOKtskchIojPwDe37M7SUmnM9Vhbxc+1b5qEKewJQ+nHY6MIRKJwfx/KA7HEGTLNUcxKNHRoq5sbyFZ9v2irEzsf7easffofHKMiRYdViO68H++9YC/27x/5R5z16Yu1duB2sPt0MdCEXuxwvolRT+lic= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=B22hTKeC; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=SLyLLGc4; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="B22hTKeC"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="SLyLLGc4" Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 63A5oLZn1925369 for ; Fri, 10 Apr 2026 09:34:29 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 0vw+GVouMdxvKPWFW8nnI4YGOVXc23873dfqdgV/NTQ=; b=B22hTKeC3mO4k4+8 gjK+W8+D9qBjDhIIIv8/CyiP9GoP42nWcFXemIfJgZ4PJasOXsz4ww8RXo7moxuM wThH4DqSFiBbc4aFoxWv3kq25AjY6CoghDTy4K3SPBMQ5XiG1fsJHBdclEVtb3oH 4wbsXor5YNIoSwrH2O4+IuQWeEA1eiUtsiizdkAAUfvdaFTK5/bazsGS5n8ciBqO MYmAWIUydhttkEnwENYpET7eQhZwmT0jrCUb90K07/+HjThjltrEzbg8f3CAVWuz ZTMtElyToeMSUHmD1Q4nm37r0eU6gW3jdlKczMqiGpExwlsXJe+V4VFPpb8M4lKq uJdtDQ== Received: from mail-qt1-f199.google.com (mail-qt1-f199.google.com [209.85.160.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4deudjrt2b-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 10 Apr 2026 09:34:28 +0000 (GMT) Received: by mail-qt1-f199.google.com with SMTP id d75a77b69052e-50b781542c1so37790381cf.1 for ; Fri, 10 Apr 2026 02:34:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1775813668; x=1776418468; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=0vw+GVouMdxvKPWFW8nnI4YGOVXc23873dfqdgV/NTQ=; b=SLyLLGc4Rw2KhfGXvqVT0HCGYXI+NdnVUcl14W05MuPcAMHSrjpnpk+xy3w9DtyKGm LnJPY/xoqXfpEGOZlhoqJY1NCbvVTZQMxz6VhH4AC/JhmM9e2LYK72dYBjowsn26BsLB qD1c7GcAcPevgmDCpbifUewc0Rpj7Y/37cw9x34IWYp2OCS0ePFyOX+ZEtuqs16M9kpU SipAqCVVyRxA4quYR8M+g2eUWou0Ps2Qb+dwf12IN+tDy7f7ZKm0UcXGPz+MOeHlRy4u 97R+pfE7bWD+5TYI28sPYoS6DcH4jF3hcQB1Juet3rMopvGroNqqM1shnScvg2ulgjm0 iVEQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775813668; x=1776418468; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=0vw+GVouMdxvKPWFW8nnI4YGOVXc23873dfqdgV/NTQ=; b=aWHPs1v/mzNl0TPS2JCptPwuRBh0kPsFqq5e6MNDnMlr+bdxGMUiWN0P4Y7/wS5Kut QuYuTIYa0UaEkF2jAdINWwhwIpbF9OklGUbDzXB2Ssqxv+9hoFVsj6KQB+2t9guvFJo6 jjNJRDQXTUE5oLvAT1gqeA55F2CFBRiFIzbzrw0uOV1yelgALzNF+iLfuqxY/18Nwt8c KCpDCr/SjLtfUhz8Or+t3F9MCZj2W43HlZP3cG63bMuRV2aqfCuFVC6eIgaP8+aS3yVi 7hzhEVZ5FiZXjE4fBUN0afFJrZuQAN14V5ouje3sLMBmWNHitRHIjBNatrjzpTRvGpoG ixaA== X-Forwarded-Encrypted: i=1; AJvYcCUgHRN6+iFv34Pj1afRAq7gZYYNzl/yWQ2ykcOrL73KDijZPDX3iHf2BGHozjs9RkQslAs+XKLEZXSCN/o=@vger.kernel.org X-Gm-Message-State: AOJu0YxXqopFzZcCrhFn4oeV1Fge2Wx8cOgjaslqShM17Unh6CByF9tX 1XAviNhHwIRedhytUshMdDUXqUgtfC3+WUS4AONbXxsGv/VSk3uNRLy+Pq6TWEefF/jhQiI0gou jdjwWihnQsALD7e9+BjPiCxpL6AM7IQY6kvu2aCgGUxnbZ5Qxj+Ibhkbc+befxfnye88= X-Gm-Gg: AeBDieupxzwSzDtZHIiTm+fPeKv8aCOX9rwu8Ufiw5vfwcM+KIYwySXge+0GbxCNajK 4463Yggnefe6hMT7soUu3T0nD+tLYizKeuRJ1J/Ih6dhhezignr0GCWpFZqaPx4JOGIdnjdjM32 Tv74KSAgDgrDixXaSrtmxtLW0hK4lqx3sbWbvO3vM2+ZUxeYXneRJ3IXYUvriG1Zpnp+oubLfvQ oXdhi1oLkCLK4NpGcA4gCpVxlpRCix4Wf7GmD0MuWPvZgoPDYp8kDu16vvql001JX50A4VT+rmb kwuZXuBrLO//k5UFuzEkp3MHOXg8iNTWtFSY8uzaJEg3DtezEuvx7aDhq+ukdG3DXWu44A7bOu8 vJlkl6uL3WufvdDPo6y+hjjQcPO9pUk3EBhNk7JljwB9f36cbwA8Bkk9DwxoxLpmvsTJNS6YCk4 1gOIaBxdo= X-Received: by 2002:a05:622a:7102:b0:50b:5286:f768 with SMTP id d75a77b69052e-50dd5bdaedbmr28094481cf.48.1775813667800; Fri, 10 Apr 2026 02:34:27 -0700 (PDT) X-Received: by 2002:a05:622a:7102:b0:50b:5286:f768 with SMTP id d75a77b69052e-50dd5bdaedbmr28094221cf.48.1775813667380; Fri, 10 Apr 2026 02:34:27 -0700 (PDT) Received: from yongmou2.ap.qualcomm.com (Global_NAT1_IAD_FW.qualcomm.com. [129.46.232.65]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-8ac84cb135fsm19223386d6.38.2026.04.10.02.34.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 10 Apr 2026 02:34:27 -0700 (PDT) From: Yongxing Mou Date: Fri, 10 Apr 2026 17:33:42 +0800 Subject: [PATCH v4 07/39] drm/msm/dp: split link setup from source params Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260410-msm-dp-mst-v4-7-b20518dea8de@oss.qualcomm.com> References: <20260410-msm-dp-mst-v4-0-b20518dea8de@oss.qualcomm.com> In-Reply-To: <20260410-msm-dp-mst-v4-0-b20518dea8de@oss.qualcomm.com> To: Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , Jessica Zhang Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, Yongxing Mou X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1775813628; l=1313; i=yongxing.mou@oss.qualcomm.com; s=20250910; h=from:subject:message-id; bh=vaB5TI6vRjLHkdJJHUC0+HLPLyjZuxAcbDY5pvSAxd0=; b=g5dy/hjzpqUBHlCBjit+1XAMpFzbXR2uUyC1CU778OHY7g9h5f7BS1OKg6d5GQ8yCvuSBx+89 jexa4rpk6R6CpOOvw+UYfzVzsgtOokS5vxOsTFBalMToFMTIa8JOWfj X-Developer-Key: i=yongxing.mou@oss.qualcomm.com; a=ed25519; pk=rAy5J1eP+V7OXqH5FJ7ngMCtUrnHhut30ZTldOj52UM= X-Authority-Analysis: v=2.4 cv=X+hi7mTe c=1 sm=1 tr=0 ts=69d8c424 cx=c_pps a=WeENfcodrlLV9YRTxbY/uA==:117 a=C3Dk8TwHQYyIj7nOf9RCJw==:17 a=IkcTkHD0fZMA:10 a=A5OVakUREuEA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_K5XuSEh1TEqbUxoQ0s3:22 a=EUspDBNiAAAA:8 a=saXSvH3Ee-fMY4W8qR0A:9 a=QEXdDO2ut3YA:10 a=kacYvNCVWA4VmyqE58fU:22 X-Proofpoint-GUID: fGGm2N-QfDfntr1sRRLiJ0WGPw9TYUxe X-Proofpoint-ORIG-GUID: fGGm2N-QfDfntr1sRRLiJ0WGPw9TYUxe X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNDEwMDA4OCBTYWx0ZWRfXx+/oSHiYPcJ0 AHVp2/E2iLyIl8K8utgv7q6CyL5tYixViLIkzu0PEy2BH/5921gy9wULKs+3DRs3s/cl2UlUTgo cb1zw1Gxs79vzeLrOryqxxoZQXWYZH4yCqDkyhWENF9vcJ3DcRHWdYQaLd8VTbbaTVMdKnzDqLy GIk3FYubdXWrI4ZhRHMMkLES+iRw+xdwREL1fik4U6tuQx1efD/cRflY9XyX+77uUh7m4BSxmEk 8IkWUHvjcDRBKX9K+7di1ZkYTVoI1R9qxg4UlBpuP97n2LTojhQ/xIZKLM/ztf9lOBbpwpY7qUy 7HIcEu0erPDGJHvGyHfIQ466GBa9LwK9aqLphHKrlWGefQOi/2MwqHeqkyQW9+P4EoLpdIvB+26 etOtelmNfppxI23DHZ7zg7SyMZleOAMOPZDNZoDc0dwemXAV56nW+FAl2bj8eLuJmSGG49FybwX +S6x7pm8n1aQHrn5oeA== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-04-10_03,2026-04-09_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 malwarescore=0 clxscore=1015 adultscore=0 priorityscore=1501 lowpriorityscore=0 suspectscore=0 spamscore=0 bulkscore=0 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604010000 definitions=main-2604100088 msm_dp_ctrl_configure_source_params() should only handle stream-related configuration. Move the link setup out of it so MST can program link and stream settings separately. Signed-off-by: Yongxing Mou --- drivers/gpu/drm/msm/dp/dp_ctrl.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/msm/dp/dp_ctrl.c b/drivers/gpu/drm/msm/dp/dp_ctrl.c index fd6caebae148..cd58968d4e14 100644 --- a/drivers/gpu/drm/msm/dp/dp_ctrl.c +++ b/drivers/gpu/drm/msm/dp/dp_ctrl.c @@ -479,10 +479,6 @@ static void msm_dp_ctrl_config_misc1_misc0(struct msm_dp_ctrl_private *ctrl, static void msm_dp_ctrl_configure_source_params(struct msm_dp_ctrl_private *ctrl) { - msm_dp_ctrl_lane_mapping(ctrl); - msm_dp_setup_peripheral_flush(ctrl); - - msm_dp_ctrl_config_ctrl_link(ctrl); msm_dp_ctrl_config_ctrl_streams(ctrl, ctrl->panel); msm_dp_ctrl_config_misc1_misc0(ctrl, ctrl->panel); @@ -2571,6 +2567,10 @@ int msm_dp_ctrl_on_stream(struct msm_dp_ctrl *msm_dp_ctrl) */ reinit_completion(&ctrl->video_comp); + msm_dp_ctrl_lane_mapping(ctrl); + msm_dp_setup_peripheral_flush(ctrl); + msm_dp_ctrl_config_ctrl_link(ctrl); + msm_dp_ctrl_configure_source_params(ctrl); msm_dp_ctrl_config_msa(ctrl, -- 2.43.0