From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5FA8A3B38BD for ; Fri, 10 Apr 2026 09:34:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775813680; cv=none; b=IqTt3DBBqro3sd4518wPRT+hg/nbnQ+Dphx8qBRBeG2lO7zvhbs16eCB7bYatYelT/NOhVcDMApbT4lvAbDUU0qzit65kqAyPIya/oCekQZoCI0Dyy8LaLXJO7vPAXNlMmZ8sGVibhqDMauT2iu3iF08ehzZdexuazUBi0NUnLE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775813680; c=relaxed/simple; bh=+lkvt5m+Hb5xdmmgv2phzN6d2NFliDsKsZRJmDLnNmo=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=RdEm3/NXEYh+MlAIqrWjOlz8Zcaot1zyGVqVmWLkl+FnI9e5UXmMqrJb6b4X5/QgPvxCNuUUQKzVllDQrpqCvIS+rRNmROZWN80OLbCvXnCzlrSXruEz2pZWWOidAXa4PSwEn7M5TzKPwKhvdGH85uqaJyNDtGITJCM+v1aW7YY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=Y237kTFn; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=SGUrCcyZ; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="Y237kTFn"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="SGUrCcyZ" Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 63A6qeIh1433198 for ; Fri, 10 Apr 2026 09:34:38 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= gGsWvVRgr+MK8OtdKIfzmiQoRUkubmuDR7D5+VwCXPg=; b=Y237kTFnCzUYzZRG qTMr1d0BOKZP7bDGK+/C50SiLl/MQQS7c3NUKQvjl9ngzCqV+aSx6+mmifjM+dw1 gRZ01CJmk64vcTX1yV4aNlXmLie4wMDHA11ReUIMCEA+9qVjhWPbL6wJUTV71Vhz XCZEdgMMippYNx55ypKEFk0Twa1/QQdoPwa10gp1wanPcts5HcbOUREgx4a/RaDb ygaIMCv3Gfpj/W67ckW+kO9QczMenHnyOEd/0atPhP+5+U2kGZ6s+Kfr5tm7zfax 6vljAq+hQvvoyuVmok3E0/Ir2ov8nkbc1DRotIV837Ui2hN3qHmdCyHM644z+yJs JvqE4A== Received: from mail-qv1-f72.google.com (mail-qv1-f72.google.com [209.85.219.72]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4deckfbp2g-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 10 Apr 2026 09:34:38 +0000 (GMT) Received: by mail-qv1-f72.google.com with SMTP id 6a1803df08f44-89ce5eec0f0so54966546d6.3 for ; Fri, 10 Apr 2026 02:34:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1775813678; x=1776418478; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=gGsWvVRgr+MK8OtdKIfzmiQoRUkubmuDR7D5+VwCXPg=; b=SGUrCcyZ4JmfEVsqu7GITsOQVAsMVzK1dGc9shhpuzFfcN6YLy3S29ycE3IkrCz8cb oFSPGSk1ideXmDYsrBZ/EhUg7CbLzLG63fCvBXonkEHVYGgGXlJCzWbYNU2fXDl1Urcl m54YI23VJvnLwe7ctfTZ/u0orhPIAfhsHiP4HHPFFwdEUHN8mCfHlDvkjGRZ1D7b+2/X OAIjNHPgbtu4dtLSvqI+A2ky+dOGllKvT2wVzcKZflEOOmKuF8FDllsUfxAC/VJ6/Y++ CbZpmXCO3S8RhRObU3TKnu/zeRks4G16nwh2ux9W/5pwBSXLQZL5g3+5pFydtzkY/VCL yQ+w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775813678; x=1776418478; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=gGsWvVRgr+MK8OtdKIfzmiQoRUkubmuDR7D5+VwCXPg=; b=H7CjND32IXAix9pFXryfqyI9Dkvz0IdNCrZDGvZ0sGl0LCSLtfGKRTzEA7o+9dUlzW U2uWtiyGxuDXZPBgnmKvsO/qa9FZgUpJhLeefAHIHgkahF/aAd19iXOQds9Zqx9tO31E MrN/P0IjC+rMmRSL6PPWTiO0jGWT7y0gno8DnmBsNHBC4X+HVNHXVtaUVKB5n0fOETiJ gJIwiE+xAxSlMyD0SJLGARQ2e4HhkSySO70loDmYt4dwWg+5Sk/KGDTUozQ/Y3dY7hmD jZeIhSeFZHAIC6Y96OoycSMHF06SBKA8wIkuUf1XwjSqUI08sSdnrD2VWxqJEp7I2xuM 7Krw== X-Forwarded-Encrypted: i=1; AJvYcCW6DOZQckTrEJS0YohxsfxOKvj7dLnwkiVwT1yXiIBBjozgKxO1wp2D505P8OtwG4TTBziVVPPJYx0w/II=@vger.kernel.org X-Gm-Message-State: AOJu0YyqHlUKTYIsS2rgRalJ42GQ7oucuB7+0CPKlumWqmSbg3dom5Z/ LHCSB+BOiaAjegFHhsm1v/Ym01uotSj4Lv7naXsTSLhzvmmPWe2VZb1KToscpHC2kMlUc//27zu ouMfQHUZqeXFVlOyTbMP3LK0JOXmh8tPMSVuwIcT43DZDxMiV2lREfE4NoKNuqqIs70E= X-Gm-Gg: AeBDiesjlghy+a1LgnLEV8rM6jAIAhtBuC8NWi52Az3/B6JqYhvUYM04M/gjjk3XtFe Rh87t4PccvudrGgxVym9rmU7hl5HzTHXQ0LpsKWkSKGIswUFxJXZfY6m0sqWLlqm+1WSTKwTanI q19dVKKD3vP55P+PTOPDR69IGbtHvK/sNXiY+kDTdRZyQN1Ar4eurMd9aDph6FdunExZpo0Uj6S 3VwHyDjQqcyV0uP6ovVwxhLKt2x9ctcB1f4wIdH8mhYAtSuY4MRWWk63YvRpYlDTAZLiK537iyD HBKQFsv+3HTNR2h/3q44z2ua7m6jrbbQVB+qsqVOFqKmGL5UmtmP1rh7HRLRP8iTSXLjZfdvyIU hsUboVKCA9YoLn9a2LBtf71smLtTTNLwHaxshl/nnVyhLxLxMqmt3ldN5N10ru2OKoFASClDxtk pM9r5Tno0= X-Received: by 2002:a05:6214:4905:b0:89a:1364:1027 with SMTP id 6a1803df08f44-8ac8617efafmr31642796d6.14.1775813677759; Fri, 10 Apr 2026 02:34:37 -0700 (PDT) X-Received: by 2002:a05:6214:4905:b0:89a:1364:1027 with SMTP id 6a1803df08f44-8ac8617efafmr31642426d6.14.1775813677303; Fri, 10 Apr 2026 02:34:37 -0700 (PDT) Received: from yongmou2.ap.qualcomm.com (Global_NAT1_IAD_FW.qualcomm.com. [129.46.232.65]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-8ac84cb135fsm19223386d6.38.2026.04.10.02.34.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 10 Apr 2026 02:34:37 -0700 (PDT) From: Yongxing Mou Date: Fri, 10 Apr 2026 17:33:44 +0800 Subject: [PATCH v4 09/39] drm/msm/dp: move the pixel clock control to its own API Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260410-msm-dp-mst-v4-9-b20518dea8de@oss.qualcomm.com> References: <20260410-msm-dp-mst-v4-0-b20518dea8de@oss.qualcomm.com> In-Reply-To: <20260410-msm-dp-mst-v4-0-b20518dea8de@oss.qualcomm.com> To: Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , Jessica Zhang Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, Yongxing Mou , Abhinav Kumar , Dmitry Baryshkov X-Mailer: b4 0.14.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1775813628; l=3984; i=yongxing.mou@oss.qualcomm.com; s=20250910; h=from:subject:message-id; bh=+lkvt5m+Hb5xdmmgv2phzN6d2NFliDsKsZRJmDLnNmo=; b=uoz5NciDlgeR427IPXgZxqP5AFeCFPhwgdTXSj472MjZBjCWJ16V88FUuUZA9+rj8ZCpZRafr Mtra9kjJEHnBT5iRu82ZlNSeym8IAUxt+mg97N4I9HT3xj4DmyrdqMe X-Developer-Key: i=yongxing.mou@oss.qualcomm.com; a=ed25519; pk=rAy5J1eP+V7OXqH5FJ7ngMCtUrnHhut30ZTldOj52UM= X-Authority-Analysis: v=2.4 cv=S/fpBosP c=1 sm=1 tr=0 ts=69d8c42e cx=c_pps a=7E5Bxpl4vBhpaufnMqZlrw==:117 a=C3Dk8TwHQYyIj7nOf9RCJw==:17 a=IkcTkHD0fZMA:10 a=A5OVakUREuEA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=rJkE3RaqiGZ5pbrm-msn:22 a=COk6AnOGAAAA:8 a=EUspDBNiAAAA:8 a=FjMX0bmgnFGAle5WrLgA:9 a=QEXdDO2ut3YA:10 a=pJ04lnu7RYOZP9TFuWaZ:22 a=TjNXssC_j7lpFel5tvFf:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNDEwMDA4OCBTYWx0ZWRfX1xRTl8/c/4yP FMgIm63W+jAsoorcfObVSOr9/mucjvaOQPHh13GFB0+fWejREjihktLrtgQbmhKwbvwOhFKnUgr ZGFYEgd8RTsauRfOEHOm7uB2UOK2rDxyz/DfPLjmLkGJyMzpjBM1f8JON8Tpnuacdisa1MqHxiS 5HVP8TrTGlUD6HGzaUCUduI80OAa2o+fXy0G/hIVK2CChy2B5hqmluGYg13/KRPNvG+zOhRI1RL UdEi/k+rFbjJGC9fu/hR+r+3/24fFDxNiYte4WURrEFSkPlJkfsL7QziXKrf/15Og9Okp66hLRq 7cbJiCL8aXdkeCgbVaVVh0izV0mfHZmp7WP/5wqeB8cWgcrvNUJ4ARKuVQZqmfQbSkpRH+lIoVq 4LN5Jh3fMdqrKBYZiDNHJySU3nq3ddSTwS1BdhxtydfMW5n3r+xC/sm1Qms3i6G3hxvUaLeHwfL ItlXvfTjYuRdX+3q1bQ== X-Proofpoint-ORIG-GUID: elJzZorufwY_mJ1-8tkcGFSJWHeITtfN X-Proofpoint-GUID: elJzZorufwY_mJ1-8tkcGFSJWHeITtfN X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-04-10_03,2026-04-09_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 malwarescore=0 adultscore=0 spamscore=0 priorityscore=1501 impostorscore=0 lowpriorityscore=0 bulkscore=0 phishscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604010000 definitions=main-2604100088 Enable/Disable of DP pixel clock happens in multiple code paths leading to code duplication. Move it into individual helpers so that the helpers can be called wherever necessary. Signed-off-by: Abhinav Kumar Signed-off-by: Yongxing Mou Reviewed-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/dp/dp_ctrl.c | 79 +++++++++++++++++++++------------------- 1 file changed, 41 insertions(+), 38 deletions(-) diff --git a/drivers/gpu/drm/msm/dp/dp_ctrl.c b/drivers/gpu/drm/msm/dp/dp_ctrl.c index d0eed8c7df45..fa62f8f91189 100644 --- a/drivers/gpu/drm/msm/dp/dp_ctrl.c +++ b/drivers/gpu/drm/msm/dp/dp_ctrl.c @@ -2176,6 +2176,42 @@ static bool msm_dp_ctrl_send_phy_test_pattern(struct msm_dp_ctrl_private *ctrl) return success; } +static int msm_dp_ctrl_on_pixel_clk(struct msm_dp_ctrl_private *ctrl, unsigned long pixel_rate) +{ + int ret; + + ret = clk_set_rate(ctrl->pixel_clk, pixel_rate * 1000); + if (ret) { + DRM_ERROR("Failed to set pixel clock rate. ret=%d\n", ret); + return ret; + } + + if (ctrl->stream_clks_on) { + drm_dbg_dp(ctrl->drm_dev, "pixel clks already enabled\n"); + } else { + ret = clk_prepare_enable(ctrl->pixel_clk); + if (ret) { + DRM_ERROR("Failed to start pixel clocks. ret=%d\n", ret); + return ret; + } + ctrl->stream_clks_on = true; + } + + return ret; +} + +static void msm_dp_ctrl_off_pixel_clk(struct msm_dp_ctrl *msm_dp_ctrl) +{ + struct msm_dp_ctrl_private *ctrl; + + ctrl = container_of(msm_dp_ctrl, struct msm_dp_ctrl_private, msm_dp_ctrl); + + if (ctrl->stream_clks_on) { + clk_disable_unprepare(ctrl->pixel_clk); + ctrl->stream_clks_on = false; + } +} + static int msm_dp_ctrl_process_phy_test_request(struct msm_dp_ctrl_private *ctrl) { int ret; @@ -2201,22 +2237,7 @@ static int msm_dp_ctrl_process_phy_test_request(struct msm_dp_ctrl_private *ctrl } pixel_rate = ctrl->panel->msm_dp_mode.drm_mode.clock; - ret = clk_set_rate(ctrl->pixel_clk, pixel_rate * 1000); - if (ret) { - DRM_ERROR("Failed to set pixel clock rate. ret=%d\n", ret); - return ret; - } - - if (ctrl->stream_clks_on) { - drm_dbg_dp(ctrl->drm_dev, "pixel clks already enabled\n"); - } else { - ret = clk_prepare_enable(ctrl->pixel_clk); - if (ret) { - DRM_ERROR("Failed to start pixel clocks. ret=%d\n", ret); - return ret; - } - ctrl->stream_clks_on = true; - } + ret = msm_dp_ctrl_on_pixel_clk(ctrl, pixel_rate); msm_dp_ctrl_send_phy_test_pattern(ctrl); @@ -2545,22 +2566,9 @@ int msm_dp_ctrl_on_stream(struct msm_dp_ctrl *msm_dp_ctrl, struct msm_dp_panel * drm_dbg_dp(ctrl->drm_dev, "pixel_rate=%lu\n", pixel_rate); - ret = clk_set_rate(ctrl->pixel_clk, pixel_rate * 1000); - if (ret) { - DRM_ERROR("Failed to set pixel clock rate. ret=%d\n", ret); - goto end; - } - - if (ctrl->stream_clks_on) { - drm_dbg_dp(ctrl->drm_dev, "pixel clks already enabled\n"); - } else { - ret = clk_prepare_enable(ctrl->pixel_clk); - if (ret) { - DRM_ERROR("Failed to start pixel clocks. ret=%d\n", ret); - goto end; - } - ctrl->stream_clks_on = true; - } + ret = msm_dp_ctrl_on_pixel_clk(ctrl, pixel_rate); + if (ret) + return ret; /* * Set up transfer unit values and set controller state to send @@ -2593,7 +2601,6 @@ int msm_dp_ctrl_on_stream(struct msm_dp_ctrl *msm_dp_ctrl, struct msm_dp_panel * drm_dbg_dp(ctrl->drm_dev, "mainlink %s\n", mainlink_ready ? "READY" : "NOT READY"); -end: return ret; } @@ -2627,11 +2634,7 @@ void msm_dp_ctrl_off(struct msm_dp_ctrl *msm_dp_ctrl) msm_dp_ctrl_reset(&ctrl->msm_dp_ctrl); - if (ctrl->stream_clks_on) { - clk_disable_unprepare(ctrl->pixel_clk); - ctrl->stream_clks_on = false; - } - + msm_dp_ctrl_off_pixel_clk(msm_dp_ctrl); dev_pm_opp_set_rate(ctrl->dev, 0); msm_dp_ctrl_link_clk_disable(&ctrl->msm_dp_ctrl); -- 2.43.0