From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f45.google.com (mail-wm1-f45.google.com [209.85.128.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C7ADD1DF75B for ; Fri, 10 Apr 2026 02:00:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.45 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775786429; cv=none; b=mIU/H9F5WYfqiWQPZ08tXHjH7h/B/U9rES8xxx1dfgbR/RksSX44+udHLehFnubG23sWbMi/LqAIGeVArX1nHIz3UwUpSnm9EN7lGLAkL4E0kGAM7pEZAEpuMhQ0X2UGNP1v+dNF92i795SYuP5QmVHIq+pGUhKSudvzmUTTh/Y= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775786429; c=relaxed/simple; bh=q02+w6fVA8fQlZiZYJsvbUg0TeTNTZ6gfTuEjCsRLwA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=RP7kEHD1g7tUYn1gwaAhy6XE4MpY8fobv1j/oXWOUQ0usDLQHWCTFxnL5Aj+/+S6un+9T/BrilqaBnQxsLg7KLdQt1BnGHWs1N/wTubZMOeKV90cPEsFESNVlLbjz7sqZgngrkQjGp1K0U82qFyas0iA8GnMiYgPY6V6krh+ajs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=DFrHsGoe; arc=none smtp.client-ip=209.85.128.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="DFrHsGoe" Received: by mail-wm1-f45.google.com with SMTP id 5b1f17b1804b1-48896199cbaso15834205e9.1 for ; Thu, 09 Apr 2026 19:00:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1775786426; x=1776391226; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=bovVPq2Hy5sXrftDQTh1EgPcGL6nK3K2wa+9gcYZYpk=; b=DFrHsGoeJ7v3oOgSESVXgmFw3Q3zutj6GNKIhH7QVYHEoLXTYVPZ5s6H4JmY2Wq9yd A3XnNnU2emGpnWS3YN0bMALoxg0QB44i65z/oKdVfnesdKEfUD+EwbwWL8InRNhOjnKm nTbAQw9idBi/O9/XvBFRrkO/yyicr86WAKDjY7x8qIwZiHPv6UkNXATk6wg6yNyTtDvp umUJ0QUFHfemH8c76kYWc0CMRBCDg711xRRR3rwbPg9ujU9pWG1c6PWnMPKhzJEehQNL oAleuVlKwILMoOVHtMDfC8ygN2ANgGOiJKU+LDU8r77gtbJEFUo0G4axsSwJOI/r1Z/8 CAgA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775786426; x=1776391226; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=bovVPq2Hy5sXrftDQTh1EgPcGL6nK3K2wa+9gcYZYpk=; b=K9MKU4yrJElXda+nL7afKphpEYMzhIDJgevDg4ifP/MXRc/JTPisNTm7Hk+YinO0/m lNtl3avzMZOFAOLkjBs0yko9FsNwpAt1MqY6347MrEQnr2yZ7zPXXEAuVj1jJt5ZSlNA Gh4TkA01Q+777VvXMh6iLC6naCxdosg1wZrp+YouKRu6b0tpBADstsRehs9LzdNp/5Kx TadooVii0u72XmVrAuRC1GNphRzbuYHGMxUZZeYlVICcGwH0rjQB+VhJnQUyiwxSsxpH LL5GD6lXW/VHwiY3ivcI4bnLNFBMVgQp9ME/ftacdhDKJucdHfqcRVj8oTCpiFkP7Ekk MrFg== X-Forwarded-Encrypted: i=1; AJvYcCXADA2YFoCov9lEgKPqeJV8chlI9uCe6drbDJPAT3VMMwndVdTaJXeXhrz4WBQg2WF5aVpxKvV//6pw+u8=@vger.kernel.org X-Gm-Message-State: AOJu0Yz5eYBF2rk/518jdBzVMyzCbqVEyaxFarEwTa1Ft3Pc/ckTW/SW QYrryuId0ejDyhc/AifZO/Ky0qBfY7ehp9UBovht3z/cVEnSUGhOUTs+ X-Gm-Gg: AeBDiesnyJPCn/kHt+B+OxLR5z4uQ3m8ph76zptQLE22u/z/ldSqqT6Pp74JVmQvUqH rXWdyoGV9bSl9F7Qay6KwGJQZ14DUfkXgR2S40yZ6gmy9DyHvTJlDxBfYRnwERPZFKi5gdyY8vc MO/5cw+24YATYqkeMpB4Gpe2YnIfPLzCuULoY2B3X580UyxssuvSXugMHO4QTQsxcPDQBXnENdh 7BseS1cUySZb0q6IKV/6tEiX++bmVCoM53oI3xGUvqAwGC/spwPonk/gAel+XmhyN7MmnkEfQZi BcxKBHK4/5bDKGDXTxi3OvZdpX04YnGD4WYPe18QJZtlLgIvG/tMnlZ3GL9i0Z/Fdf2hYsUrKSN +A6MQ9fhCJMn8L/BNvNXCRO1XBNN2wcyhbBPggSp9nN5BB67zEywD3AwOCSciyzpT1rkm0Cof5z O/6BuABKyYQyTfjENTz/VhZjC/djo5r0tYkZGK/mTnE/gR9EakATDoAbR1XIXibDq7cD54HTOGX j8FBTZ4OKo2WbJjloOB+Ec0MeeGEpPNzJoNl51BEp+1Dc8f X-Received: by 2002:a05:600c:a413:b0:488:a639:b787 with SMTP id 5b1f17b1804b1-488d67f39admr9380185e9.11.1775786426068; Thu, 09 Apr 2026 19:00:26 -0700 (PDT) Received: from DESKTOP-NQ2T5I7.localdomain (heme-13-b2-v4wan-167795-cust403.vm32.cable.virginm.net. [81.108.45.148]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-488d5d703c1sm9427005e9.3.2026.04.09.19.00.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 09 Apr 2026 19:00:25 -0700 (PDT) From: Prathamesh Deshpande To: cjubran@nvidia.com Cc: leon@kernel.org, linux-kernel@vger.kernel.org, linux-rdma@vger.kernel.org, mbloch@nvidia.com, netdev@vger.kernel.org, prathameshdeshpande7@gmail.com, richardcochran@gmail.com, saeedm@nvidia.com, tariqt@nvidia.com Subject: Re: [PATCH v2] net/mlx5: Fix OOB access and stack information leak in Date: Fri, 10 Apr 2026 03:00:25 +0100 Message-ID: <20260410020025.7386-1-prathameshdeshpande7@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <3a238d0c-4ec1-432d-995a-19d7db3e310e@nvidia.com> References: <3a238d0c-4ec1-432d-995a-19d7db3e310e@nvidia.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit On Thu, Apr 9, 2026 at 17:16 +0300, Carolina Jubran wrote: > pin is defined as u8 in struct mlx5_eqe_pps, so pin < 0 is dead code. > > As for the upper bound: in order to receive a PPS event on a pin, the > user must first configure it via mlx5_ptp_enable, which already > validates the index (rq->extts.index >= clock->ptp_info.n_pins returns > -EINVAL) and since the mtpps register only defines capabilities for 8 > pins, so n_pins cannot exceed MAX_PIN_NUM. > > Maybe wrap it with WARN_ON_ONCE instead of silently returning, so if > future hardware adds support for more pins we would notice rather than > silently dropping events. Hi Carolina, Thanks for the feedback. I've removed the redundant pin < 0 check and implemented the WARN_ON_ONCE for the upper bound as suggested. I just submitted a v3 as a fresh thread with these changes and a fix for the union corruption bug. Thanks, Prathamesh