From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 817EF3E4C74 for ; Fri, 10 Apr 2026 18:42:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775846542; cv=none; b=RplXJLJ1+sf+3Af0i6MBAPUOFasFHvYUTxu6z8y3RFaQMrJ9FBvruINDKwInz1BidAUmpHOATFwIWY91RZi0yKcrwM1nbbjqU1+eDkF5A7TdHjh5ksFKrX+PMK7hk/m99OHY973OPRJ+86FH9mkN+4QIAZ3vUaZdvk3VORCABNY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775846542; c=relaxed/simple; bh=mw7vvM6+HKApmLxOCYfWgBXtsa0fw0TBlq99ZWtHJL0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=ORvca2deR2JN5oLzQSJI4laD0v3vG01tdEKwLlHwEZmt8FbFYqpdPaVarzg4XhaXOFvDLsBmLSn8i9jWed1D+u5UJZgylNJIwrnlu8vTe72PTgX/haGteylnG/wDn55E4HePPCdQ9CHlUxjCPsuXlf9DnPuD9/B2B2kENpWwE3I= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=ek2r+GWI; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=BhThVmQD; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="ek2r+GWI"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="BhThVmQD" Received: from pps.filterd (m0279869.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 63AF5mDA3759304 for ; Fri, 10 Apr 2026 18:42:20 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=qcppdkim1; bh=DoXxJ8NEvA0 XYqlc3PfgDIa2+1HCBJnmm1ZFq9D7Jgs=; b=ek2r+GWI9t0jgeW9bexQ158+fsR 9Zf5k9UlctkM2hywVqZnEe1VoRPNHALGatf97uXpftovkRkg2wPEuSdgrdoWoNdC A7Jv+HQoZtgSEk/6OU2wzPFE67XaR0W0hTROIZcd67hqv/HwLggVQPCufKe8Tyiy hjHFXP1039DBKaj5bWYkxDfUO5NPAAVNif4/uq+2O5lfdt+SNp0otOdJgP+2TqKa QAIVFX3j5X+6Xys9K4RhgRhL41qGYAqz3e4qaKoyXf94ALNiDxQR0O8ELj6bDdiM 1qeybu6chlfnqirymtsuAiCkjUCWiqM8qOQApEZZK3Yc5MFIIz5j3oN9FPA== Received: from mail-pg1-f199.google.com (mail-pg1-f199.google.com [209.85.215.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4df3j1gn9k-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 10 Apr 2026 18:42:20 +0000 (GMT) Received: by mail-pg1-f199.google.com with SMTP id 41be03b00d2f7-c76c60c74f3so1471825a12.2 for ; Fri, 10 Apr 2026 11:42:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1775846539; x=1776451339; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=DoXxJ8NEvA0XYqlc3PfgDIa2+1HCBJnmm1ZFq9D7Jgs=; b=BhThVmQDWsJJG56URjSPsYQAplvVLSbkO8asW0NtAjBd2uRhfFG31bvurcovCaBwYU NGNNRZI4xrbc2Le/39fkczDH3nPFAE9Vkth4cZrSiyVNHZo5P4CF4uZyv7zkBe05J4Qv aBTui3wefCcXTrNkxxUpZ8j+70Rn9GlZmd3/8r7TmRYDZXxwlIjOoOCRPWprpAWFYI0C 8tBvmxmNrI2J+/Y+dLvNdWy7WkAvjhdTB79jdJWJZ5VexUSppLhK3dzuVndDDAY/8mmY UmWeErKJe+vgmyGKMKGgCmOd6va84eDNGj4TMsZdTYrAwmH3ELIbj7dzeX5GUUUx47KU a62w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775846539; x=1776451339; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=DoXxJ8NEvA0XYqlc3PfgDIa2+1HCBJnmm1ZFq9D7Jgs=; b=KG5f/Mr70Y1a7RKkS6aO1cd8NQnZ2Z5FGTHKfRN9rwDsuhIOyoPFc6CZ21RVZXV+c+ bE36C1+WnMh+q8T8yNAqhC4fb5/NPtMFwf5NCUdkWaRL2m0yuIXFKZeCNZZA2ZtIVZtE c8JN46AkqZZWtevZV09x15TjTpp7hDzCzHnZJDg0+cdkI+z4FXBB04I5FYzRZZf7ebJ6 JB86lxZ0/AKbLnQUHUHRSeKR1t/HfjYjh8ISxjijK4GjmY3LsadoRh/htRYW1ijjYUt5 zAyLqiGvivPRHZFYe9YAySaoLlh8INf+xm+/eqRmbNCxztFNFk06gmRvXTQSKgu006kl hY7w== X-Forwarded-Encrypted: i=1; AJvYcCXBclKVcMTCVO5SchdKgtuA4l6L3ZM+nBiezscxzBryA/TH2wO0sqqWLDZufq5pIcAPa5fxTicHhbfj09Y=@vger.kernel.org X-Gm-Message-State: AOJu0YyXyYZYM57XjcimCi0topHSxG6ju5gf8bPNSd5Ggdnkmw1u/OmL wf8tvL7XpHXZ7CX/0HZs6CQbUZYz7Z1VonAxI1qWwtyQwnr0zFFBVRTvQjELivITN3V2G/AEK3e Y07t4lUD3k3YeeHW5ENkB+Ar3HhHpETICDZAvg9ECFQJDqpKen/f+ozqnfvHVrRys9YE= X-Gm-Gg: AeBDieuIZYSw5rnxwJIn3w5CKRMqblczrbOD65biryeHXKTcPq9x26J2MBd5jLZhUzZ IP/C9Y4CBPewH5QMvKrhBxQALN3M/KAIHV4CTHkCO8YfPlQO6NtP2Jlv8rx3jOkQijA5jxWCik/ 0e30kLDiQIN8iSMbIymWYMYflMepR2gt4lIwC6xaHlIwsc245PyAfeV2hv9qlcYt8K/BgubD7lS 58ZQsm4AN16uats1SlJHS1hH5WgvcwH3C+utFHv+8mYMO2pF9GOqFPEwHcIkHsNxAZpd/zTZriB rrlM65N4dJ4lJxSQHl1eubTGlzVwYcqywVz6Num0ez59QY4xHoNqC0HKM23As+ia3BBPkhIm3vX 6/+fMlDjjM4VKC3EZ39pdhp7H0HeTaH2hBRqZv5HHXVkorjGB X-Received: by 2002:a05:6a00:ab85:b0:827:3ff6:fb72 with SMTP id d2e1a72fcca58-82f0c35e51dmr5159253b3a.51.1775846539390; Fri, 10 Apr 2026 11:42:19 -0700 (PDT) X-Received: by 2002:a05:6a00:ab85:b0:827:3ff6:fb72 with SMTP id d2e1a72fcca58-82f0c35e51dmr5159207b3a.51.1775846538859; Fri, 10 Apr 2026 11:42:18 -0700 (PDT) Received: from hu-mojha-hyd.qualcomm.com ([202.46.23.25]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-82f0c32e744sm4036922b3a.13.2026.04.10.11.42.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 10 Apr 2026 11:42:18 -0700 (PDT) From: Mukesh Ojha To: Thomas Gleixner , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bjorn Andersson , Konrad Dybcio Cc: cros-qcom-dts-watchers@chromium.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Mukesh Ojha Subject: [PATCH 04/35] irqchip/qcom-pdc: Replace pdc_version global with a function pointer Date: Sat, 11 Apr 2026 00:10:41 +0530 Message-ID: <20260410184124.1068210-5-mukesh.ojha@oss.qualcomm.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260410184124.1068210-1-mukesh.ojha@oss.qualcomm.com> References: <20260410184124.1068210-1-mukesh.ojha@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNDEwMDE3NCBTYWx0ZWRfX60zo87hxoeRB Bdqd+TuzetDU6ITc5UOnHgk3qHlnjy1sVMFDX/J5vqevW/wXGEQGfgvBWQYVnL40BSRSVNMvl1D 5CbcEaecpxOFoY+meOFde8NdS3Qaeyic62XoTA+p8Fj9FbNVEtBnyGQf0UW8fvtwEqhqBctlkYT wZjV9qlMwZxgOnj2vB55Dd6kJP73Y5OKSk/kMZuow50JyvkucYYoKzO/HSKNfGgf6ztS7dqK0Z9 pA0660sTA9eI3cChUkMlEkBMgPWnROlN5zjlqTislQV59w3J5nKDVfqHirayzFUMSypdAtcfSrx GwjiMfJ/1Rd4BRXSol9F2hBcsMDgZBPrkxkCoc6v1hUTjTl7LTyfNtgJ3NSdv3Ctl9KHHa7FkBb qiS0/Hby46DaJ/IcC4y38c3qDiwsa5lqw+D8glXnKOqLiP3+/juw5WWRDj4LEitKhJPI4ldFmFM 9kgQBruyc+V5aVhMLlw== X-Proofpoint-ORIG-GUID: mNws6ylxOTeNZKx0IVsWh8s-7IrYmXKd X-Authority-Analysis: v=2.4 cv=AbKB2XXG c=1 sm=1 tr=0 ts=69d9448c cx=c_pps a=Oh5Dbbf/trHjhBongsHeRQ==:117 a=ZePRamnt/+rB5gQjfz0u9A==:17 a=A5OVakUREuEA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_glEPmIy2e8OvE2BGh3C:22 a=EUspDBNiAAAA:8 a=VJwwGsi7nLGkcN4Jv9sA:9 a=_Vgx9l1VpLgwpw_dHYaR:22 X-Proofpoint-GUID: mNws6ylxOTeNZKx0IVsWh8s-7IrYmXKd X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-04-10_05,2026-04-09_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 malwarescore=0 spamscore=0 lowpriorityscore=0 suspectscore=0 bulkscore=0 clxscore=1015 adultscore=0 priorityscore=1501 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604010000 definitions=main-2604100174 Now that the two enable paths are separate functions, replace the pdc_version global with a __pdc_enable_intr function pointer. The pointer is assigned once at probe time based on the version register, moving the version comparison out of the interrupt enable/disable hot path entirely. Signed-off-by: Mukesh Ojha --- drivers/irqchip/qcom-pdc.c | 13 +++---------- 1 file changed, 3 insertions(+), 10 deletions(-) diff --git a/drivers/irqchip/qcom-pdc.c b/drivers/irqchip/qcom-pdc.c index 21e2b4b884ee..734576cdce0c 100644 --- a/drivers/irqchip/qcom-pdc.c +++ b/drivers/irqchip/qcom-pdc.c @@ -51,7 +51,7 @@ static void __iomem *pdc_base; static void __iomem *pdc_prev_base; static struct pdc_pin_region *pdc_region; static int pdc_region_cnt; -static unsigned int pdc_version; +static void (*__pdc_enable_intr)(int pin_out, bool on); static bool pdc_x1e_quirk; static void pdc_base_reg_write(void __iomem *base, int reg, u32 i, u32 val) @@ -123,14 +123,6 @@ static void pdc_enable_intr_cfg(int pin_out, bool on) pdc_reg_write(IRQ_i_CFG, pin_out, enable); } -static void __pdc_enable_intr(int pin_out, bool on) -{ - if (pdc_version < PDC_VERSION_3_2) - pdc_enable_intr_bank(pin_out, on); - else - pdc_enable_intr_cfg(pin_out, on); -} - static void pdc_enable_intr(struct irq_data *d, bool on) { unsigned long flags; @@ -400,7 +392,8 @@ static int qcom_pdc_probe(struct platform_device *pdev, struct device_node *pare goto fail; } - pdc_version = pdc_reg_read(PDC_VERSION_REG, 0); + __pdc_enable_intr = (pdc_reg_read(PDC_VERSION_REG, 0) < PDC_VERSION_3_2) ? + pdc_enable_intr_bank : pdc_enable_intr_cfg; parent_domain = irq_find_host(parent); if (!parent_domain) { -- 2.53.0