From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f182.google.com (mail-pg1-f182.google.com [209.85.215.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3057F1B6CE9 for ; Sat, 11 Apr 2026 05:17:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.182 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775884636; cv=none; b=tPKjfRj841RXljfsqHmF8R7Sm69NdcKyA/ib7Bw4fXGSCfJhYyrVzM0yxseHx7f4jpIkSilhCSUZAYbtAdadwf+5u3NiH2duB2S/3aJ+x17Qdd2tYi7wtwH8LZWMQRA+sOGtROrT9D5TGZaAS69WtvvQjVZt0qL5YpthYa26I/4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775884636; c=relaxed/simple; bh=fbqM3x3GD1CCUD2vyX99XNBmMghubH80srElmDJt3Nc=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=aHRf/i0rJnROEzflk6tsRvtza5AY+JtNpDLqzkPC0a59UyHvkg+YmYrZ2CJ6PHD3xG55ZsHWbmTvTIp4O7s3p/K11u2MlnxPVYEj8nGmuqZueohowkJAZ6UyqvyLl6qwtcHKl9Dl0ZjIpufWb8f82T+ORCKP8pXbbD0gbuOxRCo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=networkplumber.org; spf=pass smtp.mailfrom=networkplumber.org; dkim=pass (2048-bit key) header.d=networkplumber-org.20251104.gappssmtp.com header.i=@networkplumber-org.20251104.gappssmtp.com header.b=o67kgZTL; arc=none smtp.client-ip=209.85.215.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=networkplumber.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=networkplumber.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=networkplumber-org.20251104.gappssmtp.com header.i=@networkplumber-org.20251104.gappssmtp.com header.b="o67kgZTL" Received: by mail-pg1-f182.google.com with SMTP id 41be03b00d2f7-c76b87931b8so1677814a12.2 for ; Fri, 10 Apr 2026 22:17:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20251104.gappssmtp.com; s=20251104; t=1775884634; x=1776489434; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=eY+oOcv5DNu9r7imH370nri24gXDO5w1oyBmadAxFQ0=; b=o67kgZTL+CUNCLacQwaYTaiezaet4Ceeto1+KOSmsgNjbR0oWnfGm3FwG+OpZx4zJ7 gOvLvVMSRE08ydsu3uZt18nf62jOU+90ff0lnHg4/feSlO0I4pLbD4RYxpxRFOigVdoB fanVWv3rgcopgv9xtylvmEslaGh9A/NM6iCIW4XLb2WITSBcl1JtZaO0EB0MuK9mo0iD QHzpxxLTgEA/5S8TEppCXL9s85U1xgfPo6VF/wd8NAL3zHnmGiJ00zlVpFulmJxsdRBE d8AGkRICN1cJt3MCG4v2w7aC1lvMQOCOBK6disQzET9XiVx6YFYTEEDycUGDKaEjqDnu 0ZAQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775884634; x=1776489434; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=eY+oOcv5DNu9r7imH370nri24gXDO5w1oyBmadAxFQ0=; b=e3LYlhbza3m1uqGh8w42O9sbkZlrskM0YlOfTBewGUae8wBx4KZEBTtTt/H8GVOBnL Y31lTyAaaDZTs7GrG4JFPtEhxqvWY3VufAIiYUvyJYfr4fM8TS9PH52aUTdGvB4XiTnq tvJTN7xlfk9BMqKwtDHvUIvIC0Y9W3sqJ6hMFyOmdIRlGCdGAr1XFv8f+smePJxiXFkw e+96DYfKb6kPvuQaDjqwwYWL4HAQL4sd4fdYWsltv7O6/L0QFjrEAcgnkom8bgSe8iyT ZNHbmsT18mWtc425nn09xrD0C42Hxk0UDIuTOsyjvgcGaz6xLVahhIX3PyJOq7RSe1kF hwww== X-Forwarded-Encrypted: i=1; AJvYcCXMtpEIPeH38gmtOfzxHsWumTN4FhYG8NMyUsjn2Q06iiPXYx5tm7BcVvyV9OyiWp8iKIiyMJ4GDDJqyZI=@vger.kernel.org X-Gm-Message-State: AOJu0YyM2sRQZmmTLtUmmPAGVaHGgXL20MQxB1scqmOzf5AMaoLM2jFV ChO74yb5EJCYUUkpj1yAUcfPt1IC31IL+MSLrveWNj9bPQfkH1NkQBSp5ILcvLmdt/8= X-Gm-Gg: AeBDiesIp2E269BEZ7EZNm6CyFI5oo05pyj/n84YSZlslhUaXisoX9taL+acI5yr8nW S+ExriXaz4+v+W5AMUknCSCugxlzzIE0OcxDA3zRjuFrOdslinUD71Xrioy/UbwlHtyeWeHGBNI y8tEsl7k1FG9v9OfDQgB0DYvNv33lAonGJWJTbWvhM3HTchaHOGgojXxGgfe7Lxs38l3ecFySsJ wiDWoRrMT8NBJ8izmkS1ourSFLOUDil3O7jfRjEv5SFUKXlsXqHXbTeTx1iUglxxABip9NMWvDg CF+chyZe9XJ1LEm6/unKuFi1LMR2bwfYgj35eKVJe9BxXjxvD9YLQOz9X7nHJGSqIFVAb1l4Pk1 gUrpSwdtNDX9FUeunHYwRIJGTT18qwUN6Aa43xWfGwwyZ1ph6OpwjoHZ1YP2i8TRqvGYMEUhmDf vs7irLlTF2UA1fzpRT8s+HTSnpMDvsXke0 X-Received: by 2002:a05:6a20:9389:b0:398:d6a9:fc9 with SMTP id adf61e73a8af0-39fe3c78c5dmr6605779637.5.1775884633973; Fri, 10 Apr 2026 22:17:13 -0700 (PDT) Received: from phoenix.lan ([104.202.41.210]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-c7921a1ef00sm3855700a12.28.2026.04.10.22.17.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 10 Apr 2026 22:17:13 -0700 (PDT) From: Stephen Hemminger To: netdev@vger.kernel.org Cc: Stephen Hemminger , Simon Horman , Jamal Hadi Salim , Jiri Pirko , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , linux-kernel@vger.kernel.org (open list) Subject: [PATTCH net v5 1/8] net/sched: netem: fix probability gaps in 4-state loss model Date: Fri, 10 Apr 2026 22:15:50 -0700 Message-ID: <20260411051700.311679-2-stephen@networkplumber.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260411051700.311679-1-stephen@networkplumber.org> References: <20260411051700.311679-1-stephen@networkplumber.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The 4-state Markov chain in loss_4state() has gaps at the boundaries between transition probability ranges. The comparisons use: if (rnd < a4) else if (a4 < rnd && rnd < a1 + a4) When rnd equals a boundary value exactly, neither branch matches and no state transition occurs. The redundant lower-bound check (a4 < rnd) is already implied by being in the else branch. Remove the unnecessary lower-bound comparisons so the ranges are contiguous and every random value produces a transition, matching the GI (General and Intuitive) loss model specification. This bug goes back to original implementation of this model. Fixes: 661b79725fea ("netem: revised correlated loss generator") Signed-off-by: Stephen Hemminger Reviewed-by: Simon Horman --- net/sched/sch_netem.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/net/sched/sch_netem.c b/net/sched/sch_netem.c index 20df1c08b1e9..8ee72cac1faf 100644 --- a/net/sched/sch_netem.c +++ b/net/sched/sch_netem.c @@ -227,10 +227,10 @@ static bool loss_4state(struct netem_sched_data *q) if (rnd < clg->a4) { clg->state = LOST_IN_GAP_PERIOD; return true; - } else if (clg->a4 < rnd && rnd < clg->a1 + clg->a4) { + } else if (rnd < clg->a1 + clg->a4) { clg->state = LOST_IN_BURST_PERIOD; return true; - } else if (clg->a1 + clg->a4 < rnd) { + } else { clg->state = TX_IN_GAP_PERIOD; } @@ -247,9 +247,9 @@ static bool loss_4state(struct netem_sched_data *q) case LOST_IN_BURST_PERIOD: if (rnd < clg->a3) clg->state = TX_IN_BURST_PERIOD; - else if (clg->a3 < rnd && rnd < clg->a2 + clg->a3) { + else if (rnd < clg->a2 + clg->a3) { clg->state = TX_IN_GAP_PERIOD; - } else if (clg->a2 + clg->a3 < rnd) { + } else { clg->state = LOST_IN_BURST_PERIOD; return true; } -- 2.53.0