From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f171.google.com (mail-pg1-f171.google.com [209.85.215.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EA327181334 for ; Sat, 11 Apr 2026 05:17:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.171 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775884647; cv=none; b=bjvh0P7Wcpnk6I39sbFO3bcZ5frpgIaO3sKVQhUuGPe53uQSuR6kEn8WVAoVMb014dmFPGRa+giIYJiHvJjAvSwHz/NuQxbDiX6NHgbBcrAJ557eONsM2BqdAm4nu3lh7g3yYmLZ06EJvT/nsrGOqhJwMQvCYuMzboFJb/QsNp4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775884647; c=relaxed/simple; bh=fL0OfMMtDWSxHR0JJrLSv+7El8c9nsPcZEBdX0sgkzc=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=UALdWfpdKqEqtTHqEWQvxukuq3wWv0KCNrwEXC2DHiihR9w2sg/5s0olW5KQY8TafdmJz55t8o1/A4KpX6IhYriAbLXyZq37EuY0i7nds6jvjYrmaV6Ry//jYBvgHbZ0PnLyG5wd86saZfyD5KxtS4DfYxH6Deh1mkhfwFc+bQA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=networkplumber.org; spf=pass smtp.mailfrom=networkplumber.org; dkim=pass (2048-bit key) header.d=networkplumber-org.20251104.gappssmtp.com header.i=@networkplumber-org.20251104.gappssmtp.com header.b=T2T/afRL; arc=none smtp.client-ip=209.85.215.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=networkplumber.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=networkplumber.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=networkplumber-org.20251104.gappssmtp.com header.i=@networkplumber-org.20251104.gappssmtp.com header.b="T2T/afRL" Received: by mail-pg1-f171.google.com with SMTP id 41be03b00d2f7-c766a95a72dso1774242a12.1 for ; Fri, 10 Apr 2026 22:17:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20251104.gappssmtp.com; s=20251104; t=1775884645; x=1776489445; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=UsjmygR14oJm2Bm37kTyDucyaRPKWbtE7XhkLO/lfZI=; b=T2T/afRLkkToj5NW9bBd8GpuBTqvD1+BWB/16aFotoyI2651qfOg7O69gYK6kjbZTu g/CsTkCdPxWYBo+s+F+is1o8c9Ef9Oy0maymS3swEDu7WEqvdkiD7zkdSLBOeQK1KpIS g15WIaSDFgTZ4WCZsfJwQf66EmP759tCQDJa+Mz46rGDAKFJmH9HIeQcdJeQTyHzk8/8 Dtt3EIwcO6AI66IZ/94ca+rBZA/OF6catpRWDR2UVIJYzWxu2AEdmA32Boi0qD5GcjfV LqCOsA98xcUVfLElytnyfSZjum46HO385X7Y4c4KZB2yB34YhjnrdUSdi/NxRFbK0cat Zq6w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775884645; x=1776489445; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=UsjmygR14oJm2Bm37kTyDucyaRPKWbtE7XhkLO/lfZI=; b=CXOukuuhvyhU5RRIskNkFKwcbVJZm9sAsRCziq2wn7Qryiv1siBiDkiFgOMORGXC1E okeiSModn0D96SMA5yB/q70u0pSsejgr7XU4D2oBdj2S6NGXlaeijYVN5e4GLyfNO/s2 srF7xQRsZN4CnNUZwzXxRElbVOWsrhCXLyKO6Mn0UvcHAopam15IlNsJfGZlDFEr82m5 ks/XlvjPPcCjF+VkxVqCKBjXyC9Kn56onT5DCFaVZjo1bYWTdtXfsOVTaLc5k9qN9gUs mIHzREDRkCnMzFUzncwV8mlbm9+OJcJI5MmBoRFBjUgESLOTQp5Iy6iYSa2Tlohgupct t2lg== X-Forwarded-Encrypted: i=1; AJvYcCVghC4OvP0KNqp0Ng4nNYQdbw/FDEcYax3Tnm/jLVleL1h0PMljvQtpVwvFuYCuClQOG4XdK4TveKzv+pg=@vger.kernel.org X-Gm-Message-State: AOJu0Yyr/RpJmrRuJS5PWHgSKLiBatIPZ1cxPj49/RDUlkKeKdvMRytM 8qR9K9lLwIN18WB+5Ih/GMZqY1NraqM8fnh9GYlAdk5RtJiZaf+XGrpNH1gLe6sZ4dA= X-Gm-Gg: AeBDiev/pt7/zRBw4cI0o+eBp8iKgRUsOco+c46ugWDHp+TsL4w/A7sRlj8cJpoRnQZ JR4s7vjRmVrKsyFVzmKuhRr0QPZRkme0jHgdYboYzieLxpgposRwIxh/eOivWpLjB7ksz9TXcki lKFznHmbgBrs8nWoW0rXo8LEOo0SvPwRgr9R/HnevmMmYwQZcxU/WM/lfLq4sRMG3MW9BNpx14n 2YB801tkZhYwc/RUmLdpALZXhg/XYcRe4HtD9DgsKdkRAWY4Q4rE2cG89bRooI8k5rNlr4QFB7J 1V20Q1iYYHi1r4MmHQ62FsukOuNOytqGj8TR9TfAilxIIN/SgzNCQ9zML7bgGU8gGMRAF4iFOi4 C3c2kldz7G/tOUDN+c/qArwDG3BmlHxegb7RQzurLyxKubivmRBSpU+oiEH2wfZbcFMjdNh/C47 zbSdZTbNheL5PF1zLL1s+zMLeEuD0OrKJc X-Received: by 2002:a05:6300:8e10:b0:39f:23ed:8979 with SMTP id adf61e73a8af0-39fe3f3fb78mr4573458637.31.1775884645406; Fri, 10 Apr 2026 22:17:25 -0700 (PDT) Received: from phoenix.lan ([104.202.41.210]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-c7921a1ef00sm3855700a12.28.2026.04.10.22.17.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 10 Apr 2026 22:17:25 -0700 (PDT) From: Stephen Hemminger To: netdev@vger.kernel.org Cc: Stephen Hemminger , Simon Horman , Jamal Hadi Salim , Jiri Pirko , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , =?UTF-8?q?Fran=C3=A7ois=20Michel?= , linux-kernel@vger.kernel.org (open list) Subject: [PATTCH net v5 3/8] net/sched: netem: only reseed PRNG when seed is explicitly provided Date: Fri, 10 Apr 2026 22:15:52 -0700 Message-ID: <20260411051700.311679-4-stephen@networkplumber.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260411051700.311679-1-stephen@networkplumber.org> References: <20260411051700.311679-1-stephen@networkplumber.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit netem_change() unconditionally reseeds the PRNG on every tc change command. If TCA_NETEM_PRNG_SEED is not specified, a new random seed is generated, destroying reproducibility for users who set a deterministic seed on a previous change. Move the initial random seed generation to netem_init() and only reseed in netem_change() when TCA_NETEM_PRNG_SEED is explicitly provided by the user. Fixes: 4072d97ddc44 ("netem: add prng attribute to netem_sched_data") Signed-off-by: Stephen Hemminger Reviewed-by: Simon Horman --- net/sched/sch_netem.c | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/net/sched/sch_netem.c b/net/sched/sch_netem.c index d400a730eadd..556f9747f0e7 100644 --- a/net/sched/sch_netem.c +++ b/net/sched/sch_netem.c @@ -1112,11 +1112,10 @@ static int netem_change(struct Qdisc *sch, struct nlattr *opt, /* capping jitter to the range acceptable by tabledist() */ q->jitter = min_t(s64, abs(q->jitter), INT_MAX); - if (tb[TCA_NETEM_PRNG_SEED]) + if (tb[TCA_NETEM_PRNG_SEED]) { q->prng.seed = nla_get_u64(tb[TCA_NETEM_PRNG_SEED]); - else - q->prng.seed = get_random_u64(); - prandom_seed_state(&q->prng.prng_state, q->prng.seed); + prandom_seed_state(&q->prng.prng_state, q->prng.seed); + } unlock: sch_tree_unlock(sch); @@ -1139,6 +1138,9 @@ static int netem_init(struct Qdisc *sch, struct nlattr *opt, return -EINVAL; q->loss_model = CLG_RANDOM; + q->prng.seed = get_random_u64(); + prandom_seed_state(&q->prng.prng_state, q->prng.seed); + ret = netem_change(sch, opt, extack); if (ret) pr_info("netem: change failed\n"); -- 2.53.0